[GitHub] flink pull request #5617: [FLINK-8799][YARN] Make AbstractYarnClusterDescrip...

2018-03-07 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5617#discussion_r172979651 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java --- @@ -172,6 +181,88 @@ public AbstractYarnClusterDescriptor(

[GitHub] flink pull request #5617: [FLINK-8799][YARN] Make AbstractYarnClusterDescrip...

2018-03-02 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/5617#discussion_r172009559 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java --- @@ -476,14 +379,12 @@ protected Configuration

[GitHub] flink pull request #5617: [FLINK-8799][YARN] Make AbstractYarnClusterDescrip...

2018-03-02 Thread yanghua
GitHub user yanghua opened a pull request: https://github.com/apache/flink/pull/5617 [FLINK-8799][YARN] Make AbstractYarnClusterDescriptor immutable ## What is the purpose of the change *This pull request Make AbstractYarnClusterDescriptor immutable* ## Brief