[GitHub] flink pull request #6001: [FLINK-9299] ProcessWindowFunction documentation J...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/6001


---

[GitHub] flink pull request #6001: [FLINK-9299] ProcessWindowFunction documentation J...

[yanghua]

Github user yanghua commented on a diff in the pull request:

https://github.com/apache/flink/pull/6001#discussion_r188530473
  
--- Diff: docs/dev/stream/operators/windows.md ---
@@ -797,7 +797,7 @@ DataStream input = ...;
 
 input
   .keyBy()
-  .timeWindow()
+  .timeWindow()
--- End diff --

accept, hold on...


---

[GitHub] flink pull request #6001: [FLINK-9299] ProcessWindowFunction documentation J...

[StephanEwen]

Github user StephanEwen commented on a diff in the pull request:

https://github.com/apache/flink/pull/6001#discussion_r188529928
  
--- Diff: docs/dev/stream/operators/windows.md ---
@@ -797,7 +797,7 @@ DataStream input = ...;
 
 input
   .keyBy()
-  .timeWindow()
+  .timeWindow()
--- End diff --

How about using "duration" instead of "time size". I think "time size" is 
not a commonly used term...


---

[GitHub] flink pull request #6001: [FLINK-9299] ProcessWindowFunction documentation J...

[fhueske]

Github user fhueske commented on a diff in the pull request:

https://github.com/apache/flink/pull/6001#discussion_r187871263
  
--- Diff: docs/dev/stream/operators/windows.md ---
@@ -883,7 +883,7 @@ private static class AverageAggregate
 
   @Override
   public Double getResult(Tuple2 accumulator) {
-return accumulator.f0 / accumulator.f1;
+return (double) accumulator.f0 / accumulator.f1;
--- End diff --

Should probably be `((double) accumulator.f0) / accumulator.f1;`


---

[GitHub] flink pull request #6001: [FLINK-9299] ProcessWindowFunction documentation J...

[yanghua]

GitHub user yanghua opened a pull request:

https://github.com/apache/flink/pull/6001

[FLINK-9299] ProcessWindowFunction documentation Java examples have errors

## What is the purpose of the change

*This pull request fixed some document demo code error.*


## Brief change log

  - *This pull request fixed some document demo code error.*

## Verifying this change


This change is a trivial rework / code cleanup without any test coverage.

## Does this pull request potentially affect one of the following parts:

  - Dependencies (does it add or upgrade a dependency): (yes / **no**)
  - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
  - The serializers: (yes / **no** / don't know)
  - The runtime per-record code paths (performance sensitive): (yes / 
**no** / don't know)
  - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
  - The S3 file system connector: (yes / **no** / don't know)

## Documentation

  - Does this pull request introduce a new feature? (yes / **no**)
  - If yes, how is the feature documented? (not applicable / docs / 
JavaDocs / **not documented**)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/yanghua/flink FLINK-9299

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/6001.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #6001


commit cb0764151647b58fc2b46b8fe76c451ed076b830
Author: yanghua 
Date:   2018-05-13T08:27:11Z

[FLINK-9299] ProcessWindowFunction documentation Java examples have errors




---