[GitHub] flink pull request #6029: [FLINK-9387] Several log message errors in queryab...

[yanghua]

Github user yanghua commented on a diff in the pull request:

https://github.com/apache/flink/pull/6029#discussion_r189858273
  
--- Diff: 
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/AbstractServerHandler.java
 ---
@@ -303,7 +303,7 @@ public void operationComplete(ChannelFuture future) 
throws Exception {
LOG.debug("Request {} was successfully 
answered after {} ms.", request, durationMillis);

stats.reportSuccessfulRequest(durationMillis);
} else {
-   LOG.debug("Request {} failed after {} 
ms : ", request, durationMillis, future.cause());
+   LOG.debug("Request {} failed after {} 
ms caused by : {}.", request, durationMillis, future.cause());
--- End diff --

@zentol  Should I open a new issue to fix this ?


---

[GitHub] flink pull request #6029: [FLINK-9387] Several log message errors in queryab...

[zentol]

Github user zentol commented on a diff in the pull request:

https://github.com/apache/flink/pull/6029#discussion_r188936871
  
--- Diff: 
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/AbstractServerHandler.java
 ---
@@ -303,7 +303,7 @@ public void operationComplete(ChannelFuture future) 
throws Exception {
LOG.debug("Request {} was successfully 
answered after {} ms.", request, durationMillis);

stats.reportSuccessfulRequest(durationMillis);
} else {
-   LOG.debug("Request {} failed after {} 
ms : ", request, durationMillis, future.cause());
+   LOG.debug("Request {} failed after {} 
ms caused by : {}.", request, durationMillis, future.cause());
--- End diff --

`future.cause()` returns a Throwable, why is this change necessary?


---

[GitHub] flink pull request #6029: [FLINK-9387] Several log message errors in queryab...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/6029


---

[GitHub] flink pull request #6029: [FLINK-9387] Several log message errors in queryab...

[yanghua]

GitHub user yanghua opened a pull request:

https://github.com/apache/flink/pull/6029

[FLINK-9387] Several log message errors in queryable-state module

## What is the purpose of the change

*This pull request fixed several log message errors in queryable-state 
module*


## Brief change log

  - *Fixed several log message errors in queryable-state module*

## Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

## Does this pull request potentially affect one of the following parts:

  - Dependencies (does it add or upgrade a dependency): (yes / **no**)
  - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
  - The serializers: (yes / **no** / don't know)
  - The runtime per-record code paths (performance sensitive): (yes / 
**no** / don't know)
  - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
  - The S3 file system connector: (yes / **no** / don't know)

## Documentation

  - Does this pull request introduce a new feature? (yes / **no**)
  - If yes, how is the feature documented? (not applicable / docs / 
JavaDocs / **not documented**)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/yanghua/flink FLINK-9387

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/6029.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #6029


commit b940977d68e7507d4b0cfb10508cb2997f402152
Author: yanghua 
Date:   2018-05-17T07:35:29Z

[FLINK-9387] Several log message errors in queryable-state module




---