[GitHub] flink pull request #6306: [FLINK-9804][state] KeyedStateBackend.getKeys() do...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/6306


---

[GitHub] flink pull request #6306: [FLINK-9804][state] KeyedStateBackend.getKeys() do...

[aljoscha]

Github user aljoscha commented on a diff in the pull request:

https://github.com/apache/flink/pull/6306#discussion_r201944060
  
--- Diff: 
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
 ---
@@ -1666,6 +1667,7 @@ public void close() {
this.keyGroupPrefixBytes = 
Preconditions.checkNotNull(keyGroupPrefixBytes);
this.namespaceBytes = 
Preconditions.checkNotNull(namespaceBytes);
this.nextKey = null;
+   this.preKey = null;
--- End diff --

Maybe call this `previousKey`, just to be more clear.


---

[GitHub] flink pull request #6306: [FLINK-9804][state] KeyedStateBackend.getKeys() do...

[sihuazhou]

GitHub user sihuazhou opened a pull request:

https://github.com/apache/flink/pull/6306

[FLINK-9804][state] KeyedStateBackend.getKeys() does not work on RocksDB 
MapState

## What is the purpose of the change

*This PR fixes the bug that the KeyedStateBackend.getKeys() does not work 
on RocksDB MapState.*


## Brief change log

  - *Change `RocksDBKeyedStateBackend#RocksIteratorForKeysWrapper()` to let 
it support get keys for RocksDB MapState.*


## Verifying this change

  - *Added `StateBackendTestBase#testMapStateGetKeys()` to guard the 
changes*

## Does this pull request potentially affect one of the following parts:

  - Dependencies (does it add or upgrade a dependency): (no)
  - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
  - The serializers: (no)
  - The runtime per-record code paths (performance sensitive): (no)
  - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  - The S3 file system connector: (no)

## Documentation

- No

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sihuazhou/flink FLINK-9804

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/6306.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #6306


commit efc4096a4a6f38b3acb0b5189804f7b452218f23
Author: sihuazhou 
Date:   2018-07-11T12:35:22Z

fix KeyedStateBackend.getKeys() for RocksDBMapState.




---