[GitHub] tillrohrmann commented on issue #6678: [FLINK-10255] Only react to onAddedJobGraph signal when being leader

2018-09-21 Thread GitBox
tillrohrmann commented on issue #6678: [FLINK-10255] Only react to onAddedJobGraph signal when being leader URL: https://github.com/apache/flink/pull/6678#issuecomment-423455756 I think it should not be possible to have two async recovery operations ongoing since either of them will have

[GitHub] tillrohrmann commented on issue #6678: [FLINK-10255] Only react to onAddedJobGraph signal when being leader

2018-09-13 Thread GitBox
tillrohrmann commented on issue #6678: [FLINK-10255] Only react to onAddedJobGraph signal when being leader URL: https://github.com/apache/flink/pull/6678#issuecomment-420928749 Thanks for the review @GJL. I've addressed your comments and after Travis gives green light, I'll merge it.

[GitHub] tillrohrmann commented on issue #6678: [FLINK-10255] Only react to onAddedJobGraph signal when being leader

2018-09-11 Thread GitBox
tillrohrmann commented on issue #6678: [FLINK-10255] Only react to onAddedJobGraph signal when being leader URL: https://github.com/apache/flink/pull/6678#issuecomment-420190020 Thanks for the comments @TisonKun. I've fixed the failing `DispatcherTest#testOnAddedJobGraphWithFinishedJob`.