zentol commented on a change in pull request #7049: [FLINK-10816][cep] Fix
LockableTypeSerializer.duplicate() to consider…
URL: https://github.com/apache/flink/pull/7049#discussion_r231608543
##
File path:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/sharedbuffer/LockableTypeSerializerTest.java
##
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.cep.nfa.sharedbuffer;
+
+import org.apache.flink.api.common.typeutils.base.IntSerializer;
+import org.apache.flink.runtime.state.heap.CopyOnWriteStateTableTest;
+
+import org.junit.Assert;
+import org.junit.Test;
+
+/**
+ * Tests for {@link
org.apache.flink.cep.nfa.sharedbuffer.Lockable.LockableTypeSerializer}.
+ */
+public class LockableTypeSerializerTest {
+
+ /**
+* This tests that {@link Lockable.LockableTypeSerializer#duplicate()}
works as expected.
+*/
+ @Test
+ public void testDuplicate() {
+ IntSerializer nonDuplicatingInnerSerializer =
IntSerializer.INSTANCE;
+ Assert.assertSame(nonDuplicatingInnerSerializer,
nonDuplicatingInnerSerializer.duplicate());
+ Lockable.LockableTypeSerializer
candidateTestShallowDuplicate =
+ new
Lockable.LockableTypeSerializer<>(nonDuplicatingInnerSerializer);
+ Assert.assertSame(candidateTestShallowDuplicate,
candidateTestShallowDuplicate.duplicate());
+
+ CopyOnWriteStateTableTest.TestDuplicateSerializer
duplicatingInnerSerializer =
Review comment:
This is more of a personal gripe but I'm not a huge fan of re-using inner
classes from other test-cases directly just because they happen to fit the
use-case.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
