Re: [PR] [FLINK-39058][model-triton] Use Preconditions#checkArgument to replace raw condition validation in model-triton module [flink]

2026-02-10 Thread via GitHub


RocMarshal merged PR #27565:
URL: https://github.com/apache/flink/pull/27565


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] [FLINK-39058][model-triton] Use Preconditions#checkArgument to replace raw condition validation in model-triton module [flink]

2026-02-10 Thread via GitHub


RocMarshal commented on PR #27565:
URL: https://github.com/apache/flink/pull/27565#issuecomment-3876940991

   Thanks  @featzhang for the review.
   The CI failure is not related to the PR.
   So, Merging...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] [FLINK-39058][model-triton] Use Preconditions#checkArgument to replace raw condition validation in model-triton module [flink]

2026-02-09 Thread via GitHub


RocMarshal commented on PR #27565:
URL: https://github.com/apache/flink/pull/27565#issuecomment-3875726676

   Hi @featzhang, Could you help take a look ? 
   Thanks a lot


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] [FLINK-39058][model-triton] Use Preconditions#checkArgument to replace raw condition validation in model-triton module [flink]

2026-02-09 Thread via GitHub


flinkbot commented on PR #27565:
URL: https://github.com/apache/flink/pull/27565#issuecomment-3875393640

   
   ## CI report:
   
   * 5f7168170c5ee71d21fff10ab06108c5a03ca545 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



[PR] [FLINK-39058][model-triton] Use Preconditions#checkArgument to replace raw condition validation in model-triton module [flink]

2026-02-09 Thread via GitHub


RocMarshal opened a new pull request, #27565:
URL: https://github.com/apache/flink/pull/27565

   
   
   
   ## What is the purpose of the change
   
   [FLINK-39058][model-triton] Use Preconditions#checkArgument to replace raw 
condition validation in model-triton module
   
   
   ## Brief change log
   
   [FLINK-39058][model-triton] Use Preconditions#checkArgument to replace raw 
condition validation in model-triton module
   
   
   ## Verifying this change
   
   
   This change is already covered by existing tests
   
   
   ## Does this pull request potentially affect one of the following parts:
   
 - Dependencies (does it add or upgrade a dependency): (yes / **no**)
 - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
 - The serializers: (yes / **no** / don't know)
 - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
 - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't 
know)
 - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
 - Does this pull request introduce a new feature? (yes / **no**)
 - If yes, how is the feature documented? (**not applicable** / docs / 
JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]