[jira] [Commented] (FLINK-10397) Remove CoreOptions#MODE

2018-09-28 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/FLINK-10397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631935#comment-16631935
 ] 

ASF GitHub Bot commented on FLINK-10397:


asfgit closed pull request #6752: [FLINK-10397] Remove CoreOptions#MODE
URL: https://github.com/apache/flink/pull/6752
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/docs/_includes/generated/core_configuration.html 
b/docs/_includes/generated/core_configuration.html
index 98cca9125a0..4366e8b246f 100644
--- a/docs/_includes/generated/core_configuration.html
+++ b/docs/_includes/generated/core_configuration.html
@@ -27,11 +27,6 @@
 'LOCAL_DIRS' on Yarn. 
'_FLINK_TMP_DIR' on Mesos. System.getProperty("java.io.tmpdir") in 
standalone.
 
 
-
-mode
-"new"
-Switch to select the execution mode. Possible values are 'new' 
and 'legacy'.
-
 
 parallelism.default
 1
diff --git 
a/flink-clients/src/main/java/org/apache/flink/client/LocalExecutor.java 
b/flink-clients/src/main/java/org/apache/flink/client/LocalExecutor.java
index 4e4993a88db..14d3ee50a14 100644
--- a/flink-clients/src/main/java/org/apache/flink/client/LocalExecutor.java
+++ b/flink-clients/src/main/java/org/apache/flink/client/LocalExecutor.java
@@ -37,7 +37,6 @@
 import org.apache.flink.optimizer.plantranslate.JobGraphGenerator;
 import org.apache.flink.runtime.jobgraph.JobGraph;
 import org.apache.flink.runtime.minicluster.JobExecutorService;
-import org.apache.flink.runtime.minicluster.LocalFlinkMiniCluster;
 import org.apache.flink.runtime.minicluster.MiniCluster;
 import org.apache.flink.runtime.minicluster.MiniClusterConfiguration;
 import org.apache.flink.runtime.minicluster.RpcServiceSharing;
@@ -125,39 +124,28 @@ public void start() throws Exception {
}
 
private JobExecutorService createJobExecutorService(Configuration 
configuration) throws Exception {
-   final JobExecutorService newJobExecutorService;
-   if 
(CoreOptions.NEW_MODE.equals(configuration.getString(CoreOptions.MODE))) {
+   if (!configuration.contains(RestOptions.PORT)) {
+   configuration.setInteger(RestOptions.PORT, 0);
+   }
 
-   if (!configuration.contains(RestOptions.PORT)) {
-   configuration.setInteger(RestOptions.PORT, 0);
-   }
+   final MiniClusterConfiguration miniClusterConfiguration = new 
MiniClusterConfiguration.Builder()
+   .setConfiguration(configuration)
+   .setNumTaskManagers(
+   configuration.getInteger(
+   
ConfigConstants.LOCAL_NUMBER_TASK_MANAGER,
+   
ConfigConstants.DEFAULT_LOCAL_NUMBER_TASK_MANAGER))
+   .setRpcServiceSharing(RpcServiceSharing.SHARED)
+   .setNumSlotsPerTaskManager(
+   configuration.getInteger(
+   TaskManagerOptions.NUM_TASK_SLOTS, 1))
+   .build();
 
-   final MiniClusterConfiguration miniClusterConfiguration 
= new MiniClusterConfiguration.Builder()
-   .setConfiguration(configuration)
-   .setNumTaskManagers(
-   configuration.getInteger(
-   
ConfigConstants.LOCAL_NUMBER_TASK_MANAGER,
-   
ConfigConstants.DEFAULT_LOCAL_NUMBER_TASK_MANAGER))
-   .setRpcServiceSharing(RpcServiceSharing.SHARED)
-   .setNumSlotsPerTaskManager(
-   configuration.getInteger(
-   
TaskManagerOptions.NUM_TASK_SLOTS, 1))
-   .build();
-
-   final MiniCluster miniCluster = new 
MiniCluster(miniClusterConfiguration);
-   miniCluster.start();
-
-   configuration.setInteger(RestOptions.PORT, 
miniCluster.getRestAddress().getPort());
-
-   newJobExecutorService = miniCluster;
-   } else {
-   final LocalFlinkMiniCluster localFlinkMiniCluster = new 
LocalFlinkMiniCluster(configuration, true);
-   localFlinkMiniCluster.start();
-
-   newJobExecutorService = localFlinkMiniCluster;
-   }
+   final MiniCluster

[jira] [Commented] (FLINK-10397) Remove CoreOptions#MODE

2018-09-27 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/FLINK-10397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16630712#comment-16630712
 ] 

ASF GitHub Bot commented on FLINK-10397:


tillrohrmann commented on issue #6752: [FLINK-10397] Remove CoreOptions#MODE
URL: https://github.com/apache/flink/pull/6752#issuecomment-425159955
 
 
   I agree with @TisonKun. Removing the `EXECUTION_MODE_OPTION` and `isNewMode` 
can be done in another subtask of FLINK-10392.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Remove CoreOptions#MODE
> ---
>
> Key: FLINK-10397
> URL: https://issues.apache.org/jira/browse/FLINK-10397
> Project: Flink
>  Issue Type: Sub-task
>  Components: Configuration
>Affects Versions: 1.7.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.7.0
>
>
> Remove the {{CoreOptions#MODE}} since it is no longer needed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-10397) Remove CoreOptions#MODE

2018-09-27 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/FLINK-10397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16630646#comment-16630646
 ] 

ASF GitHub Bot commented on FLINK-10397:


tillrohrmann commented on a change in pull request #6752: [FLINK-10397] Remove 
CoreOptions#MODE
URL: https://github.com/apache/flink/pull/6752#discussion_r220978579
 
 

 ##
 File path: 
flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendTestBase.java
 ##
 @@ -19,43 +19,21 @@
 package org.apache.flink.client.cli;
 
 import org.apache.flink.configuration.Configuration;
-import org.apache.flink.configuration.CoreOptions;
 import org.apache.flink.configuration.GlobalConfiguration;
 import org.apache.flink.util.TestLogger;
 
-import org.junit.runner.RunWith;
-import org.junit.runners.Parameterized;
-
-import java.util.Arrays;
-import java.util.List;
-
 /**
  * Base test class for {@link CliFrontend} tests that wraps the new vs. legacy 
mode.
 
 Review comment:
   Good catch. Will update it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Remove CoreOptions#MODE
> ---
>
> Key: FLINK-10397
> URL: https://issues.apache.org/jira/browse/FLINK-10397
> Project: Flink
>  Issue Type: Sub-task
>  Components: Configuration
>Affects Versions: 1.7.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.7.0
>
>
> Remove the {{CoreOptions#MODE}} since it is no longer needed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-10397) Remove CoreOptions#MODE

2018-09-26 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/FLINK-10397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628441#comment-16628441
 ] 

ASF GitHub Bot commented on FLINK-10397:


TisonKun commented on issue #6752: [FLINK-10397] Remove CoreOptions#MODE
URL: https://github.com/apache/flink/pull/6752#issuecomment-424638073
 
 
   @StefanRRichter I would say that the removal of `EXECUTION_MODE_OPTION` and 
`isNewMode` will be part of 
[FLINK-10392](https://issues.apache.org/jira/browse/FLINK-10392). For the 
`isNewMode` part, see also my comment under #6748 .


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Remove CoreOptions#MODE
> ---
>
> Key: FLINK-10397
> URL: https://issues.apache.org/jira/browse/FLINK-10397
> Project: Flink
>  Issue Type: Sub-task
>  Components: Configuration
>Affects Versions: 1.7.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.7.0
>
>
> Remove the {{CoreOptions#MODE}} since it is no longer needed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-10397) Remove CoreOptions#MODE

2018-09-26 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/FLINK-10397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628413#comment-16628413
 ] 

ASF GitHub Bot commented on FLINK-10397:


StefanRRichter commented on a change in pull request #6752: [FLINK-10397] 
Remove CoreOptions#MODE
URL: https://github.com/apache/flink/pull/6752#discussion_r220467970
 
 

 ##
 File path: 
flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendTestBase.java
 ##
 @@ -19,43 +19,21 @@
 package org.apache.flink.client.cli;
 
 import org.apache.flink.configuration.Configuration;
-import org.apache.flink.configuration.CoreOptions;
 import org.apache.flink.configuration.GlobalConfiguration;
 import org.apache.flink.util.TestLogger;
 
-import org.junit.runner.RunWith;
-import org.junit.runners.Parameterized;
-
-import java.util.Arrays;
-import java.util.List;
-
 /**
  * Base test class for {@link CliFrontend} tests that wraps the new vs. legacy 
mode.
 
 Review comment:
   Comment update required?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Remove CoreOptions#MODE
> ---
>
> Key: FLINK-10397
> URL: https://issues.apache.org/jira/browse/FLINK-10397
> Project: Flink
>  Issue Type: Sub-task
>  Components: Configuration
>Affects Versions: 1.7.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.7.0
>
>
> Remove the {{CoreOptions#MODE}} since it is no longer needed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-10397) Remove CoreOptions#MODE

2018-09-26 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/FLINK-10397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628414#comment-16628414
 ] 

ASF GitHub Bot commented on FLINK-10397:


StefanRRichter commented on a change in pull request #6752: [FLINK-10397] 
Remove CoreOptions#MODE
URL: https://github.com/apache/flink/pull/6752#discussion_r220465820
 
 

 ##
 File path: 
flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java
 ##
 @@ -308,22 +308,4 @@
// 

//  Distributed architecture
 
 Review comment:
   Comment section can be removed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Remove CoreOptions#MODE
> ---
>
> Key: FLINK-10397
> URL: https://issues.apache.org/jira/browse/FLINK-10397
> Project: Flink
>  Issue Type: Sub-task
>  Components: Configuration
>Affects Versions: 1.7.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.7.0
>
>
> Remove the {{CoreOptions#MODE}} since it is no longer needed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-10397) Remove CoreOptions#MODE

2018-09-25 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/FLINK-10397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626877#comment-16626877
 ] 

ASF GitHub Bot commented on FLINK-10397:


yanghua commented on issue #6752: [FLINK-10397] Remove CoreOptions#MODE
URL: https://github.com/apache/flink/pull/6752#issuecomment-424227423
 
 
   @TisonKun  I know, I just give a reminder so that Travis can be turned green 
as soon as possible.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Remove CoreOptions#MODE
> ---
>
> Key: FLINK-10397
> URL: https://issues.apache.org/jira/browse/FLINK-10397
> Project: Flink
>  Issue Type: Sub-task
>  Components: Configuration
>Affects Versions: 1.7.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.7.0
>
>
> Remove the {{CoreOptions#MODE}} since it is no longer needed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-10397) Remove CoreOptions#MODE

2018-09-25 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/FLINK-10397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626867#comment-16626867
 ] 

ASF GitHub Bot commented on FLINK-10397:


TisonKun commented on issue #6752: [FLINK-10397] Remove CoreOptions#MODE
URL: https://github.com/apache/flink/pull/6752#issuecomment-424226650
 
 
   @yanghua The former can be discussed at FLINK-10403 and the latter IMO can 
be resolved by regenerate the doc( not a critical blocker ).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Remove CoreOptions#MODE
> ---
>
> Key: FLINK-10397
> URL: https://issues.apache.org/jira/browse/FLINK-10397
> Project: Flink
>  Issue Type: Sub-task
>  Components: Configuration
>Affects Versions: 1.7.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.7.0
>
>
> Remove the {{CoreOptions#MODE}} since it is no longer needed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-10397) Remove CoreOptions#MODE

2018-09-25 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/FLINK-10397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626862#comment-16626862
 ] 

ASF GitHub Bot commented on FLINK-10397:


yanghua commented on issue #6752: [FLINK-10397] Remove CoreOptions#MODE
URL: https://github.com/apache/flink/pull/6752#issuecomment-424225840
 
 
   @tillrohrmann The travis reports two issues : 
   
   ```
 
JobManagerHAProcessFailureBatchRecoveryITCase.testDispatcherProcessFailure:331 
The program did not finish in time
   ```
   and 
   
   ```
   Running 
org.apache.flink.docs.configuration.ConfigOptionsDocsCompletenessITCase
   Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.771 sec 
<<< FAILURE! - in 
org.apache.flink.docs.configuration.ConfigOptionsDocsCompletenessITCase
   
testFullReferenceCompleteness(org.apache.flink.docs.configuration.ConfigOptionsDocsCompletenessITCase)
  Time elapsed: 0.724 sec  <<< FAILURE!
   java.lang.AssertionError: Documentation is outdated, please regenerate it 
according to the instructions in flink-docs/README.md.
Problems:
Documented option mode does not exist.
at org.junit.Assert.fail(Assert.java:88)
at 
org.apache.flink.docs.configuration.ConfigOptionsDocsCompletenessITCase.compareDocumentedAndExistingOptions(ConfigOptionsDocsCompletenessITCase.java:118)
at 
org.apache.flink.docs.configuration.ConfigOptionsDocsCompletenessITCase.testFullReferenceCompleteness(ConfigOptionsDocsCompletenessITCase.java:76)
   
   
   Results :
   
   Failed tests: 
 
ConfigOptionsDocsCompletenessITCase.testFullReferenceCompleteness:76->compareDocumentedAndExistingOptions:118
 Documentation is outdated, please regenerate it according to the instructions 
in flink-docs/README.md.
Problems:
Documented option mode does not exist.
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Remove CoreOptions#MODE
> ---
>
> Key: FLINK-10397
> URL: https://issues.apache.org/jira/browse/FLINK-10397
> Project: Flink
>  Issue Type: Sub-task
>  Components: Configuration
>Affects Versions: 1.7.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.7.0
>
>
> Remove the {{CoreOptions#MODE}} since it is no longer needed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-10397) Remove CoreOptions#MODE

2018-09-24 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/FLINK-10397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626034#comment-16626034
 ] 

ASF GitHub Bot commented on FLINK-10397:


tillrohrmann opened a new pull request #6752: [FLINK-10397] Remove 
CoreOptions#MODE
URL: https://github.com/apache/flink/pull/6752
 
 
   ## What is the purpose of the change
   
   This PR is based on #6748 and #6751 and is part of the [removal of Flink's 
legacy mode](https://issues.apache.org/jira/browse/FLINK-10392).
   
   Removes the CoreOptions#MODE option used to switch between the new and 
legacy mode.
   
   ## Brief change log
   
   - Remove `CoreOptions#MODE`, `CoreOptions#NEW` and `CoreOptions#LEGACY`
   - Set the mode where it was switchable to new (e.g. `isNewMode = true` in 
`YarnTestBase`)
   
   ## Verifying this change
   
   - Not explicitly tested
   
   ## Does this pull request potentially affect one of the following parts:
   
 - Dependencies (does it add or upgrade a dependency): (no)
 - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes)
 - The serializers: (no)
 - The runtime per-record code paths (performance sensitive): (no)
 - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
 - The S3 file system connector: (no)
   
   ## Documentation
   
 - Does this pull request introduce a new feature? (no)
 - If yes, how is the feature documented? (not applicable)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Remove CoreOptions#MODE
> ---
>
> Key: FLINK-10397
> URL: https://issues.apache.org/jira/browse/FLINK-10397
> Project: Flink
>  Issue Type: Sub-task
>  Components: Configuration
>Affects Versions: 1.7.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.7.0
>
>
> Remove the {{CoreOptions#MODE}} since it is no longer needed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-10397) Remove CoreOptions#MODE

2018-09-22 Thread tison (JIRA) 


[ 
https://issues.apache.org/jira/browse/FLINK-10397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624925#comment-16624925
 ] 

tison commented on FLINK-10397:
---

This sub task would depend on the rest sub tasks, especially heavily on 
FLINK-10396. Since FLINK-10396 is about test scope and this one is about the 
whole project. Would be better to send a pull request/patch based on 
FLINK-10396 changes.

> Remove CoreOptions#MODE
> ---
>
> Key: FLINK-10397
> URL: https://issues.apache.org/jira/browse/FLINK-10397
> Project: Flink
>  Issue Type: Sub-task
>  Components: Configuration
>Affects Versions: 1.7.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Major
> Fix For: 1.7.0
>
>
> Remove the {{CoreOptions#MODE}} since it is no longer needed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)