[jira] [Commented] (FLINK-1179) Add button to JobManager web interface to request stack trace of a TaskManager
[ https://issues.apache.org/jira/browse/FLINK-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14321676#comment-14321676 ] ASF GitHub Bot commented on FLINK-1179: --- Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/374 Add button to JobManager web interface to request stack trace of a TaskManager -- Key: FLINK-1179 URL: https://issues.apache.org/jira/browse/FLINK-1179 Project: Flink Issue Type: New Feature Components: JobManager Reporter: Robert Metzger Assignee: Chiwan Park Priority: Minor Labels: starter This is something I do quite often manually and I think it might be helpful for users as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1179) Add button to JobManager web interface to request stack trace of a TaskManager
[ https://issues.apache.org/jira/browse/FLINK-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14320610#comment-14320610 ] ASF GitHub Bot commented on FLINK-1179: --- Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/374#issuecomment-74310825 I'll probably merge this change tomorrow because I'm working on a bigger change on the web frontend. Add button to JobManager web interface to request stack trace of a TaskManager -- Key: FLINK-1179 URL: https://issues.apache.org/jira/browse/FLINK-1179 Project: Flink Issue Type: New Feature Components: JobManager Reporter: Robert Metzger Assignee: Chiwan Park Priority: Minor Labels: starter This is something I do quite often manually and I think it might be helpful for users as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1179) Add button to JobManager web interface to request stack trace of a TaskManager
[
https://issues.apache.org/jira/browse/FLINK-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14311954#comment-14311954
]
ASF GitHub Bot commented on FLINK-1179:
---
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/374#discussion_r24315701
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/web/SetupInfoServlet.java
---
@@ -127,25 +134,42 @@ private void writeTaskmanagers(HttpServletResponse
resp) throws IOException {
objInner.put(physicalMemory,
instance.getResources().getSizeOfPhysicalMemory() 20);
objInner.put(freeMemory,
instance.getResources().getSizeOfJvmHeap() 20);
objInner.put(managedMemory,
instance.getResources().getSizeOfManagedMemory() 20);
+ objInner.put(instanceID, instance.getId());
array.put(objInner);
}
catch (JSONException e) {
LOG.warn(Json object creation failed, e);
}
-
+
}
try {
obj.put(taskmanagers, array);
} catch (JSONException e) {
LOG.warn(Json object creation failed, e);
}
-
+
PrintWriter w = resp.getWriter();
w.write(obj.toString());
}
-
+
+ private void writeStackTraceOfTaskManager(String instanceIdStr,
HttpServletResponse resp) throws IOException {
--- End diff --
The `RequestStackTrace` message may fail, if the task manager is not
reachable.
I suggest to surround this block with try / catch(Throwable) and forward
the error message to the web client.
The response JSON may then have two fields: errorMessage and
stackTrace. If errorMessage is defined, display the message, otherwise
print the stack trace.
Add button to JobManager web interface to request stack trace of a TaskManager
--
Key: FLINK-1179
URL: https://issues.apache.org/jira/browse/FLINK-1179
Project: Flink
Issue Type: New Feature
Components: JobManager
Reporter: Robert Metzger
Assignee: Chiwan Park
Priority: Minor
Labels: starter
This is something I do quite often manually and I think it might be helpful
for users as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-1179) Add button to JobManager web interface to request stack trace of a TaskManager
[ https://issues.apache.org/jira/browse/FLINK-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14311967#comment-14311967 ] ASF GitHub Bot commented on FLINK-1179: --- Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/374#issuecomment-73478511 I've tried it out locally. Looks very nice. Thank you. +1 to merge. Add button to JobManager web interface to request stack trace of a TaskManager -- Key: FLINK-1179 URL: https://issues.apache.org/jira/browse/FLINK-1179 Project: Flink Issue Type: New Feature Components: JobManager Reporter: Robert Metzger Assignee: Chiwan Park Priority: Minor Labels: starter This is something I do quite often manually and I think it might be helpful for users as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1179) Add button to JobManager web interface to request stack trace of a TaskManager
[ https://issues.apache.org/jira/browse/FLINK-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14312231#comment-14312231 ] ASF GitHub Bot commented on FLINK-1179: --- Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/374#issuecomment-73509674 @StephanEwen Thanks for your advice! I fixed it. Add button to JobManager web interface to request stack trace of a TaskManager -- Key: FLINK-1179 URL: https://issues.apache.org/jira/browse/FLINK-1179 Project: Flink Issue Type: New Feature Components: JobManager Reporter: Robert Metzger Assignee: Chiwan Park Priority: Minor Labels: starter This is something I do quite often manually and I think it might be helpful for users as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1179) Add button to JobManager web interface to request stack trace of a TaskManager
[
https://issues.apache.org/jira/browse/FLINK-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14311301#comment-14311301
]
ASF GitHub Bot commented on FLINK-1179:
---
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/374#discussion_r24298303
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -349,6 +349,11 @@ Actor with ActorLogMessages with ActorLogging {
case Heartbeat(instanceID) =
instanceManager.reportHeartBeat(instanceID)
+case RequestStackTrace(instanceID) =
+ val taskManager =
instanceManager.getRegisteredInstanceById(instanceID).getTaskManager
+ val result = AkkaUtils.ask[StackTrace](taskManager, SendStackTrace)
--- End diff --
This is a blocking call within the actor thread. We should avoid this. You
can simply forward the ```SendStackTrace``` message to the respective
TaskManager: ```taskManager forward SendStacktrace```
Add button to JobManager web interface to request stack trace of a TaskManager
--
Key: FLINK-1179
URL: https://issues.apache.org/jira/browse/FLINK-1179
Project: Flink
Issue Type: New Feature
Components: JobManager
Reporter: Robert Metzger
Assignee: Chiwan Park
Priority: Minor
Labels: starter
This is something I do quite often manually and I think it might be helpful
for users as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-1179) Add button to JobManager web interface to request stack trace of a TaskManager
[ https://issues.apache.org/jira/browse/FLINK-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14311304#comment-14311304 ] ASF GitHub Bot commented on FLINK-1179: --- Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/374#issuecomment-73409662 Hi Chiwan, thanks for your work. It looks really good. I had some just some minor remarks. Add button to JobManager web interface to request stack trace of a TaskManager -- Key: FLINK-1179 URL: https://issues.apache.org/jira/browse/FLINK-1179 Project: Flink Issue Type: New Feature Components: JobManager Reporter: Robert Metzger Assignee: Chiwan Park Priority: Minor Labels: starter This is something I do quite often manually and I think it might be helpful for users as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
