[jira] [Commented] (FLINK-13306) flink-examples-streaming-gcp-pubsub is missing NOTICE

2019-08-14 Thread Chesnay Schepler (JIRA)


[ 
https://issues.apache.org/jira/browse/FLINK-13306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906989#comment-16906989
 ] 

Chesnay Schepler commented on FLINK-13306:
--

[~rmetzger] It was closed as invalid since the module is neither deployed to 
maven central or contained in the distribution; as such it only exists in 
source form and doesn't require any NOTICE stuff.
If you want to add it to the distribution, then yes it still needs them.

> flink-examples-streaming-gcp-pubsub is missing NOTICE
> -
>
> Key: FLINK-13306
> URL: https://issues.apache.org/jira/browse/FLINK-13306
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / Google Cloud PubSub, Examples
>Affects Versions: 1.9.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Blocker
>
> The pubsub example is bundling various dependencies but is missing a NOTICE 
> file.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (FLINK-13306) flink-examples-streaming-gcp-pubsub is missing NOTICE

2019-08-13 Thread Richard Deurwaarder (JIRA)


[ 
https://issues.apache.org/jira/browse/FLINK-13306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905976#comment-16905976
 ] 

Richard Deurwaarder commented on FLINK-13306:
-

I had not seen this discussion before creating FLINK-13700.

Unless anyone changed their mind, shall I remove it altogether? The shaded 
example jar is actually quite big too (16mb) so that might be another reason 
for not including it in the final dist.

> flink-examples-streaming-gcp-pubsub is missing NOTICE
> -
>
> Key: FLINK-13306
> URL: https://issues.apache.org/jira/browse/FLINK-13306
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / Google Cloud PubSub, Examples
>Affects Versions: 1.9.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Blocker
>
> The pubsub example is bundling various dependencies but is missing a NOTICE 
> file.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (FLINK-13306) flink-examples-streaming-gcp-pubsub is missing NOTICE

2019-08-13 Thread Robert Metzger (JIRA)


[ 
https://issues.apache.org/jira/browse/FLINK-13306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905947#comment-16905947
 ] 

Robert Metzger commented on FLINK-13306:


[~Zentol]: Why was this closed as invalid? There's now a ticket to include the 
example into flink-dist: FLINK-13700.

If we do FLINK-13700, we need to add the missing NOTICE file.

> flink-examples-streaming-gcp-pubsub is missing NOTICE
> -
>
> Key: FLINK-13306
> URL: https://issues.apache.org/jira/browse/FLINK-13306
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / Google Cloud PubSub, Examples
>Affects Versions: 1.9.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Blocker
>
> The pubsub example is bundling various dependencies but is missing a NOTICE 
> file.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (FLINK-13306) flink-examples-streaming-gcp-pubsub is missing NOTICE

2019-07-26 Thread Konstantin Knauf (JIRA)


[ 
https://issues.apache.org/jira/browse/FLINK-13306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893794#comment-16893794
 ] 

Konstantin Knauf commented on FLINK-13306:
--

This example is also not located in `flink-examples-streaming` + packing in 
flink-examples-build-helper, but instead all the code is located in 
`flink-examples-build-helper`. 

I think, this should also be fixed, if we keep it.

> flink-examples-streaming-gcp-pubsub is missing NOTICE
> -
>
> Key: FLINK-13306
> URL: https://issues.apache.org/jira/browse/FLINK-13306
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / Google Cloud PubSub, Examples
>Affects Versions: 1.9.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Blocker
>
> The pubsub example is bundling various dependencies but is missing a NOTICE 
> file.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (FLINK-13306) flink-examples-streaming-gcp-pubsub is missing NOTICE

2019-07-24 Thread Stephan Ewen (JIRA)


[ 
https://issues.apache.org/jira/browse/FLINK-13306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16892038#comment-16892038
 ] 

Stephan Ewen commented on FLINK-13306:
--

Even more reason to remove it?

> flink-examples-streaming-gcp-pubsub is missing NOTICE
> -
>
> Key: FLINK-13306
> URL: https://issues.apache.org/jira/browse/FLINK-13306
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / Google Cloud PubSub, Examples
>Affects Versions: 1.9.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Blocker
>
> The pubsub example is bundling various dependencies but is missing a NOTICE 
> file.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (FLINK-13306) flink-examples-streaming-gcp-pubsub is missing NOTICE

2019-07-24 Thread Stephan Ewen (JIRA)


[ 
https://issues.apache.org/jira/browse/FLINK-13306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16891683#comment-16891683
 ] 

Stephan Ewen commented on FLINK-13306:
--

+1 to removing that example.

I think we do not need an examples to illustrate connectors, we don't usually 
do that for connectors.

> flink-examples-streaming-gcp-pubsub is missing NOTICE
> -
>
> Key: FLINK-13306
> URL: https://issues.apache.org/jira/browse/FLINK-13306
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / Google Cloud PubSub, Examples
>Affects Versions: 1.9.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Blocker
> Fix For: 1.9.0
>
>
> The pubsub example is bundling various dependencies but is missing a NOTICE 
> file.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (FLINK-13306) flink-examples-streaming-gcp-pubsub is missing NOTICE

2019-07-18 Thread Chesnay Schepler (JIRA)


[ 
https://issues.apache.org/jira/browse/FLINK-13306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16887751#comment-16887751
 ] 

Chesnay Schepler commented on FLINK-13306:
--

Before anyone suggests to skip the deployment; if it isn't bundled in the 
distribution, nor deployed to maven central, nor linked in the documentation, 
there's virtually no way any user will ever see it. (Especially because the 
existing docs already contain examples), at which point we might as well remove 
it.

> flink-examples-streaming-gcp-pubsub is missing NOTICE
> -
>
> Key: FLINK-13306
> URL: https://issues.apache.org/jira/browse/FLINK-13306
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / Google Cloud PubSub, Examples
>Affects Versions: 1.9.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Blocker
> Fix For: 1.9.0
>
>
> The pubsub example is bundling various dependencies but is missing a NOTICE 
> file.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (FLINK-13306) flink-examples-streaming-gcp-pubsub is missing NOTICE

2019-07-18 Thread Chesnay Schepler (JIRA)


[ 
https://issues.apache.org/jira/browse/FLINK-13306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16887671#comment-16887671
 ] 

Chesnay Schepler commented on FLINK-13306:
--

yes, because the jar is deployed to maven central.

> flink-examples-streaming-gcp-pubsub is missing NOTICE
> -
>
> Key: FLINK-13306
> URL: https://issues.apache.org/jira/browse/FLINK-13306
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / Google Cloud PubSub, Examples
>Affects Versions: 1.9.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Blocker
> Fix For: 1.9.0
>
>
> The pubsub example is bundling various dependencies but is missing a NOTICE 
> file.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (FLINK-13306) flink-examples-streaming-gcp-pubsub is missing NOTICE

2019-07-17 Thread Till Rohrmann (JIRA)


[ 
https://issues.apache.org/jira/browse/FLINK-13306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16887548#comment-16887548
 ] 

Till Rohrmann commented on FLINK-13306:
---

Is this really a blocker issue if the example is not bundled [~Zentol]?

> flink-examples-streaming-gcp-pubsub is missing NOTICE
> -
>
> Key: FLINK-13306
> URL: https://issues.apache.org/jira/browse/FLINK-13306
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / Google Cloud PubSub, Examples
>Affects Versions: 1.9.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Blocker
> Fix For: 1.9.0
>
>
> The pubsub example is bundling various dependencies but is missing a NOTICE 
> file.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (FLINK-13306) flink-examples-streaming-gcp-pubsub is missing NOTICE

2019-07-17 Thread Chesnay Schepler (JIRA)


[ 
https://issues.apache.org/jira/browse/FLINK-13306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16886927#comment-16886927
 ] 

Chesnay Schepler commented on FLINK-13306:
--

In fact I'd like to remove the example entirely instead of having to bother 
with licensing. I don't believe that it offers much value.

> flink-examples-streaming-gcp-pubsub is missing NOTICE
> -
>
> Key: FLINK-13306
> URL: https://issues.apache.org/jira/browse/FLINK-13306
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / Google Cloud PubSub, Examples
>Affects Versions: 1.9.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Blocker
> Fix For: 1.9.0
>
>
> The pubsub example is bundling various dependencies but is missing a NOTICE 
> file.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (FLINK-13306) flink-examples-streaming-gcp-pubsub is missing NOTICE

2019-07-17 Thread Chesnay Schepler (JIRA)


[ 
https://issues.apache.org/jira/browse/FLINK-13306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16886922#comment-16886922
 ] 

Chesnay Schepler commented on FLINK-13306:
--

Since the example isn't bundled in flink-dist, which is the express purpose of 
the {{flink-examples-build-helper}} module, the whole example likely shouldn't 
exist in there in the first place.

> flink-examples-streaming-gcp-pubsub is missing NOTICE
> -
>
> Key: FLINK-13306
> URL: https://issues.apache.org/jira/browse/FLINK-13306
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / Google Cloud PubSub, Examples
>Affects Versions: 1.9.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Blocker
> Fix For: 1.9.0
>
>
> The pubsub example is bundling various dependencies but is missing a NOTICE 
> file.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)