[jira] [Commented] (FLINK-1515) [Gelly] Enable access to aggregators and broadcast sets in vertex-centric iteration
[
https://issues.apache.org/jira/browse/FLINK-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14333535#comment-14333535
]
ASF GitHub Bot commented on FLINK-1515:
---
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/402#issuecomment-75588051
Thank you @tillrohrmann! Then, I'll go ahead and merge this :)
[Gelly] Enable access to aggregators and broadcast sets in vertex-centric
iteration
---
Key: FLINK-1515
URL: https://issues.apache.org/jira/browse/FLINK-1515
Project: Flink
Issue Type: Improvement
Components: Gelly
Reporter: Vasia Kalavri
Assignee: Martin Kiefer
Currently, aggregators and broadcast sets cannot be accessed through Gelly's
{{runVertexCentricIteration}} method. The functionality is already present in
the {{VertexCentricIteration}} and we just need to expose it.
This could be done like this: We create a method
{{createVertexCentricIteration}}, which will return a
{{VertexCentricIteration}} object and we change {{runVertexCentricIteration}}
to accept this as a parameter (and return the graph after running this
iteration).
The user can configure the {{VertexCentricIteration}} by directly calling the
public methods {{registerAggregator}}, {{setName}}, etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-1515) [Gelly] Enable access to aggregators and broadcast sets in vertex-centric iteration
[
https://issues.apache.org/jira/browse/FLINK-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14333583#comment-14333583
]
ASF GitHub Bot commented on FLINK-1515:
---
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/402
[Gelly] Enable access to aggregators and broadcast sets in vertex-centric
iteration
---
Key: FLINK-1515
URL: https://issues.apache.org/jira/browse/FLINK-1515
Project: Flink
Issue Type: Improvement
Components: Gelly
Reporter: Vasia Kalavri
Assignee: Martin Kiefer
Currently, aggregators and broadcast sets cannot be accessed through Gelly's
{{runVertexCentricIteration}} method. The functionality is already present in
the {{VertexCentricIteration}} and we just need to expose it.
This could be done like this: We create a method
{{createVertexCentricIteration}}, which will return a
{{VertexCentricIteration}} object and we change {{runVertexCentricIteration}}
to accept this as a parameter (and return the graph after running this
iteration).
The user can configure the {{VertexCentricIteration}} by directly calling the
public methods {{registerAggregator}}, {{setName}}, etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-1515) [Gelly] Enable access to aggregators and broadcast sets in vertex-centric iteration
[
https://issues.apache.org/jira/browse/FLINK-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14328814#comment-14328814
]
ASF GitHub Bot commented on FLINK-1515:
---
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/402#issuecomment-75220973
Hi,
if no more comments, I'd like to merge this.
There is a failing check in Travis (not related to this PR):
```
Tests in error:
JobManagerFailsITCase.run:40-org$scalatest$BeforeAndAfterAll$$super$run:40-org$scalatest$WordSpecLike$$super$run:40-runTests:40-runTest:40-withFixture:40
» Timeout
JobManagerFailsITCase.run:40-org$scalatest$BeforeAndAfterAll$$super$run:40-org$scalatest$WordSpecLike$$super$run:40-runTests:40-runTest:40-withFixture:40-TestKit.within:707-TestKit.within:707
» Timeout
```
Is this fixed by #422? Shall I proceed?
Thanks!
[Gelly] Enable access to aggregators and broadcast sets in vertex-centric
iteration
---
Key: FLINK-1515
URL: https://issues.apache.org/jira/browse/FLINK-1515
Project: Flink
Issue Type: Improvement
Components: Gelly
Reporter: Vasia Kalavri
Assignee: Martin Kiefer
Currently, aggregators and broadcast sets cannot be accessed through Gelly's
{{runVertexCentricIteration}} method. The functionality is already present in
the {{VertexCentricIteration}} and we just need to expose it.
This could be done like this: We create a method
{{createVertexCentricIteration}}, which will return a
{{VertexCentricIteration}} object and we change {{runVertexCentricIteration}}
to accept this as a parameter (and return the graph after running this
iteration).
The user can configure the {{VertexCentricIteration}} by directly calling the
public methods {{registerAggregator}}, {{setName}}, etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-1515) [Gelly] Enable access to aggregators and broadcast sets in vertex-centric iteration
[
https://issues.apache.org/jira/browse/FLINK-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14329204#comment-14329204
]
ASF GitHub Bot commented on FLINK-1515:
---
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/402#issuecomment-75279454
I'm currently working on fixing this problem. You can ignore it for the
moment.
On Fri, Feb 20, 2015 at 11:58 AM, Vasia Kalavri notificati...@github.com
wrote:
Hi,
if no more comments, I'd like to merge this.
There is a failing check in Travis (not related to this PR):
Tests in error:
JobManagerFailsITCase.run:40-org$scalatest$BeforeAndAfterAll$$super$run:40-org$scalatest$WordSpecLike$$super$run:40-runTests:40-runTest:40-withFixture:40
» Timeout
JobManagerFailsITCase.run:40-org$scalatest$BeforeAndAfterAll$$super$run:40-org$scalatest$WordSpecLike$$super$run:40-runTests:40-runTest:40-withFixture:40-TestKit.within:707-TestKit.within:707
» Timeout
Is this fixed by #422 https://github.com/apache/flink/pull/422? Shall I
proceed?
Thanks!
—
Reply to this email directly or view it on GitHub
https://github.com/apache/flink/pull/402#issuecomment-75220973.
[Gelly] Enable access to aggregators and broadcast sets in vertex-centric
iteration
---
Key: FLINK-1515
URL: https://issues.apache.org/jira/browse/FLINK-1515
Project: Flink
Issue Type: Improvement
Components: Gelly
Reporter: Vasia Kalavri
Assignee: Martin Kiefer
Currently, aggregators and broadcast sets cannot be accessed through Gelly's
{{runVertexCentricIteration}} method. The functionality is already present in
the {{VertexCentricIteration}} and we just need to expose it.
This could be done like this: We create a method
{{createVertexCentricIteration}}, which will return a
{{VertexCentricIteration}} object and we change {{runVertexCentricIteration}}
to accept this as a parameter (and return the graph after running this
iteration).
The user can configure the {{VertexCentricIteration}} by directly calling the
public methods {{registerAggregator}}, {{setName}}, etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-1515) [Gelly] Enable access to aggregators and broadcast sets in vertex-centric iteration
[
https://issues.apache.org/jira/browse/FLINK-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14327219#comment-14327219
]
ASF GitHub Bot commented on FLINK-1515:
---
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/402#issuecomment-75029446
Oh, one minor thing.. Could you prefix your commits with [FLINK-1515]
[gelly] ? Thanks!
[Gelly] Enable access to aggregators and broadcast sets in vertex-centric
iteration
---
Key: FLINK-1515
URL: https://issues.apache.org/jira/browse/FLINK-1515
Project: Flink
Issue Type: Improvement
Components: Gelly
Reporter: Vasia Kalavri
Assignee: Martin Kiefer
Currently, aggregators and broadcast sets cannot be accessed through Gelly's
{{runVertexCentricIteration}} method. The functionality is already present in
the {{VertexCentricIteration}} and we just need to expose it.
This could be done like this: We create a method
{{createVertexCentricIteration}}, which will return a
{{VertexCentricIteration}} object and we change {{runVertexCentricIteration}}
to accept this as a parameter (and return the graph after running this
iteration).
The user can configure the {{VertexCentricIteration}} by directly calling the
public methods {{registerAggregator}}, {{setName}}, etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-1515) [Gelly] Enable access to aggregators and broadcast sets in vertex-centric iteration
[
https://issues.apache.org/jira/browse/FLINK-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14327396#comment-14327396
]
ASF GitHub Bot commented on FLINK-1515:
---
Github user cebe commented on the pull request:
https://github.com/apache/flink/pull/402#issuecomment-75051739
:+1:
[Gelly] Enable access to aggregators and broadcast sets in vertex-centric
iteration
---
Key: FLINK-1515
URL: https://issues.apache.org/jira/browse/FLINK-1515
Project: Flink
Issue Type: Improvement
Components: Gelly
Reporter: Vasia Kalavri
Assignee: Martin Kiefer
Currently, aggregators and broadcast sets cannot be accessed through Gelly's
{{runVertexCentricIteration}} method. The functionality is already present in
the {{VertexCentricIteration}} and we just need to expose it.
This could be done like this: We create a method
{{createVertexCentricIteration}}, which will return a
{{VertexCentricIteration}} object and we change {{runVertexCentricIteration}}
to accept this as a parameter (and return the graph after running this
iteration).
The user can configure the {{VertexCentricIteration}} by directly calling the
public methods {{registerAggregator}}, {{setName}}, etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-1515) [Gelly] Enable access to aggregators and broadcast sets in vertex-centric iteration
[
https://issues.apache.org/jira/browse/FLINK-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14324128#comment-14324128
]
ASF GitHub Bot commented on FLINK-1515:
---
Github user martinkiefer commented on the pull request:
https://github.com/apache/flink/pull/402#issuecomment-74660459
I could change `PageRank` to read the number of vertices by broadcasting
the result of `numberofVertices()` instead of providing it in the constructor
of the algorithm. I guess, this is the use case that comes most naturally.
[Gelly] Enable access to aggregators and broadcast sets in vertex-centric
iteration
---
Key: FLINK-1515
URL: https://issues.apache.org/jira/browse/FLINK-1515
Project: Flink
Issue Type: Improvement
Components: Gelly
Reporter: Vasia Kalavri
Assignee: Martin Kiefer
Currently, aggregators and broadcast sets cannot be accessed through Gelly's
{{runVertexCentricIteration}} method. The functionality is already present in
the {{VertexCentricIteration}} and we just need to expose it.
This could be done like this: We create a method
{{createVertexCentricIteration}}, which will return a
{{VertexCentricIteration}} object and we change {{runVertexCentricIteration}}
to accept this as a parameter (and return the graph after running this
iteration).
The user can configure the {{VertexCentricIteration}} by directly calling the
public methods {{registerAggregator}}, {{setName}}, etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-1515) [Gelly] Enable access to aggregators and broadcast sets in vertex-centric iteration
[
https://issues.apache.org/jira/browse/FLINK-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322886#comment-14322886
]
ASF GitHub Bot commented on FLINK-1515:
---
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/402#issuecomment-74525590
Hi @martinkiefer! Thanks a lot for this pull request!
The change looks good :)
I was only thinking that it would be nice to have an example that
demonstrates how to use broadcast sets and / or aggregators now. It could
simply be a slight modification of an existing example, e.g. SSSP with a
counter of how many nodes have distance less than some value or similar. Could
you make this addition?
[Gelly] Enable access to aggregators and broadcast sets in vertex-centric
iteration
---
Key: FLINK-1515
URL: https://issues.apache.org/jira/browse/FLINK-1515
Project: Flink
Issue Type: Improvement
Components: Gelly
Reporter: Vasia Kalavri
Assignee: Martin Kiefer
Currently, aggregators and broadcast sets cannot be accessed through Gelly's
{{runVertexCentricIteration}} method. The functionality is already present in
the {{VertexCentricIteration}} and we just need to expose it.
This could be done like this: We create a method
{{createVertexCentricIteration}}, which will return a
{{VertexCentricIteration}} object and we change {{runVertexCentricIteration}}
to accept this as a parameter (and return the graph after running this
iteration).
The user can configure the {{VertexCentricIteration}} by directly calling the
public methods {{registerAggregator}}, {{setName}}, etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-1515) [Gelly] Enable access to aggregators and broadcast sets in vertex-centric iteration
[
https://issues.apache.org/jira/browse/FLINK-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322183#comment-14322183
]
ASF GitHub Bot commented on FLINK-1515:
---
GitHub user martinkiefer opened a pull request:
https://github.com/apache/flink/pull/402
[FLINK-1515]Splitted runVertexCentricIteration into
createVertexCentricIteration and runVertexCentricIteration
I changed the process for running a vertex-centric iteration in Gelly into
a two-step procedure:
1. `createVertexCentricIteration` returns a `VertexCentricIteration` object
to allow developers to access features like broadcast data sets and
aggregators.
2. `runVertexCentricIteration` expects a `VertexCentricIteration` and
returns the `Graph`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/martinkiefer/flink iteration
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/402.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #402
commit 151e4c3be53bb61ee1c33b4ce4f36c03bcfabc3e
Author: Martin Kiefer martinkie...@boxm.de
Date: 2015-02-15T17:07:52Z
Splitted runVertexCentricIteration into createVertexIteration and
runVertexIteration to make VertexCentricIteration object accessible to
developers.
[Gelly] Enable access to aggregators and broadcast sets in vertex-centric
iteration
---
Key: FLINK-1515
URL: https://issues.apache.org/jira/browse/FLINK-1515
Project: Flink
Issue Type: Improvement
Components: Gelly
Reporter: Vasia Kalavri
Assignee: Martin Kiefer
Currently, aggregators and broadcast sets cannot be accessed through Gelly's
{{runVertexCentricIteration}} method. The functionality is already present in
the {{VertexCentricIteration}} and we just need to expose it.
This could be done like this: We create a method
{{createVertexCentricIteration}}, which will return a
{{VertexCentricIteration}} object and we change {{runVertexCentricIteration}}
to accept this as a parameter (and return the graph after running this
iteration).
The user can configure the {{VertexCentricIteration}} by directly calling the
public methods {{registerAggregator}}, {{setName}}, etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-1515) [Gelly] Enable access to aggregators and broadcast sets in vertex-centric iteration
[
https://issues.apache.org/jira/browse/FLINK-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14316819#comment-14316819
]
Martin Kiefer commented on FLINK-1515:
--
I will do it. You can assign me.
[Gelly] Enable access to aggregators and broadcast sets in vertex-centric
iteration
---
Key: FLINK-1515
URL: https://issues.apache.org/jira/browse/FLINK-1515
Project: Flink
Issue Type: Improvement
Components: Gelly
Reporter: Vasia Kalavri
Currently, aggregators and broadcast sets cannot be accessed through Gelly's
{{runVertexCentricIteration}} method. The functionality is already present in
the {{VertexCentricIteration}} and we just need to expose it.
This could be done like this: We create a method
{{createVertexCentricIteration}}, which will return a
{{VertexCentricIteration}} object and we change {{runVertexCentricIteration}}
to accept this as a parameter (and return the graph after running this
iteration).
The user can configure the {{VertexCentricIteration}} by directly calling the
public methods {{registerAggregator}}, {{setName}}, etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-1515) [Gelly] Enable access to aggregators and broadcast sets in vertex-centric iteration
[
https://issues.apache.org/jira/browse/FLINK-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14316881#comment-14316881
]
Vasia Kalavri commented on FLINK-1515:
--
Done! Thank you :)
[Gelly] Enable access to aggregators and broadcast sets in vertex-centric
iteration
---
Key: FLINK-1515
URL: https://issues.apache.org/jira/browse/FLINK-1515
Project: Flink
Issue Type: Improvement
Components: Gelly
Reporter: Vasia Kalavri
Assignee: Martin Kiefer
Currently, aggregators and broadcast sets cannot be accessed through Gelly's
{{runVertexCentricIteration}} method. The functionality is already present in
the {{VertexCentricIteration}} and we just need to expose it.
This could be done like this: We create a method
{{createVertexCentricIteration}}, which will return a
{{VertexCentricIteration}} object and we change {{runVertexCentricIteration}}
to accept this as a parameter (and return the graph after running this
iteration).
The user can configure the {{VertexCentricIteration}} by directly calling the
public methods {{registerAggregator}}, {{setName}}, etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
