[jira] [Commented] (FLINK-1711) Replace all usages off commons.Validate with guava.check
[
https://issues.apache.org/jira/browse/FLINK-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14545200#comment-14545200
]
ASF GitHub Bot commented on FLINK-1711:
---
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/673#issuecomment-102337633
I'm running a last check on travis on my branch. Then I'm merging this.
Thanks for your work!
Replace all usages off commons.Validate with guava.check
Key: FLINK-1711
URL: https://issues.apache.org/jira/browse/FLINK-1711
Project: Flink
Issue Type: Improvement
Affects Versions: 0.9
Reporter: Stephan Ewen
Assignee: Lokesh Rajaram
Priority: Minor
Labels: easyfix, starter
Fix For: 0.9
Per discussion on the mailing list, we decided to increase homogeneity. One
part is to consistently use the Guava methods {{checkNotNull}} and
{{checkArgument}}, rather than Apache Commons Lang3 {{Validate}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-1711) Replace all usages off commons.Validate with guava.check
[
https://issues.apache.org/jira/browse/FLINK-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14545699#comment-14545699
]
ASF GitHub Bot commented on FLINK-1711:
---
Github user lokeshrajaram commented on the pull request:
https://github.com/apache/flink/pull/673#issuecomment-102445184
Thanks @aljoscha .I notice above it says This pull request is closed, but
the lokeshrajaram:all_guava branch has unmerged commits. Is there anything
more needs to be done for this?
Replace all usages off commons.Validate with guava.check
Key: FLINK-1711
URL: https://issues.apache.org/jira/browse/FLINK-1711
Project: Flink
Issue Type: Improvement
Affects Versions: 0.9
Reporter: Stephan Ewen
Assignee: Lokesh Rajaram
Priority: Minor
Labels: easyfix, starter
Fix For: 0.9
Per discussion on the mailing list, we decided to increase homogeneity. One
part is to consistently use the Guava methods {{checkNotNull}} and
{{checkArgument}}, rather than Apache Commons Lang3 {{Validate}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-1711) Replace all usages off commons.Validate with guava.check
[
https://issues.apache.org/jira/browse/FLINK-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14545746#comment-14545746
]
ASF GitHub Bot commented on FLINK-1711:
---
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/673#issuecomment-102452915
That's because I rebased your commit which changes the signature of the
commit. But if you look here https://github.com/apache/flink/commits/master you
can see that your commit is among the most recent ones. :smile:
Replace all usages off commons.Validate with guava.check
Key: FLINK-1711
URL: https://issues.apache.org/jira/browse/FLINK-1711
Project: Flink
Issue Type: Improvement
Affects Versions: 0.9
Reporter: Stephan Ewen
Assignee: Lokesh Rajaram
Priority: Minor
Labels: easyfix, starter
Fix For: 0.9
Per discussion on the mailing list, we decided to increase homogeneity. One
part is to consistently use the Guava methods {{checkNotNull}} and
{{checkArgument}}, rather than Apache Commons Lang3 {{Validate}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-1711) Replace all usages off commons.Validate with guava.check
[
https://issues.apache.org/jira/browse/FLINK-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14543938#comment-14543938
]
ASF GitHub Bot commented on FLINK-1711:
---
Github user lokeshrajaram closed the pull request at:
https://github.com/apache/flink/pull/673
Replace all usages off commons.Validate with guava.check
Key: FLINK-1711
URL: https://issues.apache.org/jira/browse/FLINK-1711
Project: Flink
Issue Type: Improvement
Affects Versions: 0.9
Reporter: Stephan Ewen
Assignee: Lokesh Rajaram
Priority: Minor
Labels: easyfix, starter
Fix For: 0.9
Per discussion on the mailing list, we decided to increase homogeneity. One
part is to consistently use the Guava methods {{checkNotNull}} and
{{checkArgument}}, rather than Apache Commons Lang3 {{Validate}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-1711) Replace all usages off commons.Validate with guava.check
[
https://issues.apache.org/jira/browse/FLINK-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14543940#comment-14543940
]
ASF GitHub Bot commented on FLINK-1711:
---
GitHub user lokeshrajaram reopened a pull request:
https://github.com/apache/flink/pull/673
[FLINK-1711] - Converted all usages of Commons Validate to Guava Checks(for
Java classes), Scala predef require(for Scala classes)
[FLINK-1711] - Converted all usages of Commons Validate to Guava Checks(for
Java classes), Scala predef require(for Scala classes)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lokeshrajaram/flink all_guava
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/673.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #673
commit 04e1695d3b8414616216264a5b0972d762664ec7
Author: lrajaram lokesh_raja...@intuit.com
Date: 2015-05-10T01:57:36Z
converted all usages of Commons Validate to Guava Checks
commit 4f68d03d50d0fab47f5067906ec805f4a8b93cfa
Author: lrajaram lokesh_raja...@intuit.com
Date: 2015-05-14T02:29:03Z
converted all usages of commons validate to guava checks(for Java classes),
scala predef require(for scala classes)
commit 1ecf70952a75728a2e2b9ae70e8f2c66ca9d337a
Author: lrajaram lokesh_raja...@intuit.com
Date: 2015-05-14T14:43:03Z
added guava dependency for flink-spargel module
Replace all usages off commons.Validate with guava.check
Key: FLINK-1711
URL: https://issues.apache.org/jira/browse/FLINK-1711
Project: Flink
Issue Type: Improvement
Affects Versions: 0.9
Reporter: Stephan Ewen
Assignee: Lokesh Rajaram
Priority: Minor
Labels: easyfix, starter
Fix For: 0.9
Per discussion on the mailing list, we decided to increase homogeneity. One
part is to consistently use the Guava methods {{checkNotNull}} and
{{checkArgument}}, rather than Apache Commons Lang3 {{Validate}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-1711) Replace all usages off commons.Validate with guava.check
[
https://issues.apache.org/jira/browse/FLINK-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14544863#comment-14544863
]
ASF GitHub Bot commented on FLINK-1711:
---
Github user lokeshrajaram closed the pull request at:
https://github.com/apache/flink/pull/673
Replace all usages off commons.Validate with guava.check
Key: FLINK-1711
URL: https://issues.apache.org/jira/browse/FLINK-1711
Project: Flink
Issue Type: Improvement
Affects Versions: 0.9
Reporter: Stephan Ewen
Assignee: Lokesh Rajaram
Priority: Minor
Labels: easyfix, starter
Fix For: 0.9
Per discussion on the mailing list, we decided to increase homogeneity. One
part is to consistently use the Guava methods {{checkNotNull}} and
{{checkArgument}}, rather than Apache Commons Lang3 {{Validate}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-1711) Replace all usages off commons.Validate with guava.check
[
https://issues.apache.org/jira/browse/FLINK-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14543112#comment-14543112
]
ASF GitHub Bot commented on FLINK-1711:
---
GitHub user lokeshrajaram opened a pull request:
https://github.com/apache/flink/pull/673
[FLINK-1711] - Converted all usages of Commons Validate to Guava Checks(for
Java classes), Scala predef require(for Scala classes)
[FLINK-1711] - Converted all usages of Commons Validate to Guava Checks(for
Java classes), Scala predef require(for Scala classes)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lokeshrajaram/flink all_guava
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/673.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #673
commit 04e1695d3b8414616216264a5b0972d762664ec7
Author: lrajaram lokesh_raja...@intuit.com
Date: 2015-05-10T01:57:36Z
converted all usages of Commons Validate to Guava Checks
commit 4f68d03d50d0fab47f5067906ec805f4a8b93cfa
Author: lrajaram lokesh_raja...@intuit.com
Date: 2015-05-14T02:29:03Z
converted all usages of commons validate to guava checks(for Java classes),
scala predef require(for scala classes)
Replace all usages off commons.Validate with guava.check
Key: FLINK-1711
URL: https://issues.apache.org/jira/browse/FLINK-1711
Project: Flink
Issue Type: Improvement
Affects Versions: 0.9
Reporter: Stephan Ewen
Assignee: Lokesh Rajaram
Priority: Minor
Labels: easyfix, starter
Fix For: 0.9
Per discussion on the mailing list, we decided to increase homogeneity. One
part is to consistently use the Guava methods {{checkNotNull}} and
{{checkArgument}}, rather than Apache Commons Lang3 {{Validate}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-1711) Replace all usages off commons.Validate with guava.check
[
https://issues.apache.org/jira/browse/FLINK-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537082#comment-14537082
]
Mathusuthan Kannan commented on FLINK-1711:
---
Robert,
I am sorry I could not complete it ... Pls assign it to those who may be
interested. My sincere apologies.
Regards
On Sat, May 9, 2015 at 4:23 PM, Robert Metzger (JIRA) j...@apache.org
Replace all usages off commons.Validate with guava.check
Key: FLINK-1711
URL: https://issues.apache.org/jira/browse/FLINK-1711
Project: Flink
Issue Type: Improvement
Affects Versions: 0.9
Reporter: Stephan Ewen
Assignee: Mathusuthan Kannan
Priority: Minor
Labels: easyfix, starter
Fix For: 0.9
Per discussion on the mailing list, we decided to increase homogeneity. One
part is to consistently use the Guava methods {{checkNotNull}} and
{{checkArgument}}, rather than Apache Commons Lang3 {{Validate}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-1711) Replace all usages off commons.Validate with guava.check
[
https://issues.apache.org/jira/browse/FLINK-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537109#comment-14537109
]
Robert Metzger commented on FLINK-1711:
---
Hey, no problem ;)
I assigned [~lokeshrajaram] to the issue.
Replace all usages off commons.Validate with guava.check
Key: FLINK-1711
URL: https://issues.apache.org/jira/browse/FLINK-1711
Project: Flink
Issue Type: Improvement
Affects Versions: 0.9
Reporter: Stephan Ewen
Assignee: Lokesh Rajaram
Priority: Minor
Labels: easyfix, starter
Fix For: 0.9
Per discussion on the mailing list, we decided to increase homogeneity. One
part is to consistently use the Guava methods {{checkNotNull}} and
{{checkArgument}}, rather than Apache Commons Lang3 {{Validate}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-1711) Replace all usages off commons.Validate with guava.check
[
https://issues.apache.org/jira/browse/FLINK-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14536359#comment-14536359
]
Robert Metzger commented on FLINK-1711:
---
Hey [~mathnkann],
are you still working on the issue?
Its no problem if you stopped working on it. But it would be nice if you could
let us know so that others who are interested in working on Flink can pick it
up.
Replace all usages off commons.Validate with guava.check
Key: FLINK-1711
URL: https://issues.apache.org/jira/browse/FLINK-1711
Project: Flink
Issue Type: Improvement
Affects Versions: 0.9
Reporter: Stephan Ewen
Assignee: Mathusuthan Kannan
Priority: Minor
Labels: easyfix, starter
Fix For: 0.9
Per discussion on the mailing list, we decided to increase homogeneity. One
part is to consistently use the Guava methods {{checkNotNull}} and
{{checkArgument}}, rather than Apache Commons Lang3 {{Validate}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-1711) Replace all usages off commons.Validate with guava.check
[
https://issues.apache.org/jira/browse/FLINK-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385721#comment-14385721
]
Mathusuthan Kannan commented on FLINK-1711:
---
Hi,
I would like to work on this issue so I can familiarize myself with the
contribution process. Would surely take on more issues once I feel comfortable
with the process.
Thanks
Replace all usages off commons.Validate with guava.check
Key: FLINK-1711
URL: https://issues.apache.org/jira/browse/FLINK-1711
Project: Flink
Issue Type: Improvement
Affects Versions: 0.9
Reporter: Stephan Ewen
Priority: Minor
Labels: easyfix, starter
Fix For: 0.9
Per discussion on the mailing list, we decided to increase homogeneity. One
part is to consistently use the Guava methods {{checkNotNull}} and
{{checkArgument}}, rather than Apache Commons Lang3 {{Validate}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-1711) Replace all usages off commons.Validate with guava.check
[
https://issues.apache.org/jira/browse/FLINK-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385727#comment-14385727
]
Fabian Hueske commented on FLINK-1711:
--
Welcome to the Flink community!
I assigned this issue to you. It is your now :-)
Let us know, if you have any questions or need help with something.
Cheers, Fabian
Replace all usages off commons.Validate with guava.check
Key: FLINK-1711
URL: https://issues.apache.org/jira/browse/FLINK-1711
Project: Flink
Issue Type: Improvement
Affects Versions: 0.9
Reporter: Stephan Ewen
Assignee: Mathusuthan Kannan
Priority: Minor
Labels: easyfix, starter
Fix For: 0.9
Per discussion on the mailing list, we decided to increase homogeneity. One
part is to consistently use the Guava methods {{checkNotNull}} and
{{checkArgument}}, rather than Apache Commons Lang3 {{Validate}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
