[jira] [Commented] (FLINK-19400) Removed unused BufferPoolOwner

2020-10-01 Thread Arvid Heise (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-19400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205297#comment-17205297
 ] 

Arvid Heise commented on FLINK-19400:
-

Merged into master as part of FLINK-16972.

> Removed unused BufferPoolOwner
> --
>
> Key: FLINK-19400
> URL: https://issues.apache.org/jira/browse/FLINK-19400
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Network
>Affects Versions: 1.12.0
>Reporter: Arvid Heise
>Assignee: Arvid Heise
>Priority: Major
>
> {{BufferPoolOwner}} does not have any production usages and just complicates 
> a few tests.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (FLINK-19400) Removed unused BufferPoolOwner

2020-09-27 Thread Zhijiang (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-19400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202759#comment-17202759
 ] 

Zhijiang commented on FLINK-19400:
--

+1 to remove, it is indeed no actual usages in core codes, as 
`ResultPartition#releaseMemory` is empty and we have to pass `nullable` owner 
in related constructors and maintain the related logics.

> Removed unused BufferPoolOwner
> --
>
> Key: FLINK-19400
> URL: https://issues.apache.org/jira/browse/FLINK-19400
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Network
>Affects Versions: 1.12.0
>Reporter: Arvid Heise
>Assignee: Arvid Heise
>Priority: Major
>
> {{BufferPoolOwner}} does not have any production usages and just complicates 
> a few tests.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (FLINK-19400) Removed unused BufferPoolOwner

2020-09-25 Thread Arvid Heise (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-19400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201989#comment-17201989
 ] 

Arvid Heise commented on FLINK-19400:
-

I think Zhijiang already gave green light.

[~sewen], [~pnowojski] also did not object, so I'd start with it. I'm waiting a 
few days until actually going through with it.

> Removed unused BufferPoolOwner
> --
>
> Key: FLINK-19400
> URL: https://issues.apache.org/jira/browse/FLINK-19400
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Network
>Affects Versions: 1.12.0
>Reporter: Arvid Heise
>Assignee: Arvid Heise
>Priority: Major
>
> {{BufferPoolOwner}} does not have any production usages and just complicates 
> a few tests.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (FLINK-19400) Removed unused BufferPoolOwner

2020-09-25 Thread Nicholas Jiang (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-19400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201983#comment-17201983
 ] 

Nicholas Jiang commented on FLINK-19400:


[~AHeise], I agree with you. IMO, BufferPoolOwner only works for releasing 
memory buffers, and releaseInternal of ResultPartition could also release the 
memory buffers, no need to implement BufferPoolOwner to release memory 
separately.
[~zjwang],[~kevin.cyj] what do you think about?

> Removed unused BufferPoolOwner
> --
>
> Key: FLINK-19400
> URL: https://issues.apache.org/jira/browse/FLINK-19400
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Network
>Affects Versions: 1.12.0
>Reporter: Arvid Heise
>Priority: Major
>
> {{BufferPoolOwner}} does not have any production usages and just complicates 
> a few tests.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)