[jira] [Commented] (FLINK-2703) Remove log4j classes from fat jar / document how to use Flink with logback

[Fabian Hueske (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14943551#comment-14943551
 ] 

Fabian Hueske commented on FLINK-2703:
--

[~rmetzger] Was this issue completely resolved by the PR? Can it be closed?

> Remove log4j classes from fat jar / document how to use Flink with logback
> --
>
> Key: FLINK-2703
> URL: https://issues.apache.org/jira/browse/FLINK-2703
> Project: Flink
>  Issue Type: Task
>  Components: Build System
>Affects Versions: 0.10
>Reporter: Robert Metzger
>Assignee: Robert Metzger
>
> Flink is using slf4j as the logging interface and log4j as the logging 
> backend.
> I got requests from users which want to use a different logging backend 
> (logback) with Flink. Currently, its quite hard for them, because they have 
> to do a custom Flink build with log4j excluded.
> The purpose of this JIRA is to ship a Flink build that is prepared for users 
> to use a different logging backend.
> I'm also going to document how to use logback with Flink.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2703) Remove log4j classes from fat jar / document how to use Flink with logback

[Robert Metzger (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14943554#comment-14943554
 ] 

Robert Metzger commented on FLINK-2703:
---

Sorry. I forgot to close it.

> Remove log4j classes from fat jar / document how to use Flink with logback
> --
>
> Key: FLINK-2703
> URL: https://issues.apache.org/jira/browse/FLINK-2703
> Project: Flink
>  Issue Type: Task
>  Components: Build System
>Affects Versions: 0.10
>Reporter: Robert Metzger
>Assignee: Robert Metzger
> Fix For: 0.10
>
>
> Flink is using slf4j as the logging interface and log4j as the logging 
> backend.
> I got requests from users which want to use a different logging backend 
> (logback) with Flink. Currently, its quite hard for them, because they have 
> to do a custom Flink build with log4j excluded.
> The purpose of this JIRA is to ship a Flink build that is prepared for users 
> to use a different logging backend.
> I'm also going to document how to use logback with Flink.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2703) Remove log4j classes from fat jar / document how to use Flink with logback

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14936480#comment-14936480
 ] 

ASF GitHub Bot commented on FLINK-2703:
---

Github user rmetzger commented on a diff in the pull request:

https://github.com/apache/flink/pull/1194#discussion_r40764829
  
--- Diff: flink-dist/src/main/assemblies/bin.xml ---
@@ -40,6 +40,9 @@ under the License.
 

org.apache.flink:flink-python
+   org.apache.flink:flink-python
--- End diff --

Oops... Yes. I'll remove that again


> Remove log4j classes from fat jar / document how to use Flink with logback
> --
>
> Key: FLINK-2703
> URL: https://issues.apache.org/jira/browse/FLINK-2703
> Project: Flink
>  Issue Type: Task
>  Components: Build System
>Affects Versions: 0.10
>Reporter: Robert Metzger
>Assignee: Robert Metzger
>
> Flink is using slf4j as the logging interface and log4j as the logging 
> backend.
> I got requests from users which want to use a different logging backend 
> (logback) with Flink. Currently, its quite hard for them, because they have 
> to do a custom Flink build with log4j excluded.
> The purpose of this JIRA is to ship a Flink build that is prepared for users 
> to use a different logging backend.
> I'm also going to document how to use logback with Flink.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2703) Remove log4j classes from fat jar / document how to use Flink with logback

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14937298#comment-14937298
 ] 

ASF GitHub Bot commented on FLINK-2703:
---

Github user rmetzger commented on the pull request:

https://github.com/apache/flink/pull/1194#issuecomment-144459509
  
Thank you for the review. I'm merging this PR


> Remove log4j classes from fat jar / document how to use Flink with logback
> --
>
> Key: FLINK-2703
> URL: https://issues.apache.org/jira/browse/FLINK-2703
> Project: Flink
>  Issue Type: Task
>  Components: Build System
>Affects Versions: 0.10
>Reporter: Robert Metzger
>Assignee: Robert Metzger
>
> Flink is using slf4j as the logging interface and log4j as the logging 
> backend.
> I got requests from users which want to use a different logging backend 
> (logback) with Flink. Currently, its quite hard for them, because they have 
> to do a custom Flink build with log4j excluded.
> The purpose of this JIRA is to ship a Flink build that is prepared for users 
> to use a different logging backend.
> I'm also going to document how to use logback with Flink.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2703) Remove log4j classes from fat jar / document how to use Flink with logback

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14937439#comment-14937439
 ] 

ASF GitHub Bot commented on FLINK-2703:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/1194


> Remove log4j classes from fat jar / document how to use Flink with logback
> --
>
> Key: FLINK-2703
> URL: https://issues.apache.org/jira/browse/FLINK-2703
> Project: Flink
>  Issue Type: Task
>  Components: Build System
>Affects Versions: 0.10
>Reporter: Robert Metzger
>Assignee: Robert Metzger
>
> Flink is using slf4j as the logging interface and log4j as the logging 
> backend.
> I got requests from users which want to use a different logging backend 
> (logback) with Flink. Currently, its quite hard for them, because they have 
> to do a custom Flink build with log4j excluded.
> The purpose of this JIRA is to ship a Flink build that is prepared for users 
> to use a different logging backend.
> I'm also going to document how to use logback with Flink.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2703) Remove log4j classes from fat jar / document how to use Flink with logback

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14935862#comment-14935862
 ] 

ASF GitHub Bot commented on FLINK-2703:
---

Github user StephanEwen commented on a diff in the pull request:

https://github.com/apache/flink/pull/1194#discussion_r40730119
  
--- Diff: flink-dist/src/main/assemblies/bin.xml ---
@@ -40,6 +40,9 @@ under the License.
 

org.apache.flink:flink-python
+   org.apache.flink:flink-python
--- End diff --

Accidental line duplication?


> Remove log4j classes from fat jar / document how to use Flink with logback
> --
>
> Key: FLINK-2703
> URL: https://issues.apache.org/jira/browse/FLINK-2703
> Project: Flink
>  Issue Type: Task
>  Components: Build System
>Affects Versions: 0.10
>Reporter: Robert Metzger
>Assignee: Robert Metzger
>
> Flink is using slf4j as the logging interface and log4j as the logging 
> backend.
> I got requests from users which want to use a different logging backend 
> (logback) with Flink. Currently, its quite hard for them, because they have 
> to do a custom Flink build with log4j excluded.
> The purpose of this JIRA is to ship a Flink build that is prepared for users 
> to use a different logging backend.
> I'm also going to document how to use logback with Flink.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2703) Remove log4j classes from fat jar / document how to use Flink with logback

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14935865#comment-14935865
 ] 

ASF GitHub Bot commented on FLINK-2703:
---

Github user StephanEwen commented on the pull request:

https://github.com/apache/flink/pull/1194#issuecomment-144192517
  
Nice addition, looks good to me!

+1 to merge this


> Remove log4j classes from fat jar / document how to use Flink with logback
> --
>
> Key: FLINK-2703
> URL: https://issues.apache.org/jira/browse/FLINK-2703
> Project: Flink
>  Issue Type: Task
>  Components: Build System
>Affects Versions: 0.10
>Reporter: Robert Metzger
>Assignee: Robert Metzger
>
> Flink is using slf4j as the logging interface and log4j as the logging 
> backend.
> I got requests from users which want to use a different logging backend 
> (logback) with Flink. Currently, its quite hard for them, because they have 
> to do a custom Flink build with log4j excluded.
> The purpose of this JIRA is to ship a Flink build that is prepared for users 
> to use a different logging backend.
> I'm also going to document how to use logback with Flink.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2703) Remove log4j classes from fat jar / document how to use Flink with logback

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14935787#comment-14935787
 ] 

ASF GitHub Bot commented on FLINK-2703:
---

GitHub user rmetzger opened a pull request:

https://github.com/apache/flink/pull/1194

[FLINK-2703] Prepare Flink for using it with Logback.

i was talking to a user recently who asked for using Logback instead of 
Log4j.

This pull request is adding a section in the "Best practices" page which 
describes how to use Logback for running Flink locally from the IDE and on a 
cluster.
I also needed to change the pom's of `flink-dist`: They are now placing 
log4j and slf4j-log4j as separate jars into the lib/ folder (instead of packing 
them into the fat jar).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rmetzger/flink flink2703

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/1194.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1194


commit 505778994ce9bce1a8389e4c7ba0c782512cd65a
Author: Robert Metzger 
Date:   2015-09-28T10:16:29Z

[FLINK-2703] Prepare Flink for being used with Logback.




> Remove log4j classes from fat jar / document how to use Flink with logback
> --
>
> Key: FLINK-2703
> URL: https://issues.apache.org/jira/browse/FLINK-2703
> Project: Flink
>  Issue Type: Task
>  Components: Build System
>Affects Versions: 0.10
>Reporter: Robert Metzger
>Assignee: Robert Metzger
>
> Flink is using slf4j as the logging interface and log4j as the logging 
> backend.
> I got requests from users which want to use a different logging backend 
> (logback) with Flink. Currently, its quite hard for them, because they have 
> to do a custom Flink build with log4j excluded.
> The purpose of this JIRA is to ship a Flink build that is prepared for users 
> to use a different logging backend.
> I'm also going to document how to use logback with Flink.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)