[jira] [Commented] (FLINK-3513) Fix interplay of automatic Operator UID and Changing name of WindowOperator

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15167659#comment-15167659
 ] 

ASF GitHub Bot commented on FLINK-3513:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/1712


> Fix interplay of automatic Operator UID and Changing name of WindowOperator
> ---
>
> Key: FLINK-3513
> URL: https://issues.apache.org/jira/browse/FLINK-3513
> Project: Flink
>  Issue Type: Bug
>  Components: Streaming
>Affects Versions: 1.0.0
>Reporter: Aljoscha Krettek
>Assignee: Ufuk Celebi
>Priority: Blocker
> Fix For: 1.0.0
>
>
> WindowOperator can have a changing name because it has the TypeSerializer 
> .toString() output in it's name. For some type serializers that don't 
> implement toString() this means that the name changes.
> This means that savepoint restore does not work for the automatically 
> generated UID.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3513) Fix interplay of automatic Operator UID and Changing name of WindowOperator

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15167654#comment-15167654
 ] 

ASF GitHub Bot commented on FLINK-3513:
---

Github user uce commented on the pull request:

https://github.com/apache/flink/pull/1712#issuecomment-188932532
  
I'm merging this to master.


> Fix interplay of automatic Operator UID and Changing name of WindowOperator
> ---
>
> Key: FLINK-3513
> URL: https://issues.apache.org/jira/browse/FLINK-3513
> Project: Flink
>  Issue Type: Bug
>  Components: Streaming
>Affects Versions: 1.0.0
>Reporter: Aljoscha Krettek
>Assignee: Ufuk Celebi
>Priority: Blocker
>
> WindowOperator can have a changing name because it has the TypeSerializer 
> .toString() output in it's name. For some type serializers that don't 
> implement toString() this means that the name changes.
> This means that savepoint restore does not work for the automatically 
> generated UID.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3513) Fix interplay of automatic Operator UID and Changing name of WindowOperator

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15167393#comment-15167393
 ] 

ASF GitHub Bot commented on FLINK-3513:
---

Github user uce commented on the pull request:

https://github.com/apache/flink/pull/1712#issuecomment-188862999
  
`mvn clean verify` was successful on my local machine, so if we need this 
for a new RC, we can merge it before the Travis run finishes.


> Fix interplay of automatic Operator UID and Changing name of WindowOperator
> ---
>
> Key: FLINK-3513
> URL: https://issues.apache.org/jira/browse/FLINK-3513
> Project: Flink
>  Issue Type: Bug
>  Components: Streaming
>Affects Versions: 1.0.0
>Reporter: Aljoscha Krettek
>Assignee: Ufuk Celebi
>Priority: Blocker
>
> WindowOperator can have a changing name because it has the TypeSerializer 
> .toString() output in it's name. For some type serializers that don't 
> implement toString() this means that the name changes.
> This means that savepoint restore does not work for the automatically 
> generated UID.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3513) Fix interplay of automatic Operator UID and Changing name of WindowOperator

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15167373#comment-15167373
 ] 

ASF GitHub Bot commented on FLINK-3513:
---

Github user aljoscha commented on the pull request:

https://github.com/apache/flink/pull/1712#issuecomment-188858495
  
:+1: 


> Fix interplay of automatic Operator UID and Changing name of WindowOperator
> ---
>
> Key: FLINK-3513
> URL: https://issues.apache.org/jira/browse/FLINK-3513
> Project: Flink
>  Issue Type: Bug
>  Components: Streaming
>Affects Versions: 1.0.0
>Reporter: Aljoscha Krettek
>Assignee: Ufuk Celebi
>Priority: Blocker
>
> WindowOperator can have a changing name because it has the TypeSerializer 
> .toString() output in it's name. For some type serializers that don't 
> implement toString() this means that the name changes.
> This means that savepoint restore does not work for the automatically 
> generated UID.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3513) Fix interplay of automatic Operator UID and Changing name of WindowOperator

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15167350#comment-15167350
 ] 

ASF GitHub Bot commented on FLINK-3513:
---

GitHub user uce opened a pull request:

https://github.com/apache/flink/pull/1712

[FLINK-3513] [FLINK-3512] Fix savepoint issues

@aljoscha spotted the following two issues (so far) while working with 
savepoints and the rocks DB state backend.

- FLINK-3513: The operator name is used in the deterministic hash 
assignment, which is actually not necessary and leads to problems with the 
WindowOperator (changing name).
- FLINK-3512: The savepoint backend was trying to be too clever and fell 
back to jobmanager when it found "wrong" config combinations.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/uce/flink hash_gen

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/1712.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1712


commit dab3c654fafecf8caee6453b7da8965174646771
Author: Ufuk Celebi 
Date:   2016-02-25T15:55:04Z

[FLINK-3513] [runtime] Fix interplay of automatic Operator UID and Changing 
name of WindowOperator

commit 3c3a81acee8de1128a3eee7f59ca6f8803acbd5c
Author: Ufuk Celebi 
Date:   2016-02-25T15:55:38Z

[FLINK-3512] [runtime] Savepoint backend should not revert to 'jobmanager'




> Fix interplay of automatic Operator UID and Changing name of WindowOperator
> ---
>
> Key: FLINK-3513
> URL: https://issues.apache.org/jira/browse/FLINK-3513
> Project: Flink
>  Issue Type: Bug
>  Components: Streaming
>Affects Versions: 1.0.0
>Reporter: Aljoscha Krettek
>Assignee: Ufuk Celebi
>Priority: Blocker
>
> WindowOperator can have a changing name because it has the TypeSerializer 
> .toString() output in it's name. For some type serializers that don't 
> implement toString() this means that the name changes.
> This means that savepoint restore does not work for the automatically 
> generated UID.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)