[jira] [Commented] (FLINK-3758) Add possibility to register accumulators in custom triggers

[ https://issues.apache.org/jira/browse/FLINK-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003353#comment-16003353 ] ASF GitHub Bot commented on FLINK-3758: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-3758) Add possibility to register accumulators in custom triggers

[ https://issues.apache.org/jira/browse/FLINK-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15333196#comment-15333196 ] ASF GitHub Bot commented on FLINK-3758: --- Github user aljoscha commented on the issue:

[jira] [Commented] (FLINK-3758) Add possibility to register accumulators in custom triggers

[ https://issues.apache.org/jira/browse/FLINK-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15333144#comment-15333144 ] Konstantin Knauf commented on FLINK-3758: - Sure. I see you alreaday open a PR for it. Great. >

[jira] [Commented] (FLINK-3758) Add possibility to register accumulators in custom triggers

[ https://issues.apache.org/jira/browse/FLINK-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327244#comment-15327244 ] Aljoscha Krettek commented on FLINK-3758: - [~knaufk] Would it be alright if I closed in favor of

[jira] [Commented] (FLINK-3758) Add possibility to register accumulators in custom triggers

[ https://issues.apache.org/jira/browse/FLINK-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15310006#comment-15310006 ] ASF GitHub Bot commented on FLINK-3758: --- Github user StephanEwen commented on the pull request:

[jira] [Commented] (FLINK-3758) Add possibility to register accumulators in custom triggers

[ https://issues.apache.org/jira/browse/FLINK-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15309998#comment-15309998 ] Robert Metzger commented on FLINK-3758: --- I think metrics and accumulators are going to co-exist.

[jira] [Commented] (FLINK-3758) Add possibility to register accumulators in custom triggers

[ https://issues.apache.org/jira/browse/FLINK-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308581#comment-15308581 ] ASF GitHub Bot commented on FLINK-3758: --- Github user rmetzger commented on the pull request:

[jira] [Commented] (FLINK-3758) Add possibility to register accumulators in custom triggers

[ https://issues.apache.org/jira/browse/FLINK-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15302624#comment-15302624 ] Aljoscha Krettek commented on FLINK-3758: - There might be one, I don't know too much about it,

[jira] [Commented] (FLINK-3758) Add possibility to register accumulators in custom triggers

[ https://issues.apache.org/jira/browse/FLINK-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15302555#comment-15302555 ] Konstantin Knauf commented on FLINK-3758: - [~aljoscha] Yes, in particular my goal is to monitor

[jira] [Commented] (FLINK-3758) Add possibility to register accumulators in custom triggers

[ https://issues.apache.org/jira/browse/FLINK-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298079#comment-15298079 ] Aljoscha Krettek commented on FLINK-3758: - The issue for the monitoring is this one: FLINK-456 >

[jira] [Commented] (FLINK-3758) Add possibility to register accumulators in custom triggers

[ https://issues.apache.org/jira/browse/FLINK-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298074#comment-15298074 ] Aljoscha Krettek commented on FLINK-3758: - [~knaufk], we might have to reconsider how this is

[jira] [Commented] (FLINK-3758) Add possibility to register accumulators in custom triggers

[ https://issues.apache.org/jira/browse/FLINK-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15279033#comment-15279033 ] ASF GitHub Bot commented on FLINK-3758: --- Github user knaufk closed the pull request at:

[jira] [Commented] (FLINK-3758) Add possibility to register accumulators in custom triggers

[ https://issues.apache.org/jira/browse/FLINK-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15279035#comment-15279035 ] ASF GitHub Bot commented on FLINK-3758: --- GitHub user knaufk reopened a pull request:

[jira] [Commented] (FLINK-3758) Add possibility to register accumulators in custom triggers

[ https://issues.apache.org/jira/browse/FLINK-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15276356#comment-15276356 ] Aljoscha Krettek commented on FLINK-3758: - Please open a PR. The changes look good, module some

[jira] [Commented] (FLINK-3758) Add possibility to register accumulators in custom triggers

[ https://issues.apache.org/jira/browse/FLINK-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15276351#comment-15276351 ] Aljoscha Krettek commented on FLINK-3758: - I'm looking at it. :-) > Add possibility to register

[jira] [Commented] (FLINK-3758) Add possibility to register accumulators in custom triggers

[ https://issues.apache.org/jira/browse/FLINK-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15276266#comment-15276266 ] Konstantin Knauf commented on FLINK-3758: - [~aljoscha] Ping. Going on vacation soon, and what to

[jira] [Commented] (FLINK-3758) Add possibility to register accumulators in custom triggers

[ https://issues.apache.org/jira/browse/FLINK-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272819#comment-15272819 ] Konstantin Knauf commented on FLINK-3758: - [~aljoscha] What do you think of

[jira] [Commented] (FLINK-3758) Add possibility to register accumulators in custom triggers

[ https://issues.apache.org/jira/browse/FLINK-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15250106#comment-15250106 ] Konstantin Knauf commented on FLINK-3758: - {quote} In the Trigger we would not know when to call

[jira] [Commented] (FLINK-3758) Add possibility to register accumulators in custom triggers

[ https://issues.apache.org/jira/browse/FLINK-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15249718#comment-15249718 ] Aljoscha Krettek commented on FLINK-3758: - Yes, I think it should work but we would need to add