[jira] [Commented] (FLINK-3999) Rename the `running` flag in the drivers to `canceled`
[
https://issues.apache.org/jira/browse/FLINK-3999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15591577#comment-15591577
]
ASF GitHub Bot commented on FLINK-3999:
---
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2642
@nssalian Thanks for understanding.
We as a community together have actually gone into that mode (more
conservative and stability focused) not too long ago. So it is still a bit of a
learning process for everyone here (committers and contributors).
> Rename the `running` flag in the drivers to `canceled`
> --
>
> Key: FLINK-3999
> URL: https://issues.apache.org/jira/browse/FLINK-3999
> Project: Flink
> Issue Type: Bug
> Components: Local Runtime
>Reporter: Gabor Gevay
>Assignee: Neelesh Srinivas Salian
>Priority: Trivial
>
> The name of the {{running}} flag in the drivers doesn't reflect its usage:
> when the operator just stops normally, then it is not running anymore, but
> the {{running}} flag will still be true, since the {{running}} flag is only
> set when cancelling.
> It should be renamed, and the value inverted.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-3999) Rename the `running` flag in the drivers to `canceled`
[
https://issues.apache.org/jira/browse/FLINK-3999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15588991#comment-15588991
]
ASF GitHub Bot commented on FLINK-3999:
---
Github user nssalian commented on the issue:
https://github.com/apache/flink/pull/2642
Thanks @uce, agreed, it would be a community effort indeed. I will try to
help as much as possible.
@ggevay, it's alright. I'll close the PR.
> Rename the `running` flag in the drivers to `canceled`
> --
>
> Key: FLINK-3999
> URL: https://issues.apache.org/jira/browse/FLINK-3999
> Project: Flink
> Issue Type: Bug
> Components: Local Runtime
>Reporter: Gabor Gevay
>Assignee: Neelesh Srinivas Salian
>Priority: Trivial
>
> The name of the {{running}} flag in the drivers doesn't reflect its usage:
> when the operator just stops normally, then it is not running anymore, but
> the {{running}} flag will still be true, since the {{running}} flag is only
> set when cancelling.
> It should be renamed, and the value inverted.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-3999) Rename the `running` flag in the drivers to `canceled`
[
https://issues.apache.org/jira/browse/FLINK-3999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15588992#comment-15588992
]
ASF GitHub Bot commented on FLINK-3999:
---
Github user nssalian closed the pull request at:
https://github.com/apache/flink/pull/2642
> Rename the `running` flag in the drivers to `canceled`
> --
>
> Key: FLINK-3999
> URL: https://issues.apache.org/jira/browse/FLINK-3999
> Project: Flink
> Issue Type: Bug
> Components: Local Runtime
>Reporter: Gabor Gevay
>Assignee: Neelesh Srinivas Salian
>Priority: Trivial
>
> The name of the {{running}} flag in the drivers doesn't reflect its usage:
> when the operator just stops normally, then it is not running anymore, but
> the {{running}} flag will still be true, since the {{running}} flag is only
> set when cancelling.
> It should be renamed, and the value inverted.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-3999) Rename the `running` flag in the drivers to `canceled`
[
https://issues.apache.org/jira/browse/FLINK-3999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15588183#comment-15588183
]
ASF GitHub Bot commented on FLINK-3999:
---
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2642
@nssalian Your suggestion regarding JIRAs makes very much sense. Let's try
to ensure that this does not happen again. But no single person can do this
alone... we have to do it as a community.
> Rename the `running` flag in the drivers to `canceled`
> --
>
> Key: FLINK-3999
> URL: https://issues.apache.org/jira/browse/FLINK-3999
> Project: Flink
> Issue Type: Bug
> Components: Local Runtime
>Reporter: Gabor Gevay
>Assignee: Neelesh Srinivas Salian
>Priority: Trivial
>
> The name of the {{running}} flag in the drivers doesn't reflect its usage:
> when the operator just stops normally, then it is not running anymore, but
> the {{running}} flag will still be true, since the {{running}} flag is only
> set when cancelling.
> It should be renamed, and the value inverted.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-3999) Rename the `running` flag in the drivers to `canceled`
[
https://issues.apache.org/jira/browse/FLINK-3999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15587758#comment-15587758
]
ASF GitHub Bot commented on FLINK-3999:
---
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/2642
OK, I see your point now @StephanEwen.
@nssalian, I'm sorry for opening the jira; I didn't think it through from
this perspective at the time.
> Rename the `running` flag in the drivers to `canceled`
> --
>
> Key: FLINK-3999
> URL: https://issues.apache.org/jira/browse/FLINK-3999
> Project: Flink
> Issue Type: Bug
> Components: Local Runtime
>Reporter: Gabor Gevay
>Assignee: Neelesh Srinivas Salian
>Priority: Trivial
>
> The name of the {{running}} flag in the drivers doesn't reflect its usage:
> when the operator just stops normally, then it is not running anymore, but
> the {{running}} flag will still be true, since the {{running}} flag is only
> set when cancelling.
> It should be renamed, and the value inverted.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-3999) Rename the `running` flag in the drivers to `canceled`
[
https://issues.apache.org/jira/browse/FLINK-3999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15586694#comment-15586694
]
ASF GitHub Bot commented on FLINK-3999:
---
Github user nssalian commented on the issue:
https://github.com/apache/flink/pull/2642
@StephanEwen ,thanks for that, that makes sense. But it is hard for someone
new to understand the problem you mention. If someone familiar with the
product, could review new JIRAs for clear benefit / validity, that would
encourage folks jumping on the tasks to know it better. I realize it may not be
feasible but it saves time too to let them know in advance. I can certainly
close the PR and make it Not a Problem. But if there is a better way to have
this clearer , I would appreciate it before the effort is put in.
> Rename the `running` flag in the drivers to `canceled`
> --
>
> Key: FLINK-3999
> URL: https://issues.apache.org/jira/browse/FLINK-3999
> Project: Flink
> Issue Type: Bug
> Components: Local Runtime
>Reporter: Gabor Gevay
>Assignee: Neelesh Srinivas Salian
>Priority: Trivial
>
> The name of the {{running}} flag in the drivers doesn't reflect its usage:
> when the operator just stops normally, then it is not running anymore, but
> the {{running}} flag will still be true, since the {{running}} flag is only
> set when cancelling.
> It should be renamed, and the value inverted.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-3999) Rename the `running` flag in the drivers to `canceled`
[
https://issues.apache.org/jira/browse/FLINK-3999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15586580#comment-15586580
]
ASF GitHub Bot commented on FLINK-3999:
---
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2642
I am a bit skeptical about these types of changes.
Maintaining stability of Flink is crucially important now. With changes
like these we risk introducing subtle bugs without fixing a bug or improving a
functionality or anything. It just changes a naming preference.
The kind of bugs one can introduce with changes like that are very subtle
(we have seen that in cases where the cancelling logic was fragile depending on
how the flag was exactly set) and hard to catch all in reviews. Not everything
is fully covered by bullet proof tested in practice.
I would actually suggest to rather contribute on issues where there is a
clearer benefit.
> Rename the `running` flag in the drivers to `canceled`
> --
>
> Key: FLINK-3999
> URL: https://issues.apache.org/jira/browse/FLINK-3999
> Project: Flink
> Issue Type: Bug
> Components: Local Runtime
>Reporter: Gabor Gevay
>Assignee: Neelesh Srinivas Salian
>Priority: Trivial
>
> The name of the {{running}} flag in the drivers doesn't reflect its usage:
> when the operator just stops normally, then it is not running anymore, but
> the {{running}} flag will still be true, since the {{running}} flag is only
> set when cancelling.
> It should be renamed, and the value inverted.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-3999) Rename the `running` flag in the drivers to `canceled`
[
https://issues.apache.org/jira/browse/FLINK-3999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585754#comment-15585754
]
ASF GitHub Bot commented on FLINK-3999:
---
Github user nssalian commented on the issue:
https://github.com/apache/flink/pull/2642
@ggevay they are not related.. I think it caught from me old branch on to
this one. The 3 in the middle2ef4401,46d91b0,1433a5d are
relevant here. Apologies for the mix up.
> Rename the `running` flag in the drivers to `canceled`
> --
>
> Key: FLINK-3999
> URL: https://issues.apache.org/jira/browse/FLINK-3999
> Project: Flink
> Issue Type: Bug
> Components: Local Runtime
>Reporter: Gabor Gevay
>Assignee: Neelesh Srinivas Salian
>Priority: Trivial
>
> The name of the {{running}} flag in the drivers doesn't reflect its usage:
> when the operator just stops normally, then it is not running anymore, but
> the {{running}} flag will still be true, since the {{running}} flag is only
> set when cancelling.
> It should be renamed, and the value inverted.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-3999) Rename the `running` flag in the drivers to `canceled`
[
https://issues.apache.org/jira/browse/FLINK-3999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585220#comment-15585220
]
ASF GitHub Bot commented on FLINK-3999:
---
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/2642
Could you please explain why are the first and last commit
(65b3ff78f100ed1b13ec2fcc727f4869823b5918 and
ba4f429043f3985db5ab37a3902a6fee15a7440e) necessary? Are they related to
FLINK-3999?
> Rename the `running` flag in the drivers to `canceled`
> --
>
> Key: FLINK-3999
> URL: https://issues.apache.org/jira/browse/FLINK-3999
> Project: Flink
> Issue Type: Bug
> Components: Local Runtime
>Reporter: Gabor Gevay
>Assignee: Neelesh Srinivas Salian
>Priority: Trivial
>
> The name of the {{running}} flag in the drivers doesn't reflect its usage:
> when the operator just stops normally, then it is not running anymore, but
> the {{running}} flag will still be true, since the {{running}} flag is only
> set when cancelling.
> It should be renamed, and the value inverted.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-3999) Rename the `running` flag in the drivers to `canceled`
[
https://issues.apache.org/jira/browse/FLINK-3999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15580868#comment-15580868
]
ASF GitHub Bot commented on FLINK-3999:
---
GitHub user nssalian opened a pull request:
https://github.com/apache/flink/pull/2642
[FLINK-3999]: Rename the `running` flag in the drivers to `canceled`
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-3999]
Rename the `running` flag in the drivers to `canceled`")
- Added the cancelled flag instead of the running flag to replace the
functionality since it was not truly "running".
- Modified the operators to have the cancelled instead of running even in
tests
- [ ] Documentation
- Modified the Example for the Loading Data where the import statement
needed to be changed.
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
- Ran a Travis build and local mvn tests as well.
@ggevay if you could help review. Thank you.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nssalian/flink FLINK-3999
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2642.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2642
commit 65b3ff78f100ed1b13ec2fcc727f4869823b5918
Author: Neelesh Srinivas Salian
Date: 2016-09-12T22:38:06Z
FLINK-4614: Changed the version from 1.2-SNAPSHOT to 1.2 to help correct
docs in 1.2.0
commit 2ef440161699943cb3cc38eccc6ef39a1bd512a1
Author: Neelesh Srinivas Salian
Date: 2016-10-16T20:41:00Z
FLINK-3999: Modified the running flag for the runtime module to cancelled
to depict correctness
commit 46d91b0052971e5116c674a350ff38aa692616bb
Author: Neelesh Srinivas Salian
Date: 2016-10-16T23:07:45Z
FLINK-3999: Fixed Tests
commit 1433a5db5ad13aef3f76e8ab4b2fa131272fe59d
Author: Neelesh Srinivas Salian
Date: 2016-10-16T23:58:33Z
FLINK-3999: More changes to fix tests
commit ba4f429043f3985db5ab37a3902a6fee15a7440e
Author: Neelesh Srinivas Salian
Date: 2016-10-17T01:12:43Z
FLINK-3999: Updated config version
> Rename the `running` flag in the drivers to `canceled`
> --
>
> Key: FLINK-3999
> URL: https://issues.apache.org/jira/browse/FLINK-3999
> Project: Flink
> Issue Type: Bug
> Components: Local Runtime
>Reporter: Gabor Gevay
>Assignee: Neelesh Srinivas Salian
>Priority: Trivial
>
> The name of the {{running}} flag in the drivers doesn't reflect its usage:
> when the operator just stops normally, then it is not running anymore, but
> the {{running}} flag will still be true, since the {{running}} flag is only
> set when cancelling.
> It should be renamed, and the value inverted.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-3999) Rename the `running` flag in the drivers to `canceled`
[
https://issues.apache.org/jira/browse/FLINK-3999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15543749#comment-15543749
]
Neelesh Srinivas Salian commented on FLINK-3999:
Apologies. Haven't had the chance to work on this. Will post a PR soon.
> Rename the `running` flag in the drivers to `canceled`
> --
>
> Key: FLINK-3999
> URL: https://issues.apache.org/jira/browse/FLINK-3999
> Project: Flink
> Issue Type: Bug
> Components: Local Runtime
>Reporter: Gabor Gevay
>Assignee: Neelesh Srinivas Salian
>Priority: Trivial
>
> The name of the {{running}} flag in the drivers doesn't reflect its usage:
> when the operator just stops normally, then it is not running anymore, but
> the {{running}} flag will still be true, since the {{running}} flag is only
> set when cancelling.
> It should be renamed, and the value inverted.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-3999) Rename the `running` flag in the drivers to `canceled`
[
https://issues.apache.org/jira/browse/FLINK-3999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15447356#comment-15447356
]
Neelesh Srinivas Salian commented on FLINK-3999:
Thank you [~ggevay]. Will post a PR this week.
> Rename the `running` flag in the drivers to `canceled`
> --
>
> Key: FLINK-3999
> URL: https://issues.apache.org/jira/browse/FLINK-3999
> Project: Flink
> Issue Type: Bug
> Components: Local Runtime
>Reporter: Gabor Gevay
>Assignee: Neelesh Srinivas Salian
>Priority: Trivial
>
> The name of the {{running}} flag in the drivers doesn't reflect its usage:
> when the operator just stops normally, then it is not running anymore, but
> the {{running}} flag will still be true, since the {{running}} flag is only
> set when cancelling.
> It should be renamed, and the value inverted.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-3999) Rename the `running` flag in the drivers to `canceled`
[
https://issues.apache.org/jira/browse/FLINK-3999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435446#comment-15435446
]
Gabor Gevay commented on FLINK-3999:
Yes, thank you for working on it!
> Rename the `running` flag in the drivers to `canceled`
> --
>
> Key: FLINK-3999
> URL: https://issues.apache.org/jira/browse/FLINK-3999
> Project: Flink
> Issue Type: Bug
> Components: Local Runtime
>Reporter: Gabor Gevay
>Priority: Trivial
>
> The name of the {{running}} flag in the drivers doesn't reflect its usage:
> when the operator just stops normally, then it is not running anymore, but
> the {{running}} flag will still be true, since the {{running}} flag is only
> set when cancelling.
> It should be renamed, and the value inverted.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-3999) Rename the `running` flag in the drivers to `canceled`
[
https://issues.apache.org/jira/browse/FLINK-3999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435037#comment-15435037
]
Neelesh Srinivas Salian commented on FLINK-3999:
Shall I work on this JIRA, if no one else is working already?
> Rename the `running` flag in the drivers to `canceled`
> --
>
> Key: FLINK-3999
> URL: https://issues.apache.org/jira/browse/FLINK-3999
> Project: Flink
> Issue Type: Bug
> Components: Local Runtime
>Reporter: Gabor Gevay
>Priority: Trivial
>
> The name of the {{running}} flag in the drivers doesn't reflect its usage:
> when the operator just stops normally, then it is not running anymore, but
> the {{running}} flag will still be true, since the {{running}} flag is only
> set when cancelling.
> It should be renamed, and the value inverted.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
