[jira] [Commented] (FLINK-4370) Offer a default IntelliJ inspection profile with Flink

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15986223#comment-15986223
 ] 

ASF GitHub Bot commented on FLINK-4370:
---

Github user StephanEwen commented on the issue:

https://github.com/apache/flink/pull/2352
  
@greghogan That could definitely be done.

I was initially trying to do a trick: Check in the inspection profile that 
we want (in terms of what qualifies as a warning) but also add it to .gitignore 
so that any customization on a developer's end is not committed back.

That way we would set up everyone with the common base and still allow for 
customization.


> Offer a default IntelliJ inspection profile with Flink
> --
>
> Key: FLINK-4370
> URL: https://issues.apache.org/jira/browse/FLINK-4370
> Project: Flink
>  Issue Type: Improvement
>  Components: Build System
>Reporter: Stephan Ewen
>Assignee: Stephan Ewen
>
> We can commit an inspection profile under {{.idea/inspectionProfiles}} which 
> should be automatically picked up when the code is checked out and imported 
> into IntelliJ



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-4370) Offer a default IntelliJ inspection profile with Flink

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985606#comment-15985606
 ] 

ASF GitHub Bot commented on FLINK-4370:
---

Github user greghogan commented on the issue:

https://github.com/apache/flink/pull/2352
  
@StephanEwen can these be shared under `tools/idea/...`? If they are 
installed by default then any user modifications will be noted by git. 
Conversely, most contributors won't notice these files or synchronize as 
additional inspections are enabled, but as of now developers are on their own.


> Offer a default IntelliJ inspection profile with Flink
> --
>
> Key: FLINK-4370
> URL: https://issues.apache.org/jira/browse/FLINK-4370
> Project: Flink
>  Issue Type: Improvement
>  Components: Build System
>Reporter: Stephan Ewen
>Assignee: Stephan Ewen
>
> We can commit an inspection profile under {{.idea/inspectionProfiles}} which 
> should be automatically picked up when the code is checked out and imported 
> into IntelliJ



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-4370) Offer a default IntelliJ inspection profile with Flink

[Greg Hogan (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15574880#comment-15574880
 ] 

Greg Hogan commented on FLINK-4370:
---

I thought you had already force-added the file to git, but there is no way 
around that git will raise an error when checking out a file over an existing 
file.

Another aspect is that many developers may have their own configurations and 
may choose to ignore this file. They would need to copy their existing file to 
a safe location, rebase, then copy their file back. And since these files are 
now tracked any user customizations will appear in the working directory. So 
perhaps {{/tools}} is best.

> Offer a default IntelliJ inspection profile with Flink
> --
>
> Key: FLINK-4370
> URL: https://issues.apache.org/jira/browse/FLINK-4370
> Project: Flink
>  Issue Type: Improvement
>Reporter: Stephan Ewen
>Assignee: Stephan Ewen
>
> We can commit an inspection profile under {{.idea/inspectionProfiles}} which 
> should be automatically picked up when the code is checked out and imported 
> into IntelliJ



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4370) Offer a default IntelliJ inspection profile with Flink

[Stephan Ewen (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15574851#comment-15574851
 ] 

Stephan Ewen commented on FLINK-4370:
-

I would like to go with putting the file into {{.idea}}, but have not found a 
way around the {{.gitignore}} problem.
This may look promising, though: 
http://stackoverflow.com/questions/23296370/add-previously-ignored-directory-to-git-repository

> Offer a default IntelliJ inspection profile with Flink
> --
>
> Key: FLINK-4370
> URL: https://issues.apache.org/jira/browse/FLINK-4370
> Project: Flink
>  Issue Type: Improvement
>Reporter: Stephan Ewen
>Assignee: Stephan Ewen
>
> We can commit an inspection profile under {{.idea/inspectionProfiles}} which 
> should be automatically picked up when the code is checked out and imported 
> into IntelliJ



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4370) Offer a default IntelliJ inspection profile with Flink

[Greg Hogan (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15573068#comment-15573068
 ] 

Greg Hogan commented on FLINK-4370:
---

[~StephanEwen] have you discovered a third way? Our options so far are to 
include these files in {{/tools}} or {{.idea}}. As noted, the documentation for 
the former will be mostly overlooked and for the latter users will see a 
{{git}} error and be required to deleted the offending files.

> Offer a default IntelliJ inspection profile with Flink
> --
>
> Key: FLINK-4370
> URL: https://issues.apache.org/jira/browse/FLINK-4370
> Project: Flink
>  Issue Type: Improvement
>Reporter: Stephan Ewen
>Assignee: Stephan Ewen
>
> We can commit an inspection profile under {{.idea/inspectionProfiles}} which 
> should be automatically picked up when the code is checked out and imported 
> into IntelliJ



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4370) Offer a default IntelliJ inspection profile with Flink

[Stephan Ewen (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417302#comment-15417302
 ] 

Stephan Ewen commented on FLINK-4370:
-

In theory, putting it in "tools" and referencing in the docs is nice.
In practice, many people do not read these things let alone import settings. I 
guess that if it does not work automatically, many contributors will not use it.

> Offer a default IntelliJ inspection profile with Flink
> --
>
> Key: FLINK-4370
> URL: https://issues.apache.org/jira/browse/FLINK-4370
> Project: Flink
>  Issue Type: Improvement
>Reporter: Stephan Ewen
>Assignee: Stephan Ewen
>
> We can commit an inspection profile under {{.idea/inspectionProfiles}} which 
> should be automatically picked up when the code is checked out and imported 
> into IntelliJ



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4370) Offer a default IntelliJ inspection profile with Flink

[Greg Hogan (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417241#comment-15417241
 ] 

Greg Hogan commented on FLINK-4370:
---

I'd rather add this to its proper place ({{.idea}}) and have current developers 
inconvenienced once with the rebase on top of an untracked file than to clutter 
{{tools}} and the new contributor guidelines. A notice could be posted to the 
flink-devel mailing list explaining the one-time need to remove the existing 
files before rebasing to master.

> Offer a default IntelliJ inspection profile with Flink
> --
>
> Key: FLINK-4370
> URL: https://issues.apache.org/jira/browse/FLINK-4370
> Project: Flink
>  Issue Type: Improvement
>Reporter: Stephan Ewen
>Assignee: Stephan Ewen
>
> We can commit an inspection profile under {{.idea/inspectionProfiles}} which 
> should be automatically picked up when the code is checked out and imported 
> into IntelliJ



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4370) Offer a default IntelliJ inspection profile with Flink

[Jark Wu (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417208#comment-15417208
 ] 

Jark Wu commented on FLINK-4370:


Yes. We can put this files into tools folder (or other) as well as  the code 
style file.  And document it in {{ide_setup.md}}

> Offer a default IntelliJ inspection profile with Flink
> --
>
> Key: FLINK-4370
> URL: https://issues.apache.org/jira/browse/FLINK-4370
> Project: Flink
>  Issue Type: Improvement
>Reporter: Stephan Ewen
>Assignee: Stephan Ewen
>
> We can commit an inspection profile under {{.idea/inspectionProfiles}} which 
> should be automatically picked up when the code is checked out and imported 
> into IntelliJ



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4370) Offer a default IntelliJ inspection profile with Flink

[Greg Hogan (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417185#comment-15417185
 ] 

Greg Hogan commented on FLINK-4370:
---

We've had pull requests rejected due to formatting changes, and even the 
smallest changes such as reordering imports muddy the review. I'd like to see 
this included if it improves consistency. I'd prefer to include configuration 
files in the repository rather than on the website where new contributors may 
not know to look.

Adding an IntelliJ code style in FLINK-3870 is still open.

> Offer a default IntelliJ inspection profile with Flink
> --
>
> Key: FLINK-4370
> URL: https://issues.apache.org/jira/browse/FLINK-4370
> Project: Flink
>  Issue Type: Improvement
>Reporter: Stephan Ewen
>Assignee: Stephan Ewen
>
> We can commit an inspection profile under {{.idea/inspectionProfiles}} which 
> should be automatically picked up when the code is checked out and imported 
> into IntelliJ



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4370) Offer a default IntelliJ inspection profile with Flink

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417141#comment-15417141
 ] 

ASF GitHub Bot commented on FLINK-4370:
---

Github user StephanEwen closed the pull request at:

https://github.com/apache/flink/pull/2352


> Offer a default IntelliJ inspection profile with Flink
> --
>
> Key: FLINK-4370
> URL: https://issues.apache.org/jira/browse/FLINK-4370
> Project: Flink
>  Issue Type: Improvement
>Reporter: Stephan Ewen
>Assignee: Stephan Ewen
>
> We can commit an inspection profile under {{.idea/inspectionProfiles}} which 
> should be automatically picked up when the code is checked out and imported 
> into IntelliJ



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4370) Offer a default IntelliJ inspection profile with Flink

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417140#comment-15417140
 ] 

ASF GitHub Bot commented on FLINK-4370:
---

Github user StephanEwen commented on the issue:

https://github.com/apache/flink/pull/2352
  
Okay, I see, it is not that easy with ignored files ;-)
Let me close this pull request and see if I can find another way to share 
these inspections automatically.


> Offer a default IntelliJ inspection profile with Flink
> --
>
> Key: FLINK-4370
> URL: https://issues.apache.org/jira/browse/FLINK-4370
> Project: Flink
>  Issue Type: Improvement
>Reporter: Stephan Ewen
>Assignee: Stephan Ewen
>
> We can commit an inspection profile under {{.idea/inspectionProfiles}} which 
> should be automatically picked up when the code is checked out and imported 
> into IntelliJ



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4370) Offer a default IntelliJ inspection profile with Flink

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417129#comment-15417129
 ] 

ASF GitHub Bot commented on FLINK-4370:
---

Github user wuchong commented on the issue:

https://github.com/apache/flink/pull/2352
  
Try to pull this patch and the following error occurred

```
$ git pull https://github.com/StephanEwen/incubator-flink inspections
From https://github.com/StephanEwen/incubator-flink
 * branchinspections -> FETCH_HEAD
error: The following untracked working tree files would be overwritten by 
merge:
.idea/inspectionProfiles/Project_Default.xml
.idea/inspectionProfiles/profiles_settings.xml
Please move or remove them before you can merge.
Aborting
```


> Offer a default IntelliJ inspection profile with Flink
> --
>
> Key: FLINK-4370
> URL: https://issues.apache.org/jira/browse/FLINK-4370
> Project: Flink
>  Issue Type: Improvement
>Reporter: Stephan Ewen
>Assignee: Stephan Ewen
>
> We can commit an inspection profile under {{.idea/inspectionProfiles}} which 
> should be automatically picked up when the code is checked out and imported 
> into IntelliJ



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4370) Offer a default IntelliJ inspection profile with Flink

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417109#comment-15417109
 ] 

ASF GitHub Bot commented on FLINK-4370:
---

Github user StephanEwen commented on the issue:

https://github.com/apache/flink/pull/2352
  
This is only a suggestion. I thought it would be great to have a more 
unified set of warnings and errors, because it would encourage a more unified 
code style.

With this change, most IDE specific settings are still up to the user. This 
only sets a project-default set of inspections/warnings to display in the 
editor.
Changes to `.idea` are generally ignored - these files are an exception 
(they were "force added").


> Offer a default IntelliJ inspection profile with Flink
> --
>
> Key: FLINK-4370
> URL: https://issues.apache.org/jira/browse/FLINK-4370
> Project: Flink
>  Issue Type: Improvement
>Reporter: Stephan Ewen
>Assignee: Stephan Ewen
>
> We can commit an inspection profile under {{.idea/inspectionProfiles}} which 
> should be automatically picked up when the code is checked out and imported 
> into IntelliJ



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4370) Offer a default IntelliJ inspection profile with Flink

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417088#comment-15417088
 ] 

ASF GitHub Bot commented on FLINK-4370:
---

Github user wuchong commented on the issue:

https://github.com/apache/flink/pull/2352
  
Agree with @tillrohrmann . And I'm confused that can it work? As `.idea` 
folder is in `.gitignore` list.


> Offer a default IntelliJ inspection profile with Flink
> --
>
> Key: FLINK-4370
> URL: https://issues.apache.org/jira/browse/FLINK-4370
> Project: Flink
>  Issue Type: Improvement
>Reporter: Stephan Ewen
>Assignee: Stephan Ewen
>
> We can commit an inspection profile under {{.idea/inspectionProfiles}} which 
> should be automatically picked up when the code is checked out and imported 
> into IntelliJ



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4370) Offer a default IntelliJ inspection profile with Flink

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416713#comment-15416713
 ] 

ASF GitHub Bot commented on FLINK-4370:
---

Github user tillrohrmann commented on the issue:

https://github.com/apache/flink/pull/2352
  
Should this be part of the repository? I think that IDE specific settings 
should be configured by the individual developers themselves and should remain 
local. However, I think that adding this profile to the flink website as a 
recommendation for IntelliJ is a good idea.


> Offer a default IntelliJ inspection profile with Flink
> --
>
> Key: FLINK-4370
> URL: https://issues.apache.org/jira/browse/FLINK-4370
> Project: Flink
>  Issue Type: Improvement
>Reporter: Stephan Ewen
>Assignee: Stephan Ewen
>
> We can commit an inspection profile under {{.idea/inspectionProfiles}} which 
> should be automatically picked up when the code is checked out and imported 
> into IntelliJ



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4370) Offer a default IntelliJ inspection profile with Flink

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415624#comment-15415624
 ] 

ASF GitHub Bot commented on FLINK-4370:
---

GitHub user StephanEwen opened a pull request:

https://github.com/apache/flink/pull/2352

[FLINK-4370] Add an IntelliJ Inspections Profile

This adds an IntelliJ inspections profile for Flink in the `.idea` folder.
When the code is imported into IntelliJ, it should automatically pick up 
and use that inspection profile.

The profile adds some extra warnings and errors that I found useful in the 
past.
We should gradually activate more inspections (or deactivate some) as we 
feel it helps the development.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/StephanEwen/incubator-flink inspections

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/2352.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2352


commit e25e9ef6ac91dc5936d92212c74f96137646a0d1
Author: Stephan Ewen 
Date:   2016-08-10T17:21:28Z

[FLINK-4370] Add an IntelliJ Inspections Profile




> Offer a default IntelliJ inspection profile with Flink
> --
>
> Key: FLINK-4370
> URL: https://issues.apache.org/jira/browse/FLINK-4370
> Project: Flink
>  Issue Type: Improvement
>Reporter: Stephan Ewen
>Assignee: Stephan Ewen
>
> We can commit an inspection profile under {{.idea/inspectionProfiles}} which 
> should be automatically picked up when the code is checked out and imported 
> into IntelliJ



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)