[jira] [Commented] (FLINK-4519) scala maxLineLength increased to 120

2016-08-29 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-4519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15445553#comment-15445553
 ] 

ASF GitHub Bot commented on FLINK-4519:
---

Github user shijinkui closed the pull request at:

https://github.com/apache/flink/pull/2429


> scala maxLineLength increased to 120  
> --
>
> Key: FLINK-4519
> URL: https://issues.apache.org/jira/browse/FLINK-4519
> Project: Flink
>  Issue Type: Improvement
>Reporter: shijinkui
>
> `tools/maven/scalastyle-config.xml`



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4519) scala maxLineLength increased to 120

2016-08-29 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-4519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15445552#comment-15445552
 ] 

ASF GitHub Bot commented on FLINK-4519:
---

Github user shijinkui commented on the issue:

https://github.com/apache/flink/pull/2429
  
@StephanEwen Thanks for your reply.
That's OK. We can discuss first


> scala maxLineLength increased to 120  
> --
>
> Key: FLINK-4519
> URL: https://issues.apache.org/jira/browse/FLINK-4519
> Project: Flink
>  Issue Type: Improvement
>Reporter: shijinkui
>
> `tools/maven/scalastyle-config.xml`



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4519) scala maxLineLength increased to 120

2016-08-29 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-4519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15445327#comment-15445327
 ] 

ASF GitHub Bot commented on FLINK-4519:
---

Github user StephanEwen commented on the issue:

https://github.com/apache/flink/pull/2429
  
Things like this need to be discussed before we can make such a change.
It was a conscious decision initially to have 100 characters line length.

I personally do not mind 120 char lines, but back then, most people were 
pretty strong on the 100 chars limit.

I would close this and start a [DISCUSS] thread on the dev mailing list. If 
you can convince people of this, then we can make the change.


> scala maxLineLength increased to 120  
> --
>
> Key: FLINK-4519
> URL: https://issues.apache.org/jira/browse/FLINK-4519
> Project: Flink
>  Issue Type: Improvement
>Reporter: shijinkui
>
> `tools/maven/scalastyle-config.xml`



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4519) scala maxLineLength increased to 120

2016-08-29 Thread shijinkui (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-4519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15445211#comment-15445211
 ] 

shijinkui commented on FLINK-4519:
--

Scala function's parameter is longger, and less than four parameter one line 
may be more readable. Although most of project MaxLineLength is 100.


> scala maxLineLength increased to 120  
> --
>
> Key: FLINK-4519
> URL: https://issues.apache.org/jira/browse/FLINK-4519
> Project: Flink
>  Issue Type: Improvement
>Reporter: shijinkui
>
> `tools/maven/scalastyle-config.xml`



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4519) scala maxLineLength increased to 120

2016-08-29 Thread Chesnay Schepler (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-4519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15445103#comment-15445103
 ] 

Chesnay Schepler commented on FLINK-4519:
-

Could you provide a reason as to why the maxLineLength should be increased from 
100 to 120?

> scala maxLineLength increased to 120  
> --
>
> Key: FLINK-4519
> URL: https://issues.apache.org/jira/browse/FLINK-4519
> Project: Flink
>  Issue Type: Improvement
>Reporter: shijinkui
>
> `tools/maven/scalastyle-config.xml`



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4519) scala maxLineLength increased to 120

2016-08-28 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-4519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15444399#comment-15444399
 ] 

ASF GitHub Bot commented on FLINK-4519:
---

Github user shijinkui commented on the issue:

https://github.com/apache/flink/pull/2429
  
@rehevkor5 
https://builds.apache.org/job/flink-github-ci/274/org.apache.flink$flink-connector-kafka-0.8_2.10/testReport/org.apache.flink.streaming.connectors.kafka/Kafka08ITCase/org_apache_flink_streaming_connectors_kafka_Kafka08ITCase/

```
Error Message

Failed to bind to: /127.0.0.1:2624
Stacktrace

org.jboss.netty.channel.ChannelException: Failed to bind to: /127.0.0.1:2624
at 
org.jboss.netty.bootstrap.ServerBootstrap.bind(ServerBootstrap.java:272)
at 
akka.remote.transport.netty.NettyTransport$$anonfun$listen$1.apply(NettyTransport.scala:393)
at 
akka.remote.transport.netty.NettyTransport$$anonfun$listen$1.apply(NettyTransport.scala:389)
at scala.util.Success$$anonfun$map$1.apply(Try.scala:206)
at scala.util.Try$.apply(Try.scala:161)
at scala.util.Success.map(Try.scala:206)
at scala.concurrent.Future$$anonfun$map$1.apply(Future.scala:235)
at scala.concurrent.Future$$anonfun$map$1.apply(Future.scala:235)
at scala.concurrent.impl.CallbackRunnable.run(Promise.scala:32)
at 
akka.dispatch.BatchingExecutor$Batch$$anonfun$run$1.processBatch$1(BatchingExecutor.scala:67)
at 
akka.dispatch.BatchingExecutor$Batch$$anonfun$run$1.apply$mcV$sp(BatchingExecutor.scala:82)
at 
akka.dispatch.BatchingExecutor$Batch$$anonfun$run$1.apply(BatchingExecutor.scala:59)
at 
akka.dispatch.BatchingExecutor$Batch$$anonfun$run$1.apply(BatchingExecutor.scala:59)
at 
scala.concurrent.BlockContext$.withBlockContext(BlockContext.scala:72)
at akka.dispatch.BatchingExecutor$Batch.run(BatchingExecutor.scala:58)
at akka.dispatch.TaskInvocation.run(AbstractDispatcher.scala:41)
at 
akka.dispatch.ForkJoinExecutorConfigurator$AkkaForkJoinTask.exec(AbstractDispatcher.scala:401)
at scala.concurrent.forkjoin.ForkJoinTask.doExec(ForkJoinTask.java:260)
at 
scala.concurrent.forkjoin.ForkJoinPool$WorkQueue.pollAndExecAll(ForkJoinPool.java:1253)
at 
scala.concurrent.forkjoin.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1346)
at 
scala.concurrent.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979)
at 
scala.concurrent.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107)
Caused by: java.net.BindException: Address already in use
at sun.nio.ch.Net.bind0(Native Method)
at sun.nio.ch.Net.bind(Net.java:433)
at sun.nio.ch.Net.bind(Net.java:425)
at 
sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:223)
at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74)
at 
org.jboss.netty.channel.socket.nio.NioServerBoss$RegisterTask.run(NioServerBoss.java:193)
at 
org.jboss.netty.channel.socket.nio.AbstractNioSelector.processTaskQueue(AbstractNioSelector.java:366)
at 
org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:290)
at 
org.jboss.netty.channel.socket.nio.NioServerBoss.run(NioServerBoss.java:42)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
```


> scala maxLineLength increased to 120  
> --
>
> Key: FLINK-4519
> URL: https://issues.apache.org/jira/browse/FLINK-4519
> Project: Flink
>  Issue Type: Improvement
>Reporter: shijinkui
>
> `tools/maven/scalastyle-config.xml`



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4519) scala maxLineLength increased to 120

2016-08-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-4519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15441232#comment-15441232
 ] 

ASF GitHub Bot commented on FLINK-4519:
---

GitHub user shijinkui opened a pull request:

https://github.com/apache/flink/pull/2429

[FLINK-4519] scala maxLineLength increased to 120

Because Scala function's parameter is more long than Java code, We can set 
the maxLineLength to 120. 

The pull request references the related JIRA issue  FLINK-4519

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shijinkui/flink maxLineLength_120

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/2429.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2429


commit 583ca8d40228ade306f1b52be898ac5ffc8ce230
Author: shijinkui 
Date:   2016-08-27T10:37:03Z

[FLINK-4519] scala maxLineLength increased to 120




> scala maxLineLength increased to 120  
> --
>
> Key: FLINK-4519
> URL: https://issues.apache.org/jira/browse/FLINK-4519
> Project: Flink
>  Issue Type: Improvement
>Reporter: shijinkui
>
> `tools/maven/scalastyle-config.xml`



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)