[jira] [Commented] (FLINK-4612) Close FileWriter using try with resources

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15495978#comment-15495978
 ] 

ASF GitHub Bot commented on FLINK-4612:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/2492


> Close FileWriter using try with resources
> -
>
> Key: FLINK-4612
> URL: https://issues.apache.org/jira/browse/FLINK-4612
> Project: Flink
>  Issue Type: Bug
>  Components: Java API
>Affects Versions: 1.1.2
>Reporter: Alexander Pivovarov
>Priority: Trivial
> Fix For: 1.2.0
>
>
> FileWriter is not closed properly in many places in the project modules



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4612) Close FileWriter using try with resources

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15495962#comment-15495962
 ] 

ASF GitHub Bot commented on FLINK-4612:
---

Github user zentol commented on the issue:

https://github.com/apache/flink/pull/2492
  
merging


> Close FileWriter using try with resources
> -
>
> Key: FLINK-4612
> URL: https://issues.apache.org/jira/browse/FLINK-4612
> Project: Flink
>  Issue Type: Bug
>  Components: Java API
>Affects Versions: 1.1.2
>Reporter: Alexander Pivovarov
>Priority: Trivial
>
> FileWriter is not closed properly in many places in the project modules



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4612) Close FileWriter using try with resources

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15485185#comment-15485185
 ] 

ASF GitHub Bot commented on FLINK-4612:
---

Github user apivovarov commented on a diff in the pull request:

https://github.com/apache/flink/pull/2492#discussion_r78447379
  
--- Diff: 
flink-core/src/test/java/org/apache/flink/testutils/TestFileUtils.java ---
@@ -55,11 +55,8 @@ public static String createTempFileInDirectory(String 
dir, String contents) thro
f.createNewFile();
f.deleteOnExit();

-   BufferedWriter out = new BufferedWriter(new FileWriter(f));
-   try { 
+   try(BufferedWriter out = new BufferedWriter(new FileWriter(f))) 
{
--- End diff --

Thank you. Just fixed that


> Close FileWriter using try with resources
> -
>
> Key: FLINK-4612
> URL: https://issues.apache.org/jira/browse/FLINK-4612
> Project: Flink
>  Issue Type: Bug
>  Components: Java API
>Affects Versions: 1.1.2
>Reporter: Alexander Pivovarov
>Priority: Trivial
>
> FileWriter is not closed properly in many places in the project modules



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4612) Close FileWriter using try with resources

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15484935#comment-15484935
 ] 

ASF GitHub Bot commented on FLINK-4612:
---

Github user zentol commented on a diff in the pull request:

https://github.com/apache/flink/pull/2492#discussion_r78430845
  
--- Diff: 
flink-core/src/test/java/org/apache/flink/testutils/TestFileUtils.java ---
@@ -55,11 +55,8 @@ public static String createTempFileInDirectory(String 
dir, String contents) thro
f.createNewFile();
f.deleteOnExit();

-   BufferedWriter out = new BufferedWriter(new FileWriter(f));
-   try { 
+   try(BufferedWriter out = new BufferedWriter(new FileWriter(f))) 
{
--- End diff --

there should be a space after try; same issue occurs in other places as 
well.


> Close FileWriter using try with resources
> -
>
> Key: FLINK-4612
> URL: https://issues.apache.org/jira/browse/FLINK-4612
> Project: Flink
>  Issue Type: Bug
>  Components: Java API
>Affects Versions: 1.1.2
>Reporter: Alexander Pivovarov
>Priority: Trivial
>
> FileWriter is not closed properly in many places in the project modules



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4612) Close FileWriter using try with resources

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15483161#comment-15483161
 ] 

ASF GitHub Bot commented on FLINK-4612:
---

GitHub user apivovarov opened a pull request:

https://github.com/apache/flink/pull/2492

[FLINK-4612] Close FileWriter using try with resources

https://issues.apache.org/jira/browse/FLINK-4612

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apivovarov/flink FLINK-4612

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/2492.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2492


commit 3b1a73cb47fb4581e169f2ea5cfaa69d9f4a1c64
Author: Alexander Pivovarov 
Date:   2016-09-12T05:46:55Z

[FLINK-4612] Close FileWriter using try with resources




> Close FileWriter using try with resources
> -
>
> Key: FLINK-4612
> URL: https://issues.apache.org/jira/browse/FLINK-4612
> Project: Flink
>  Issue Type: Bug
>  Components: Java API
>Affects Versions: 1.1.2
>Reporter: Alexander Pivovarov
>Priority: Trivial
>
> FileWriter is not closed properly in many places in the project modules



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)