[jira] [Commented] (FLINK-4735) Migrate some job execution related akka messages to rpc calls
[ https://issues.apache.org/jira/browse/FLINK-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15573719#comment-15573719 ] ASF GitHub Bot commented on FLINK-4735: --- Github user KurtYoung closed the pull request at: https://github.com/apache/flink/pull/2588 > Migrate some job execution related akka messages to rpc calls > - > > Key: FLINK-4735 > URL: https://issues.apache.org/jira/browse/FLINK-4735 > Project: Flink > Issue Type: Sub-task > Components: Cluster Management >Reporter: Kurt Young >Assignee: Kurt Young > > This includes the following operations about job execution: > 1. checkpointing > 2. kvstate > 3. savepoint > 4. classloading props -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4735) Migrate some job execution related akka messages to rpc calls
[ https://issues.apache.org/jira/browse/FLINK-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15572286#comment-15572286 ] ASF GitHub Bot commented on FLINK-4735: --- Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2588 Merged to the `flip-6` feature branch in 34fef4752e94b3d0c7afe7a9525799bb651a07b4 > Migrate some job execution related akka messages to rpc calls > - > > Key: FLINK-4735 > URL: https://issues.apache.org/jira/browse/FLINK-4735 > Project: Flink > Issue Type: Sub-task > Components: Cluster Management >Reporter: Kurt Young >Assignee: Kurt Young > > This includes the following operations about job execution: > 1. checkpointing > 2. kvstate > 3. savepoint > 4. classloading props -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4735) Migrate some job execution related akka messages to rpc calls
[ https://issues.apache.org/jira/browse/FLINK-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15571902#comment-15571902 ] ASF GitHub Bot commented on FLINK-4735: --- Github user KurtYoung commented on the issue: https://github.com/apache/flink/pull/2588 This PR now contains some work from master branch picked by Stephan. Rebased to the latest flip-6 > Migrate some job execution related akka messages to rpc calls > - > > Key: FLINK-4735 > URL: https://issues.apache.org/jira/browse/FLINK-4735 > Project: Flink > Issue Type: Sub-task > Components: Cluster Management >Reporter: Kurt Young >Assignee: Kurt Young > > This includes the following operations about job execution: > 1. checkpointing > 2. kvstate > 3. savepoint > 4. classloading props -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4735) Migrate some job execution related akka messages to rpc calls
[ https://issues.apache.org/jira/browse/FLINK-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15552354#comment-15552354 ] ASF GitHub Bot commented on FLINK-4735: --- Github user KurtYoung commented on the issue: https://github.com/apache/flink/pull/2588 @StephanEwen Sounds reasonable. This PR has some overlayer with #2594, will address your comment after that one merged and rebase to the latest flip-6 branch > Migrate some job execution related akka messages to rpc calls > - > > Key: FLINK-4735 > URL: https://issues.apache.org/jira/browse/FLINK-4735 > Project: Flink > Issue Type: Sub-task > Components: Cluster Management >Reporter: Kurt Young >Assignee: Kurt Young > > This includes the following operations about job execution: > 1. checkpointing > 2. kvstate > 3. savepoint > 4. classloading props -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4735) Migrate some job execution related akka messages to rpc calls
[ https://issues.apache.org/jira/browse/FLINK-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15552140#comment-15552140 ] ASF GitHub Bot commented on FLINK-4735: --- Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2588 Looks good, thanks, will merge this. I would suggest two followups: - We can remove the "dispose savepoint" method, because that is functionality disappearing right now. Savepoints need no special remove logic any more, they are just a directory in a filesystem. - We can reduce the number of message classes (like `TriggerSavepointResponse`) by using exceptions more prominently. The "triggerSavepoint()" method could simply return a String (success) or throw an exception (failure). Exceptions are propagated by the RPC, so the caller future will always get it as a response. > Migrate some job execution related akka messages to rpc calls > - > > Key: FLINK-4735 > URL: https://issues.apache.org/jira/browse/FLINK-4735 > Project: Flink > Issue Type: Sub-task > Components: Cluster Management >Reporter: Kurt Young >Assignee: Kurt Young > > This includes the following operations about job execution: > 1. checkpointing > 2. kvstate > 3. savepoint > 4. classloading props -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4735) Migrate some job execution related akka messages to rpc calls
[ https://issues.apache.org/jira/browse/FLINK-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15546359#comment-15546359 ] Greg Hogan commented on FLINK-4735: --- Apologies for sending the PR for FLINK-4734 to this ticket. I deleted the link but cannot delete the message from the ASF Github Bot. > Migrate some job execution related akka messages to rpc calls > - > > Key: FLINK-4735 > URL: https://issues.apache.org/jira/browse/FLINK-4735 > Project: Flink > Issue Type: Sub-task > Components: Cluster Management >Reporter: Kurt Young >Assignee: Kurt Young > > This includes the following operations about job execution: > 1. checkpointing > 2. kvstate > 3. savepoint > 4. classloading props -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4735) Migrate some job execution related akka messages to rpc calls
[ https://issues.apache.org/jira/browse/FLINK-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15546180#comment-15546180 ] ASF GitHub Bot commented on FLINK-4735: --- GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/2590 [FLINK-4735] [gelly] Remove use of Tuple setField for fixed position You can merge this pull request into a Git repository by running: $ git pull https://github.com/greghogan/flink 4734_remove_use_of_tuple_setfield_for_fixed_position Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/2590.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2590 commit b970807ae8895b262a582cae96138a6995b1543c Author: Greg Hogan Date: 2016-10-04T13:50:42Z [FLINK-4735] [gelly] Remove use of Tuple setField for fixed position > Migrate some job execution related akka messages to rpc calls > - > > Key: FLINK-4735 > URL: https://issues.apache.org/jira/browse/FLINK-4735 > Project: Flink > Issue Type: Sub-task > Components: Cluster Management >Reporter: Kurt Young >Assignee: Kurt Young > > This includes the following operations about job execution: > 1. checkpointing > 2. kvstate > 3. savepoint > 4. classloading props -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4735) Migrate some job execution related akka messages to rpc calls
[ https://issues.apache.org/jira/browse/FLINK-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15545661#comment-15545661 ] ASF GitHub Bot commented on FLINK-4735: --- GitHub user KurtYoung opened a pull request: https://github.com/apache/flink/pull/2588 [FLINK-4735] [cluster management] Migrate some job execution related akka messages to rpc calls This includes the following operations about job execution: 1. checkpointing 2. kvstate 3. savepoint 4. classloading props You can merge this pull request into a Git repository by running: $ git pull https://github.com/KurtYoung/flink flink-4735 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/2588.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2588 commit 15533a84608f1fc8a2bd3184297e2da3159703df Author: Kurt Young Date: 2016-10-04T15:00:22Z [FLINK-4735] [cluster management] Migrate some job execution related akka messages to rpc calls > Migrate some job execution related akka messages to rpc calls > - > > Key: FLINK-4735 > URL: https://issues.apache.org/jira/browse/FLINK-4735 > Project: Flink > Issue Type: Sub-task > Components: Cluster Management >Reporter: Kurt Young >Assignee: Kurt Young > > This includes the following operations about job execution: > 1. checkpointing > 2. kvstate > 3. savepoint > 4. classloading props -- This message was sent by Atlassian JIRA (v6.3.4#6332)
