[jira] [Commented] (FLINK-4746) Replace TaskManagerRuntimeInfo by TaskManagerConfiguration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15568121#comment-15568121
 ] 

ASF GitHub Bot commented on FLINK-4746:
---

Github user tillrohrmann closed the pull request at:

https://github.com/apache/flink/pull/2599


> Replace TaskManagerRuntimeInfo by TaskManagerConfiguration
> --
>
> Key: FLINK-4746
> URL: https://issues.apache.org/jira/browse/FLINK-4746
> Project: Flink
>  Issue Type: Sub-task
>  Components: TaskManager
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Minor
>
> The {{TaskExecutor}} creates an additional {{TaskManagerRuntimeInfo}} when 
> created. It contains information which is already contained in the 
> {{TaskManagerConfiguration}} object. We should replace this object because it 
> stores redundant information. Furthermore, it makes testing the 
> {{TaskExecutor}} more difficult, since mocking the 
> {{TaskManagerConfiguration}} will cause a failure when trying to create the 
> {{TaskManagerRuntimeInformation}} from the {{TaskManagerConfiguration}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4746) Replace TaskManagerRuntimeInfo by TaskManagerConfiguration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15565115#comment-15565115
 ] 

ASF GitHub Bot commented on FLINK-4746:
---

Github user tillrohrmann commented on the issue:

https://github.com/apache/flink/pull/2599
  
Rebasing this PR. If Travis gives green light, then I'll merge the PR.


> Replace TaskManagerRuntimeInfo by TaskManagerConfiguration
> --
>
> Key: FLINK-4746
> URL: https://issues.apache.org/jira/browse/FLINK-4746
> Project: Flink
>  Issue Type: Sub-task
>  Components: TaskManager
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Minor
>
> The {{TaskExecutor}} creates an additional {{TaskManagerRuntimeInfo}} when 
> created. It contains information which is already contained in the 
> {{TaskManagerConfiguration}} object. We should replace this object because it 
> stores redundant information. Furthermore, it makes testing the 
> {{TaskExecutor}} more difficult, since mocking the 
> {{TaskManagerConfiguration}} will cause a failure when trying to create the 
> {{TaskManagerRuntimeInformation}} from the {{TaskManagerConfiguration}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4746) Replace TaskManagerRuntimeInfo by TaskManagerConfiguration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15548618#comment-15548618
 ] 

ASF GitHub Bot commented on FLINK-4746:
---

GitHub user tillrohrmann opened a pull request:

https://github.com/apache/flink/pull/2599

[FLINK-4746] Make TaskManagerRuntimeInfo an interface

This PR is based on #2594.

Let the `TaskManagerConfiguration` implement the `TaskManagerRuntimeInfo` 
interface to make some of the TaskManager's configuration values accessible 
from different components.

This change makes the `TaskManager` easier to test because we don't create 
an additional `TaskManagerRuntimeInfo` which would depend on the 
`TaskManagerConfiguration`. Furthermore, we avoid to store duplicate 
information.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tillrohrmann/flink taskManagerConfiguration

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/2599.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2599


commit a7703f8a7aad94632019cb2d026073bd92be9cf3
Author: Till Rohrmann 
Date:   2016-09-28T12:39:51Z

[FLINK-4738] [TaskManager] Port TaskManager logic to new Flip-6 TaskManager

The ported logic contains the task lifecycle management methods, JobManager 
association and
setup of TaskManager components.

Introduce Rpc implementations for TaskManager components

Implement metrics setup

Move more TaskManager components out of the constructor to make 
TaskExecutor more testable

commit e9b504d2aaea79c40a2b04c9ba274807f2678b7a
Author: Till Rohrmann 
Date:   2016-10-05T12:47:24Z

[FLINK-4746] Make TaskManagerRuntimeInfo an interface

Let the TaskManagerConfiguration implement the 
TaskManagerRuntimeInformation to make some of
the TaskManager's configuration values accessible from different components.




> Replace TaskManagerRuntimeInfo by TaskManagerConfiguration
> --
>
> Key: FLINK-4746
> URL: https://issues.apache.org/jira/browse/FLINK-4746
> Project: Flink
>  Issue Type: Sub-task
>  Components: TaskManager
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Minor
>
> The {{TaskExecutor}} creates an additional {{TaskManagerRuntimeInfo}} when 
> created. It contains information which is already contained in the 
> {{TaskManagerConfiguration}} object. We should replace this object because it 
> stores redundant information. Furthermore, it makes testing the 
> {{TaskExecutor}} more difficult, since mocking the 
> {{TaskManagerConfiguration}} will cause a failure when trying to create the 
> {{TaskManagerRuntimeInformation}} from the {{TaskManagerConfiguration}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)