[jira] [Commented] (FLINK-4917) Deprecate "CheckpointedAsynchronously" interface

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836397#comment-15836397
 ] 

ASF GitHub Bot commented on FLINK-4917:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/3087


> Deprecate "CheckpointedAsynchronously" interface
> 
>
> Key: FLINK-4917
> URL: https://issues.apache.org/jira/browse/FLINK-4917
> Project: Flink
>  Issue Type: Improvement
>  Components: Streaming
>Reporter: Stephan Ewen
>  Labels: easyfix, starter
>
> The {{CheckpointedAsynchronously}} should be deprecated, as it is no longer 
> part of the new operator state abstraction.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4917) Deprecate "CheckpointedAsynchronously" interface

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15834785#comment-15834785
 ] 

ASF GitHub Bot commented on FLINK-4917:
---

Github user StephanEwen commented on the issue:

https://github.com/apache/flink/pull/3087
  
@mtunique I am addressing the `Checkpointed` in a quick followup to this 
pull request, pretty much copying the docs from `CheckpointedAsynchronously`.


> Deprecate "CheckpointedAsynchronously" interface
> 
>
> Key: FLINK-4917
> URL: https://issues.apache.org/jira/browse/FLINK-4917
> Project: Flink
>  Issue Type: Improvement
>  Components: Streaming
>Reporter: Stephan Ewen
>  Labels: easyfix, starter
>
> The {{CheckpointedAsynchronously}} should be deprecated, as it is no longer 
> part of the new operator state abstraction.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4917) Deprecate "CheckpointedAsynchronously" interface

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15834763#comment-15834763
 ] 

ASF GitHub Bot commented on FLINK-4917:
---

Github user mtunique commented on the issue:

https://github.com/apache/flink/pull/3087
  
Maybe we should open an issue about `Checkpointed` java doc to talk about 
how to replace the APIs.


> Deprecate "CheckpointedAsynchronously" interface
> 
>
> Key: FLINK-4917
> URL: https://issues.apache.org/jira/browse/FLINK-4917
> Project: Flink
>  Issue Type: Improvement
>  Components: Streaming
>Reporter: Stephan Ewen
>  Labels: easyfix, starter
>
> The {{CheckpointedAsynchronously}} should be deprecated, as it is no longer 
> part of the new operator state abstraction.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4917) Deprecate "CheckpointedAsynchronously" interface

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15834757#comment-15834757
 ] 

ASF GitHub Bot commented on FLINK-4917:
---

Github user StephanEwen commented on the issue:

https://github.com/apache/flink/pull/3087
  
Thanks, much better now!
Will merge this for 1.2 and master...


> Deprecate "CheckpointedAsynchronously" interface
> 
>
> Key: FLINK-4917
> URL: https://issues.apache.org/jira/browse/FLINK-4917
> Project: Flink
>  Issue Type: Improvement
>  Components: Streaming
>Reporter: Stephan Ewen
>  Labels: easyfix, starter
>
> The {{CheckpointedAsynchronously}} should be deprecated, as it is no longer 
> part of the new operator state abstraction.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4917) Deprecate "CheckpointedAsynchronously" interface

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15823911#comment-15823911
 ] 

ASF GitHub Bot commented on FLINK-4917:
---

Github user StephanEwen commented on the issue:

https://github.com/apache/flink/pull/3087
  
I think this needs to also talk about the asynchrony, and the short cut 
replacement via `ListCheckpointed` etc.


> Deprecate "CheckpointedAsynchronously" interface
> 
>
> Key: FLINK-4917
> URL: https://issues.apache.org/jira/browse/FLINK-4917
> Project: Flink
>  Issue Type: Improvement
>  Components: Streaming
>Reporter: Stephan Ewen
>  Labels: easyfix, starter
>
> The {{CheckpointedAsynchronously}} should be deprecated, as it is no longer 
> part of the new operator state abstraction.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4917) Deprecate "CheckpointedAsynchronously" interface

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15818374#comment-15818374
 ] 

ASF GitHub Bot commented on FLINK-4917:
---

Github user mtunique commented on the issue:

https://github.com/apache/flink/pull/3087
  
@greghogan I have add the javadoc about replacement. Maybe `Checkpointed` 
has the same problem about javadoc. Fix it in this PR or create a new issue on 
jira?


> Deprecate "CheckpointedAsynchronously" interface
> 
>
> Key: FLINK-4917
> URL: https://issues.apache.org/jira/browse/FLINK-4917
> Project: Flink
>  Issue Type: Improvement
>  Components: Streaming
>Reporter: Stephan Ewen
>  Labels: easyfix, starter
>
> The {{CheckpointedAsynchronously}} should be deprecated, as it is no longer 
> part of the new operator state abstraction.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4917) Deprecate "CheckpointedAsynchronously" interface

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15816780#comment-15816780
 ] 

ASF GitHub Bot commented on FLINK-4917:
---

Github user mtunique commented on the issue:

https://github.com/apache/flink/pull/3087
  
I am sorry about it.


> Deprecate "CheckpointedAsynchronously" interface
> 
>
> Key: FLINK-4917
> URL: https://issues.apache.org/jira/browse/FLINK-4917
> Project: Flink
>  Issue Type: Improvement
>  Components: Streaming
>Reporter: Stephan Ewen
>  Labels: easyfix, starter
>
> The {{CheckpointedAsynchronously}} should be deprecated, as it is no longer 
> part of the new operator state abstraction.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4917) Deprecate "CheckpointedAsynchronously" interface

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15815300#comment-15815300
 ] 

ASF GitHub Bot commented on FLINK-4917:
---

Github user greghogan commented on the issue:

https://github.com/apache/flink/pull/3087
  
Per Fabian's comment from the Jira, we should also document the deprecation 
in the javadoc with the recommended replacement functionality.


> Deprecate "CheckpointedAsynchronously" interface
> 
>
> Key: FLINK-4917
> URL: https://issues.apache.org/jira/browse/FLINK-4917
> Project: Flink
>  Issue Type: Improvement
>  Components: Streaming
>Reporter: Stephan Ewen
>  Labels: easyfix, starter
>
> The {{CheckpointedAsynchronously}} should be deprecated, as it is no longer 
> part of the new operator state abstraction.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4917) Deprecate "CheckpointedAsynchronously" interface

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15815258#comment-15815258
 ] 

ASF GitHub Bot commented on FLINK-4917:
---

GitHub user mtunique opened a pull request:

https://github.com/apache/flink/pull/3087

[FLINK-4917] Deprecate "CheckpointedAsynchronously" interface

- [x] General
  - The pull request references the related JIRA issue ([FLINK-4917] 
Deprecate "CheckpointedAsynchronously" interface)
  - The pull request addresses only one issue
  - Each commit in the PR has a meaningful commit message (including the 
JIRA id)

- [x] Documentation
  - Documentation has been added for new functionality
  - Old documentation affected by the pull request has been updated
  - JavaDoc for public methods has been added

- [x] Tests & Build
  - Functionality added by the pull request is covered by tests
  - `mvn clean verify` has been executed successfully locally or a Travis 
build has passed


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mtunique/flink flink-4917

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/3087.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3087


commit e4ed2142447daf585cdd0c76fadc559429f8ac11
Author: mtunique 
Date:   2017-01-10T15:05:44Z

[FLINK-4917] Deprecate "CheckpointedAsynchronously" interface




> Deprecate "CheckpointedAsynchronously" interface
> 
>
> Key: FLINK-4917
> URL: https://issues.apache.org/jira/browse/FLINK-4917
> Project: Flink
>  Issue Type: Improvement
>  Components: Streaming
>Reporter: Stephan Ewen
>  Labels: easyfix, starter
>
> The {{CheckpointedAsynchronously}} should be deprecated, as it is no longer 
> part of the new operator state abstraction.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4917) Deprecate "CheckpointedAsynchronously" interface

[Pattarawat Chormai (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15609680#comment-15609680
 ] 

Pattarawat Chormai commented on FLINK-4917:
---

Yeah, I'm also thinking about that. However, I'm quite new to Flink and 
actually never use this feature before, so could you please point me out to 
related issues in which I can sense what is the reasons behind?

> Deprecate "CheckpointedAsynchronously" interface
> 
>
> Key: FLINK-4917
> URL: https://issues.apache.org/jira/browse/FLINK-4917
> Project: Flink
>  Issue Type: Improvement
>  Components: Streaming
>Reporter: Stephan Ewen
>  Labels: easyfix, starter
>
> The {{CheckpointedAsynchronously}} should be deprecated, as it is no longer 
> part of the new operator state abstraction.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4917) Deprecate "CheckpointedAsynchronously" interface

[Fabian Hueske (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15609660#comment-15609660
 ] 

Fabian Hueske commented on FLINK-4917:
--

When deprecating interfaces it is good practice to add a comment about 
alternatives or workarounds (if there are any) or explain why the feature will 
be dropped. This helps users to rewrite their code.

> Deprecate "CheckpointedAsynchronously" interface
> 
>
> Key: FLINK-4917
> URL: https://issues.apache.org/jira/browse/FLINK-4917
> Project: Flink
>  Issue Type: Improvement
>  Components: Streaming
>Reporter: Stephan Ewen
>  Labels: easyfix, starter
>
> The {{CheckpointedAsynchronously}} should be deprecated, as it is no longer 
> part of the new operator state abstraction.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4917) Deprecate "CheckpointedAsynchronously" interface

[Pattarawat Chormai (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15609614#comment-15609614
 ] 

Pattarawat Chormai commented on FLINK-4917:
---

If I understand correctly, what we have to do here is to put *@Deprecated* 
annotation similar to https://git.io/vXvj4, am I correct?

Anything else should be done?

> Deprecate "CheckpointedAsynchronously" interface
> 
>
> Key: FLINK-4917
> URL: https://issues.apache.org/jira/browse/FLINK-4917
> Project: Flink
>  Issue Type: Improvement
>  Components: Streaming
>Reporter: Stephan Ewen
>  Labels: easyfix, starter
>
> The {{CheckpointedAsynchronously}} should be deprecated, as it is no longer 
> part of the new operator state abstraction.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)