[jira] [Commented] (FLINK-5050) JSON.org license is CatX
[
https://issues.apache.org/jira/browse/FLINK-5050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15701961#comment-15701961
]
ASF GitHub Bot commented on FLINK-5050:
---
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2824
> JSON.org license is CatX
>
>
> Key: FLINK-5050
> URL: https://issues.apache.org/jira/browse/FLINK-5050
> Project: Flink
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Sergey Sokur
>
> We should exclude org.json:json dependency from hive-exec dependency.
> {code}
> [INFO] +- org.apache.flink:flink-java:jar:1.2-SNAPSHOT:provided
> ...
> [INFO] +- org.apache.hive.hcatalog:hcatalog-core:jar:0.12.0:compile
> ...
> [INFO] | +- org.apache.hive:hive-exec:jar:0.12.0:compile
> [INFO] | | +- com.google.protobuf:protobuf-java:jar:2.4.1:compile
> [INFO] | | +- org.iq80.snappy:snappy:jar:0.2:compile
> [INFO] | | +- org.json:json:jar:20090211:compile
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-5050) JSON.org license is CatX
[
https://issues.apache.org/jira/browse/FLINK-5050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689933#comment-15689933
]
ASF GitHub Bot commented on FLINK-5050:
---
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2824
+1, merging this
> JSON.org license is CatX
>
>
> Key: FLINK-5050
> URL: https://issues.apache.org/jira/browse/FLINK-5050
> Project: Flink
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Sergey Sokur
>
> We should exclude org.json:json dependency from hive-exec dependency.
> {code}
> [INFO] +- org.apache.flink:flink-java:jar:1.2-SNAPSHOT:provided
> ...
> [INFO] +- org.apache.hive.hcatalog:hcatalog-core:jar:0.12.0:compile
> ...
> [INFO] | +- org.apache.hive:hive-exec:jar:0.12.0:compile
> [INFO] | | +- com.google.protobuf:protobuf-java:jar:2.4.1:compile
> [INFO] | | +- org.iq80.snappy:snappy:jar:0.2:compile
> [INFO] | | +- org.json:json:jar:20090211:compile
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-5050) JSON.org license is CatX
[
https://issues.apache.org/jira/browse/FLINK-5050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15687938#comment-15687938
]
ASF GitHub Bot commented on FLINK-5050:
---
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/2824
lgtm
> JSON.org license is CatX
>
>
> Key: FLINK-5050
> URL: https://issues.apache.org/jira/browse/FLINK-5050
> Project: Flink
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Sergey Sokur
>
> We should exclude org.json:json dependency from hive-exec dependency.
> {code}
> [INFO] +- org.apache.flink:flink-java:jar:1.2-SNAPSHOT:provided
> ...
> [INFO] +- org.apache.hive.hcatalog:hcatalog-core:jar:0.12.0:compile
> ...
> [INFO] | +- org.apache.hive:hive-exec:jar:0.12.0:compile
> [INFO] | | +- com.google.protobuf:protobuf-java:jar:2.4.1:compile
> [INFO] | | +- org.iq80.snappy:snappy:jar:0.2:compile
> [INFO] | | +- org.json:json:jar:20090211:compile
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-5050) JSON.org license is CatX
[
https://issues.apache.org/jira/browse/FLINK-5050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15674172#comment-15674172
]
ASF GitHub Bot commented on FLINK-5050:
---
GitHub user bitchelov opened a pull request:
https://github.com/apache/flink/pull/2824
[FLINK-5050] JSON.org license is CatX
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bitchelov/flink json_dependency
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2824.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2824
commit 28d8535d59ecee433b54b486be2bbe5d11b9a3e6
Author: sergey_sokur
Date: 2016-11-17T16:28:20Z
[FLINK-5050] JSON.org license is CatX
> JSON.org license is CatX
>
>
> Key: FLINK-5050
> URL: https://issues.apache.org/jira/browse/FLINK-5050
> Project: Flink
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Sergey Sokur
>
> We should exclude org.json:json dependency from hive-exec dependency.
> {code}
> [INFO] +- org.apache.flink:flink-java:jar:1.2-SNAPSHOT:provided
> ...
> [INFO] +- org.apache.hive.hcatalog:hcatalog-core:jar:0.12.0:compile
> ...
> [INFO] | +- org.apache.hive:hive-exec:jar:0.12.0:compile
> [INFO] | | +- com.google.protobuf:protobuf-java:jar:2.4.1:compile
> [INFO] | | +- org.iq80.snappy:snappy:jar:0.2:compile
> [INFO] | | +- org.json:json:jar:20090211:compile
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-5050) JSON.org license is CatX
[
https://issues.apache.org/jira/browse/FLINK-5050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15662583#comment-15662583
]
Ted Yu commented on FLINK-5050:
---
We can just exclude dependency on org.json
> JSON.org license is CatX
>
>
> Key: FLINK-5050
> URL: https://issues.apache.org/jira/browse/FLINK-5050
> Project: Flink
> Issue Type: Bug
>Reporter: Ted Yu
>
> We should exclude org.json:json dependency from hive-exec dependency.
> {code}
> [INFO] +- org.apache.flink:flink-java:jar:1.2-SNAPSHOT:provided
> ...
> [INFO] +- org.apache.hive.hcatalog:hcatalog-core:jar:0.12.0:compile
> ...
> [INFO] | +- org.apache.hive:hive-exec:jar:0.12.0:compile
> [INFO] | | +- com.google.protobuf:protobuf-java:jar:2.4.1:compile
> [INFO] | | +- org.iq80.snappy:snappy:jar:0.2:compile
> [INFO] | | +- org.json:json:jar:20090211:compile
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-5050) JSON.org license is CatX
[
https://issues.apache.org/jira/browse/FLINK-5050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15656895#comment-15656895
]
Stephan Ewen commented on FLINK-5050:
-
Do we need the {{hive-exec}} dependency, or can we exclude that as a whole?
> JSON.org license is CatX
>
>
> Key: FLINK-5050
> URL: https://issues.apache.org/jira/browse/FLINK-5050
> Project: Flink
> Issue Type: Bug
>Reporter: Ted Yu
>
> We should exclude org.json:json dependency from hive-exec dependency.
> {code}
> [INFO] +- org.apache.flink:flink-java:jar:1.2-SNAPSHOT:provided
> ...
> [INFO] +- org.apache.hive.hcatalog:hcatalog-core:jar:0.12.0:compile
> ...
> [INFO] | +- org.apache.hive:hive-exec:jar:0.12.0:compile
> [INFO] | | +- com.google.protobuf:protobuf-java:jar:2.4.1:compile
> [INFO] | | +- org.iq80.snappy:snappy:jar:0.2:compile
> [INFO] | | +- org.json:json:jar:20090211:compile
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
