[jira] [Commented] (FLINK-5250) Make AbstractUdfStreamOperator aware of WrappingFunction

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15822489#comment-15822489
 ] 

ASF GitHub Bot commented on FLINK-5250:
---

Github user StefanRRichter closed the pull request at:

https://github.com/apache/flink/pull/3115


> Make AbstractUdfStreamOperator aware of WrappingFunction
> 
>
> Key: FLINK-5250
> URL: https://issues.apache.org/jira/browse/FLINK-5250
> Project: Flink
>  Issue Type: Improvement
>  Components: Streaming
>Reporter: Aljoscha Krettek
>Assignee: Stefan Richter
>
> Right now, when using a {{WrappingFunction}}, as happens for 
> {{WindowFunction}} and also for some functions in the Scala API then using 
> custom interfaces is not possible. These custom interfaces are, for example, 
> the checkpointing functions such as {{ListCheckpointed}} and 
> {{CheckpointedFunction}}.
> We should teach {{AbstractUdfStreamOperator}} about {{WrapingFunction}} so 
> that it can correctly handle the case where wrapped user functions implement 
> on of these interfaces.
> Also, in the Scala API we have some custom functions that mimic 
> {{WrappingFunction}} behaviour. These should be moved to use 
> {{WrappingFunction}}, if possible.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-5250) Make AbstractUdfStreamOperator aware of WrappingFunction

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15822415#comment-15822415
 ] 

ASF GitHub Bot commented on FLINK-5250:
---

Github user aljoscha commented on the issue:

https://github.com/apache/flink/pull/3115
  
Thanks! Could you please close this PR? I merged it on master and am 
waiting for travis to merge to release-1.2 branch.


> Make AbstractUdfStreamOperator aware of WrappingFunction
> 
>
> Key: FLINK-5250
> URL: https://issues.apache.org/jira/browse/FLINK-5250
> Project: Flink
>  Issue Type: Improvement
>  Components: Streaming
>Reporter: Aljoscha Krettek
>Assignee: Stefan Richter
>
> Right now, when using a {{WrappingFunction}}, as happens for 
> {{WindowFunction}} and also for some functions in the Scala API then using 
> custom interfaces is not possible. These custom interfaces are, for example, 
> the checkpointing functions such as {{ListCheckpointed}} and 
> {{CheckpointedFunction}}.
> We should teach {{AbstractUdfStreamOperator}} about {{WrapingFunction}} so 
> that it can correctly handle the case where wrapped user functions implement 
> on of these interfaces.
> Also, in the Scala API we have some custom functions that mimic 
> {{WrappingFunction}} behaviour. These should be moved to use 
> {{WrappingFunction}}, if possible.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-5250) Make AbstractUdfStreamOperator aware of WrappingFunction

[Aljoscha Krettek (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15822412#comment-15822412
 ] 

Aljoscha Krettek commented on FLINK-5250:
-

Implemented on master in:
ce023503f6f9601c80d41766c6d59836bcb0abb6
8492d9b7b92674db309f177e48782b11d9d1be5a

> Make AbstractUdfStreamOperator aware of WrappingFunction
> 
>
> Key: FLINK-5250
> URL: https://issues.apache.org/jira/browse/FLINK-5250
> Project: Flink
>  Issue Type: Improvement
>  Components: Streaming
>Reporter: Aljoscha Krettek
>Assignee: Stefan Richter
>
> Right now, when using a {{WrappingFunction}}, as happens for 
> {{WindowFunction}} and also for some functions in the Scala API then using 
> custom interfaces is not possible. These custom interfaces are, for example, 
> the checkpointing functions such as {{ListCheckpointed}} and 
> {{CheckpointedFunction}}.
> We should teach {{AbstractUdfStreamOperator}} about {{WrapingFunction}} so 
> that it can correctly handle the case where wrapped user functions implement 
> on of these interfaces.
> Also, in the Scala API we have some custom functions that mimic 
> {{WrappingFunction}} behaviour. These should be moved to use 
> {{WrappingFunction}}, if possible.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-5250) Make AbstractUdfStreamOperator aware of WrappingFunction

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15821629#comment-15821629
 ] 

ASF GitHub Bot commented on FLINK-5250:
---

Github user StefanRRichter commented on the issue:

https://github.com/apache/flink/pull/3115
  
cc @aljoscha 


> Make AbstractUdfStreamOperator aware of WrappingFunction
> 
>
> Key: FLINK-5250
> URL: https://issues.apache.org/jira/browse/FLINK-5250
> Project: Flink
>  Issue Type: Improvement
>  Components: Streaming
>Reporter: Aljoscha Krettek
>Assignee: Stefan Richter
>
> Right now, when using a {{WrappingFunction}}, as happens for 
> {{WindowFunction}} and also for some functions in the Scala API then using 
> custom interfaces is not possible. These custom interfaces are, for example, 
> the checkpointing functions such as {{ListCheckpointed}} and 
> {{CheckpointedFunction}}.
> We should teach {{AbstractUdfStreamOperator}} about {{WrapingFunction}} so 
> that it can correctly handle the case where wrapped user functions implement 
> on of these interfaces.
> Also, in the Scala API we have some custom functions that mimic 
> {{WrappingFunction}} behaviour. These should be moved to use 
> {{WrappingFunction}}, if possible.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-5250) Make AbstractUdfStreamOperator aware of WrappingFunction

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15821628#comment-15821628
 ] 

ASF GitHub Bot commented on FLINK-5250:
---

GitHub user StefanRRichter opened a pull request:

https://github.com/apache/flink/pull/3115

[FLINK-5250] Make AbstractUdfStreamOperator aware of WrappingFunction

This PR fixes [FLINK-5250].

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/StefanRRichter/flink 
CheckpointedFunctionWithWrapping

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/3115.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3115


commit 0db9eb164379e7673fb7883e42f29a3d9cae3c91
Author: Stefan Richter 
Date:   2017-01-05T22:47:15Z

Handle checkpointing callbacks in wrapped functions

commit 6ca0c4b7e91cacb11ebc9c2e77d8c9df5479af8e
Author: Stefan Richter 
Date:   2017-01-13T11:01:55Z

Unit test




> Make AbstractUdfStreamOperator aware of WrappingFunction
> 
>
> Key: FLINK-5250
> URL: https://issues.apache.org/jira/browse/FLINK-5250
> Project: Flink
>  Issue Type: Improvement
>  Components: Streaming
>Reporter: Aljoscha Krettek
>Assignee: Stefan Richter
>
> Right now, when using a {{WrappingFunction}}, as happens for 
> {{WindowFunction}} and also for some functions in the Scala API then using 
> custom interfaces is not possible. These custom interfaces are, for example, 
> the checkpointing functions such as {{ListCheckpointed}} and 
> {{CheckpointedFunction}}.
> We should teach {{AbstractUdfStreamOperator}} about {{WrapingFunction}} so 
> that it can correctly handle the case where wrapped user functions implement 
> on of these interfaces.
> Also, in the Scala API we have some custom functions that mimic 
> {{WrappingFunction}} behaviour. These should be moved to use 
> {{WrappingFunction}}, if possible.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-5250) Make AbstractUdfStreamOperator aware of WrappingFunction

[Aljoscha Krettek (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15815072#comment-15815072
 ] 

Aljoscha Krettek commented on FLINK-5250:
-

Remember to close FLINK-5416 when we close this issue.

> Make AbstractUdfStreamOperator aware of WrappingFunction
> 
>
> Key: FLINK-5250
> URL: https://issues.apache.org/jira/browse/FLINK-5250
> Project: Flink
>  Issue Type: Improvement
>  Components: Streaming
>Reporter: Aljoscha Krettek
>Assignee: Stefan Richter
>
> Right now, when using a {{WrappingFunction}}, as happens for 
> {{WindowFunction}} and also for some functions in the Scala API then using 
> custom interfaces is not possible. These custom interfaces are, for example, 
> the checkpointing functions such as {{ListCheckpointed}} and 
> {{CheckpointedFunction}}.
> We should teach {{AbstractUdfStreamOperator}} about {{WrapingFunction}} so 
> that it can correctly handle the case where wrapped user functions implement 
> on of these interfaces.
> Also, in the Scala API we have some custom functions that mimic 
> {{WrappingFunction}} behaviour. These should be moved to use 
> {{WrappingFunction}}, if possible.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)