[jira] [Commented] (FLINK-6494) Migrate ResourceManager configuration options
[ https://issues.apache.org/jira/browse/FLINK-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121488#comment-16121488 ] ASF GitHub Bot commented on FLINK-6494: --- Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4075 > Migrate ResourceManager configuration options > - > > Key: FLINK-6494 > URL: https://issues.apache.org/jira/browse/FLINK-6494 > Project: Flink > Issue Type: Sub-task > Components: Distributed Coordination, ResourceManager >Reporter: Chesnay Schepler >Assignee: Fang Yong > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-6494) Migrate ResourceManager configuration options
[ https://issues.apache.org/jira/browse/FLINK-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119786#comment-16119786 ] ASF GitHub Bot commented on FLINK-6494: --- Github user zentol commented on the issue: https://github.com/apache/flink/pull/4075 merging. > Migrate ResourceManager configuration options > - > > Key: FLINK-6494 > URL: https://issues.apache.org/jira/browse/FLINK-6494 > Project: Flink > Issue Type: Sub-task > Components: Distributed Coordination, ResourceManager >Reporter: Chesnay Schepler >Assignee: Fang Yong > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-6494) Migrate ResourceManager configuration options
[ https://issues.apache.org/jira/browse/FLINK-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16115907#comment-16115907 ] ASF GitHub Bot commented on FLINK-6494: --- Github user zentol commented on the issue: https://github.com/apache/flink/pull/4075 I'll try to get this in this week. > Migrate ResourceManager configuration options > - > > Key: FLINK-6494 > URL: https://issues.apache.org/jira/browse/FLINK-6494 > Project: Flink > Issue Type: Sub-task > Components: Distributed Coordination, ResourceManager >Reporter: Chesnay Schepler >Assignee: Fang Yong > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-6494) Migrate ResourceManager configuration options
[ https://issues.apache.org/jira/browse/FLINK-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108583#comment-16108583 ] ASF GitHub Bot commented on FLINK-6494: --- Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4075 @zentol I updated this PR and fix some code conflicts, could you please have a look when you're free, thanks > Migrate ResourceManager configuration options > - > > Key: FLINK-6494 > URL: https://issues.apache.org/jira/browse/FLINK-6494 > Project: Flink > Issue Type: Sub-task > Components: Distributed Coordination, ResourceManager >Reporter: Chesnay Schepler >Assignee: Fang Yong > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-6494) Migrate ResourceManager configuration options
[ https://issues.apache.org/jira/browse/FLINK-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067781#comment-16067781 ] ASF GitHub Bot commented on FLINK-6494: --- Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4075 @zentol Thank you for your suggestion, I have fixed the problems you metioned. Thanks > Migrate ResourceManager configuration options > - > > Key: FLINK-6494 > URL: https://issues.apache.org/jira/browse/FLINK-6494 > Project: Flink > Issue Type: Sub-task > Components: Distributed Coordination, ResourceManager >Reporter: Chesnay Schepler >Assignee: Fang Yong > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-6494) Migrate ResourceManager configuration options
[
https://issues.apache.org/jira/browse/FLINK-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066291#comment-16066291
]
ASF GitHub Bot commented on FLINK-6494:
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4075#discussion_r124504146
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ResourceManagerOptions.java
---
@@ -33,6 +33,45 @@
.key("resourcemanager.job.timeout")
.defaultValue("5 minutes");
+ public static final ConfigOption LOCAL_NUMBER_RESOURCE_MANAGER
= ConfigOptions
+ .key("local.number-resourcemanager")
+ .defaultValue(1);
+
+ public static final ConfigOption RESOURCE_MANAGER_IPC_PORT =
ConfigOptions
+ .key("resourcemanager.rpc.port")
+ .defaultValue(0);
+
+ /**
+* Percentage of heap space to remove from containers (YARN / Mesos),
to compensate
+* for other JVM memory usage.
+*/
+ public static final ConfigOption CONTAINERIZED_HEAP_CUTOFF_RATIO
= ConfigOptions
+ .key("containerized.heap-cutoff-ratio")
+ .defaultValue(0.25f)
+ .withDeprecatedKeys(ConfigConstants.YARN_HEAP_CUTOFF_RATIO);
--- End diff --
let's use the actual key here. I'd like to end up in a state where we could
remove the deprecated parts of the ConfigConstants class without requiring
other changes.
> Migrate ResourceManager configuration options
> -
>
> Key: FLINK-6494
> URL: https://issues.apache.org/jira/browse/FLINK-6494
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination, ResourceManager
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-6494) Migrate ResourceManager configuration options
[
https://issues.apache.org/jira/browse/FLINK-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066293#comment-16066293
]
ASF GitHub Bot commented on FLINK-6494:
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4075#discussion_r124503662
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ResourceManagerOptions.java
---
@@ -33,6 +33,45 @@
.key("resourcemanager.job.timeout")
.defaultValue("5 minutes");
+ public static final ConfigOption LOCAL_NUMBER_RESOURCE_MANAGER
= ConfigOptions
+ .key("local.number-resourcemanager")
+ .defaultValue(1);
+
+ public static final ConfigOption RESOURCE_MANAGER_IPC_PORT =
ConfigOptions
--- End diff --
remove RESOURCE_MANAGER prefix
> Migrate ResourceManager configuration options
> -
>
> Key: FLINK-6494
> URL: https://issues.apache.org/jira/browse/FLINK-6494
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination, ResourceManager
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-6494) Migrate ResourceManager configuration options
[
https://issues.apache.org/jira/browse/FLINK-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066292#comment-16066292
]
ASF GitHub Bot commented on FLINK-6494:
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4075#discussion_r124501969
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/configuration/MesosConfigOptions.java
---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.mesos.configuration;
+
+import org.apache.flink.configuration.ConfigOption;
+
+import static org.apache.flink.configuration.ConfigOptions.key;
+
+/**
+ * The set of configuration options relating to mesos settings.
+ */
+public class MesosConfigOptions {
--- End diff --
Let's rename this to `MesosOptions`, akin to the classes in flink-core.
> Migrate ResourceManager configuration options
> -
>
> Key: FLINK-6494
> URL: https://issues.apache.org/jira/browse/FLINK-6494
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination, ResourceManager
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-6494) Migrate ResourceManager configuration options
[
https://issues.apache.org/jira/browse/FLINK-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066290#comment-16066290
]
ASF GitHub Bot commented on FLINK-6494:
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4075#discussion_r124504177
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ResourceManagerOptions.java
---
@@ -33,6 +33,45 @@
.key("resourcemanager.job.timeout")
.defaultValue("5 minutes");
+ public static final ConfigOption LOCAL_NUMBER_RESOURCE_MANAGER
= ConfigOptions
+ .key("local.number-resourcemanager")
+ .defaultValue(1);
+
+ public static final ConfigOption RESOURCE_MANAGER_IPC_PORT =
ConfigOptions
+ .key("resourcemanager.rpc.port")
+ .defaultValue(0);
+
+ /**
+* Percentage of heap space to remove from containers (YARN / Mesos),
to compensate
+* for other JVM memory usage.
+*/
+ public static final ConfigOption CONTAINERIZED_HEAP_CUTOFF_RATIO
= ConfigOptions
+ .key("containerized.heap-cutoff-ratio")
+ .defaultValue(0.25f)
+ .withDeprecatedKeys(ConfigConstants.YARN_HEAP_CUTOFF_RATIO);
+
+ /**
+* Minimum amount of heap memory to remove in containers, as a safety
margin.
+*/
+ public static final ConfigOption CONTAINERIZED_HEAP_CUTOFF_MIN
= ConfigOptions
+ .key("containerized.heap-cutoff-min")
+ .defaultValue(600)
+ .withDeprecatedKeys(ConfigConstants.YARN_HEAP_CUTOFF_MIN);
--- End diff --
same as above
> Migrate ResourceManager configuration options
> -
>
> Key: FLINK-6494
> URL: https://issues.apache.org/jira/browse/FLINK-6494
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination, ResourceManager
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-6494) Migrate ResourceManager configuration options
[ https://issues.apache.org/jira/browse/FLINK-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16058931#comment-16058931 ] ASF GitHub Bot commented on FLINK-6494: --- Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4075 I have fixed the problems you metioned, thanks @zentol > Migrate ResourceManager configuration options > - > > Key: FLINK-6494 > URL: https://issues.apache.org/jira/browse/FLINK-6494 > Project: Flink > Issue Type: Sub-task > Components: Distributed Coordination, ResourceManager >Reporter: Chesnay Schepler >Assignee: Fang Yong > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-6494) Migrate ResourceManager configuration options
[
https://issues.apache.org/jira/browse/FLINK-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057237#comment-16057237
]
ASF GitHub Bot commented on FLINK-6494:
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4075#discussion_r123197240
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/configuration/YarnConfigOptions.java
---
@@ -52,7 +52,74 @@
key("yarn.per-job-cluster.include-user-jar")
.defaultValue("ORDER");
+ /**
+* The vcores exposed by YARN.
+*/
+ public static final ConfigOption YARN_VCORES =
+ key("yarn.containers.vcores")
+ .defaultValue(Integer.MAX_VALUE);
--- End diff --
Personally i think we should have methods that allow overriding the default
for non-String options; I've already opened FLINK-6638 for this.
Let's use -1 as the default instead, it's a more "expected" invalid value i
suppose.
> Migrate ResourceManager configuration options
> -
>
> Key: FLINK-6494
> URL: https://issues.apache.org/jira/browse/FLINK-6494
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination, ResourceManager
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-6494) Migrate ResourceManager configuration options
[
https://issues.apache.org/jira/browse/FLINK-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057147#comment-16057147
]
ASF GitHub Bot commented on FLINK-6494:
---
Github user zjureel commented on a diff in the pull request:
https://github.com/apache/flink/pull/4075#discussion_r123180174
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/configuration/YarnConfigOptions.java
---
@@ -52,7 +52,74 @@
key("yarn.per-job-cluster.include-user-jar")
.defaultValue("ORDER");
+ /**
+* The vcores exposed by YARN.
+*/
+ public static final ConfigOption YARN_VCORES =
+ key("yarn.containers.vcores")
+ .defaultValue(Integer.MAX_VALUE);
--- End diff --
I determine this default by test case, sorry :(
In fact I want to use `noDefaultValue()` here, but I find this method can
be used for `String` only, and there's no `getInteger(ConfigOption
option, int overrideDefault)` in `Configuration`.
I think it may be better to add `public ConfigOption noDefaultValue()`
in `ConfigOptions` and add `public int getString(ConfigOption
configOption, int overrideDefault)` in `Configuration` . What do you think? THX
:)
> Migrate ResourceManager configuration options
> -
>
> Key: FLINK-6494
> URL: https://issues.apache.org/jira/browse/FLINK-6494
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination, ResourceManager
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-6494) Migrate ResourceManager configuration options
[
https://issues.apache.org/jira/browse/FLINK-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055978#comment-16055978
]
ASF GitHub Bot commented on FLINK-6494:
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4075#discussion_r123012831
--- Diff:
flink-mesos/src/test/java/org/apache/flink/mesos/runtime/clusterframework/MesosFlinkResourceManagerTest.java
---
@@ -105,8 +105,8 @@
private static final long serialVersionUID =
-952579203067648838L;
{
- setInteger(ConfigConstants.MESOS_MAX_FAILED_TASKS, -1);
- setInteger(ConfigConstants.MESOS_INITIAL_TASKS, 0);
+
setInteger(MesosConfigOptions.MESOS_MAX_FAILED_TASKS.key(), -1);
--- End diff --
remove call to `key()`
> Migrate ResourceManager configuration options
> -
>
> Key: FLINK-6494
> URL: https://issues.apache.org/jira/browse/FLINK-6494
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination, ResourceManager
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-6494) Migrate ResourceManager configuration options
[
https://issues.apache.org/jira/browse/FLINK-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055979#comment-16055979
]
ASF GitHub Bot commented on FLINK-6494:
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4075#discussion_r123015212
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosApplicationMasterRunner.java
---
@@ -492,42 +492,38 @@ public static MesosConfiguration
createMesosConfig(Configuration flinkConfig, St
.setHostname(hostname);
Protos.Credential.Builder credential = null;
- if (!flinkConfig.containsKey(ConfigConstants.MESOS_MASTER_URL))
{
- throw new
IllegalConfigurationException(ConfigConstants.MESOS_MASTER_URL + " must be
configured.");
+ if (!flinkConfig.contains(MesosConfigOptions.MESOS_MASTER_URL))
{
+ throw new
IllegalConfigurationException(MesosConfigOptions.MESOS_MASTER_URL.key() + "
must be configured.");
}
- String masterUrl =
flinkConfig.getString(ConfigConstants.MESOS_MASTER_URL, null);
+ String masterUrl =
flinkConfig.getString(MesosConfigOptions.MESOS_MASTER_URL, null);
Duration failoverTimeout = FiniteDuration.apply(
flinkConfig.getInteger(
- ConfigConstants.MESOS_FAILOVER_TIMEOUT_SECONDS,
-
ConfigConstants.DEFAULT_MESOS_FAILOVER_TIMEOUT_SECS),
+
MesosConfigOptions.MESOS_FAILOVER_TIMEOUT_SECONDS),
TimeUnit.SECONDS);
frameworkInfo.setFailoverTimeout(failoverTimeout.toSeconds());
frameworkInfo.setName(flinkConfig.getString(
- ConfigConstants.MESOS_RESOURCEMANAGER_FRAMEWORK_NAME,
-
ConfigConstants.DEFAULT_MESOS_RESOURCEMANAGER_FRAMEWORK_NAME));
+
MesosConfigOptions.MESOS_RESOURCEMANAGER_FRAMEWORK_NAME));
frameworkInfo.setRole(flinkConfig.getString(
- ConfigConstants.MESOS_RESOURCEMANAGER_FRAMEWORK_ROLE,
-
ConfigConstants.DEFAULT_MESOS_RESOURCEMANAGER_FRAMEWORK_ROLE));
+
MesosConfigOptions.MESOS_RESOURCEMANAGER_FRAMEWORK_ROLE));
frameworkInfo.setUser(flinkConfig.getString(
- ConfigConstants.MESOS_RESOURCEMANAGER_FRAMEWORK_USER,
-
ConfigConstants.DEFAULT_MESOS_RESOURCEMANAGER_FRAMEWORK_USER));
+
MesosConfigOptions.MESOS_RESOURCEMANAGER_FRAMEWORK_USER));
- if
(flinkConfig.containsKey(ConfigConstants.MESOS_RESOURCEMANAGER_FRAMEWORK_PRINCIPAL))
{
+ if
(flinkConfig.contains(MesosConfigOptions.MESOS_RESOURCEMANAGER_FRAMEWORK_PRINCIPAL))
{
frameworkInfo.setPrincipal(flinkConfig.getString(
-
ConfigConstants.MESOS_RESOURCEMANAGER_FRAMEWORK_PRINCIPAL, null));
+
MesosConfigOptions.MESOS_RESOURCEMANAGER_FRAMEWORK_PRINCIPAL, null));
credential = Protos.Credential.newBuilder();
credential.setPrincipal(frameworkInfo.getPrincipal());
// some environments use a side-channel to communicate
the secret to Mesos,
// and thus don't set the 'secret' configuration setting
- if
(flinkConfig.containsKey(ConfigConstants.MESOS_RESOURCEMANAGER_FRAMEWORK_SECRET))
{
+ if
(flinkConfig.contains(MesosConfigOptions.MESOS_RESOURCEMANAGER_FRAMEWORK_SECRET))
{
credential.setSecret(flinkConfig.getString(
-
ConfigConstants.MESOS_RESOURCEMANAGER_FRAMEWORK_SECRET, null));
+
MesosConfigOptions.MESOS_RESOURCEMANAGER_FRAMEWORK_SECRET, null));
--- End diff --
null argument can be removed.
> Migrate ResourceManager configuration options
> -
>
> Key: FLINK-6494
> URL: https://issues.apache.org/jira/browse/FLINK-6494
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination, ResourceManager
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-6494) Migrate ResourceManager configuration options
[
https://issues.apache.org/jira/browse/FLINK-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055976#comment-16055976
]
ASF GitHub Bot commented on FLINK-6494:
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4075#discussion_r123012918
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/configuration/MesosConfigOptions.java
---
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.mesos.configuration;
+
+import org.apache.flink.configuration.ConfigOption;
+
+import static org.apache.flink.configuration.ConfigOptions.key;
+
+/**
+ * This class holds configuration constants used by Flink's MESOS runners.
+ *
+ * These options are not expected to be ever configured by users
explicitly.
+ */
+public class MesosConfigOptions {
+
+ /**
+* The initial number of Mesos tasks to allocate.
+*/
+ public static final ConfigOption MESOS_INITIAL_TASKS =
--- End diff --
remove `Mesos_` prefix
> Migrate ResourceManager configuration options
> -
>
> Key: FLINK-6494
> URL: https://issues.apache.org/jira/browse/FLINK-6494
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination, ResourceManager
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-6494) Migrate ResourceManager configuration options
[
https://issues.apache.org/jira/browse/FLINK-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055980#comment-16055980
]
ASF GitHub Bot commented on FLINK-6494:
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4075#discussion_r123013245
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/configuration/MesosConfigOptions.java
---
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.mesos.configuration;
+
+import org.apache.flink.configuration.ConfigOption;
+
+import static org.apache.flink.configuration.ConfigOptions.key;
+
+/**
+ * This class holds configuration constants used by Flink's MESOS runners.
+ *
+ * These options are not expected to be ever configured by users
explicitly.
+ */
+public class MesosConfigOptions {
+
+ /**
+* The initial number of Mesos tasks to allocate.
+*/
+ public static final ConfigOption MESOS_INITIAL_TASKS =
+ key("mesos.initial-tasks")
+ .defaultValue(0);
+
+ /**
+* The maximum number of failed Mesos tasks before entirely stopping
+* the Mesos session / job on Mesos.
+*
+* By default, we take the number of of initially requested tasks.
+*/
+ public static final ConfigOption MESOS_MAX_FAILED_TASKS =
+ key("mesos.maximum-failed-tasks")
+ .noDefaultValue();
+
+ /**
+* The Mesos master URL.
+*
+* The value should be in one of the following forms:
+*
+* {@code
+* host:port
+* zk://host1:port1,host2:port2,.../path
+* zk://username:password@host1:port1,host2:port2,.../path
+* file:///path/to/file (where file contains one of the above)
+* }
+*
+*
--- End diff --
remove empty line
> Migrate ResourceManager configuration options
> -
>
> Key: FLINK-6494
> URL: https://issues.apache.org/jira/browse/FLINK-6494
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination, ResourceManager
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-6494) Migrate ResourceManager configuration options
[
https://issues.apache.org/jira/browse/FLINK-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055977#comment-16055977
]
ASF GitHub Bot commented on FLINK-6494:
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4075#discussion_r123012988
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/configuration/MesosConfigOptions.java
---
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.mesos.configuration;
+
+import org.apache.flink.configuration.ConfigOption;
+
+import static org.apache.flink.configuration.ConfigOptions.key;
+
+/**
+ * This class holds configuration constants used by Flink's MESOS runners.
+ *
+ * These options are not expected to be ever configured by users
explicitly.
+ */
+public class MesosConfigOptions {
+
+ /**
+* The initial number of Mesos tasks to allocate.
+*/
+ public static final ConfigOption MESOS_INITIAL_TASKS =
+ key("mesos.initial-tasks")
+ .defaultValue(0);
--- End diff --
please indent the `.defaultValue` line
> Migrate ResourceManager configuration options
> -
>
> Key: FLINK-6494
> URL: https://issues.apache.org/jira/browse/FLINK-6494
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination, ResourceManager
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-6494) Migrate ResourceManager configuration options
[ https://issues.apache.org/jira/browse/FLINK-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055982#comment-16055982 ] ASF GitHub Bot commented on FLINK-6494: --- Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4075#discussion_r123013163 --- Diff: flink-mesos/src/main/java/org/apache/flink/mesos/configuration/MesosConfigOptions.java --- @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.mesos.configuration; + +import org.apache.flink.configuration.ConfigOption; + +import static org.apache.flink.configuration.ConfigOptions.key; + +/** + * This class holds configuration constants used by Flink's MESOS runners. + * + * These options are not expected to be ever configured by users explicitly. --- End diff -- I don't understand this comment. > Migrate ResourceManager configuration options > - > > Key: FLINK-6494 > URL: https://issues.apache.org/jira/browse/FLINK-6494 > Project: Flink > Issue Type: Sub-task > Components: Distributed Coordination, ResourceManager >Reporter: Chesnay Schepler >Assignee: Fang Yong > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-6494) Migrate ResourceManager configuration options
[
https://issues.apache.org/jira/browse/FLINK-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055983#comment-16055983
]
ASF GitHub Bot commented on FLINK-6494:
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4075#discussion_r123014657
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/configuration/MesosConfigOptions.java
---
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.mesos.configuration;
+
+import org.apache.flink.configuration.ConfigOption;
+
+import static org.apache.flink.configuration.ConfigOptions.key;
+
+/**
+ * This class holds configuration constants used by Flink's MESOS runners.
+ *
+ * These options are not expected to be ever configured by users
explicitly.
+ */
+public class MesosConfigOptions {
+
+ /**
+* The initial number of Mesos tasks to allocate.
+*/
+ public static final ConfigOption MESOS_INITIAL_TASKS =
+ key("mesos.initial-tasks")
+ .defaultValue(0);
+
+ /**
+* The maximum number of failed Mesos tasks before entirely stopping
+* the Mesos session / job on Mesos.
+*
+* By default, we take the number of of initially requested tasks.
+*/
+ public static final ConfigOption MESOS_MAX_FAILED_TASKS =
+ key("mesos.maximum-failed-tasks")
+ .noDefaultValue();
+
+ /**
+* The Mesos master URL.
+*
+* The value should be in one of the following forms:
+*
+* {@code
+* host:port
+* zk://host1:port1,host2:port2,.../path
+* zk://username:password@host1:port1,host2:port2,.../path
+* file:///path/to/file (where file contains one of the above)
+* }
+*
+*
+*/
+ public static final ConfigOption MESOS_MASTER_URL =
+ key("mesos.master").noDefaultValue();
+
+ /**
+* The failover timeout for the Mesos scheduler, after which running
tasks are automatically shut down.
+*
+* The default value is 600 (seconds).
--- End diff --
dont need this comment anymore.
> Migrate ResourceManager configuration options
> -
>
> Key: FLINK-6494
> URL: https://issues.apache.org/jira/browse/FLINK-6494
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination, ResourceManager
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-6494) Migrate ResourceManager configuration options
[
https://issues.apache.org/jira/browse/FLINK-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055981#comment-16055981
]
ASF GitHub Bot commented on FLINK-6494:
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4075#discussion_r123015168
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosApplicationMasterRunner.java
---
@@ -492,42 +492,38 @@ public static MesosConfiguration
createMesosConfig(Configuration flinkConfig, St
.setHostname(hostname);
Protos.Credential.Builder credential = null;
- if (!flinkConfig.containsKey(ConfigConstants.MESOS_MASTER_URL))
{
- throw new
IllegalConfigurationException(ConfigConstants.MESOS_MASTER_URL + " must be
configured.");
+ if (!flinkConfig.contains(MesosConfigOptions.MESOS_MASTER_URL))
{
+ throw new
IllegalConfigurationException(MesosConfigOptions.MESOS_MASTER_URL.key() + "
must be configured.");
}
- String masterUrl =
flinkConfig.getString(ConfigConstants.MESOS_MASTER_URL, null);
+ String masterUrl =
flinkConfig.getString(MesosConfigOptions.MESOS_MASTER_URL, null);
Duration failoverTimeout = FiniteDuration.apply(
flinkConfig.getInteger(
- ConfigConstants.MESOS_FAILOVER_TIMEOUT_SECONDS,
-
ConfigConstants.DEFAULT_MESOS_FAILOVER_TIMEOUT_SECS),
+
MesosConfigOptions.MESOS_FAILOVER_TIMEOUT_SECONDS),
TimeUnit.SECONDS);
frameworkInfo.setFailoverTimeout(failoverTimeout.toSeconds());
frameworkInfo.setName(flinkConfig.getString(
- ConfigConstants.MESOS_RESOURCEMANAGER_FRAMEWORK_NAME,
-
ConfigConstants.DEFAULT_MESOS_RESOURCEMANAGER_FRAMEWORK_NAME));
+
MesosConfigOptions.MESOS_RESOURCEMANAGER_FRAMEWORK_NAME));
frameworkInfo.setRole(flinkConfig.getString(
- ConfigConstants.MESOS_RESOURCEMANAGER_FRAMEWORK_ROLE,
-
ConfigConstants.DEFAULT_MESOS_RESOURCEMANAGER_FRAMEWORK_ROLE));
+
MesosConfigOptions.MESOS_RESOURCEMANAGER_FRAMEWORK_ROLE));
frameworkInfo.setUser(flinkConfig.getString(
- ConfigConstants.MESOS_RESOURCEMANAGER_FRAMEWORK_USER,
-
ConfigConstants.DEFAULT_MESOS_RESOURCEMANAGER_FRAMEWORK_USER));
+
MesosConfigOptions.MESOS_RESOURCEMANAGER_FRAMEWORK_USER));
- if
(flinkConfig.containsKey(ConfigConstants.MESOS_RESOURCEMANAGER_FRAMEWORK_PRINCIPAL))
{
+ if
(flinkConfig.contains(MesosConfigOptions.MESOS_RESOURCEMANAGER_FRAMEWORK_PRINCIPAL))
{
frameworkInfo.setPrincipal(flinkConfig.getString(
-
ConfigConstants.MESOS_RESOURCEMANAGER_FRAMEWORK_PRINCIPAL, null));
+
MesosConfigOptions.MESOS_RESOURCEMANAGER_FRAMEWORK_PRINCIPAL, null));
--- End diff --
We can remove the null argument here.
> Migrate ResourceManager configuration options
> -
>
> Key: FLINK-6494
> URL: https://issues.apache.org/jira/browse/FLINK-6494
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination, ResourceManager
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-6494) Migrate ResourceManager configuration options
[
https://issues.apache.org/jira/browse/FLINK-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055952#comment-16055952
]
ASF GitHub Bot commented on FLINK-6494:
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4075#discussion_r123010334
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -415,31 +417,39 @@
* the YARN session / job on YARN.
*
* By default, we take the number of of initially requested containers.
+* @deprecated in favor of {@code #CONTAINERIZED_HEAP_CUTOFF_MIN}.
--- End diff --
well this doesn't look right.
> Migrate ResourceManager configuration options
> -
>
> Key: FLINK-6494
> URL: https://issues.apache.org/jira/browse/FLINK-6494
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination, ResourceManager
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-6494) Migrate ResourceManager configuration options
[
https://issues.apache.org/jira/browse/FLINK-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055950#comment-16055950
]
ASF GitHub Bot commented on FLINK-6494:
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4075#discussion_r123009144
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/configuration/YarnConfigOptions.java
---
@@ -52,7 +52,74 @@
key("yarn.per-job-cluster.include-user-jar")
.defaultValue("ORDER");
+ /**
+* The vcores exposed by YARN.
+*/
+ public static final ConfigOption YARN_VCORES =
--- End diff --
remove `YARN_` prefix.
> Migrate ResourceManager configuration options
> -
>
> Key: FLINK-6494
> URL: https://issues.apache.org/jira/browse/FLINK-6494
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination, ResourceManager
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-6494) Migrate ResourceManager configuration options
[
https://issues.apache.org/jira/browse/FLINK-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055951#comment-16055951
]
ASF GitHub Bot commented on FLINK-6494:
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4075#discussion_r123009951
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/configuration/YarnConfigOptions.java
---
@@ -52,7 +52,74 @@
key("yarn.per-job-cluster.include-user-jar")
.defaultValue("ORDER");
+ /**
+* The vcores exposed by YARN.
+*/
+ public static final ConfigOption YARN_VCORES =
+ key("yarn.containers.vcores")
+ .defaultValue(Integer.MAX_VALUE);
+
+ /**
+* The maximum number of failed YARN containers before entirely stopping
+* the YARN session / job on YARN.
+*
+* By default, we take the number of of initially requested containers.
+*/
+ public static final ConfigOption YARN_MAX_FAILED_CONTAINERS =
+ key("yarn.maximum-failed-containers")
+ .noDefaultValue();
+ /**
+* Set the number of retries for failed YARN
ApplicationMasters/JobManagers in high
+* availability mode. This value is usually limited by YARN.
+*
+* By default, it's 1 in the standalone case and 2 in the high
availability case.
+*/
+ public static final ConfigOption YARN_APPLICATION_ATTEMPTS =
+ key("yarn.application-attempts")
+ .noDefaultValue();
+
+ /**
+* The heartbeat interval between the Application Master and the YARN
Resource Manager.
+*
+* The default value is 5 (seconds).
+*/
+ public static final ConfigOption YARN_HEARTBEAT_DELAY_SECONDS =
+ key("yarn.heartbeat-delay")
+ .defaultValue("5 s");
--- End diff --
We can't just change the type of the option, nor the syntax with which it
is configured. It should remain an Integer.
> Migrate ResourceManager configuration options
> -
>
> Key: FLINK-6494
> URL: https://issues.apache.org/jira/browse/FLINK-6494
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination, ResourceManager
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-6494) Migrate ResourceManager configuration options
[
https://issues.apache.org/jira/browse/FLINK-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055953#comment-16055953
]
ASF GitHub Bot commented on FLINK-6494:
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4075#discussion_r123010982
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/configuration/YarnConfigOptions.java
---
@@ -52,7 +52,74 @@
key("yarn.per-job-cluster.include-user-jar")
.defaultValue("ORDER");
+ /**
+* The vcores exposed by YARN.
+*/
+ public static final ConfigOption YARN_VCORES =
+ key("yarn.containers.vcores")
+ .defaultValue(Integer.MAX_VALUE);
--- End diff --
is this really a reasonable default value? I wouldn't be surprised if YARN
would reject this.
> Migrate ResourceManager configuration options
> -
>
> Key: FLINK-6494
> URL: https://issues.apache.org/jira/browse/FLINK-6494
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination, ResourceManager
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-6494) Migrate ResourceManager configuration options
[ https://issues.apache.org/jira/browse/FLINK-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16048776#comment-16048776 ] ASF GitHub Bot commented on FLINK-6494: --- Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4075 @zentol Thank you for your suggestion. I have split the commits into one for yarn/mesos/RM each :) > Migrate ResourceManager configuration options > - > > Key: FLINK-6494 > URL: https://issues.apache.org/jira/browse/FLINK-6494 > Project: Flink > Issue Type: Sub-task > Components: Distributed Coordination, ResourceManager >Reporter: Chesnay Schepler >Assignee: Fang Yong > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-6494) Migrate ResourceManager configuration options
[
https://issues.apache.org/jira/browse/FLINK-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16042149#comment-16042149
]
ASF GitHub Bot commented on FLINK-6494:
---
GitHub user zjureel reopened a pull request:
https://github.com/apache/flink/pull/4075
[FLINK-6494] Migrate ResourceManager/Yarn/Mesos configuration options
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjureel/flink FLINK-6494
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4075.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4075
commit a33bee88929d1c98d4bd9c1ba175fb5bebd9aa96
Author: zjureel
Date: 2017-06-08T03:38:56Z
[FLINK-6494] Migrate ResourceManager configuration options
> Migrate ResourceManager configuration options
> -
>
> Key: FLINK-6494
> URL: https://issues.apache.org/jira/browse/FLINK-6494
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination, ResourceManager
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (FLINK-6494) Migrate ResourceManager configuration options
[ https://issues.apache.org/jira/browse/FLINK-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16040080#comment-16040080 ] ASF GitHub Bot commented on FLINK-6494: --- Github user zjureel closed the pull request at: https://github.com/apache/flink/pull/4075 > Migrate ResourceManager configuration options > - > > Key: FLINK-6494 > URL: https://issues.apache.org/jira/browse/FLINK-6494 > Project: Flink > Issue Type: Sub-task > Components: Distributed Coordination, ResourceManager >Reporter: Chesnay Schepler >Assignee: Fang Yong > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FLINK-6494) Migrate ResourceManager configuration options
[ https://issues.apache.org/jira/browse/FLINK-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16038432#comment-16038432 ] ASF GitHub Bot commented on FLINK-6494: --- Github user zentol commented on the issue: https://github.com/apache/flink/pull/4075 Could you split the commits into one for yarn/mesos/RM each, and remove the merge commit? > Migrate ResourceManager configuration options > - > > Key: FLINK-6494 > URL: https://issues.apache.org/jira/browse/FLINK-6494 > Project: Flink > Issue Type: Sub-task > Components: Distributed Coordination, ResourceManager >Reporter: Chesnay Schepler >Assignee: Fang Yong > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FLINK-6494) Migrate ResourceManager configuration options
[ https://issues.apache.org/jira/browse/FLINK-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036500#comment-16036500 ] ASF GitHub Bot commented on FLINK-6494: --- Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4075 @zentol In addtion to ResourceManager, I have migrated the configuration options of yarn and mesos to their class files, would you please make a review while you are free, thanks :) > Migrate ResourceManager configuration options > - > > Key: FLINK-6494 > URL: https://issues.apache.org/jira/browse/FLINK-6494 > Project: Flink > Issue Type: Sub-task > Components: Distributed Coordination, ResourceManager >Reporter: Chesnay Schepler >Assignee: Fang Yong > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FLINK-6494) Migrate ResourceManager configuration options
[
https://issues.apache.org/jira/browse/FLINK-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036498#comment-16036498
]
ASF GitHub Bot commented on FLINK-6494:
---
GitHub user zjureel opened a pull request:
https://github.com/apache/flink/pull/4075
[FLINK-6494] Migrate ResourceManager/Yarn/Mesos configuration options
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjureel/flink FLINK-6494
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4075.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4075
commit 8b911d2a8799e3fb64b5f79306e3a629e890952a
Author: zjureel
Date: 2017-06-05T03:51:31Z
[FLINK-6494] Migrate ResourceManager/Yarn/Mesos configuration options
> Migrate ResourceManager configuration options
> -
>
> Key: FLINK-6494
> URL: https://issues.apache.org/jira/browse/FLINK-6494
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination, ResourceManager
>Reporter: Chesnay Schepler
>Assignee: Fang Yong
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (FLINK-6494) Migrate ResourceManager configuration options
[ https://issues.apache.org/jira/browse/FLINK-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16023038#comment-16023038 ] Chesnay Schepler commented on FLINK-6494: - yes, the yarn and mesos options should be migrated as well. > Migrate ResourceManager configuration options > - > > Key: FLINK-6494 > URL: https://issues.apache.org/jira/browse/FLINK-6494 > Project: Flink > Issue Type: Sub-task > Components: Distributed Coordination, ResourceManager >Reporter: Chesnay Schepler >Assignee: Fang Yong > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FLINK-6494) Migrate ResourceManager configuration options
[ https://issues.apache.org/jira/browse/FLINK-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022231#comment-16022231 ] Fang Yong commented on FLINK-6494: -- If so, I think another two subtasks should be created to migrate configuration options of yarn and mesos. I find YarnConfigOptions has alread exist, and MesosConfigOptions should be created also, what do you think of this? > Migrate ResourceManager configuration options > - > > Key: FLINK-6494 > URL: https://issues.apache.org/jira/browse/FLINK-6494 > Project: Flink > Issue Type: Sub-task > Components: Distributed Coordination, ResourceManager >Reporter: Chesnay Schepler >Assignee: Fang Yong > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FLINK-6494) Migrate ResourceManager configuration options
[ https://issues.apache.org/jira/browse/FLINK-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020758#comment-16020758 ] Chesnay Schepler commented on FLINK-6494: - no. > Migrate ResourceManager configuration options > - > > Key: FLINK-6494 > URL: https://issues.apache.org/jira/browse/FLINK-6494 > Project: Flink > Issue Type: Sub-task > Components: Distributed Coordination, ResourceManager >Reporter: Chesnay Schepler >Assignee: Fang Yong > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FLINK-6494) Migrate ResourceManager configuration options
[ https://issues.apache.org/jira/browse/FLINK-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020675#comment-16020675 ] Fang Yong commented on FLINK-6494: -- Should configurations of yarn and mesos be moved to ResourceManagerOptions? [~Zentol] > Migrate ResourceManager configuration options > - > > Key: FLINK-6494 > URL: https://issues.apache.org/jira/browse/FLINK-6494 > Project: Flink > Issue Type: Sub-task > Components: Distributed Coordination, ResourceManager >Reporter: Chesnay Schepler > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
