[jira] [Commented] (FLINK-7194) Add getResultType and getAccumulatorType to AggregateFunction

2017-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097252#comment-16097252 ] ASF GitHub Bot commented on FLINK-7194: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-7194) Add getResultType and getAccumulatorType to AggregateFunction

2017-07-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096958#comment-16096958 ] ASF GitHub Bot commented on FLINK-7194: --- Github user sunjincheng121 commented on the issue:

[jira] [Commented] (FLINK-7194) Add getResultType and getAccumulatorType to AggregateFunction

2017-07-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096385#comment-16096385 ] ASF GitHub Bot commented on FLINK-7194: --- Github user wuchong commented on the issue:

[jira] [Commented] (FLINK-7194) Add getResultType and getAccumulatorType to AggregateFunction

2017-07-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096322#comment-16096322 ] ASF GitHub Bot commented on FLINK-7194: --- Github user sunjincheng121 commented on the issue:

[jira] [Commented] (FLINK-7194) Add getResultType and getAccumulatorType to AggregateFunction

2017-07-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096299#comment-16096299 ] ASF GitHub Bot commented on FLINK-7194: --- Github user sunjincheng121 commented on a diff in the pull

[jira] [Commented] (FLINK-7194) Add getResultType and getAccumulatorType to AggregateFunction

2017-07-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096168#comment-16096168 ] ASF GitHub Bot commented on FLINK-7194: --- Github user fhueske commented on the issue:

[jira] [Commented] (FLINK-7194) Add getResultType and getAccumulatorType to AggregateFunction

2017-07-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096165#comment-16096165 ] ASF GitHub Bot commented on FLINK-7194: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7194) Add getResultType and getAccumulatorType to AggregateFunction

2017-07-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096086#comment-16096086 ] ASF GitHub Bot commented on FLINK-7194: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7194) Add getResultType and getAccumulatorType to AggregateFunction

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095610#comment-16095610 ] ASF GitHub Bot commented on FLINK-7194: --- Github user sunjincheng121 commented on a diff in the pull

[jira] [Commented] (FLINK-7194) Add getResultType and getAccumulatorType to AggregateFunction

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095608#comment-16095608 ] ASF GitHub Bot commented on FLINK-7194: --- Github user sunjincheng121 commented on a diff in the pull

[jira] [Commented] (FLINK-7194) Add getResultType and getAccumulatorType to AggregateFunction

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095605#comment-16095605 ] ASF GitHub Bot commented on FLINK-7194: --- Github user sunjincheng121 commented on a diff in the pull

[jira] [Commented] (FLINK-7194) Add getResultType and getAccumulatorType to AggregateFunction

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095607#comment-16095607 ] ASF GitHub Bot commented on FLINK-7194: --- Github user sunjincheng121 commented on a diff in the pull

[jira] [Commented] (FLINK-7194) Add getResultType and getAccumulatorType to AggregateFunction

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095606#comment-16095606 ] ASF GitHub Bot commented on FLINK-7194: --- Github user sunjincheng121 commented on a diff in the pull

[jira] [Commented] (FLINK-7194) Add getResultType and getAccumulatorType to AggregateFunction

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095609#comment-16095609 ] ASF GitHub Bot commented on FLINK-7194: --- Github user sunjincheng121 commented on a diff in the pull

[jira] [Commented] (FLINK-7194) Add getResultType and getAccumulatorType to AggregateFunction

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094838#comment-16094838 ] ASF GitHub Bot commented on FLINK-7194: --- GitHub user fhueske opened a pull request:

[jira] [Commented] (FLINK-7194) Add getResultType and getAccumulatorType to AggregateFunction

2017-07-19 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094064#comment-16094064 ] Jark Wu commented on FLINK-7194: +1 to do that > Add getResultType and getAccumulatorType to

[jira] [Commented] (FLINK-7194) Add getResultType and getAccumulatorType to AggregateFunction

2017-07-19 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092983#comment-16092983 ] Shaoxuan Wang commented on FLINK-7194: -- [~fhueske], I am ok with your proposal for the changes to the

[jira] [Commented] (FLINK-7194) Add getResultType and getAccumulatorType to AggregateFunction

2017-07-19 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092798#comment-16092798 ] Fabian Hueske commented on FLINK-7194: -- You are of course right [~jark]. Unless there are any

[jira] [Commented] (FLINK-7194) Add getResultType and getAccumulatorType to AggregateFunction

2017-07-18 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092476#comment-16092476 ] Jark Wu commented on FLINK-7194: [~fhueske], even if we change {{ScalarFunction.getResultType()}} to

[jira] [Commented] (FLINK-7194) Add getResultType and getAccumulatorType to AggregateFunction

2017-07-18 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16091327#comment-16091327 ] Fabian Hueske commented on FLINK-7194: -- Oh I see what you mean. Thanks [~RuidongLi]. I would treat

[jira] [Commented] (FLINK-7194) Add getResultType and getAccumulatorType to AggregateFunction

2017-07-17 Thread Ruidong Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16091036#comment-16091036 ] Ruidong Li commented on FLINK-7194: --- {{ScalarFunction.getResultType()}} has parameters while

[jira] [Commented] (FLINK-7194) Add getResultType and getAccumulatorType to AggregateFunction

2017-07-17 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089732#comment-16089732 ] Fabian Hueske commented on FLINK-7194: -- In what sense is {{ScalarFunction.getResultType()}} different

[jira] [Commented] (FLINK-7194) Add getResultType and getAccumulatorType to AggregateFunction

2017-07-17 Thread Ruidong Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089419#comment-16089419 ] Ruidong Li commented on FLINK-7194: --- [~fhueske]I agree to your suggestion, but the {{getResultType()}}