[jira] [Commented] (FLINK-7450) Bounded generic POJO field is identified as Object by TypeExtractor

[Flink Jira Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/FLINK-7450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17334232#comment-17334232
 ] 

Flink Jira Bot commented on FLINK-7450:
---

This issue was marked "stale-assigned" and has not received an update in 7 
days. It is now automatically unassigned. If you are still working on it, you 
can assign it to yourself again. Please also give an update about the status of 
the work.

> Bounded generic POJO field is identified as Object by TypeExtractor
> ---
>
> Key: FLINK-7450
> URL: https://issues.apache.org/jira/browse/FLINK-7450
> Project: Flink
>  Issue Type: Bug
>  Components: API / Type Serialization System
>Affects Versions: 1.3.2, 1.4.0
>Reporter: Timo Walther
>Assignee: Timo Walther
>Priority: Major
>  Labels: pull-request-available, stale-assigned
>
> The TypeExtractor does not correctly handle POJO fields with bounded generics.
> For example:
> {code}
> public class Foo implements Serializable {
> public SomeKey someKey;
> public Foo() {}
> public Foo(SomeKey someKey) {
> this.someKey = someKey;
> }
> }
> {code}
> Is identified as:
> {code}
> PojoType = [someKey: GenericType]>
> {code}
> So even though the reflection field has a type, the type information only 
> describes a Object class.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (FLINK-7450) Bounded generic POJO field is identified as Object by TypeExtractor

[Flink Jira Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/FLINK-7450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17323614#comment-17323614
 ] 

Flink Jira Bot commented on FLINK-7450:
---

This issue is assigned but has not received an update in 7 days so it has been 
labeled "stale-assigned". If you are still working on the issue, please give an 
update and remove the label. If you are no longer working on the issue, please 
unassign so someone else may work on it. In 7 days the issue will be 
automatically unassigned.

> Bounded generic POJO field is identified as Object by TypeExtractor
> ---
>
> Key: FLINK-7450
> URL: https://issues.apache.org/jira/browse/FLINK-7450
> Project: Flink
>  Issue Type: Bug
>  Components: API / Type Serialization System
>Affects Versions: 1.3.2, 1.4.0
>Reporter: Timo Walther
>Assignee: Timo Walther
>Priority: Major
>  Labels: pull-request-available, stale-assigned
>
> The TypeExtractor does not correctly handle POJO fields with bounded generics.
> For example:
> {code}
> public class Foo implements Serializable {
> public SomeKey someKey;
> public Foo() {}
> public Foo(SomeKey someKey) {
> this.someKey = someKey;
> }
> }
> {code}
> Is identified as:
> {code}
> PojoType = [someKey: GenericType]>
> {code}
> So even though the reflection field has a type, the type information only 
> describes a Object class.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (FLINK-7450) Bounded generic POJO field is identified as Object by TypeExtractor

[Timo Walther (Jira)]

[ 
https://issues.apache.org/jira/browse/FLINK-7450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277010#comment-17277010
 ] 

Timo Walther commented on FLINK-7450:
-

I have closed the PR for now because we still don't have a strategy how to deal 
with TypeExtractor changes and state backwards compatibility.

> Bounded generic POJO field is identified as Object by TypeExtractor
> ---
>
> Key: FLINK-7450
> URL: https://issues.apache.org/jira/browse/FLINK-7450
> Project: Flink
>  Issue Type: Bug
>  Components: API / Type Serialization System
>Affects Versions: 1.3.2, 1.4.0
>Reporter: Timo Walther
>Assignee: Timo Walther
>Priority: Major
>  Labels: pull-request-available
>
> The TypeExtractor does not correctly handle POJO fields with bounded generics.
> For example:
> {code}
> public class Foo implements Serializable {
> public SomeKey someKey;
> public Foo() {}
> public Foo(SomeKey someKey) {
> this.someKey = someKey;
> }
> }
> {code}
> Is identified as:
> {code}
> PojoType = [someKey: GenericType]>
> {code}
> So even though the reflection field has a type, the type information only 
> describes a Object class.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (FLINK-7450) Bounded generic POJO field is identified as Object by TypeExtractor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479147#comment-16479147
 ] 

ASF GitHub Bot commented on FLINK-7450:
---

GitHub user twalthr opened a pull request:

https://github.com/apache/flink/pull/6034

[FLINK-7450] [types] Fix type extraction of bounded generic POJO fields

## What is the purpose of the change

This PR fixes the type extraction of POJO fields with bounded generics. 
Before those fields were treated as unknown fields with `Object` type in Kryo. 
This PR breaks backwards compatibility for jobs with such special cases. We 
need to discuss if we want to do that.

## Brief change log

- Use generic bounds of type variables during POJO extraction


## Verifying this change

- Two unit tests have been added

## Does this pull request potentially affect one of the following parts:

  - Dependencies (does it add or upgrade a dependency): no
  - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
  - The serializers: yes
  - The runtime per-record code paths (performance sensitive): no
  - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: no
  - The S3 file system connector: no

## Documentation

  - Does this pull request introduce a new feature? no
  - If yes, how is the feature documented? JavaDocs


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/twalthr/flink FLINK-7450

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/6034.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #6034


commit d94eda3b85273603e92ce41ec269494be512758d
Author: Timo Walther 
Date:   2018-05-17T14:12:54Z

[FLINK-7450] [types] Fix type extraction of bounded generic POJO fields




> Bounded generic POJO field is identified as Object by TypeExtractor
> ---
>
> Key: FLINK-7450
> URL: https://issues.apache.org/jira/browse/FLINK-7450
> Project: Flink
>  Issue Type: Bug
>  Components: Type Serialization System
>Affects Versions: 1.4.0, 1.3.2
>Reporter: Timo Walther
>Assignee: Timo Walther
>Priority: Major
>
> The TypeExtractor does not correctly handle POJO fields with bounded generics.
> For example:
> {code}
> public class Foo implements Serializable {
> public SomeKey someKey;
> public Foo() {}
> public Foo(SomeKey someKey) {
> this.someKey = someKey;
> }
> }
> {code}
> Is identified as:
> {code}
> PojoType = [someKey: GenericType]>
> {code}
> So even though the reflection field has a type, the type information only 
> describes a Object class.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)