[jira] [Commented] (FLINK-7658) Support COLLECT Aggregate function in Flink TABLE API

2018-02-14 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/FLINK-7658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364641#comment-16364641
 ] 

ASF GitHub Bot commented on FLINK-7658:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/5472


> Support COLLECT Aggregate function in Flink TABLE API
> -
>
> Key: FLINK-7658
> URL: https://issues.apache.org/jira/browse/FLINK-7658
> Project: Flink
>  Issue Type: New Feature
>  Components: Table API  SQL
>Reporter: Shuyi Chen
>Assignee: Shuyi Chen
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (FLINK-7658) Support COLLECT Aggregate function in Flink TABLE API

2018-02-14 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/FLINK-7658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364117#comment-16364117
 ] 

ASF GitHub Bot commented on FLINK-7658:
---

Github user fhueske commented on the issue:

https://github.com/apache/flink/pull/5472
  
We also have to add the function to `FunctionCatalog` to be able to parse 
it in the String-based Java Table API.


> Support COLLECT Aggregate function in Flink TABLE API
> -
>
> Key: FLINK-7658
> URL: https://issues.apache.org/jira/browse/FLINK-7658
> Project: Flink
>  Issue Type: New Feature
>  Components: Table API  SQL
>Reporter: Shuyi Chen
>Assignee: Shuyi Chen
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (FLINK-7658) Support COLLECT Aggregate function in Flink TABLE API

2018-02-14 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/FLINK-7658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364086#comment-16364086
 ] 

ASF GitHub Bot commented on FLINK-7658:
---

Github user fhueske commented on a diff in the pull request:

https://github.com/apache/flink/pull/5472#discussion_r168183721
  
--- Diff: docs/dev/table/tableApi.md ---
@@ -2885,6 +2885,17 @@ FIELD.varSamp
   
 
 
+
+  
+{% highlight java %}
--- End diff --

We need to add the function as well in the Scala function table.


> Support COLLECT Aggregate function in Flink TABLE API
> -
>
> Key: FLINK-7658
> URL: https://issues.apache.org/jira/browse/FLINK-7658
> Project: Flink
>  Issue Type: New Feature
>  Components: Table API  SQL
>Reporter: Shuyi Chen
>Assignee: Shuyi Chen
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (FLINK-7658) Support COLLECT Aggregate function in Flink TABLE API

2018-02-13 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/FLINK-7658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362035#comment-16362035
 ] 

ASF GitHub Bot commented on FLINK-7658:
---

GitHub user suez1224 opened a pull request:

https://github.com/apache/flink/pull/5472

[FLINK-7658][Table API & SQL] support Collect aggregate function in Table 
API

## What is the purpose of the change

Add Collect aggregate function for Table API.


## Brief change log

  - Add Collect aggregate function for Table API


## Verifying this change
  - Added integration tests 

## Does this pull request potentially affect one of the following parts:

  - Dependencies (does it add or upgrade a dependency): ( no)
  - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: ( no)
  - The serializers: ( no)
  - The runtime per-record code paths (performance sensitive): (no )
  - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: ( no )
  - The S3 file system connector: (no)

## Documentation

  - Does this pull request introduce a new feature? (yes)
  - If yes, how is the feature documented? (docs)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/suez1224/flink FLINK-7658

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/5472.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #5472


commit da26176105a7ee3634d9db2834bacf17003c3823
Author: Shuyi Chen 
Date:   2018-02-13T09:18:12Z

support Collect aggregate function in Table API




> Support COLLECT Aggregate function in Flink TABLE API
> -
>
> Key: FLINK-7658
> URL: https://issues.apache.org/jira/browse/FLINK-7658
> Project: Flink
>  Issue Type: New Feature
>  Components: Table API  SQL
>Reporter: Shuyi Chen
>Assignee: Shuyi Chen
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)