[jira] [Commented] (FLINK-7660) Support sideOutput in ProcessAllWindowFunction

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202829#comment-16202829
 ] 

ASF GitHub Bot commented on FLINK-7660:
---

Github user bowenli86 commented on the issue:

https://github.com/apache/flink/pull/4740
  
@aljoscha  Thank you!


> Support sideOutput in ProcessAllWindowFunction
> --
>
> Key: FLINK-7660
> URL: https://issues.apache.org/jira/browse/FLINK-7660
> Project: Flink
>  Issue Type: Improvement
>  Components: DataStream API, Scala API
>Reporter: Bowen Li
>Assignee: Bowen Li
> Fix For: 1.4.0
>
>
> Add side output support to ProcessAllWindow functions.
> This is a sibling ticket for FLINK-7635



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7660) Support sideOutput in ProcessAllWindowFunction

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202830#comment-16202830
 ] 

ASF GitHub Bot commented on FLINK-7660:
---

Github user bowenli86 closed the pull request at:

https://github.com/apache/flink/pull/4740


> Support sideOutput in ProcessAllWindowFunction
> --
>
> Key: FLINK-7660
> URL: https://issues.apache.org/jira/browse/FLINK-7660
> Project: Flink
>  Issue Type: Improvement
>  Components: DataStream API, Scala API
>Reporter: Bowen Li
>Assignee: Bowen Li
> Fix For: 1.4.0
>
>
> Add side output support to ProcessAllWindow functions.
> This is a sibling ticket for FLINK-7635



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7660) Support sideOutput in ProcessAllWindowFunction

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16201675#comment-16201675
 ] 

ASF GitHub Bot commented on FLINK-7660:
---

Github user aljoscha commented on the issue:

https://github.com/apache/flink/pull/4740
  
Thanks a lot for working on this, @bowenli86!  

I merged, could you please close the PR?


> Support sideOutput in ProcessAllWindowFunction
> --
>
> Key: FLINK-7660
> URL: https://issues.apache.org/jira/browse/FLINK-7660
> Project: Flink
>  Issue Type: Improvement
>  Components: DataStream API, Scala API
>Reporter: Bowen Li
>Assignee: Bowen Li
> Fix For: 1.4.0
>
>
> Add side output support to ProcessAllWindow functions.
> This is a sibling ticket for FLINK-7635



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7660) Support sideOutput in ProcessAllWindowFunction

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196339#comment-16196339
 ] 

ASF GitHub Bot commented on FLINK-7660:
---

Github user bowenli86 commented on the issue:

https://github.com/apache/flink/pull/4740
  
@aljoscha @chenqin  Hi guys, can you please take a look?


> Support sideOutput in ProcessAllWindowFunction
> --
>
> Key: FLINK-7660
> URL: https://issues.apache.org/jira/browse/FLINK-7660
> Project: Flink
>  Issue Type: Improvement
>  Components: DataStream API, Scala API
>Reporter: Bowen Li
>Assignee: Bowen Li
> Fix For: 1.4.0
>
>
> Add side output support to ProcessAllWindow functions.
> This is a sibling ticket for FLINK-7635



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7660) Support sideOutput in ProcessAllWindowFunction

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185454#comment-16185454
 ] 

ASF GitHub Bot commented on FLINK-7660:
---

Github user bowenli86 commented on the issue:

https://github.com/apache/flink/pull/4740
  
cc @aljoscha @chenqin 


> Support sideOutput in ProcessAllWindowFunction
> --
>
> Key: FLINK-7660
> URL: https://issues.apache.org/jira/browse/FLINK-7660
> Project: Flink
>  Issue Type: Improvement
>  Components: DataStream API, Scala API
>Reporter: Bowen Li
>Assignee: Bowen Li
> Fix For: 1.4.0
>
>
> Add side output support to ProcessAllWindow functions.
> This is a sibling ticket for FLINK-7635



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7660) Support sideOutput in ProcessAllWindowFunction

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16183719#comment-16183719
 ] 

ASF GitHub Bot commented on FLINK-7660:
---

GitHub user bowenli86 opened a pull request:

https://github.com/apache/flink/pull/4740

[FLINK-7660][DataStream API/Scala API] Support sideOutput in 
ProcessAllWindowFunction

## What is the purpose of the change

Support sideOutput in ProcessAllWindowFunction

## Brief change log

changed both java and scala APIs

## Verifying this change

This change added tests and can be verified as follows:

- `testProcessdWindowFunctionSideOutput()` in `SideOutputITCase.java`
- `testProcessWindowFunctionSideOutput()` in `SideOutputITCase.scala`
 
## Does this pull request potentially affect one of the following parts:

  - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes)

## Documentation

  - Does this pull request introduce a new feature? (yes)
  - If yes, how is the feature documented? (docs / JavaDocs)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bowenli86/flink FLINK-7660

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/4740.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4740


commit c5716edb64ed7f7ff6dda7bf48b2f90e9a80cd07
Author: Bowen Li 
Date:   2017-09-28T06:09:20Z

[FLINK-7660] Support sideOutput in ProcessAllWindowFunction




> Support sideOutput in ProcessAllWindowFunction
> --
>
> Key: FLINK-7660
> URL: https://issues.apache.org/jira/browse/FLINK-7660
> Project: Flink
>  Issue Type: Improvement
>  Components: DataStream API, Scala API
>Reporter: Bowen Li
>Assignee: Bowen Li
> Fix For: 1.4.0
>
>
> Add side output support to ProcessAllWindow functions.
> This is a sibling ticket for FLINK-7635



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)