[jira] [Commented] (FLINK-8472) Extend migration tests for Flink 1.4
[
https://issues.apache.org/jira/browse/FLINK-8472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354386#comment-16354386
]
Tzu-Li (Gordon) Tai commented on FLINK-8472:
Merged.
1.5 - 130ca4ec3895825022c2a05c0022684ab8c1a3bf
1.4 - f68fe3ee652820ea29653c17c7515bd466389ce9
> Extend migration tests for Flink 1.4
>
>
> Key: FLINK-8472
> URL: https://issues.apache.org/jira/browse/FLINK-8472
> Project: Flink
> Issue Type: Test
> Components: Tests
>Reporter: Tzu-Li (Gordon) Tai
>Assignee: Tzu-Li (Gordon) Tai
>Priority: Blocker
> Fix For: 1.5.0, 1.4.1
>
>
> The following migration tests should be extended to cover migrating Flink
> jobs with a 1.4 savepoint.
> * {{WindowOperatorMigrationTest}}
> * {{CEPMigrationTest}}
> * {{StatefulJobSavepointMigrationTestITCase}}
> * {{FlinkKinesisConsumerMigrationTest}}
> * {{FlinkKafkaConsumerBaseMigrationTest}}
> * {{ContinuousFileProcessingMigrationTest}}
> * {{BucketingSinkMigrationTest}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8472) Extend migration tests for Flink 1.4
[
https://issues.apache.org/jira/browse/FLINK-8472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354361#comment-16354361
]
ASF GitHub Bot commented on FLINK-8472:
---
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5364
> Extend migration tests for Flink 1.4
>
>
> Key: FLINK-8472
> URL: https://issues.apache.org/jira/browse/FLINK-8472
> Project: Flink
> Issue Type: Test
> Components: Tests
>Reporter: Tzu-Li (Gordon) Tai
>Assignee: Tzu-Li (Gordon) Tai
>Priority: Blocker
> Fix For: 1.5.0, 1.4.1
>
>
> The following migration tests should be extended to cover migrating Flink
> jobs with a 1.4 savepoint.
> * {{WindowOperatorMigrationTest}}
> * {{CEPMigrationTest}}
> * {{StatefulJobSavepointMigrationTestITCase}}
> * {{FlinkKinesisConsumerMigrationTest}}
> * {{FlinkKafkaConsumerBaseMigrationTest}}
> * {{ContinuousFileProcessingMigrationTest}}
> * {{BucketingSinkMigrationTest}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8472) Extend migration tests for Flink 1.4
[
https://issues.apache.org/jira/browse/FLINK-8472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350146#comment-16350146
]
ASF GitHub Bot commented on FLINK-8472:
---
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/5364
Thanks for the reviews, I'll address Chesnay's comment and the merge this
then (to `master` and `release-1.4`).
> Extend migration tests for Flink 1.4
>
>
> Key: FLINK-8472
> URL: https://issues.apache.org/jira/browse/FLINK-8472
> Project: Flink
> Issue Type: Test
> Components: Tests
>Reporter: Tzu-Li (Gordon) Tai
>Assignee: Tzu-Li (Gordon) Tai
>Priority: Blocker
> Fix For: 1.5.0, 1.4.1
>
>
> The following migration tests should be extended to cover migrating Flink
> jobs with a 1.4 savepoint.
> * {{WindowOperatorMigrationTest}}
> * {{CEPMigrationTest}}
> * {{StatefulJobSavepointMigrationTestITCase}}
> * {{FlinkKinesisConsumerMigrationTest}}
> * {{FlinkKafkaConsumerBaseMigrationTest}}
> * {{ContinuousFileProcessingMigrationTest}}
> * {{BucketingSinkMigrationTest}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8472) Extend migration tests for Flink 1.4
[
https://issues.apache.org/jira/browse/FLINK-8472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349131#comment-16349131
]
ASF GitHub Bot commented on FLINK-8472:
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5364#discussion_r165459894
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/state/operator/restore/keyed/KeyedJob.java
---
@@ -100,9 +100,7 @@ public static void main(String[] args) throws Exception
{
.map(new StatefulStringStoringMap(mode, "first"))
.setParallelism(4);
- if (mode == ExecutionMode.MIGRATE || mode ==
ExecutionMode.RESTORE) {
--- End diff --
yeah it should be alright to remove that, but let's chain the uid call to
the operator creation as we do for the others for style points.
> Extend migration tests for Flink 1.4
>
>
> Key: FLINK-8472
> URL: https://issues.apache.org/jira/browse/FLINK-8472
> Project: Flink
> Issue Type: Test
> Components: Tests
>Reporter: Tzu-Li (Gordon) Tai
>Assignee: Tzu-Li (Gordon) Tai
>Priority: Blocker
> Fix For: 1.5.0, 1.4.1
>
>
> The following migration tests should be extended to cover migrating Flink
> jobs with a 1.4 savepoint.
> * {{WindowOperatorMigrationTest}}
> * {{CEPMigrationTest}}
> * {{StatefulJobSavepointMigrationTestITCase}}
> * {{FlinkKinesisConsumerMigrationTest}}
> * {{FlinkKafkaConsumerBaseMigrationTest}}
> * {{ContinuousFileProcessingMigrationTest}}
> * {{BucketingSinkMigrationTest}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8472) Extend migration tests for Flink 1.4
[
https://issues.apache.org/jira/browse/FLINK-8472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348831#comment-16348831
]
ASF GitHub Bot commented on FLINK-8472:
---
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/5364
Looks good but let's wait what @zentol has to say.
> Extend migration tests for Flink 1.4
>
>
> Key: FLINK-8472
> URL: https://issues.apache.org/jira/browse/FLINK-8472
> Project: Flink
> Issue Type: Test
> Components: Tests
>Reporter: Tzu-Li (Gordon) Tai
>Assignee: Tzu-Li (Gordon) Tai
>Priority: Blocker
> Fix For: 1.5.0, 1.4.1
>
>
> The following migration tests should be extended to cover migrating Flink
> jobs with a 1.4 savepoint.
> * {{WindowOperatorMigrationTest}}
> * {{CEPMigrationTest}}
> * {{StatefulJobSavepointMigrationTestITCase}}
> * {{FlinkKinesisConsumerMigrationTest}}
> * {{FlinkKafkaConsumerBaseMigrationTest}}
> * {{ContinuousFileProcessingMigrationTest}}
> * {{BucketingSinkMigrationTest}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8472) Extend migration tests for Flink 1.4
[
https://issues.apache.org/jira/browse/FLINK-8472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348713#comment-16348713
]
ASF GitHub Bot commented on FLINK-8472:
---
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/5364#discussion_r165385564
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/state/operator/restore/keyed/KeyedJob.java
---
@@ -100,9 +100,7 @@ public static void main(String[] args) throws Exception
{
.map(new StatefulStringStoringMap(mode, "first"))
.setParallelism(4);
- if (mode == ExecutionMode.MIGRATE || mode ==
ExecutionMode.RESTORE) {
--- End diff --
@zentol can you confirm whether these changes make sense?
From the discussions I see in https://github.com/apache/flink/pull/3844, I
assume this was a leftover to write a 1.2 savepoint (when uids couldn't be
added for each chained operator separately). So it should be ok to remove this?
> Extend migration tests for Flink 1.4
>
>
> Key: FLINK-8472
> URL: https://issues.apache.org/jira/browse/FLINK-8472
> Project: Flink
> Issue Type: Test
> Components: Tests
>Reporter: Tzu-Li (Gordon) Tai
>Assignee: Tzu-Li (Gordon) Tai
>Priority: Blocker
> Fix For: 1.5.0, 1.4.1
>
>
> The following migration tests should be extended to cover migrating Flink
> jobs with a 1.4 savepoint.
> * {{WindowOperatorMigrationTest}}
> * {{CEPMigrationTest}}
> * {{StatefulJobSavepointMigrationTestITCase}}
> * {{FlinkKinesisConsumerMigrationTest}}
> * {{FlinkKafkaConsumerBaseMigrationTest}}
> * {{ContinuousFileProcessingMigrationTest}}
> * {{BucketingSinkMigrationTest}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8472) Extend migration tests for Flink 1.4
[
https://issues.apache.org/jira/browse/FLINK-8472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348707#comment-16348707
]
ASF GitHub Bot commented on FLINK-8472:
---
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/5364
@aljoscha @zentol
could you have another quick look at commit 8882fb7? That commit extends
`KeyedComplexChainTest`, `ChainBreakTest`, `ChainLengthIncreaseTest`, ... etc.
also for 1.4.
Once that is good, I'll merge this to `master` and `release-1.4`.
> Extend migration tests for Flink 1.4
>
>
> Key: FLINK-8472
> URL: https://issues.apache.org/jira/browse/FLINK-8472
> Project: Flink
> Issue Type: Test
> Components: Tests
>Reporter: Tzu-Li (Gordon) Tai
>Assignee: Tzu-Li (Gordon) Tai
>Priority: Blocker
> Fix For: 1.5.0, 1.4.1
>
>
> The following migration tests should be extended to cover migrating Flink
> jobs with a 1.4 savepoint.
> * {{WindowOperatorMigrationTest}}
> * {{CEPMigrationTest}}
> * {{StatefulJobSavepointMigrationTestITCase}}
> * {{FlinkKinesisConsumerMigrationTest}}
> * {{FlinkKafkaConsumerBaseMigrationTest}}
> * {{ContinuousFileProcessingMigrationTest}}
> * {{BucketingSinkMigrationTest}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8472) Extend migration tests for Flink 1.4
[
https://issues.apache.org/jira/browse/FLINK-8472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344842#comment-16344842
]
ASF GitHub Bot commented on FLINK-8472:
---
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/5364
The changes look straightforward and good!
Plus, they help me sleep better...
> Extend migration tests for Flink 1.4
>
>
> Key: FLINK-8472
> URL: https://issues.apache.org/jira/browse/FLINK-8472
> Project: Flink
> Issue Type: Test
> Components: Tests
>Reporter: Tzu-Li (Gordon) Tai
>Assignee: Tzu-Li (Gordon) Tai
>Priority: Blocker
> Fix For: 1.5.0, 1.4.1
>
>
> The following migration tests should be extended to cover migrating Flink
> jobs with a 1.4 savepoint.
> * {{WindowOperatorMigrationTest}}
> * {{CEPMigrationTest}}
> * {{StatefulJobSavepointMigrationTestITCase}}
> * {{FlinkKinesisConsumerMigrationTest}}
> * {{FlinkKafkaConsumerBaseMigrationTest}}
> * {{ContinuousFileProcessingMigrationTest}}
> * {{BucketingSinkMigrationTest}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8472) Extend migration tests for Flink 1.4
[
https://issues.apache.org/jira/browse/FLINK-8472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343492#comment-16343492
]
ASF GitHub Bot commented on FLINK-8472:
---
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/5364
It seems like we'll also need to extend these migration tests for 1.4:
- All subclasses of `AbstractKeyedOperatorRestoreTestBase`
- All subclasses of `AbstractNonKeyedOperatorRestoreTestBase`
> Extend migration tests for Flink 1.4
>
>
> Key: FLINK-8472
> URL: https://issues.apache.org/jira/browse/FLINK-8472
> Project: Flink
> Issue Type: Test
> Components: Tests
>Reporter: Tzu-Li (Gordon) Tai
>Assignee: Tzu-Li (Gordon) Tai
>Priority: Blocker
> Fix For: 1.5.0, 1.4.1
>
>
> The following migration tests should be extended to cover migrating Flink
> jobs with a 1.4 savepoint.
> * {{WindowOperatorMigrationTest}}
> * {{CEPMigrationTest}}
> * {{StatefulJobSavepointMigrationTestITCase}}
> * {{FlinkKinesisConsumerMigrationTest}}
> * {{FlinkKafkaConsumerBaseMigrationTest}}
> * {{ContinuousFileProcessingMigrationTest}}
> * {{BucketingSinkMigrationTest}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
