[jira] [Commented] (FLINK-8644) Shut down AkkaRpcActors with PoisonPill

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-8644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365369#comment-16365369
 ] 

ASF GitHub Bot commented on FLINK-8644:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/5476


> Shut down AkkaRpcActors with PoisonPill
> ---
>
> Key: FLINK-8644
> URL: https://issues.apache.org/jira/browse/FLINK-8644
> Project: Flink
>  Issue Type: Sub-task
>  Components: Distributed Coordination
>Affects Versions: 1.5.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Major
>  Labels: flip-6
> Fix For: 1.5.0
>
>
> In order to ensure that all messages get processed before shutting down an 
> {{AkkaRpcActor}} we should stop it by sending a {{PoisonPill}}. Otherwise we 
> risk that we have some dangling futures which will time out.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-8644) Shut down AkkaRpcActors with PoisonPill

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-8644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364391#comment-16364391
 ] 

ASF GitHub Bot commented on FLINK-8644:
---

Github user tillrohrmann commented on the issue:

https://github.com/apache/flink/pull/5476
  
Merging this PR.


> Shut down AkkaRpcActors with PoisonPill
> ---
>
> Key: FLINK-8644
> URL: https://issues.apache.org/jira/browse/FLINK-8644
> Project: Flink
>  Issue Type: Sub-task
>  Components: Distributed Coordination
>Affects Versions: 1.5.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Major
>  Labels: flip-6
> Fix For: 1.5.0
>
>
> In order to ensure that all messages get processed before shutting down an 
> {{AkkaRpcActor}} we should stop it by sending a {{PoisonPill}}. Otherwise we 
> risk that we have some dangling futures which will time out.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-8644) Shut down AkkaRpcActors with PoisonPill

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-8644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362322#comment-16362322
 ] 

ASF GitHub Bot commented on FLINK-8644:
---

GitHub user tillrohrmann opened a pull request:

https://github.com/apache/flink/pull/5476

[FLINK-8644] [flip6] Shut down AkkaRpcActors with PoisonPill

## What is the purpose of the change

Shutting AkkaRpcActors down with Kill can result in uncompleted futures, if
the mailbox contains requests which will be dropped. Therefore, it is better
to stop AkkaRpcActors with a PoisonPill which assures that all messages 
before
the pill will be processed.

## Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

## Does this pull request potentially affect one of the following parts:

  - Dependencies (does it add or upgrade a dependency): (no)
  - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
  - The serializers: (no)
  - The runtime per-record code paths (performance sensitive): (no)
  - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
  - The S3 file system connector: (no)

## Documentation

  - Does this pull request introduce a new feature? (no)
  - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tillrohrmann/flink 
shutDownRpcEndpointWithPoisonPill

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/5476.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #5476


commit 2224098c3d66ac22074be1f1a2562695b6734298
Author: Till Rohrmann 
Date:   2018-02-13T13:27:31Z

[FLINK-8644] [flip6] Shut down AkkaRpcActors with PoisonPill

Shutting AkkaRpcActors down with Kill can result in uncompleted futures, if
the mailbox contains requests which will be dropped. Therefore, it is better
to stop AkkaRpcActors with a PoisonPill which assures that all messages 
before
the pill will be processed.




> Shut down AkkaRpcActors with PoisonPill
> ---
>
> Key: FLINK-8644
> URL: https://issues.apache.org/jira/browse/FLINK-8644
> Project: Flink
>  Issue Type: Sub-task
>  Components: Distributed Coordination
>Affects Versions: 1.5.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Major
>  Labels: flip-6
> Fix For: 1.5.0
>
>
> In order to ensure that all messages get processed before shutting down an 
> {{AkkaRpcActor}} we should stop it by sending a {{PoisonPill}}. Otherwise we 
> risk that we have some dangling futures which will time out.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)