[jira] [Commented] (FLINK-8699) Fix concurrency problem in rocksdb full checkpoint
[ https://issues.apache.org/jira/browse/FLINK-8699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428182#comment-16428182 ] ASF GitHub Bot commented on FLINK-8699: --- Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5705 > Fix concurrency problem in rocksdb full checkpoint > -- > > Key: FLINK-8699 > URL: https://issues.apache.org/jira/browse/FLINK-8699 > Project: Flink > Issue Type: Bug > Components: State Backends, Checkpointing >Affects Versions: 1.5.0 >Reporter: Sihua Zhou >Assignee: Sihua Zhou >Priority: Blocker > Fix For: 1.5.0 > > > In full checkpoint, `kvStateInformation` is not a copied object and it can be > changed when writeKVStateMetaData() is invoking ... This can lead to > problematic, which is serious. > {code} > private void writeKVStateMetaData() throws IOException { > // ... > for (Map.EntryRegisteredKeyedBackendStateMetaInfo>> column : > stateBackend.kvStateInformation.entrySet()) { > } > //... > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-8699) Fix concurrency problem in rocksdb full checkpoint
[ https://issues.apache.org/jira/browse/FLINK-8699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427022#comment-16427022 ] ASF GitHub Bot commented on FLINK-8699: --- Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/5705 Hi, @StefanRRichter thanks a lot. > Fix concurrency problem in rocksdb full checkpoint > -- > > Key: FLINK-8699 > URL: https://issues.apache.org/jira/browse/FLINK-8699 > Project: Flink > Issue Type: Bug > Components: State Backends, Checkpointing >Affects Versions: 1.5.0 >Reporter: Sihua Zhou >Assignee: Sihua Zhou >Priority: Blocker > Fix For: 1.5.0 > > > In full checkpoint, `kvStateInformation` is not a copied object and it can be > changed when writeKVStateMetaData() is invoking ... This can lead to > problematic, which is serious. > {code} > private void writeKVStateMetaData() throws IOException { > // ... > for (Map.EntryRegisteredKeyedBackendStateMetaInfo>> column : > stateBackend.kvStateInformation.entrySet()) { > } > //... > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-8699) Fix concurrency problem in rocksdb full checkpoint
[ https://issues.apache.org/jira/browse/FLINK-8699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427012#comment-16427012 ] ASF GitHub Bot commented on FLINK-8699: --- Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/5705 Thanks for the fixes. LGTM Will merge this. Sorry that this took so long. > Fix concurrency problem in rocksdb full checkpoint > -- > > Key: FLINK-8699 > URL: https://issues.apache.org/jira/browse/FLINK-8699 > Project: Flink > Issue Type: Bug > Components: State Backends, Checkpointing >Affects Versions: 1.5.0 >Reporter: Sihua Zhou >Assignee: Sihua Zhou >Priority: Blocker > Fix For: 1.5.0 > > > In full checkpoint, `kvStateInformation` is not a copied object and it can be > changed when writeKVStateMetaData() is invoking ... This can lead to > problematic, which is serious. > {code} > private void writeKVStateMetaData() throws IOException { > // ... > for (Map.EntryRegisteredKeyedBackendStateMetaInfo>> column : > stateBackend.kvStateInformation.entrySet()) { > } > //... > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-8699) Fix concurrency problem in rocksdb full checkpoint
[ https://issues.apache.org/jira/browse/FLINK-8699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417553#comment-16417553 ] ASF GitHub Bot commented on FLINK-8699: --- Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/5705 Hi @tillrohrmann thanks for your reply, and god bless Stefan, hope he will get well soon... > Fix concurrency problem in rocksdb full checkpoint > -- > > Key: FLINK-8699 > URL: https://issues.apache.org/jira/browse/FLINK-8699 > Project: Flink > Issue Type: Bug > Components: State Backends, Checkpointing >Affects Versions: 1.5.0 >Reporter: Sihua Zhou >Assignee: Sihua Zhou >Priority: Blocker > Fix For: 1.5.0 > > > In full checkpoint, `kvStateInformation` is not a copied object and it can be > changed when writeKVStateMetaData() is invoking ... This can lead to > problematic, which is serious. > {code} > private void writeKVStateMetaData() throws IOException { > // ... > for (Map.EntryRegisteredKeyedBackendStateMetaInfo>> column : > stateBackend.kvStateInformation.entrySet()) { > } > //... > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-8699) Fix concurrency problem in rocksdb full checkpoint
[ https://issues.apache.org/jira/browse/FLINK-8699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417522#comment-16417522 ] ASF GitHub Bot commented on FLINK-8699: --- Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5705 Hi @sihuazhou, Stefan is currently sick but he should come back in a bit. Since he already reviewed parts of the PR, I would suggest to wait for his return. If he should not be back by next week, I'll take over. > Fix concurrency problem in rocksdb full checkpoint > -- > > Key: FLINK-8699 > URL: https://issues.apache.org/jira/browse/FLINK-8699 > Project: Flink > Issue Type: Bug > Components: State Backends, Checkpointing >Affects Versions: 1.5.0 >Reporter: Sihua Zhou >Assignee: Sihua Zhou >Priority: Blocker > Fix For: 1.5.0 > > > In full checkpoint, `kvStateInformation` is not a copied object and it can be > changed when writeKVStateMetaData() is invoking ... This can lead to > problematic, which is serious. > {code} > private void writeKVStateMetaData() throws IOException { > // ... > for (Map.EntryRegisteredKeyedBackendStateMetaInfo>> column : > stateBackend.kvStateInformation.entrySet()) { > } > //... > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-8699) Fix concurrency problem in rocksdb full checkpoint
[ https://issues.apache.org/jira/browse/FLINK-8699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417483#comment-16417483 ] ASF GitHub Bot commented on FLINK-8699: --- Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/5705 Could anyone have a look at this PR? > Fix concurrency problem in rocksdb full checkpoint > -- > > Key: FLINK-8699 > URL: https://issues.apache.org/jira/browse/FLINK-8699 > Project: Flink > Issue Type: Bug > Components: State Backends, Checkpointing >Affects Versions: 1.5.0 >Reporter: Sihua Zhou >Assignee: Sihua Zhou >Priority: Blocker > Fix For: 1.5.0 > > > In full checkpoint, `kvStateInformation` is not a copied object and it can be > changed when writeKVStateMetaData() is invoking ... This can lead to > problematic, which is serious. > {code} > private void writeKVStateMetaData() throws IOException { > // ... > for (Map.EntryRegisteredKeyedBackendStateMetaInfo>> column : > stateBackend.kvStateInformation.entrySet()) { > } > //... > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-8699) Fix concurrency problem in rocksdb full checkpoint
[ https://issues.apache.org/jira/browse/FLINK-8699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369087#comment-16369087 ] ASF GitHub Bot commented on FLINK-8699: --- Github user sihuazhou closed the pull request at: https://github.com/apache/flink/pull/5525 > Fix concurrency problem in rocksdb full checkpoint > -- > > Key: FLINK-8699 > URL: https://issues.apache.org/jira/browse/FLINK-8699 > Project: Flink > Issue Type: Bug > Components: State Backends, Checkpointing >Affects Versions: 1.5.0 >Reporter: Sihua Zhou >Assignee: Sihua Zhou >Priority: Blocker > Fix For: 1.5.0 > > > In full checkpoint, `kvStateInformation` is not a copied object and it can be > changed when writeKVStateMetaData() is invoking ... This can lead to > problematic, which is serious. > {code} > private void writeKVStateMetaData() throws IOException { > // ... > for (Map.EntryRegisteredKeyedBackendStateMetaInfo>> column : > stateBackend.kvStateInformation.entrySet()) { > } > //... > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-8699) Fix concurrency problem in rocksdb full checkpoint
[ https://issues.apache.org/jira/browse/FLINK-8699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369079#comment-16369079 ] ASF GitHub Bot commented on FLINK-8699: --- Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/5525 @StefanRRichter Could you please have a look? > Fix concurrency problem in rocksdb full checkpoint > -- > > Key: FLINK-8699 > URL: https://issues.apache.org/jira/browse/FLINK-8699 > Project: Flink > Issue Type: Bug > Components: State Backends, Checkpointing >Affects Versions: 1.5.0 >Reporter: Sihua Zhou >Assignee: Sihua Zhou >Priority: Blocker > Fix For: 1.5.0 > > > In full checkpoint, `kvStateInformation` is not a copied object and it can be > changed when writeKVStateMetaData() is invoking ... This can lead to > problematic, which is serious. > {code} > private void writeKVStateMetaData() throws IOException { > // ... > for (Map.EntryRegisteredKeyedBackendStateMetaInfo>> column : > stateBackend.kvStateInformation.entrySet()) { > } > //... > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-8699) Fix concurrency problem in rocksdb full checkpoint
[ https://issues.apache.org/jira/browse/FLINK-8699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369071#comment-16369071 ] ASF GitHub Bot commented on FLINK-8699: --- GitHub user sihuazhou opened a pull request: https://github.com/apache/flink/pull/5525 [FLINK-8699][hotfix] Fix in concurrency problem for full Checkpoint. This PR fix [FLINK-8699](https://issues.apache.org/jira/browse/FLINK-8699). In fully checkpoint, `kvStateInformation` is not a copied object and it can be changed when writeKVStateMetaData() is invoking ... This can lead to problematic, which is serious. ## Brief change log - Copy `kvStateInformation` to avoid concurrency problem. ## Verifying this change - This change can be verified by the existed unit tests. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) You can merge this pull request into a Git repository by running: $ git pull https://github.com/sihuazhou/flink hotfix_full_checkpoint Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/5525.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5525 commit de191cdd8ab6073cd6c06c3c3f0174f15c08369a Author: sihuazhouDate: 2018-02-19T12:13:58Z fix in concurrency problem for full Checkpoint. > Fix concurrency problem in rocksdb full checkpoint > -- > > Key: FLINK-8699 > URL: https://issues.apache.org/jira/browse/FLINK-8699 > Project: Flink > Issue Type: Bug > Components: State Backends, Checkpointing >Affects Versions: 1.5.0 >Reporter: Sihua Zhou >Assignee: Sihua Zhou >Priority: Blocker > Fix For: 1.5.0 > > > In full checkpoint, `kvStateInformation` is not a copied object and it can be > changed when writeKVStateMetaData() is invoking ... This can lead to > problematic, which is serious. > {code} > private void writeKVStateMetaData() throws IOException { > // ... > for (Map.Entry RegisteredKeyedBackendStateMetaInfo>> column : > stateBackend.kvStateInformation.entrySet()) { > } > //... > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)