[jira] [Commented] (FLINK-8837) Move DataStreamUtils to package 'experimental'.
[
https://issues.apache.org/jira/browse/FLINK-8837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419171#comment-16419171
]
Till Rohrmann commented on FLINK-8837:
--
+1 for the {{@Experimental}} annotation.
Also +1 for [~phoenixjiangnan] to take a stab at it from my side.
> Move DataStreamUtils to package 'experimental'.
> ---
>
> Key: FLINK-8837
> URL: https://issues.apache.org/jira/browse/FLINK-8837
> Project: Flink
> Issue Type: Bug
> Components: Streaming
>Reporter: Stephan Ewen
>Priority: Blocker
> Fix For: 1.5.0
>
>
> The class {{DataStreamUtils}} came from 'flink-contrib' and now accidentally
> moved to the fully supported API packages. It should be in package
> 'experimental' to properly communicate that it is not guaranteed to be API
> stable.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8837) Move DataStreamUtils to package 'experimental'.
[
https://issues.apache.org/jira/browse/FLINK-8837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385772#comment-16385772
]
Bowen Li commented on FLINK-8837:
-
+1 on adding a new {{experimental}} annotation.
I can take this ticket if everyone agrees on the approach, since I moved
DataStreamUtils from flink-contrib to flink-streaming-java
> Move DataStreamUtils to package 'experimental'.
> ---
>
> Key: FLINK-8837
> URL: https://issues.apache.org/jira/browse/FLINK-8837
> Project: Flink
> Issue Type: Bug
> Components: Streaming
>Reporter: Stephan Ewen
>Priority: Blocker
> Fix For: 1.5.0
>
>
> The class {{DataStreamUtils}} came from 'flink-contrib' and now accidentally
> moved to the fully supported API packages. It should be in package
> 'experimental' to properly communicate that it is not guaranteed to be API
> stable.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8837) Move DataStreamUtils to package 'experimental'.
[
https://issues.apache.org/jira/browse/FLINK-8837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384533#comment-16384533
]
Chesnay Schepler commented on FLINK-8837:
-
I'd be in favor of adding an annotation as there should only be one way to
define the API stability.
> Move DataStreamUtils to package 'experimental'.
> ---
>
> Key: FLINK-8837
> URL: https://issues.apache.org/jira/browse/FLINK-8837
> Project: Flink
> Issue Type: Bug
> Components: Streaming
>Reporter: Stephan Ewen
>Priority: Blocker
> Fix For: 1.5.0
>
>
> The class {{DataStreamUtils}} came from 'flink-contrib' and now accidentally
> moved to the fully supported API packages. It should be in package
> 'experimental' to properly communicate that it is not guaranteed to be API
> stable.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8837) Move DataStreamUtils to package 'experimental'.
[
https://issues.apache.org/jira/browse/FLINK-8837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383772#comment-16383772
]
Stephan Ewen commented on FLINK-8837:
-
I see the issue with package private methods.
Originally, the PublicEvolving annotation was intended for just that case.
I think many users by now implicitly assume that PublicEvolving is quite okay
to use (we kept most PublicEvolving stuff stable as well), which is why we were
keen to create the {{flink-contrib}} module, or the {{experimental}} package,
to make it blindingly obvious to users that this stuff is risky to use.
An {{@Experimental}} annotation may be a nice way to solve this, if we have
broad consensus that we should have such an annotation level.
> Move DataStreamUtils to package 'experimental'.
> ---
>
> Key: FLINK-8837
> URL: https://issues.apache.org/jira/browse/FLINK-8837
> Project: Flink
> Issue Type: Bug
> Components: Streaming
>Reporter: Stephan Ewen
>Priority: Blocker
> Fix For: 1.5.0
>
>
> The class {{DataStreamUtils}} came from 'flink-contrib' and now accidentally
> moved to the fully supported API packages. It should be in package
> 'experimental' to properly communicate that it is not guaranteed to be API
> stable.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8837) Move DataStreamUtils to package 'experimental'.
[
https://issues.apache.org/jira/browse/FLINK-8837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383509#comment-16383509
]
Stefan Richter commented on FLINK-8837:
---
The class is annotated as evolving and as you said, there is no experimental
annotation.
> Move DataStreamUtils to package 'experimental'.
> ---
>
> Key: FLINK-8837
> URL: https://issues.apache.org/jira/browse/FLINK-8837
> Project: Flink
> Issue Type: Bug
> Components: Streaming
>Reporter: Stephan Ewen
>Priority: Blocker
> Fix For: 1.5.0
>
>
> The class {{DataStreamUtils}} came from 'flink-contrib' and now accidentally
> moved to the fully supported API packages. It should be in package
> 'experimental' to properly communicate that it is not guaranteed to be API
> stable.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8837) Move DataStreamUtils to package 'experimental'.
[
https://issues.apache.org/jira/browse/FLINK-8837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383508#comment-16383508
]
Chesnay Schepler commented on FLINK-8837:
-
why not annotate them with {{PublicEvolving}} instead? Or introduce a separate
{{Experimental}} annotation for API's exposed to users that could be removed at
any time.
> Move DataStreamUtils to package 'experimental'.
> ---
>
> Key: FLINK-8837
> URL: https://issues.apache.org/jira/browse/FLINK-8837
> Project: Flink
> Issue Type: Bug
> Components: Streaming
>Reporter: Stephan Ewen
>Priority: Blocker
> Fix For: 1.5.0
>
>
> The class {{DataStreamUtils}} came from 'flink-contrib' and now accidentally
> moved to the fully supported API packages. It should be in package
> 'experimental' to properly communicate that it is not guaranteed to be API
> stable.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8837) Move DataStreamUtils to package 'experimental'.
[
https://issues.apache.org/jira/browse/FLINK-8837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383502#comment-16383502
]
Stefan Richter commented on FLINK-8837:
---
I think there is one problem with keeping it in an experimental package: this
class is used to expose functionality that goes through package-private methods
in data stream classes. If we move it to a different package, those methods
need to become public. If the methods are public, then there is also little use
in exposing them over `DataStreamUtils`.
> Move DataStreamUtils to package 'experimental'.
> ---
>
> Key: FLINK-8837
> URL: https://issues.apache.org/jira/browse/FLINK-8837
> Project: Flink
> Issue Type: Bug
> Components: Streaming
>Reporter: Stephan Ewen
>Priority: Blocker
> Fix For: 1.5.0
>
>
> The class {{DataStreamUtils}} came from 'flink-contrib' and now accidentally
> moved to the fully supported API packages. It should be in package
> 'experimental' to properly communicate that it is not guaranteed to be API
> stable.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
