[jira] [Commented] (FLINK-8960) Port SavepointITCase to flip6

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-8960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443691#comment-16443691
 ] 

ASF GitHub Bot commented on FLINK-8960:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/5806


> Port SavepointITCase to flip6
> -
>
> Key: FLINK-8960
> URL: https://issues.apache.org/jira/browse/FLINK-8960
> Project: Flink
>  Issue Type: Improvement
>  Components: Tests
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Blocker
> Fix For: 1.5.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-8960) Port SavepointITCase to flip6

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-8960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16442597#comment-16442597
 ] 

ASF GitHub Bot commented on FLINK-8960:
---

Github user zentol commented on the issue:

https://github.com/apache/flink/pull/5806
  
merging.


> Port SavepointITCase to flip6
> -
>
> Key: FLINK-8960
> URL: https://issues.apache.org/jira/browse/FLINK-8960
> Project: Flink
>  Issue Type: Improvement
>  Components: Tests
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Blocker
> Fix For: 1.5.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-8960) Port SavepointITCase to flip6

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-8960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439511#comment-16439511
 ] 

ASF GitHub Bot commented on FLINK-8960:
---

Github user aljoscha commented on the issue:

https://github.com/apache/flink/pull/5806
  
I think this is good to go.  

Actually verifying the TDDs should have been done in a unit test or a 
different integration test, but this is not specific to savepoints, which we're 
trying to test here.


> Port SavepointITCase to flip6
> -
>
> Key: FLINK-8960
> URL: https://issues.apache.org/jira/browse/FLINK-8960
> Project: Flink
>  Issue Type: Improvement
>  Components: Tests
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Blocker
> Fix For: 1.5.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-8960) Port SavepointITCase to flip6

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-8960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423841#comment-16423841
 ] 

ASF GitHub Bot commented on FLINK-8960:
---

GitHub user zentol opened a pull request:

https://github.com/apache/flink/pull/5806

[FLINK-8960][tests] Port SavepointITCase to flip6

## What is the purpose of the change

This PR ports the `SavepointITCase` to flip6.

Significant changes were made to the 
`testTriggerSavepointAndResumeWithFileBasedCheckpoints`:
The test was split into 2 steps:
*  `submitJobAndGetVerifiedSavepoint` submits the original job and creates 
a savepoint. It also verifies that the savepoint exists on disc as expected. (1 
file per substask + metadata file)
* `restoreJobAndVerifyState` loads the same job from the created savepoint 
and verifies that the state is properly restored.

Furthermore, the test was requesting actual `Savepoint` objects from the 
JobManager and was actively matching it against the `TaskDeploymentDescriptors` 
sent to the TaskManagers. This part was removed entirely on the assumption that 
they are redundant as we already verified that the state is properly restored 
for each subtask when restarting the job.

## Verifying this change

Run `ResumeCheckpointManuallyITCase` with `legacyCode` profile 
enabled/disabled.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zentol/flink 8960

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/5806.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #5806


commit 262c8d4194c51f30b8aa30ed504a62c8de5221cd
Author: zentol 
Date:   2018-03-27T12:45:03Z

[FLINK-8960][tests] Port SavepointITCase to flip6




> Port SavepointITCase to flip6
> -
>
> Key: FLINK-8960
> URL: https://issues.apache.org/jira/browse/FLINK-8960
> Project: Flink
>  Issue Type: Improvement
>  Components: Tests
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Blocker
> Fix For: 1.5.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)