[jira] [Commented] (FLINK-9458) Unable to recover from job failure on YARN with NPE
[ https://issues.apache.org/jira/browse/FLINK-9458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510735#comment-16510735 ] ASF GitHub Bot commented on FLINK-9458: --- Github user tillrohrmann closed the pull request at: https://github.com/apache/flink/pull/6119 > Unable to recover from job failure on YARN with NPE > --- > > Key: FLINK-9458 > URL: https://issues.apache.org/jira/browse/FLINK-9458 > Project: Flink > Issue Type: Bug >Affects Versions: 1.5.0 > Environment: Ambari HDP 2.6.3 > Hadoop 2.7.3 > > Job configuration: > 120 Task Managers x 1 slots > > >Reporter: Truong Duc Kien >Assignee: Till Rohrmann >Priority: Blocker > Fix For: 1.6.0, 1.5.1 > > > After upgrading our job to Flink 1.5, they are unable to recover from failure > with the following exception appears repeatedly > {noformat} > 2018-05-29 04:56:06,086 [ jobmanager-future-thread-36] INFO > o.a.f.r.e.ExecutionGraph Try to restart or fail the job xxx > (23d9e87bf43ce163ff7db8afb062fb1d) if no longer possible. > 2018-05-29 04:56:06,086 [ jobmanager-future-thread-36] INFO > o.a.f.r.e.ExecutionGraph Job xxx (23d9e87bf43ce163ff7db8afb062fb1d) switched > from state RESTARTING to RESTARTING. > 2018-05-29 04:56:06,086 [ jobmanager-future-thread-36] INFO > o.a.f.r.e.ExecutionGraph Restarting the job xxx > (23d9e87bf43ce163ff7db8afb062fb1d). > 2018-05-29 04:57:06,086 [ jobmanager-future-thread-36] WARN > o.a.f.r.e.ExecutionGraph Failed to restart the job. > java.lang.NullPointerException at > org.apache.flink.runtime.jobmanager.scheduler.CoLocationConstraint.isAssignedAndAlive(CoLocationConstraint.java:104) > at > org.apache.flink.runtime.jobmanager.scheduler.CoLocationGroup.resetConstraints(CoLocationGroup.java:119) > at > org.apache.flink.runtime.executiongraph.ExecutionGraph.restart(ExecutionGraph.java:1247) > at > org.apache.flink.runtime.executiongraph.restart.ExecutionGraphRestartCallback.triggerFullRecovery(ExecutionGraphRestartCallback.java:59) > at > org.apache.flink.runtime.executiongraph.restart.FixedDelayRestartStrategy$1.run(FixedDelayRestartStrategy.java:68) > at > java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at > java.util.concurrent.FutureTask.run(FutureTask.java:266) at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) > at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > at java.lang.Thread.run(Thread.java:748) > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-9458) Unable to recover from job failure on YARN with NPE
[ https://issues.apache.org/jira/browse/FLINK-9458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509441#comment-16509441 ] ASF GitHub Bot commented on FLINK-9458: --- Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/6119 Thanks for the review @StefanRRichter. Merging this PR. > Unable to recover from job failure on YARN with NPE > --- > > Key: FLINK-9458 > URL: https://issues.apache.org/jira/browse/FLINK-9458 > Project: Flink > Issue Type: Bug >Affects Versions: 1.5.0 > Environment: Ambari HDP 2.6.3 > Hadoop 2.7.3 > > Job configuration: > 120 Task Managers x 1 slots > > >Reporter: Truong Duc Kien >Assignee: Till Rohrmann >Priority: Blocker > Fix For: 1.6.0, 1.5.1 > > > After upgrading our job to Flink 1.5, they are unable to recover from failure > with the following exception appears repeatedly > {noformat} > 2018-05-29 04:56:06,086 [ jobmanager-future-thread-36] INFO > o.a.f.r.e.ExecutionGraph Try to restart or fail the job xxx > (23d9e87bf43ce163ff7db8afb062fb1d) if no longer possible. > 2018-05-29 04:56:06,086 [ jobmanager-future-thread-36] INFO > o.a.f.r.e.ExecutionGraph Job xxx (23d9e87bf43ce163ff7db8afb062fb1d) switched > from state RESTARTING to RESTARTING. > 2018-05-29 04:56:06,086 [ jobmanager-future-thread-36] INFO > o.a.f.r.e.ExecutionGraph Restarting the job xxx > (23d9e87bf43ce163ff7db8afb062fb1d). > 2018-05-29 04:57:06,086 [ jobmanager-future-thread-36] WARN > o.a.f.r.e.ExecutionGraph Failed to restart the job. > java.lang.NullPointerException at > org.apache.flink.runtime.jobmanager.scheduler.CoLocationConstraint.isAssignedAndAlive(CoLocationConstraint.java:104) > at > org.apache.flink.runtime.jobmanager.scheduler.CoLocationGroup.resetConstraints(CoLocationGroup.java:119) > at > org.apache.flink.runtime.executiongraph.ExecutionGraph.restart(ExecutionGraph.java:1247) > at > org.apache.flink.runtime.executiongraph.restart.ExecutionGraphRestartCallback.triggerFullRecovery(ExecutionGraphRestartCallback.java:59) > at > org.apache.flink.runtime.executiongraph.restart.FixedDelayRestartStrategy$1.run(FixedDelayRestartStrategy.java:68) > at > java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at > java.util.concurrent.FutureTask.run(FutureTask.java:266) at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) > at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > at java.lang.Thread.run(Thread.java:748) > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-9458) Unable to recover from job failure on YARN with NPE
[ https://issues.apache.org/jira/browse/FLINK-9458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507926#comment-16507926 ] ASF GitHub Bot commented on FLINK-9458: --- Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/6119 LGTM > Unable to recover from job failure on YARN with NPE > --- > > Key: FLINK-9458 > URL: https://issues.apache.org/jira/browse/FLINK-9458 > Project: Flink > Issue Type: Bug >Affects Versions: 1.5.0 > Environment: Ambari HDP 2.6.3 > Hadoop 2.7.3 > > Job configuration: > 120 Task Managers x 1 slots > > >Reporter: Truong Duc Kien >Assignee: Till Rohrmann >Priority: Blocker > Fix For: 1.6.0, 1.5.1 > > > After upgrading our job to Flink 1.5, they are unable to recover from failure > with the following exception appears repeatedly > {noformat} > 2018-05-29 04:56:06,086 [ jobmanager-future-thread-36] INFO > o.a.f.r.e.ExecutionGraph Try to restart or fail the job xxx > (23d9e87bf43ce163ff7db8afb062fb1d) if no longer possible. > 2018-05-29 04:56:06,086 [ jobmanager-future-thread-36] INFO > o.a.f.r.e.ExecutionGraph Job xxx (23d9e87bf43ce163ff7db8afb062fb1d) switched > from state RESTARTING to RESTARTING. > 2018-05-29 04:56:06,086 [ jobmanager-future-thread-36] INFO > o.a.f.r.e.ExecutionGraph Restarting the job xxx > (23d9e87bf43ce163ff7db8afb062fb1d). > 2018-05-29 04:57:06,086 [ jobmanager-future-thread-36] WARN > o.a.f.r.e.ExecutionGraph Failed to restart the job. > java.lang.NullPointerException at > org.apache.flink.runtime.jobmanager.scheduler.CoLocationConstraint.isAssignedAndAlive(CoLocationConstraint.java:104) > at > org.apache.flink.runtime.jobmanager.scheduler.CoLocationGroup.resetConstraints(CoLocationGroup.java:119) > at > org.apache.flink.runtime.executiongraph.ExecutionGraph.restart(ExecutionGraph.java:1247) > at > org.apache.flink.runtime.executiongraph.restart.ExecutionGraphRestartCallback.triggerFullRecovery(ExecutionGraphRestartCallback.java:59) > at > org.apache.flink.runtime.executiongraph.restart.FixedDelayRestartStrategy$1.run(FixedDelayRestartStrategy.java:68) > at > java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at > java.util.concurrent.FutureTask.run(FutureTask.java:266) at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) > at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > at java.lang.Thread.run(Thread.java:748) > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-9458) Unable to recover from job failure on YARN with NPE
[ https://issues.apache.org/jira/browse/FLINK-9458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501404#comment-16501404 ] ASF GitHub Bot commented on FLINK-9458: --- Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6101 @tillrohrmann OK, closing... > Unable to recover from job failure on YARN with NPE > --- > > Key: FLINK-9458 > URL: https://issues.apache.org/jira/browse/FLINK-9458 > Project: Flink > Issue Type: Bug >Affects Versions: 1.5.0 > Environment: Ambari HDP 2.6.3 > Hadoop 2.7.3 > > Job configuration: > 120 Task Managers x 1 slots > > >Reporter: Truong Duc Kien >Assignee: Till Rohrmann >Priority: Blocker > Fix For: 1.6.0, 1.5.1 > > > After upgrading our job to Flink 1.5, they are unable to recover from failure > with the following exception appears repeatedly > {noformat} > 2018-05-29 04:56:06,086 [ jobmanager-future-thread-36] INFO > o.a.f.r.e.ExecutionGraph Try to restart or fail the job xxx > (23d9e87bf43ce163ff7db8afb062fb1d) if no longer possible. > 2018-05-29 04:56:06,086 [ jobmanager-future-thread-36] INFO > o.a.f.r.e.ExecutionGraph Job xxx (23d9e87bf43ce163ff7db8afb062fb1d) switched > from state RESTARTING to RESTARTING. > 2018-05-29 04:56:06,086 [ jobmanager-future-thread-36] INFO > o.a.f.r.e.ExecutionGraph Restarting the job xxx > (23d9e87bf43ce163ff7db8afb062fb1d). > 2018-05-29 04:57:06,086 [ jobmanager-future-thread-36] WARN > o.a.f.r.e.ExecutionGraph Failed to restart the job. > java.lang.NullPointerException at > org.apache.flink.runtime.jobmanager.scheduler.CoLocationConstraint.isAssignedAndAlive(CoLocationConstraint.java:104) > at > org.apache.flink.runtime.jobmanager.scheduler.CoLocationGroup.resetConstraints(CoLocationGroup.java:119) > at > org.apache.flink.runtime.executiongraph.ExecutionGraph.restart(ExecutionGraph.java:1247) > at > org.apache.flink.runtime.executiongraph.restart.ExecutionGraphRestartCallback.triggerFullRecovery(ExecutionGraphRestartCallback.java:59) > at > org.apache.flink.runtime.executiongraph.restart.FixedDelayRestartStrategy$1.run(FixedDelayRestartStrategy.java:68) > at > java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at > java.util.concurrent.FutureTask.run(FutureTask.java:266) at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) > at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > at java.lang.Thread.run(Thread.java:748) > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-9458) Unable to recover from job failure on YARN with NPE
[ https://issues.apache.org/jira/browse/FLINK-9458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501405#comment-16501405 ] ASF GitHub Bot commented on FLINK-9458: --- Github user yanghua closed the pull request at: https://github.com/apache/flink/pull/6101 > Unable to recover from job failure on YARN with NPE > --- > > Key: FLINK-9458 > URL: https://issues.apache.org/jira/browse/FLINK-9458 > Project: Flink > Issue Type: Bug >Affects Versions: 1.5.0 > Environment: Ambari HDP 2.6.3 > Hadoop 2.7.3 > > Job configuration: > 120 Task Managers x 1 slots > > >Reporter: Truong Duc Kien >Assignee: Till Rohrmann >Priority: Blocker > Fix For: 1.6.0, 1.5.1 > > > After upgrading our job to Flink 1.5, they are unable to recover from failure > with the following exception appears repeatedly > {noformat} > 2018-05-29 04:56:06,086 [ jobmanager-future-thread-36] INFO > o.a.f.r.e.ExecutionGraph Try to restart or fail the job xxx > (23d9e87bf43ce163ff7db8afb062fb1d) if no longer possible. > 2018-05-29 04:56:06,086 [ jobmanager-future-thread-36] INFO > o.a.f.r.e.ExecutionGraph Job xxx (23d9e87bf43ce163ff7db8afb062fb1d) switched > from state RESTARTING to RESTARTING. > 2018-05-29 04:56:06,086 [ jobmanager-future-thread-36] INFO > o.a.f.r.e.ExecutionGraph Restarting the job xxx > (23d9e87bf43ce163ff7db8afb062fb1d). > 2018-05-29 04:57:06,086 [ jobmanager-future-thread-36] WARN > o.a.f.r.e.ExecutionGraph Failed to restart the job. > java.lang.NullPointerException at > org.apache.flink.runtime.jobmanager.scheduler.CoLocationConstraint.isAssignedAndAlive(CoLocationConstraint.java:104) > at > org.apache.flink.runtime.jobmanager.scheduler.CoLocationGroup.resetConstraints(CoLocationGroup.java:119) > at > org.apache.flink.runtime.executiongraph.ExecutionGraph.restart(ExecutionGraph.java:1247) > at > org.apache.flink.runtime.executiongraph.restart.ExecutionGraphRestartCallback.triggerFullRecovery(ExecutionGraphRestartCallback.java:59) > at > org.apache.flink.runtime.executiongraph.restart.FixedDelayRestartStrategy$1.run(FixedDelayRestartStrategy.java:68) > at > java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at > java.util.concurrent.FutureTask.run(FutureTask.java:266) at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) > at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > at java.lang.Thread.run(Thread.java:748) > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-9458) Unable to recover from job failure on YARN with NPE
[ https://issues.apache.org/jira/browse/FLINK-9458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501403#comment-16501403 ] ASF GitHub Bot commented on FLINK-9458: --- Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/6101 Could you please close this PR @yanghua. It is now subsumed by #6119. > Unable to recover from job failure on YARN with NPE > --- > > Key: FLINK-9458 > URL: https://issues.apache.org/jira/browse/FLINK-9458 > Project: Flink > Issue Type: Bug >Affects Versions: 1.5.0 > Environment: Ambari HDP 2.6.3 > Hadoop 2.7.3 > > Job configuration: > 120 Task Managers x 1 slots > > >Reporter: Truong Duc Kien >Assignee: Till Rohrmann >Priority: Blocker > Fix For: 1.6.0, 1.5.1 > > > After upgrading our job to Flink 1.5, they are unable to recover from failure > with the following exception appears repeatedly > {noformat} > 2018-05-29 04:56:06,086 [ jobmanager-future-thread-36] INFO > o.a.f.r.e.ExecutionGraph Try to restart or fail the job xxx > (23d9e87bf43ce163ff7db8afb062fb1d) if no longer possible. > 2018-05-29 04:56:06,086 [ jobmanager-future-thread-36] INFO > o.a.f.r.e.ExecutionGraph Job xxx (23d9e87bf43ce163ff7db8afb062fb1d) switched > from state RESTARTING to RESTARTING. > 2018-05-29 04:56:06,086 [ jobmanager-future-thread-36] INFO > o.a.f.r.e.ExecutionGraph Restarting the job xxx > (23d9e87bf43ce163ff7db8afb062fb1d). > 2018-05-29 04:57:06,086 [ jobmanager-future-thread-36] WARN > o.a.f.r.e.ExecutionGraph Failed to restart the job. > java.lang.NullPointerException at > org.apache.flink.runtime.jobmanager.scheduler.CoLocationConstraint.isAssignedAndAlive(CoLocationConstraint.java:104) > at > org.apache.flink.runtime.jobmanager.scheduler.CoLocationGroup.resetConstraints(CoLocationGroup.java:119) > at > org.apache.flink.runtime.executiongraph.ExecutionGraph.restart(ExecutionGraph.java:1247) > at > org.apache.flink.runtime.executiongraph.restart.ExecutionGraphRestartCallback.triggerFullRecovery(ExecutionGraphRestartCallback.java:59) > at > org.apache.flink.runtime.executiongraph.restart.FixedDelayRestartStrategy$1.run(FixedDelayRestartStrategy.java:68) > at > java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at > java.util.concurrent.FutureTask.run(FutureTask.java:266) at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) > at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > at java.lang.Thread.run(Thread.java:748) > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-9458) Unable to recover from job failure on YARN with NPE
[ https://issues.apache.org/jira/browse/FLINK-9458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501402#comment-16501402 ] ASF GitHub Bot commented on FLINK-9458: --- GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/6119 [FLINK-9458] Ignore SharedSlot in CoLocationConstraint when not using legacy mode ## What is the purpose of the change The SharedSlot in CoLocationConstraint is only set when using the legacy mode. Thus, CoLocationConstraint#isAssignedAlive should only check the SharedSlot if it was previously set. This fixes the NPE when restarting a job with a co-location constraint when using the new mode. ## Verifying this change - Added `ExecutionGraphCoLocationRestartTest#testConstraintsAfterRestart` which verifies that an `ExecutionGraph` with co-location constraints can be restarted with the legacy as well as the new mode. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable) You can merge this pull request into a Git repository by running: $ git pull https://github.com/tillrohrmann/flink fixCoLocationConstraintRecovery Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/6119.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #6119 commit acf70e8cca10caa2fe0cd8d5e95885b39ed0b187 Author: Till Rohrmann Date: 2018-06-05T07:12:49Z [FLINK-9458] Ignore SharedSlot in CoLocationConstraint when not using legacy mode The SharedSlot in CoLocationConstraint is only set when using the legacy mode. Thus, CoLocationConstraint#isAssignedAlive should only check the SharedSlot if it was previously set. This fixes the NPE when restarting a job with a co-location constraint when using the new mode. > Unable to recover from job failure on YARN with NPE > --- > > Key: FLINK-9458 > URL: https://issues.apache.org/jira/browse/FLINK-9458 > Project: Flink > Issue Type: Bug >Affects Versions: 1.5.0 > Environment: Ambari HDP 2.6.3 > Hadoop 2.7.3 > > Job configuration: > 120 Task Managers x 1 slots > > >Reporter: Truong Duc Kien >Assignee: Till Rohrmann >Priority: Blocker > Fix For: 1.6.0, 1.5.1 > > > After upgrading our job to Flink 1.5, they are unable to recover from failure > with the following exception appears repeatedly > {noformat} > 2018-05-29 04:56:06,086 [ jobmanager-future-thread-36] INFO > o.a.f.r.e.ExecutionGraph Try to restart or fail the job xxx > (23d9e87bf43ce163ff7db8afb062fb1d) if no longer possible. > 2018-05-29 04:56:06,086 [ jobmanager-future-thread-36] INFO > o.a.f.r.e.ExecutionGraph Job xxx (23d9e87bf43ce163ff7db8afb062fb1d) switched > from state RESTARTING to RESTARTING. > 2018-05-29 04:56:06,086 [ jobmanager-future-thread-36] INFO > o.a.f.r.e.ExecutionGraph Restarting the job xxx > (23d9e87bf43ce163ff7db8afb062fb1d). > 2018-05-29 04:57:06,086 [ jobmanager-future-thread-36] WARN > o.a.f.r.e.ExecutionGraph Failed to restart the job. > java.lang.NullPointerException at > org.apache.flink.runtime.jobmanager.scheduler.CoLocationConstraint.isAssignedAndAlive(CoLocationConstraint.java:104) > at > org.apache.flink.runtime.jobmanager.scheduler.CoLocationGroup.resetConstraints(CoLocationGroup.java:119) > at > org.apache.flink.runtime.executiongraph.ExecutionGraph.restart(ExecutionGraph.java:1247) > at > org.apache.flink.runtime.executiongraph.restart.ExecutionGraphRestartCallback.triggerFullRecovery(ExecutionGraphRestartCallback.java:59) > at > org.apache.flink.runtime.executiongraph.restart.FixedDelayRestartStrategy$1.run(FixedDelayRestartStrategy.java:68) > at > java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at > java.util.concurrent.FutureTask.run(FutureTask.java:266) at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) > at >
[jira] [Commented] (FLINK-9458) Unable to recover from job failure on YARN with NPE
[ https://issues.apache.org/jira/browse/FLINK-9458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499963#comment-16499963 ] vinoyang commented on FLINK-9458: - [~till.rohrmann] OK, I have released this issue. > Unable to recover from job failure on YARN with NPE > --- > > Key: FLINK-9458 > URL: https://issues.apache.org/jira/browse/FLINK-9458 > Project: Flink > Issue Type: Bug >Affects Versions: 1.5.0 > Environment: Ambari HDP 2.6.3 > Hadoop 2.7.3 > > Job configuration: > 120 Task Managers x 1 slots > > >Reporter: Truong Duc Kien >Priority: Blocker > Fix For: 1.6.0, 1.5.1 > > > After upgrading our job to Flink 1.5, they are unable to recover from failure > with the following exception appears repeatedly > {noformat} > 2018-05-29 04:56:06,086 [ jobmanager-future-thread-36] INFO > o.a.f.r.e.ExecutionGraph Try to restart or fail the job xxx > (23d9e87bf43ce163ff7db8afb062fb1d) if no longer possible. > 2018-05-29 04:56:06,086 [ jobmanager-future-thread-36] INFO > o.a.f.r.e.ExecutionGraph Job xxx (23d9e87bf43ce163ff7db8afb062fb1d) switched > from state RESTARTING to RESTARTING. > 2018-05-29 04:56:06,086 [ jobmanager-future-thread-36] INFO > o.a.f.r.e.ExecutionGraph Restarting the job xxx > (23d9e87bf43ce163ff7db8afb062fb1d). > 2018-05-29 04:57:06,086 [ jobmanager-future-thread-36] WARN > o.a.f.r.e.ExecutionGraph Failed to restart the job. > java.lang.NullPointerException at > org.apache.flink.runtime.jobmanager.scheduler.CoLocationConstraint.isAssignedAndAlive(CoLocationConstraint.java:104) > at > org.apache.flink.runtime.jobmanager.scheduler.CoLocationGroup.resetConstraints(CoLocationGroup.java:119) > at > org.apache.flink.runtime.executiongraph.ExecutionGraph.restart(ExecutionGraph.java:1247) > at > org.apache.flink.runtime.executiongraph.restart.ExecutionGraphRestartCallback.triggerFullRecovery(ExecutionGraphRestartCallback.java:59) > at > org.apache.flink.runtime.executiongraph.restart.FixedDelayRestartStrategy$1.run(FixedDelayRestartStrategy.java:68) > at > java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at > java.util.concurrent.FutureTask.run(FutureTask.java:266) at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) > at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > at java.lang.Thread.run(Thread.java:748) > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-9458) Unable to recover from job failure on YARN with NPE
[ https://issues.apache.org/jira/browse/FLINK-9458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499936#comment-16499936 ] Till Rohrmann commented on FLINK-9458: -- The problem is some legacy code path which assumes that {{CoLocationConstraint}} has always a {{SharedSlot}} assigned if the {{lockedLocation}} is set. This holds no longer true for the {{SlotPool}} because the {{CoLocationConstraint}} is now more of a data object which does not need to know about slots. [~yanghua] if it is ok, then I would take over the PR, do the refactoring and add some test. > Unable to recover from job failure on YARN with NPE > --- > > Key: FLINK-9458 > URL: https://issues.apache.org/jira/browse/FLINK-9458 > Project: Flink > Issue Type: Bug >Affects Versions: 1.5.0 > Environment: Ambari HDP 2.6.3 > Hadoop 2.7.3 > > Job configuration: > 120 Task Managers x 1 slots > > >Reporter: Truong Duc Kien >Assignee: vinoyang >Priority: Blocker > Fix For: 1.6.0, 1.5.1 > > > After upgrading our job to Flink 1.5, they are unable to recover from failure > with the following exception appears repeatedly > {noformat} > 2018-05-29 04:56:06,086 [ jobmanager-future-thread-36] INFO > o.a.f.r.e.ExecutionGraph Try to restart or fail the job xxx > (23d9e87bf43ce163ff7db8afb062fb1d) if no longer possible. > 2018-05-29 04:56:06,086 [ jobmanager-future-thread-36] INFO > o.a.f.r.e.ExecutionGraph Job xxx (23d9e87bf43ce163ff7db8afb062fb1d) switched > from state RESTARTING to RESTARTING. > 2018-05-29 04:56:06,086 [ jobmanager-future-thread-36] INFO > o.a.f.r.e.ExecutionGraph Restarting the job xxx > (23d9e87bf43ce163ff7db8afb062fb1d). > 2018-05-29 04:57:06,086 [ jobmanager-future-thread-36] WARN > o.a.f.r.e.ExecutionGraph Failed to restart the job. > java.lang.NullPointerException at > org.apache.flink.runtime.jobmanager.scheduler.CoLocationConstraint.isAssignedAndAlive(CoLocationConstraint.java:104) > at > org.apache.flink.runtime.jobmanager.scheduler.CoLocationGroup.resetConstraints(CoLocationGroup.java:119) > at > org.apache.flink.runtime.executiongraph.ExecutionGraph.restart(ExecutionGraph.java:1247) > at > org.apache.flink.runtime.executiongraph.restart.ExecutionGraphRestartCallback.triggerFullRecovery(ExecutionGraphRestartCallback.java:59) > at > org.apache.flink.runtime.executiongraph.restart.FixedDelayRestartStrategy$1.run(FixedDelayRestartStrategy.java:68) > at > java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at > java.util.concurrent.FutureTask.run(FutureTask.java:266) at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) > at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > at java.lang.Thread.run(Thread.java:748) > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-9458) Unable to recover from job failure on YARN with NPE
[ https://issues.apache.org/jira/browse/FLINK-9458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496954#comment-16496954 ] ASF GitHub Bot commented on FLINK-9458: --- Github user kkrugler commented on the issue: https://github.com/apache/flink/pull/6101 One other note - I ran into this problem, but it wasn't on YARN. It was running locally (via unit test triggered in Eclipse). > Unable to recover from job failure on YARN with NPE > --- > > Key: FLINK-9458 > URL: https://issues.apache.org/jira/browse/FLINK-9458 > Project: Flink > Issue Type: Bug >Affects Versions: 1.5.0 > Environment: Ambari HDP 2.6.3 > Hadoop 2.7.3 > > Job configuration: > 120 Task Managers x 1 slots > > >Reporter: Truong Duc Kien >Assignee: vinoyang >Priority: Blocker > Fix For: 1.6.0, 1.5.1 > > > After upgrading our job to Flink 1.5, they are unable to recover from failure > with the following exception appears repeatedly > {noformat} > 2018-05-29 04:56:06,086 [ jobmanager-future-thread-36] INFO > o.a.f.r.e.ExecutionGraph Try to restart or fail the job xxx > (23d9e87bf43ce163ff7db8afb062fb1d) if no longer possible. > 2018-05-29 04:56:06,086 [ jobmanager-future-thread-36] INFO > o.a.f.r.e.ExecutionGraph Job xxx (23d9e87bf43ce163ff7db8afb062fb1d) switched > from state RESTARTING to RESTARTING. > 2018-05-29 04:56:06,086 [ jobmanager-future-thread-36] INFO > o.a.f.r.e.ExecutionGraph Restarting the job xxx > (23d9e87bf43ce163ff7db8afb062fb1d). > 2018-05-29 04:57:06,086 [ jobmanager-future-thread-36] WARN > o.a.f.r.e.ExecutionGraph Failed to restart the job. > java.lang.NullPointerException at > org.apache.flink.runtime.jobmanager.scheduler.CoLocationConstraint.isAssignedAndAlive(CoLocationConstraint.java:104) > at > org.apache.flink.runtime.jobmanager.scheduler.CoLocationGroup.resetConstraints(CoLocationGroup.java:119) > at > org.apache.flink.runtime.executiongraph.ExecutionGraph.restart(ExecutionGraph.java:1247) > at > org.apache.flink.runtime.executiongraph.restart.ExecutionGraphRestartCallback.triggerFullRecovery(ExecutionGraphRestartCallback.java:59) > at > org.apache.flink.runtime.executiongraph.restart.FixedDelayRestartStrategy$1.run(FixedDelayRestartStrategy.java:68) > at > java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at > java.util.concurrent.FutureTask.run(FutureTask.java:266) at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) > at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > at java.lang.Thread.run(Thread.java:748) > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-9458) Unable to recover from job failure on YARN with NPE
[ https://issues.apache.org/jira/browse/FLINK-9458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496952#comment-16496952 ] ASF GitHub Bot commented on FLINK-9458: --- Github user kkrugler commented on the issue: https://github.com/apache/flink/pull/6101 I'm wondering why, now, we're encountering cases where the `sharedSlot` value is null? Seems like this could be caused by a deeper problem somewhere, so just adding the null check is masking something else that should be fixed. Also, seems like we'd want a test case to verify the failure (pre-fix) and then appropriate behavior with the fix. > Unable to recover from job failure on YARN with NPE > --- > > Key: FLINK-9458 > URL: https://issues.apache.org/jira/browse/FLINK-9458 > Project: Flink > Issue Type: Bug >Affects Versions: 1.5.0 > Environment: Ambari HDP 2.6.3 > Hadoop 2.7.3 > > Job configuration: > 120 Task Managers x 1 slots > > >Reporter: Truong Duc Kien >Assignee: vinoyang >Priority: Blocker > Fix For: 1.6.0, 1.5.1 > > > After upgrading our job to Flink 1.5, they are unable to recover from failure > with the following exception appears repeatedly > {noformat} > 2018-05-29 04:56:06,086 [ jobmanager-future-thread-36] INFO > o.a.f.r.e.ExecutionGraph Try to restart or fail the job xxx > (23d9e87bf43ce163ff7db8afb062fb1d) if no longer possible. > 2018-05-29 04:56:06,086 [ jobmanager-future-thread-36] INFO > o.a.f.r.e.ExecutionGraph Job xxx (23d9e87bf43ce163ff7db8afb062fb1d) switched > from state RESTARTING to RESTARTING. > 2018-05-29 04:56:06,086 [ jobmanager-future-thread-36] INFO > o.a.f.r.e.ExecutionGraph Restarting the job xxx > (23d9e87bf43ce163ff7db8afb062fb1d). > 2018-05-29 04:57:06,086 [ jobmanager-future-thread-36] WARN > o.a.f.r.e.ExecutionGraph Failed to restart the job. > java.lang.NullPointerException at > org.apache.flink.runtime.jobmanager.scheduler.CoLocationConstraint.isAssignedAndAlive(CoLocationConstraint.java:104) > at > org.apache.flink.runtime.jobmanager.scheduler.CoLocationGroup.resetConstraints(CoLocationGroup.java:119) > at > org.apache.flink.runtime.executiongraph.ExecutionGraph.restart(ExecutionGraph.java:1247) > at > org.apache.flink.runtime.executiongraph.restart.ExecutionGraphRestartCallback.triggerFullRecovery(ExecutionGraphRestartCallback.java:59) > at > org.apache.flink.runtime.executiongraph.restart.FixedDelayRestartStrategy$1.run(FixedDelayRestartStrategy.java:68) > at > java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at > java.util.concurrent.FutureTask.run(FutureTask.java:266) at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) > at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > at java.lang.Thread.run(Thread.java:748) > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-9458) Unable to recover from job failure on YARN with NPE
[ https://issues.apache.org/jira/browse/FLINK-9458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495030#comment-16495030 ] ASF GitHub Bot commented on FLINK-9458: --- Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6101 cc @zentol > Unable to recover from job failure on YARN with NPE > --- > > Key: FLINK-9458 > URL: https://issues.apache.org/jira/browse/FLINK-9458 > Project: Flink > Issue Type: Bug >Affects Versions: 1.5.0 > Environment: Ambari HDP 2.6.3 > Hadoop 2.7.3 > > Job configuration: > 120 Task Managers x 1 slots > > >Reporter: Truong Duc Kien >Assignee: vinoyang >Priority: Blocker > Fix For: 1.6.0, 1.5.1 > > > After upgrading our job to Flink 1.5, they are unable to recover from failure > with the following exception appears repeatedly > {noformat} > 2018-05-29 04:56:06,086 [ jobmanager-future-thread-36] INFO > o.a.f.r.e.ExecutionGraph Try to restart or fail the job xxx > (23d9e87bf43ce163ff7db8afb062fb1d) if no longer possible. > 2018-05-29 04:56:06,086 [ jobmanager-future-thread-36] INFO > o.a.f.r.e.ExecutionGraph Job xxx (23d9e87bf43ce163ff7db8afb062fb1d) switched > from state RESTARTING to RESTARTING. > 2018-05-29 04:56:06,086 [ jobmanager-future-thread-36] INFO > o.a.f.r.e.ExecutionGraph Restarting the job xxx > (23d9e87bf43ce163ff7db8afb062fb1d). > 2018-05-29 04:57:06,086 [ jobmanager-future-thread-36] WARN > o.a.f.r.e.ExecutionGraph Failed to restart the job. > java.lang.NullPointerException at > org.apache.flink.runtime.jobmanager.scheduler.CoLocationConstraint.isAssignedAndAlive(CoLocationConstraint.java:104) > at > org.apache.flink.runtime.jobmanager.scheduler.CoLocationGroup.resetConstraints(CoLocationGroup.java:119) > at > org.apache.flink.runtime.executiongraph.ExecutionGraph.restart(ExecutionGraph.java:1247) > at > org.apache.flink.runtime.executiongraph.restart.ExecutionGraphRestartCallback.triggerFullRecovery(ExecutionGraphRestartCallback.java:59) > at > org.apache.flink.runtime.executiongraph.restart.FixedDelayRestartStrategy$1.run(FixedDelayRestartStrategy.java:68) > at > java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at > java.util.concurrent.FutureTask.run(FutureTask.java:266) at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) > at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > at java.lang.Thread.run(Thread.java:748) > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-9458) Unable to recover from job failure on YARN with NPE
[ https://issues.apache.org/jira/browse/FLINK-9458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494785#comment-16494785 ] ASF GitHub Bot commented on FLINK-9458: --- GitHub user yanghua opened a pull request: https://github.com/apache/flink/pull/6101 [FLINK-9458] Unable to recover from job failure on YARN with NPE ## What is the purpose of the change *This pull request fixed a NPE when recover job on YARN* ## Brief change log - *Add non-null judge in the expression * ## Verifying this change This change is already covered by existing tests, such as *CoLocationConstraintTest*. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**) You can merge this pull request into a Git repository by running: $ git pull https://github.com/yanghua/flink FLINK-9458 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/6101.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #6101 commit fa9f1e95aa9b38d243021d330859007f25acaddf Author: yanghua Date: 2018-05-30T07:06:58Z [FLINK-9458] Unable to recover from job failure on YARN with NPE > Unable to recover from job failure on YARN with NPE > --- > > Key: FLINK-9458 > URL: https://issues.apache.org/jira/browse/FLINK-9458 > Project: Flink > Issue Type: Bug >Affects Versions: 1.5.0 > Environment: Ambari HDP 2.6.3 > Hadoop 2.7.3 > > Job configuration: > 120 Task Managers x 1 slots > > >Reporter: Truong Duc Kien >Assignee: vinoyang >Priority: Blocker > Fix For: 1.6.0, 1.5.1 > > > After upgrading our job to Flink 1.5, they are unable to recover from failure > with the following exception appears repeatedly > {noformat} > 2018-05-29 04:56:06,086 [ jobmanager-future-thread-36] INFO > o.a.f.r.e.ExecutionGraph Try to restart or fail the job xxx > (23d9e87bf43ce163ff7db8afb062fb1d) if no longer possible. > 2018-05-29 04:56:06,086 [ jobmanager-future-thread-36] INFO > o.a.f.r.e.ExecutionGraph Job xxx (23d9e87bf43ce163ff7db8afb062fb1d) switched > from state RESTARTING to RESTARTING. > 2018-05-29 04:56:06,086 [ jobmanager-future-thread-36] INFO > o.a.f.r.e.ExecutionGraph Restarting the job xxx > (23d9e87bf43ce163ff7db8afb062fb1d). > 2018-05-29 04:57:06,086 [ jobmanager-future-thread-36] WARN > o.a.f.r.e.ExecutionGraph Failed to restart the job. > java.lang.NullPointerException at > org.apache.flink.runtime.jobmanager.scheduler.CoLocationConstraint.isAssignedAndAlive(CoLocationConstraint.java:104) > at > org.apache.flink.runtime.jobmanager.scheduler.CoLocationGroup.resetConstraints(CoLocationGroup.java:119) > at > org.apache.flink.runtime.executiongraph.ExecutionGraph.restart(ExecutionGraph.java:1247) > at > org.apache.flink.runtime.executiongraph.restart.ExecutionGraphRestartCallback.triggerFullRecovery(ExecutionGraphRestartCallback.java:59) > at > org.apache.flink.runtime.executiongraph.restart.FixedDelayRestartStrategy$1.run(FixedDelayRestartStrategy.java:68) > at > java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at > java.util.concurrent.FutureTask.run(FutureTask.java:266) at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) > at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > at java.lang.Thread.run(Thread.java:748) > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)