[jira] [Updated] (FLINK-13563) TumblingGroupWindow should implement toString method

[Kurt Young (Jira)]

 [ 
https://issues.apache.org/jira/browse/FLINK-13563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kurt Young updated FLINK-13563:
---
Fix Version/s: 1.10.0

> TumblingGroupWindow should implement toString method
> 
>
> Key: FLINK-13563
> URL: https://issues.apache.org/jira/browse/FLINK-13563
> Project: Flink
>  Issue Type: Bug
>  Components: Table SQL / Planner
>Affects Versions: 1.9.0, 1.10.0
>Reporter: godfrey he
>Assignee: godfrey he
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.10.0, 1.9.1
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> {code:scala}
>   @Test
>   def testAllEventTimeTumblingGroupWindowOverTime(): Unit = {
> val util = streamTestUtil()
> val table = util.addDataStream[(Long, Int, String)](
>   "T1", 'long, 'int, 'string, 'rowtime.rowtime)
> val windowedTable = table
>   .window(Tumble over 5.millis on 'rowtime as 'w)
>   .groupBy('w)
>   .select('int.count)
> util.verifyPlan(windowedTable)
>   }
> {code}
> currently, it's physical plan is 
> {code:java}
> HashWindowAggregate(window=[TumblingGroupWindow], 
> select=[Final_COUNT(count$0) AS EXPR$0])
> +- Exchange(distribution=[single])
>+- LocalHashWindowAggregate(window=[TumblingGroupWindow], 
> select=[Partial_COUNT(int) AS count$0])
>   +- TableSourceScan(table=[[default_catalog, default_database, Table1, 
> source: [TestTableSource(long, int, string)]]], fields=[long, int, string])
> {code}
> we know nothing about the TumblingGroupWindow except its name. the expected 
> plan is
> {code:java}
> HashWindowAggregate(window=[TumblingGroupWindow('w, long, 5)], 
> select=[Final_COUNT(count$0) AS EXPR$0])
> +- Exchange(distribution=[single])
>+- LocalHashWindowAggregate(window=[TumblingGroupWindow('w, long, 5)], 
> select=[Partial_COUNT(int) AS count$0])
>   +- TableSourceScan(table=[[default_catalog, default_database, Table1, 
> source: [TestTableSource(long, int, string)]]], fields=[long, int, string])
> {code}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Updated] (FLINK-13563) TumblingGroupWindow should implement toString method

[Jark Wu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/FLINK-13563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jark Wu updated FLINK-13563:

Fix Version/s: (was: 1.9.0)
   1.9.1

> TumblingGroupWindow should implement toString method
> 
>
> Key: FLINK-13563
> URL: https://issues.apache.org/jira/browse/FLINK-13563
> Project: Flink
>  Issue Type: Bug
>  Components: Table SQL / Planner
>Affects Versions: 1.9.0, 1.10.0
>Reporter: godfrey he
>Assignee: godfrey he
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.9.1
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> {code:scala}
>   @Test
>   def testAllEventTimeTumblingGroupWindowOverTime(): Unit = {
> val util = streamTestUtil()
> val table = util.addDataStream[(Long, Int, String)](
>   "T1", 'long, 'int, 'string, 'rowtime.rowtime)
> val windowedTable = table
>   .window(Tumble over 5.millis on 'rowtime as 'w)
>   .groupBy('w)
>   .select('int.count)
> util.verifyPlan(windowedTable)
>   }
> {code}
> currently, it's physical plan is 
> {code:java}
> HashWindowAggregate(window=[TumblingGroupWindow], 
> select=[Final_COUNT(count$0) AS EXPR$0])
> +- Exchange(distribution=[single])
>+- LocalHashWindowAggregate(window=[TumblingGroupWindow], 
> select=[Partial_COUNT(int) AS count$0])
>   +- TableSourceScan(table=[[default_catalog, default_database, Table1, 
> source: [TestTableSource(long, int, string)]]], fields=[long, int, string])
> {code}
> we know nothing about the TumblingGroupWindow except its name. the expected 
> plan is
> {code:java}
> HashWindowAggregate(window=[TumblingGroupWindow('w, long, 5)], 
> select=[Final_COUNT(count$0) AS EXPR$0])
> +- Exchange(distribution=[single])
>+- LocalHashWindowAggregate(window=[TumblingGroupWindow('w, long, 5)], 
> select=[Partial_COUNT(int) AS count$0])
>   +- TableSourceScan(table=[[default_catalog, default_database, Table1, 
> source: [TestTableSource(long, int, string)]]], fields=[long, int, string])
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Updated] (FLINK-13563) TumblingGroupWindow should implement toString method

[Tzu-Li (Gordon) Tai (JIRA)]

 [ 
https://issues.apache.org/jira/browse/FLINK-13563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tzu-Li (Gordon) Tai updated FLINK-13563:

Fix Version/s: (was: 1.9.0)

> TumblingGroupWindow should implement toString method
> 
>
> Key: FLINK-13563
> URL: https://issues.apache.org/jira/browse/FLINK-13563
> Project: Flink
>  Issue Type: Bug
>  Components: Table SQL / Planner
>Affects Versions: 1.9.0, 1.10.0
>Reporter: godfrey he
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> {code:scala}
>   @Test
>   def testAllEventTimeTumblingGroupWindowOverTime(): Unit = {
> val util = streamTestUtil()
> val table = util.addDataStream[(Long, Int, String)](
>   "T1", 'long, 'int, 'string, 'rowtime.rowtime)
> val windowedTable = table
>   .window(Tumble over 5.millis on 'rowtime as 'w)
>   .groupBy('w)
>   .select('int.count)
> util.verifyPlan(windowedTable)
>   }
> {code}
> currently, it's physical plan is 
> {code:java}
> HashWindowAggregate(window=[TumblingGroupWindow], 
> select=[Final_COUNT(count$0) AS EXPR$0])
> +- Exchange(distribution=[single])
>+- LocalHashWindowAggregate(window=[TumblingGroupWindow], 
> select=[Partial_COUNT(int) AS count$0])
>   +- TableSourceScan(table=[[default_catalog, default_database, Table1, 
> source: [TestTableSource(long, int, string)]]], fields=[long, int, string])
> {code}
> we know nothing about the TumblingGroupWindow except its name. the expected 
> plan is
> {code:java}
> HashWindowAggregate(window=[TumblingGroupWindow('w, long, 5)], 
> select=[Final_COUNT(count$0) AS EXPR$0])
> +- Exchange(distribution=[single])
>+- LocalHashWindowAggregate(window=[TumblingGroupWindow('w, long, 5)], 
> select=[Partial_COUNT(int) AS count$0])
>   +- TableSourceScan(table=[[default_catalog, default_database, Table1, 
> source: [TestTableSource(long, int, string)]]], fields=[long, int, string])
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Updated] (FLINK-13563) TumblingGroupWindow should implement toString method

[Kurt Young (JIRA)]

 [ 
https://issues.apache.org/jira/browse/FLINK-13563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kurt Young updated FLINK-13563:
---
Fix Version/s: (was: 1.10.0)

> TumblingGroupWindow should implement toString method
> 
>
> Key: FLINK-13563
> URL: https://issues.apache.org/jira/browse/FLINK-13563
> Project: Flink
>  Issue Type: Bug
>  Components: Table SQL / Planner
>Affects Versions: 1.9.0, 1.10.0
>Reporter: godfrey he
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.9.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> {code:scala}
>   @Test
>   def testAllEventTimeTumblingGroupWindowOverTime(): Unit = {
> val util = streamTestUtil()
> val table = util.addDataStream[(Long, Int, String)](
>   "T1", 'long, 'int, 'string, 'rowtime.rowtime)
> val windowedTable = table
>   .window(Tumble over 5.millis on 'rowtime as 'w)
>   .groupBy('w)
>   .select('int.count)
> util.verifyPlan(windowedTable)
>   }
> {code}
> currently, it's physical plan is 
> {code:java}
> HashWindowAggregate(window=[TumblingGroupWindow], 
> select=[Final_COUNT(count$0) AS EXPR$0])
> +- Exchange(distribution=[single])
>+- LocalHashWindowAggregate(window=[TumblingGroupWindow], 
> select=[Partial_COUNT(int) AS count$0])
>   +- TableSourceScan(table=[[default_catalog, default_database, Table1, 
> source: [TestTableSource(long, int, string)]]], fields=[long, int, string])
> {code}
> we know nothing about the TumblingGroupWindow except its name. the expected 
> plan is
> {code:java}
> HashWindowAggregate(window=[TumblingGroupWindow('w, long, 5)], 
> select=[Final_COUNT(count$0) AS EXPR$0])
> +- Exchange(distribution=[single])
>+- LocalHashWindowAggregate(window=[TumblingGroupWindow('w, long, 5)], 
> select=[Partial_COUNT(int) AS count$0])
>   +- TableSourceScan(table=[[default_catalog, default_database, Table1, 
> source: [TestTableSource(long, int, string)]]], fields=[long, int, string])
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Updated] (FLINK-13563) TumblingGroupWindow should implement toString method

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/FLINK-13563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated FLINK-13563:
---
Labels: pull-request-available  (was: )

> TumblingGroupWindow should implement toString method
> 
>
> Key: FLINK-13563
> URL: https://issues.apache.org/jira/browse/FLINK-13563
> Project: Flink
>  Issue Type: Bug
>  Components: Table SQL / Planner
>Affects Versions: 1.9.0, 1.10.0
>Reporter: godfrey he
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.9.0, 1.10.0
>
>
> {code:scala}
>   @Test
>   def testAllEventTimeTumblingGroupWindowOverTime(): Unit = {
> val util = streamTestUtil()
> val table = util.addDataStream[(Long, Int, String)](
>   "T1", 'long, 'int, 'string, 'rowtime.rowtime)
> val windowedTable = table
>   .window(Tumble over 5.millis on 'rowtime as 'w)
>   .groupBy('w)
>   .select('int.count)
> util.verifyPlan(windowedTable)
>   }
> {code}
> currently, it's physical plan is 
> {code:java}
> HashWindowAggregate(window=[TumblingGroupWindow], 
> select=[Final_COUNT(count$0) AS EXPR$0])
> +- Exchange(distribution=[single])
>+- LocalHashWindowAggregate(window=[TumblingGroupWindow], 
> select=[Partial_COUNT(int) AS count$0])
>   +- TableSourceScan(table=[[default_catalog, default_database, Table1, 
> source: [TestTableSource(long, int, string)]]], fields=[long, int, string])
> {code}
> we know nothing about the TumblingGroupWindow except its name. the expected 
> plan is
> {code:java}
> HashWindowAggregate(window=[TumblingGroupWindow('w, long, 5)], 
> select=[Final_COUNT(count$0) AS EXPR$0])
> +- Exchange(distribution=[single])
>+- LocalHashWindowAggregate(window=[TumblingGroupWindow('w, long, 5)], 
> select=[Partial_COUNT(int) AS count$0])
>   +- TableSourceScan(table=[[default_catalog, default_database, Table1, 
> source: [TestTableSource(long, int, string)]]], fields=[long, int, string])
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Updated] (FLINK-13563) TumblingGroupWindow should implement toString method

[godfrey he (JIRA)]

 [ 
https://issues.apache.org/jira/browse/FLINK-13563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

godfrey he updated FLINK-13563:
---
Description: 
{code:scala}
  @Test
  def testAllEventTimeTumblingGroupWindowOverTime(): Unit = {
val util = streamTestUtil()
val table = util.addDataStream[(Long, Int, String)](
  "T1", 'long, 'int, 'string, 'rowtime.rowtime)

val windowedTable = table
  .window(Tumble over 5.millis on 'rowtime as 'w)
  .groupBy('w)
  .select('int.count)
util.verifyPlan(windowedTable)
  }
{code}

currently, it's physical plan is 

{code:java}
HashWindowAggregate(window=[TumblingGroupWindow], select=[Final_COUNT(count$0) 
AS EXPR$0])
+- Exchange(distribution=[single])
   +- LocalHashWindowAggregate(window=[TumblingGroupWindow], 
select=[Partial_COUNT(int) AS count$0])
  +- TableSourceScan(table=[[default_catalog, default_database, Table1, 
source: [TestTableSource(long, int, string)]]], fields=[long, int, string])
{code}

we know nothing about the TumblingGroupWindow except its name. the expected 
plan is

{code:java}
HashWindowAggregate(window=[TumblingGroupWindow('w, long, 5)], 
select=[Final_COUNT(count$0) AS EXPR$0])
+- Exchange(distribution=[single])
   +- LocalHashWindowAggregate(window=[TumblingGroupWindow('w, long, 5)], 
select=[Partial_COUNT(int) AS count$0])
  +- TableSourceScan(table=[[default_catalog, default_database, Table1, 
source: [TestTableSource(long, int, string)]]], fields=[long, int, string])

{code}



  was:
{code:scala}
  @Test
  def testAllEventTimeTumblingGroupWindowOverTime(): Unit = {
val util = streamTestUtil()
val table = util.addDataStream[(Long, Int, String)](
  "T1", 'long, 'int, 'string, 'rowtime.rowtime)

val windowedTable = table
  .window(Tumble over 5.millis on 'rowtime as 'w)
  .groupBy('w)
  .select('int.count)
util.verifyPlan(windowedTable)
  }
{code}

currently, it's physical plan is 

{code:java}
HashWindowAggregate(window=[TumblingGroupWindow], select=[Final_COUNT(count$0) 
AS EXPR$0])
+- Exchange(distribution=[single])
   +- LocalHashWindowAggregate(window=[TumblingGroupWindow], 
select=[Partial_COUNT(int) AS count$0])
  +- TableSourceScan(table=[[default_catalog, default_database, Table1, 
source: [TestTableSource(long, int, string)]]], fields=[long, int, string])
{code}

we know nothing about the TumblingGroupWindow except its name



> TumblingGroupWindow should implement toString method
> 
>
> Key: FLINK-13563
> URL: https://issues.apache.org/jira/browse/FLINK-13563
> Project: Flink
>  Issue Type: Bug
>  Components: Table SQL / Planner
>Affects Versions: 1.9.0, 1.10.0
>Reporter: godfrey he
>Priority: Major
> Fix For: 1.9.0, 1.10.0
>
>
> {code:scala}
>   @Test
>   def testAllEventTimeTumblingGroupWindowOverTime(): Unit = {
> val util = streamTestUtil()
> val table = util.addDataStream[(Long, Int, String)](
>   "T1", 'long, 'int, 'string, 'rowtime.rowtime)
> val windowedTable = table
>   .window(Tumble over 5.millis on 'rowtime as 'w)
>   .groupBy('w)
>   .select('int.count)
> util.verifyPlan(windowedTable)
>   }
> {code}
> currently, it's physical plan is 
> {code:java}
> HashWindowAggregate(window=[TumblingGroupWindow], 
> select=[Final_COUNT(count$0) AS EXPR$0])
> +- Exchange(distribution=[single])
>+- LocalHashWindowAggregate(window=[TumblingGroupWindow], 
> select=[Partial_COUNT(int) AS count$0])
>   +- TableSourceScan(table=[[default_catalog, default_database, Table1, 
> source: [TestTableSource(long, int, string)]]], fields=[long, int, string])
> {code}
> we know nothing about the TumblingGroupWindow except its name. the expected 
> plan is
> {code:java}
> HashWindowAggregate(window=[TumblingGroupWindow('w, long, 5)], 
> select=[Final_COUNT(count$0) AS EXPR$0])
> +- Exchange(distribution=[single])
>+- LocalHashWindowAggregate(window=[TumblingGroupWindow('w, long, 5)], 
> select=[Partial_COUNT(int) AS count$0])
>   +- TableSourceScan(table=[[default_catalog, default_database, Table1, 
> source: [TestTableSource(long, int, string)]]], fields=[long, int, string])
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)