Re: [PR] [FLINK-35039][rest] Use PUT method supported by YARN web proxy instead of POST [flink]
yeezychao commented on PR #24689: URL: https://github.com/apache/flink/pull/24689#issuecomment-2084432438 Hi @yuchen-ecnu, I agreee with you,so I created issues [YARN-11691](https://issues.apache.org/jira/browse/YARN-11691) to the YARN community. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35039][rest] Use PUT method supported by YARN web proxy instead of POST [flink]
yuchen-ecnu commented on PR #24689: URL: https://github.com/apache/flink/pull/24689#issuecomment-2084282176 Hi @yeezychao , sorry for the late response. It's not enough to just change the request type on the front end, you also need to modify the type of the corresponding REST interface on the JobManager side (e.g., `org.apache.flink.runtime.rest.messages.cluster.JobManagerProfilingHeaders# getHttpMethod`). In addition, in Standalone Cluster, you can validate your changes in Postman by referring to the request shown below. (I think POST 400 because you missed the request parameters, which contain the necessary arguments: profiling type and duration) https://github.com/apache/flink/assets/19743175/201bd043-374d-448d-bd14-c34d069bdba4;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35039][rest] Use PUT method supported by YARN web proxy instead of POST [flink]
Myasuka commented on PR #24689: URL: https://github.com/apache/flink/pull/24689#issuecomment-2082294994 @yeezychao from many tests, we can use this profiling feature in a standalone cluster on local Mac. If the Flink cluster cannot be profiled after merging your PR, I think this introduced such an obvious regression. I will also try to test your PR later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35039][rest] Use PUT method supported by YARN web proxy instead of POST [flink]
yeezychao commented on PR #24689:
URL: https://github.com/apache/flink/pull/24689#issuecomment-2081417257
Hi @Myasuka ,I understand what you mean.I tested.
If use PUT method, Return 404 error.
If use POST method, Return 400 Bad Request.
https://github.com/apache/flink/assets/18387619/77604546-a820-4108-a105-91d5458376f1;>
https://github.com/apache/flink/assets/18387619/a1c5a37d-e93f-4c44-b9cc-ccbdfb3fd03f;>
`{
"errors": [
"org.apache.flink.runtime.rest.handler.RestHandlerException: Bad
request received. Request did not conform to expected format.\n\tat
org.apache.flink.runtime.rest.handler.AbstractHandler.respondAsLeader(AbstractHandler.java:154)\n\tat
org.apache.flink.runtime.rest.handler.LeaderRetrievalHandler.lambda$channelRead0$0(LeaderRetrievalHandler.java:88)\n\tat
java.util.Optional.ifPresent(Optional.java:159)\n\tat
org.apache.flink.util.OptionalConsumer.ifPresent(OptionalConsumer.java:45)\n\tat
org.apache.flink.runtime.rest.handler.LeaderRetrievalHandler.channelRead0(LeaderRetrievalHandler.java:85)\n\tat
org.apache.flink.runtime.rest.handler.LeaderRetrievalHandler.channelRead0(LeaderRetrievalHandler.java:50)\n\tat
org.apache.flink.shaded.netty4.io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:99)\n\tat
org.apache.flink.shaded.netty4.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444)\n\tat
org.apache.flink.shaded.netty4.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420)\n\tat
org.apache.flink.shaded.netty4.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412)\n\tat
org.apache.flink.runtime.rest.handler.router.RouterHandler.routed(RouterHandler.java:115)\n\tat
org.apache.flink.runtime.rest.handler.router.RouterHandler.channelRead0(RouterHandler.java:94)\n\tat
org.apache.flink.runtime.rest.handler.router.RouterHandler.channelRead0(RouterHandler.java:55)\n\tat
org.apache.flink.shaded.netty4.io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:99)\n\tat
org.apache.flink.shaded.netty4.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444)\n\tat
org.apache.flink.shaded.netty4.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420)\n\tat
o
rg.apache.flink.shaded.netty4.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412)\n\tat
org.apache.flink.shaded.netty4.io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103)\n\tat
org.apache.flink.shaded.netty4.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444)\n\tat
org.apache.flink.shaded.netty4.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420)\n\tat
org.apache.flink.shaded.netty4.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412)\n\tat
org.apache.flink.runtime.rest.FileUploadHandler.channelRead0(FileUploadHandler.java:208)\n\tat
org.apache.flink.runtime.rest.FileUploadHandler.channelRead0(FileUploadHandler.java:69)\n\tat
org.apache.flink.shaded.netty4.io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler
.java:99)\n\tat
org.apache.flink.shaded.netty4.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444)\n\tat
org.apache.flink.shaded.netty4.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420)\n\tat
org.apache.flink.shaded.netty4.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412)\n\tat
org.apache.flink.shaded.netty4.io.netty.channel.CombinedChannelDuplexHandler$DelegatingChannelHandlerContext.fireChannelRead(CombinedChannelDuplexHandler.java:436)\n\tat
org.apache.flink.shaded.netty4.io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:346)\n\tat
org.apache.flink.shaded.netty4.io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:318)\n\tat
org.apache.flink.shaded.netty4.io.netty.channel.CombinedChannelDuplexHandler.channelRead(CombinedChannelDuplexHandler.java:251)\n\tat
o
rg.apache.flink.shaded.netty4.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:442)\n\tat
org.apache.flink.shaded.netty4.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420)\n\tat
org.apache.flink.shaded.netty4.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412)\n\tat
Re: [PR] [FLINK-35039][rest] Use PUT method supported by YARN web proxy instead of POST [flink]
Myasuka commented on PR #24689: URL: https://github.com/apache/flink/pull/24689#issuecomment-2081350154 @yeezychao You can refer to [FLINK-34310](https://issues.apache.org/jira/browse/FLINK-34310) to launch [a local standalone Flink cluster](https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/resource-providers/standalone/overview/) (not a YARN cluster) to see whether this could still work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35039][rest] Use PUT method supported by YARN web proxy instead of POST [flink]
yeezychao commented on PR #24689: URL: https://github.com/apache/flink/pull/24689#issuecomment-2081342644 @Myasuka Sorry, I still don't understand what you mean, what do I need to do. Because I tested the standalone cluster locally and could not use the **async-profiler**. Is there any relevant documentation for the **self-profiling** you mentioned? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35039][rest] Use PUT method supported by YARN web proxy instead of POST [flink]
Myasuka commented on PR #24689: URL: https://github.com/apache/flink/pull/24689#issuecomment-2081310552 > @Myasuka Thx u for your reply. Maybe we can create a new Jira to discuss how to works in standalone env. Can you review this pr first？ Flink already supports self-profiling in standalone cluster, and we should also support this after your fix merged to avoid regression. That's why I asked how it does with your patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35039][rest] Use PUT method supported by YARN web proxy instead of POST [flink]
yeezychao commented on PR #24689: URL: https://github.com/apache/flink/pull/24689#issuecomment-2078737494 @Myasuka PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35039][rest] Use PUT method supported by YARN web proxy instead of POST [flink]
yeezychao commented on PR #24689: URL: https://github.com/apache/flink/pull/24689#issuecomment-2068868982 @Myasuka Thx u for your reply. Maybe we can create a new Jira to discuss how to works in standalone env. Can you review this pr first？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35039][rest] Use PUT method supported by YARN web proxy instead of POST [flink]
Myasuka commented on PR #24689: URL: https://github.com/apache/flink/pull/24689#issuecomment-2066319875 @yeezychao Can your solution also works in standalone environment? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35039][rest] Use PUT method supported by YARN web proxy instead of POST [flink]
flinkbot commented on PR #24689: URL: https://github.com/apache/flink/pull/24689#issuecomment-2066235806 ## CI report: * 5179e513e55a60de15d50b32497442d432cf051b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
