Re: [PR] [FLINK-38996][transform] Enhance error messages for projection and filtering expressions [flink-cdc]
yuxiqian merged PR #4243: URL: https://github.com/apache/flink-cdc/pull/4243 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [FLINK-38996][transform] Enhance error messages for projection and filtering expressions [flink-cdc]
yuxiqian commented on code in PR #4243:
URL: https://github.com/apache/flink-cdc/pull/4243#discussion_r2745378958
##
flink-cdc-composer/src/test/java/org/apache/flink/cdc/composer/flink/FlinkPipelineTransformITCase.java:
##
@@ -2808,7 +2808,10 @@ void testTransformErrorMessage() {
.cause()
.isExactlyInstanceOf(RuntimeException.class)
.hasMessageContaining(
-"Failed to evaluate filtering expression
`greaterThan($0 + 1, 0)` for table `default_namespace.default_schema.mytable1`")
+"Failed to evaluate filtering expression for table
`default_namespace.default_schema.mytable1`.\n"
++ "\tOriginal expression: name + 1 > 0\n"
++ "\tCompiled expression: greaterThan($0 + 1,
0)\n"
++ "\tColumn name map: {$0 -> name}")
.hasMessageContaining("Column name map: {$0 -> name}")
Review Comment:
True, but not a major problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] [FLINK-38996][transform] Enhance error messages for projection and filtering expressions [flink-cdc]
lvyanquan commented on PR #4243: URL: https://github.com/apache/flink-cdc/pull/4243#issuecomment-3822615974 Hi @yuxiqian, maybe you can help to review this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [FLINK-38996][transform] Enhance error messages for projection and filtering expressions [flink-cdc]
Copilot commented on code in PR #4243:
URL: https://github.com/apache/flink-cdc/pull/4243#discussion_r2745263292
##
flink-cdc-composer/src/test/java/org/apache/flink/cdc/composer/flink/FlinkPipelineTransformITCase.java:
##
@@ -2808,7 +2808,10 @@ void testTransformErrorMessage() {
.cause()
.isExactlyInstanceOf(RuntimeException.class)
.hasMessageContaining(
-"Failed to evaluate filtering expression
`greaterThan($0 + 1, 0)` for table `default_namespace.default_schema.mytable1`")
+"Failed to evaluate filtering expression for table
`default_namespace.default_schema.mytable1`.\n"
++ "\tOriginal expression: name + 1 > 0\n"
++ "\tCompiled expression: greaterThan($0 + 1,
0)\n"
++ "\tColumn name map: {$0 -> name}")
.hasMessageContaining("Column name map: {$0 -> name}")
Review Comment:
This assertion is redundant as the column name map is already verified as
part of the full message assertion on lines 2810-2814. The
`.hasMessageContaining("Column name map: {$0 -> name}")` check duplicates what
was already asserted in the complete error message.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] [FLINK-38996][transform] Enhance error messages for projection and filtering expressions [flink-cdc]
Hisoka-X commented on PR #4243: URL: https://github.com/apache/flink-cdc/pull/4243#issuecomment-3822096649 > Hi @Hisoka-X, you may need to rebase master to fix confilct. done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [FLINK-38996][transform] Enhance error messages for projection and filtering expressions [flink-cdc]
lvyanquan commented on PR #4243: URL: https://github.com/apache/flink-cdc/pull/4243#issuecomment-3822040453 Hi @Hisoka-X, you may need to rebase master to fix confilct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
