Re: [PR] [MINOR] Update starrocks.md [flink-cdc]
lvyanquan merged PR #4304: URL: https://github.com/apache/flink-cdc/pull/4304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [MINOR] Update starrocks.md [flink-cdc]
ThorneANN commented on code in PR #4304: URL: https://github.com/apache/flink-cdc/pull/4304#discussion_r2902914541 ## docs/content.zh/docs/connectors/pipeline-connectors/starrocks.md: ## @@ -240,7 +240,7 @@ pipeline: 自动设置分桶数量。对于 StarRocks 2.5 之前的版本必须设置，否则无法自动创建表。 * 对于表结构变更同步 - * 只支持增删列 + * 支持创建/删除/清空表、增加/删除/重命名列、修改列类型 Review Comment: 支持创建/删除/清空表，增加/删除/重命名列、修改列类型 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [MINOR] Update starrocks.md [flink-cdc]
ThorneANN commented on code in PR #4304: URL: https://github.com/apache/flink-cdc/pull/4304#discussion_r2902911803 ## docs/content.zh/docs/connectors/pipeline-connectors/starrocks.md: ## @@ -240,7 +240,7 @@ pipeline: 自动设置分桶数量。对于 StarRocks 2.5 之前的版本必须设置，否则无法自动创建表。 * 对于表结构变更同步 - * 只支持增删列 + * 支持创建/删除/清空表、增加/删除/重命名列、修改列类型 Review Comment: May be we use `，` symbol instand of `、` symbol to distinguish actions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [MINOR] Update starrocks.md [flink-cdc]
ThorneANN commented on PR #4304: URL: https://github.com/apache/flink-cdc/pull/4304#issuecomment-4020705867 > > can u see this ? > > It's in a pending state; you haven't submitted it. Sorry and i submit it now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [MINOR] Update starrocks.md [flink-cdc]
ThorneANN commented on code in PR #4304: URL: https://github.com/apache/flink-cdc/pull/4304#discussion_r2894572780 ## docs/content.zh/docs/connectors/pipeline-connectors/starrocks.md: ## @@ -240,7 +240,7 @@ pipeline: 自动设置分桶数量。对于 StarRocks 2.5 之前的版本必须设置，否则无法自动创建表。 * 对于表结构变更同步 - * 只支持增删列 + * 支持创建删除清空表、增删重命名列、修改列类型 Review Comment: Perhaps we should use '/' to distinguish each behavior ## docs/content.zh/docs/connectors/pipeline-connectors/starrocks.md: ## @@ -240,7 +240,7 @@ pipeline: 自动设置分桶数量。对于 StarRocks 2.5 之前的版本必须设置，否则无法自动创建表。 * 对于表结构变更同步 - * 只支持增删列 + * 支持创建删除清空表、增删重命名列、修改列类型 Review Comment: @zml1206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [MINOR] Update starrocks.md [flink-cdc]
zml1206 commented on PR #4304: URL: https://github.com/apache/flink-cdc/pull/4304#issuecomment-4020702044 > can u see this ? It's in a pending state; you haven't submitted it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [MINOR] Update starrocks.md [flink-cdc]
ThorneANN commented on PR #4304: URL: https://github.com/apache/flink-cdc/pull/4304#issuecomment-4020695996 > @ThorneANN Thank you, I didn't see the comments. can u see this ? https://github.com/user-attachments/assets/bc5697cf-a27e-44fb-9564-8bb721026aa1"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [MINOR] Update starrocks.md [flink-cdc]
zml1206 commented on PR #4304: URL: https://github.com/apache/flink-cdc/pull/4304#issuecomment-4020658358 @ThorneANN Thank you, I didn't see the comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [MINOR] Update starrocks.md [flink-cdc]
ThorneANN commented on PR #4304: URL: https://github.com/apache/flink-cdc/pull/4304#issuecomment-4010396911 Thank for your contribution and i left some comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
