[jira] [Assigned] (GEODE-1798) Dead code in transaction layer confusing
[ https://issues.apache.org/jira/browse/GEODE-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Rhomberg reassigned GEODE-1798: --- Assignee: (was: Patrick Rhomberg) > Dead code in transaction layer confusing > > > Key: GEODE-1798 > URL: https://issues.apache.org/jira/browse/GEODE-1798 > Project: Geode > Issue Type: Improvement > Components: transactions >Reporter: Darrel Schneider >Priority: Major > > In geode the transaction code always has a collection of "pendingCallbacks". > But the code makes some special calls if this collection is null. This code > should be cleaned up to only handle an existing collection. > Also BucketRegion has an implementation of invokeTXCallbacks that is wrong. > If it ever is called it will cause extra events. But it should never be > invoked since pendingCallbacks is never null. Instead > PartitionedRegion.invokeTXCallbacks will be invoked. > So the implementation of BucketRegion invokeTXCallbacks should be changed to > throw an exception. If tests find any code paths that call it they should be > changed to instead call PartitionedRegion. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (GEODE-1798) Dead code in transaction layer confusing
[ https://issues.apache.org/jira/browse/GEODE-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Rhomberg reassigned GEODE-1798: --- Assignee: Patrick Rhomberg > Dead code in transaction layer confusing > > > Key: GEODE-1798 > URL: https://issues.apache.org/jira/browse/GEODE-1798 > Project: Geode > Issue Type: Improvement > Components: transactions >Reporter: Darrel Schneider >Assignee: Patrick Rhomberg >Priority: Major > > In geode the transaction code always has a collection of "pendingCallbacks". > But the code makes some special calls if this collection is null. This code > should be cleaned up to only handle an existing collection. > Also BucketRegion has an implementation of invokeTXCallbacks that is wrong. > If it ever is called it will cause extra events. But it should never be > invoked since pendingCallbacks is never null. Instead > PartitionedRegion.invokeTXCallbacks will be invoked. > So the implementation of BucketRegion invokeTXCallbacks should be changed to > throw an exception. If tests find any code paths that call it they should be > changed to instead call PartitionedRegion. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
