[jira] [Commented] (GEODE-1653) Executing a fire-and-forget function on all servers doesn't actually execute on all servers
[ https://issues.apache.org/jira/browse/GEODE-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15713695#comment-15713695 ] ASF subversion and git services commented on GEODE-1653: Commit c61028966d51db436e75ba228465767cb1a0bd21 in incubator-geode's branch refs/heads/feature/GEODE-2156 from [~abarve] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=c610289 ] This closes #293 GEODE-1653: Added helper method getAllServers in ExecuteFunctionNoAckOp to get all available servers, instead executing Fire and Forget only on the ones the client is currently connected to. GEODE-1653: Dunit test for Executing a fire-and-forget function on all servers as opposed to only executing on the ones the client is currently connected to. GEODE-1653: changes after spotlessApply. GEODE-1653: 1. renamed test file to FireAndForgetFunctionOnAllServersDUnitTest and test to testFireAndForgetFunctionOnAllServers 2. replaced thread sleep with waitUntilDeterministic function before verifying results after Fire and Forget Function execution 3. removed commented testServerSingleKeyExecution_Bug43513_OnServer test. GEODE-1653: Replacing Thread's sleep with Awatility, if the condition is not met during the timeout, a ConditionTimeoutException will be thrown. This makes analyzing the failure much simpler. GEODE-1653: Use a larger timeout value such as 60 seconds to prevent test from failing on slower machines or garbage collection during the test. GEODE-1653: 1. Code changes a. Added getAllServers() method to connection source, and converted AutoConnectionSourceImpl's findAllServers logic into it. b. Made relevant changes to both ExecuteFunctionNoAckOp and ExecuteFunctionOp classes 2. Test changes a. removed author tag in the test. b. created a new function (FireAndForgetFunctionOnAllServers) for test and removed it from TestFunction. c. test change about awaitility and actual assertion. d. asserted for pool's current server size after starting a new server and stopping existing server. GEODE-1653: Adding missed out file for FireAndForgetFunctionOnAllServers function. GEODE-1653: Adding @Override to ExplicitConnectionSourceImpl's getAllServers() method. GEODE-1653: fix the test code to double check the getCurrentServer only returns 1 server > Executing a fire-and-forget function on all servers doesn't actually execute > on all servers > --- > > Key: GEODE-1653 > URL: https://issues.apache.org/jira/browse/GEODE-1653 > Project: Geode > Issue Type: Bug > Components: functions >Reporter: Barry Oglesby >Assignee: Amey Barve > > Executing a fire-and-forget function on all servers only executes on the ones > the client is currently connected to. > The two {{ExecuteFunctionNoAckOp execute}} methods get the servers to execute > against using code like: > {noformat} > pool.getCurrentServers(); > {noformat} > This method just gets all the {{EndpointManager's endpointMap's > ServerLocations}}. > What should be done is more like what the {{ExecuteFunctionOp execute}} > methods do: > {noformat} > private static List getAllServers(PoolImpl pool) { > List servers = null; > if (pool.getLocators() == null || pool.getLocators().isEmpty()) { > servers = ((ExplicitConnectionSourceImpl) > pool.getConnectionSource()).getAllServers(); > } else { > servers = ((AutoConnectionSourceImpl) > pool.getConnectionSource()).findAllServers(); // n/w call on locator > } > return servers; > } > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1653) Executing a fire-and-forget function on all servers doesn't actually execute on all servers
[ https://issues.apache.org/jira/browse/GEODE-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15713693#comment-15713693 ] ASF subversion and git services commented on GEODE-1653: Commit c61028966d51db436e75ba228465767cb1a0bd21 in incubator-geode's branch refs/heads/feature/GEODE-2156 from [~abarve] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=c610289 ] This closes #293 GEODE-1653: Added helper method getAllServers in ExecuteFunctionNoAckOp to get all available servers, instead executing Fire and Forget only on the ones the client is currently connected to. GEODE-1653: Dunit test for Executing a fire-and-forget function on all servers as opposed to only executing on the ones the client is currently connected to. GEODE-1653: changes after spotlessApply. GEODE-1653: 1. renamed test file to FireAndForgetFunctionOnAllServersDUnitTest and test to testFireAndForgetFunctionOnAllServers 2. replaced thread sleep with waitUntilDeterministic function before verifying results after Fire and Forget Function execution 3. removed commented testServerSingleKeyExecution_Bug43513_OnServer test. GEODE-1653: Replacing Thread's sleep with Awatility, if the condition is not met during the timeout, a ConditionTimeoutException will be thrown. This makes analyzing the failure much simpler. GEODE-1653: Use a larger timeout value such as 60 seconds to prevent test from failing on slower machines or garbage collection during the test. GEODE-1653: 1. Code changes a. Added getAllServers() method to connection source, and converted AutoConnectionSourceImpl's findAllServers logic into it. b. Made relevant changes to both ExecuteFunctionNoAckOp and ExecuteFunctionOp classes 2. Test changes a. removed author tag in the test. b. created a new function (FireAndForgetFunctionOnAllServers) for test and removed it from TestFunction. c. test change about awaitility and actual assertion. d. asserted for pool's current server size after starting a new server and stopping existing server. GEODE-1653: Adding missed out file for FireAndForgetFunctionOnAllServers function. GEODE-1653: Adding @Override to ExplicitConnectionSourceImpl's getAllServers() method. GEODE-1653: fix the test code to double check the getCurrentServer only returns 1 server > Executing a fire-and-forget function on all servers doesn't actually execute > on all servers > --- > > Key: GEODE-1653 > URL: https://issues.apache.org/jira/browse/GEODE-1653 > Project: Geode > Issue Type: Bug > Components: functions >Reporter: Barry Oglesby >Assignee: Amey Barve > > Executing a fire-and-forget function on all servers only executes on the ones > the client is currently connected to. > The two {{ExecuteFunctionNoAckOp execute}} methods get the servers to execute > against using code like: > {noformat} > pool.getCurrentServers(); > {noformat} > This method just gets all the {{EndpointManager's endpointMap's > ServerLocations}}. > What should be done is more like what the {{ExecuteFunctionOp execute}} > methods do: > {noformat} > private static List getAllServers(PoolImpl pool) { > List servers = null; > if (pool.getLocators() == null || pool.getLocators().isEmpty()) { > servers = ((ExplicitConnectionSourceImpl) > pool.getConnectionSource()).getAllServers(); > } else { > servers = ((AutoConnectionSourceImpl) > pool.getConnectionSource()).findAllServers(); // n/w call on locator > } > return servers; > } > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1653) Executing a fire-and-forget function on all servers doesn't actually execute on all servers
[ https://issues.apache.org/jira/browse/GEODE-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15713690#comment-15713690 ] ASF subversion and git services commented on GEODE-1653: Commit c61028966d51db436e75ba228465767cb1a0bd21 in incubator-geode's branch refs/heads/feature/GEODE-2156 from [~abarve] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=c610289 ] This closes #293 GEODE-1653: Added helper method getAllServers in ExecuteFunctionNoAckOp to get all available servers, instead executing Fire and Forget only on the ones the client is currently connected to. GEODE-1653: Dunit test for Executing a fire-and-forget function on all servers as opposed to only executing on the ones the client is currently connected to. GEODE-1653: changes after spotlessApply. GEODE-1653: 1. renamed test file to FireAndForgetFunctionOnAllServersDUnitTest and test to testFireAndForgetFunctionOnAllServers 2. replaced thread sleep with waitUntilDeterministic function before verifying results after Fire and Forget Function execution 3. removed commented testServerSingleKeyExecution_Bug43513_OnServer test. GEODE-1653: Replacing Thread's sleep with Awatility, if the condition is not met during the timeout, a ConditionTimeoutException will be thrown. This makes analyzing the failure much simpler. GEODE-1653: Use a larger timeout value such as 60 seconds to prevent test from failing on slower machines or garbage collection during the test. GEODE-1653: 1. Code changes a. Added getAllServers() method to connection source, and converted AutoConnectionSourceImpl's findAllServers logic into it. b. Made relevant changes to both ExecuteFunctionNoAckOp and ExecuteFunctionOp classes 2. Test changes a. removed author tag in the test. b. created a new function (FireAndForgetFunctionOnAllServers) for test and removed it from TestFunction. c. test change about awaitility and actual assertion. d. asserted for pool's current server size after starting a new server and stopping existing server. GEODE-1653: Adding missed out file for FireAndForgetFunctionOnAllServers function. GEODE-1653: Adding @Override to ExplicitConnectionSourceImpl's getAllServers() method. GEODE-1653: fix the test code to double check the getCurrentServer only returns 1 server > Executing a fire-and-forget function on all servers doesn't actually execute > on all servers > --- > > Key: GEODE-1653 > URL: https://issues.apache.org/jira/browse/GEODE-1653 > Project: Geode > Issue Type: Bug > Components: functions >Reporter: Barry Oglesby >Assignee: Amey Barve > > Executing a fire-and-forget function on all servers only executes on the ones > the client is currently connected to. > The two {{ExecuteFunctionNoAckOp execute}} methods get the servers to execute > against using code like: > {noformat} > pool.getCurrentServers(); > {noformat} > This method just gets all the {{EndpointManager's endpointMap's > ServerLocations}}. > What should be done is more like what the {{ExecuteFunctionOp execute}} > methods do: > {noformat} > private static List getAllServers(PoolImpl pool) { > List servers = null; > if (pool.getLocators() == null || pool.getLocators().isEmpty()) { > servers = ((ExplicitConnectionSourceImpl) > pool.getConnectionSource()).getAllServers(); > } else { > servers = ((AutoConnectionSourceImpl) > pool.getConnectionSource()).findAllServers(); // n/w call on locator > } > return servers; > } > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1653) Executing a fire-and-forget function on all servers doesn't actually execute on all servers
[ https://issues.apache.org/jira/browse/GEODE-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15713531#comment-15713531 ] ASF subversion and git services commented on GEODE-1653: Commit c61028966d51db436e75ba228465767cb1a0bd21 in incubator-geode's branch refs/heads/develop from [~abarve] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=c610289 ] This closes #293 GEODE-1653: Added helper method getAllServers in ExecuteFunctionNoAckOp to get all available servers, instead executing Fire and Forget only on the ones the client is currently connected to. GEODE-1653: Dunit test for Executing a fire-and-forget function on all servers as opposed to only executing on the ones the client is currently connected to. GEODE-1653: changes after spotlessApply. GEODE-1653: 1. renamed test file to FireAndForgetFunctionOnAllServersDUnitTest and test to testFireAndForgetFunctionOnAllServers 2. replaced thread sleep with waitUntilDeterministic function before verifying results after Fire and Forget Function execution 3. removed commented testServerSingleKeyExecution_Bug43513_OnServer test. GEODE-1653: Replacing Thread's sleep with Awatility, if the condition is not met during the timeout, a ConditionTimeoutException will be thrown. This makes analyzing the failure much simpler. GEODE-1653: Use a larger timeout value such as 60 seconds to prevent test from failing on slower machines or garbage collection during the test. GEODE-1653: 1. Code changes a. Added getAllServers() method to connection source, and converted AutoConnectionSourceImpl's findAllServers logic into it. b. Made relevant changes to both ExecuteFunctionNoAckOp and ExecuteFunctionOp classes 2. Test changes a. removed author tag in the test. b. created a new function (FireAndForgetFunctionOnAllServers) for test and removed it from TestFunction. c. test change about awaitility and actual assertion. d. asserted for pool's current server size after starting a new server and stopping existing server. GEODE-1653: Adding missed out file for FireAndForgetFunctionOnAllServers function. GEODE-1653: Adding @Override to ExplicitConnectionSourceImpl's getAllServers() method. GEODE-1653: fix the test code to double check the getCurrentServer only returns 1 server > Executing a fire-and-forget function on all servers doesn't actually execute > on all servers > --- > > Key: GEODE-1653 > URL: https://issues.apache.org/jira/browse/GEODE-1653 > Project: Geode > Issue Type: Bug > Components: functions >Reporter: Barry Oglesby >Assignee: Amey Barve > > Executing a fire-and-forget function on all servers only executes on the ones > the client is currently connected to. > The two {{ExecuteFunctionNoAckOp execute}} methods get the servers to execute > against using code like: > {noformat} > pool.getCurrentServers(); > {noformat} > This method just gets all the {{EndpointManager's endpointMap's > ServerLocations}}. > What should be done is more like what the {{ExecuteFunctionOp execute}} > methods do: > {noformat} > private static List getAllServers(PoolImpl pool) { > List servers = null; > if (pool.getLocators() == null || pool.getLocators().isEmpty()) { > servers = ((ExplicitConnectionSourceImpl) > pool.getConnectionSource()).getAllServers(); > } else { > servers = ((AutoConnectionSourceImpl) > pool.getConnectionSource()).findAllServers(); // n/w call on locator > } > return servers; > } > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1653) Executing a fire-and-forget function on all servers doesn't actually execute on all servers
[ https://issues.apache.org/jira/browse/GEODE-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15713528#comment-15713528 ] ASF subversion and git services commented on GEODE-1653: Commit c61028966d51db436e75ba228465767cb1a0bd21 in incubator-geode's branch refs/heads/develop from [~abarve] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=c610289 ] This closes #293 GEODE-1653: Added helper method getAllServers in ExecuteFunctionNoAckOp to get all available servers, instead executing Fire and Forget only on the ones the client is currently connected to. GEODE-1653: Dunit test for Executing a fire-and-forget function on all servers as opposed to only executing on the ones the client is currently connected to. GEODE-1653: changes after spotlessApply. GEODE-1653: 1. renamed test file to FireAndForgetFunctionOnAllServersDUnitTest and test to testFireAndForgetFunctionOnAllServers 2. replaced thread sleep with waitUntilDeterministic function before verifying results after Fire and Forget Function execution 3. removed commented testServerSingleKeyExecution_Bug43513_OnServer test. GEODE-1653: Replacing Thread's sleep with Awatility, if the condition is not met during the timeout, a ConditionTimeoutException will be thrown. This makes analyzing the failure much simpler. GEODE-1653: Use a larger timeout value such as 60 seconds to prevent test from failing on slower machines or garbage collection during the test. GEODE-1653: 1. Code changes a. Added getAllServers() method to connection source, and converted AutoConnectionSourceImpl's findAllServers logic into it. b. Made relevant changes to both ExecuteFunctionNoAckOp and ExecuteFunctionOp classes 2. Test changes a. removed author tag in the test. b. created a new function (FireAndForgetFunctionOnAllServers) for test and removed it from TestFunction. c. test change about awaitility and actual assertion. d. asserted for pool's current server size after starting a new server and stopping existing server. GEODE-1653: Adding missed out file for FireAndForgetFunctionOnAllServers function. GEODE-1653: Adding @Override to ExplicitConnectionSourceImpl's getAllServers() method. GEODE-1653: fix the test code to double check the getCurrentServer only returns 1 server > Executing a fire-and-forget function on all servers doesn't actually execute > on all servers > --- > > Key: GEODE-1653 > URL: https://issues.apache.org/jira/browse/GEODE-1653 > Project: Geode > Issue Type: Bug > Components: functions >Reporter: Barry Oglesby >Assignee: Amey Barve > > Executing a fire-and-forget function on all servers only executes on the ones > the client is currently connected to. > The two {{ExecuteFunctionNoAckOp execute}} methods get the servers to execute > against using code like: > {noformat} > pool.getCurrentServers(); > {noformat} > This method just gets all the {{EndpointManager's endpointMap's > ServerLocations}}. > What should be done is more like what the {{ExecuteFunctionOp execute}} > methods do: > {noformat} > private static List getAllServers(PoolImpl pool) { > List servers = null; > if (pool.getLocators() == null || pool.getLocators().isEmpty()) { > servers = ((ExplicitConnectionSourceImpl) > pool.getConnectionSource()).getAllServers(); > } else { > servers = ((AutoConnectionSourceImpl) > pool.getConnectionSource()).findAllServers(); // n/w call on locator > } > return servers; > } > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1653) Executing a fire-and-forget function on all servers doesn't actually execute on all servers
[ https://issues.apache.org/jira/browse/GEODE-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15713529#comment-15713529 ] ASF subversion and git services commented on GEODE-1653: Commit c61028966d51db436e75ba228465767cb1a0bd21 in incubator-geode's branch refs/heads/develop from [~abarve] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=c610289 ] This closes #293 GEODE-1653: Added helper method getAllServers in ExecuteFunctionNoAckOp to get all available servers, instead executing Fire and Forget only on the ones the client is currently connected to. GEODE-1653: Dunit test for Executing a fire-and-forget function on all servers as opposed to only executing on the ones the client is currently connected to. GEODE-1653: changes after spotlessApply. GEODE-1653: 1. renamed test file to FireAndForgetFunctionOnAllServersDUnitTest and test to testFireAndForgetFunctionOnAllServers 2. replaced thread sleep with waitUntilDeterministic function before verifying results after Fire and Forget Function execution 3. removed commented testServerSingleKeyExecution_Bug43513_OnServer test. GEODE-1653: Replacing Thread's sleep with Awatility, if the condition is not met during the timeout, a ConditionTimeoutException will be thrown. This makes analyzing the failure much simpler. GEODE-1653: Use a larger timeout value such as 60 seconds to prevent test from failing on slower machines or garbage collection during the test. GEODE-1653: 1. Code changes a. Added getAllServers() method to connection source, and converted AutoConnectionSourceImpl's findAllServers logic into it. b. Made relevant changes to both ExecuteFunctionNoAckOp and ExecuteFunctionOp classes 2. Test changes a. removed author tag in the test. b. created a new function (FireAndForgetFunctionOnAllServers) for test and removed it from TestFunction. c. test change about awaitility and actual assertion. d. asserted for pool's current server size after starting a new server and stopping existing server. GEODE-1653: Adding missed out file for FireAndForgetFunctionOnAllServers function. GEODE-1653: Adding @Override to ExplicitConnectionSourceImpl's getAllServers() method. GEODE-1653: fix the test code to double check the getCurrentServer only returns 1 server > Executing a fire-and-forget function on all servers doesn't actually execute > on all servers > --- > > Key: GEODE-1653 > URL: https://issues.apache.org/jira/browse/GEODE-1653 > Project: Geode > Issue Type: Bug > Components: functions >Reporter: Barry Oglesby >Assignee: Amey Barve > > Executing a fire-and-forget function on all servers only executes on the ones > the client is currently connected to. > The two {{ExecuteFunctionNoAckOp execute}} methods get the servers to execute > against using code like: > {noformat} > pool.getCurrentServers(); > {noformat} > This method just gets all the {{EndpointManager's endpointMap's > ServerLocations}}. > What should be done is more like what the {{ExecuteFunctionOp execute}} > methods do: > {noformat} > private static List getAllServers(PoolImpl pool) { > List servers = null; > if (pool.getLocators() == null || pool.getLocators().isEmpty()) { > servers = ((ExplicitConnectionSourceImpl) > pool.getConnectionSource()).getAllServers(); > } else { > servers = ((AutoConnectionSourceImpl) > pool.getConnectionSource()).findAllServers(); // n/w call on locator > } > return servers; > } > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1653) Executing a fire-and-forget function on all servers doesn't actually execute on all servers
[ https://issues.apache.org/jira/browse/GEODE-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15713530#comment-15713530 ] ASF subversion and git services commented on GEODE-1653: Commit c61028966d51db436e75ba228465767cb1a0bd21 in incubator-geode's branch refs/heads/develop from [~abarve] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=c610289 ] This closes #293 GEODE-1653: Added helper method getAllServers in ExecuteFunctionNoAckOp to get all available servers, instead executing Fire and Forget only on the ones the client is currently connected to. GEODE-1653: Dunit test for Executing a fire-and-forget function on all servers as opposed to only executing on the ones the client is currently connected to. GEODE-1653: changes after spotlessApply. GEODE-1653: 1. renamed test file to FireAndForgetFunctionOnAllServersDUnitTest and test to testFireAndForgetFunctionOnAllServers 2. replaced thread sleep with waitUntilDeterministic function before verifying results after Fire and Forget Function execution 3. removed commented testServerSingleKeyExecution_Bug43513_OnServer test. GEODE-1653: Replacing Thread's sleep with Awatility, if the condition is not met during the timeout, a ConditionTimeoutException will be thrown. This makes analyzing the failure much simpler. GEODE-1653: Use a larger timeout value such as 60 seconds to prevent test from failing on slower machines or garbage collection during the test. GEODE-1653: 1. Code changes a. Added getAllServers() method to connection source, and converted AutoConnectionSourceImpl's findAllServers logic into it. b. Made relevant changes to both ExecuteFunctionNoAckOp and ExecuteFunctionOp classes 2. Test changes a. removed author tag in the test. b. created a new function (FireAndForgetFunctionOnAllServers) for test and removed it from TestFunction. c. test change about awaitility and actual assertion. d. asserted for pool's current server size after starting a new server and stopping existing server. GEODE-1653: Adding missed out file for FireAndForgetFunctionOnAllServers function. GEODE-1653: Adding @Override to ExplicitConnectionSourceImpl's getAllServers() method. GEODE-1653: fix the test code to double check the getCurrentServer only returns 1 server > Executing a fire-and-forget function on all servers doesn't actually execute > on all servers > --- > > Key: GEODE-1653 > URL: https://issues.apache.org/jira/browse/GEODE-1653 > Project: Geode > Issue Type: Bug > Components: functions >Reporter: Barry Oglesby >Assignee: Amey Barve > > Executing a fire-and-forget function on all servers only executes on the ones > the client is currently connected to. > The two {{ExecuteFunctionNoAckOp execute}} methods get the servers to execute > against using code like: > {noformat} > pool.getCurrentServers(); > {noformat} > This method just gets all the {{EndpointManager's endpointMap's > ServerLocations}}. > What should be done is more like what the {{ExecuteFunctionOp execute}} > methods do: > {noformat} > private static List getAllServers(PoolImpl pool) { > List servers = null; > if (pool.getLocators() == null || pool.getLocators().isEmpty()) { > servers = ((ExplicitConnectionSourceImpl) > pool.getConnectionSource()).getAllServers(); > } else { > servers = ((AutoConnectionSourceImpl) > pool.getConnectionSource()).findAllServers(); // n/w call on locator > } > return servers; > } > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1653) Executing a fire-and-forget function on all servers doesn't actually execute on all servers
[ https://issues.apache.org/jira/browse/GEODE-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15713537#comment-15713537 ] ASF subversion and git services commented on GEODE-1653: Commit c61028966d51db436e75ba228465767cb1a0bd21 in incubator-geode's branch refs/heads/develop from [~abarve] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=c610289 ] This closes #293 GEODE-1653: Added helper method getAllServers in ExecuteFunctionNoAckOp to get all available servers, instead executing Fire and Forget only on the ones the client is currently connected to. GEODE-1653: Dunit test for Executing a fire-and-forget function on all servers as opposed to only executing on the ones the client is currently connected to. GEODE-1653: changes after spotlessApply. GEODE-1653: 1. renamed test file to FireAndForgetFunctionOnAllServersDUnitTest and test to testFireAndForgetFunctionOnAllServers 2. replaced thread sleep with waitUntilDeterministic function before verifying results after Fire and Forget Function execution 3. removed commented testServerSingleKeyExecution_Bug43513_OnServer test. GEODE-1653: Replacing Thread's sleep with Awatility, if the condition is not met during the timeout, a ConditionTimeoutException will be thrown. This makes analyzing the failure much simpler. GEODE-1653: Use a larger timeout value such as 60 seconds to prevent test from failing on slower machines or garbage collection during the test. GEODE-1653: 1. Code changes a. Added getAllServers() method to connection source, and converted AutoConnectionSourceImpl's findAllServers logic into it. b. Made relevant changes to both ExecuteFunctionNoAckOp and ExecuteFunctionOp classes 2. Test changes a. removed author tag in the test. b. created a new function (FireAndForgetFunctionOnAllServers) for test and removed it from TestFunction. c. test change about awaitility and actual assertion. d. asserted for pool's current server size after starting a new server and stopping existing server. GEODE-1653: Adding missed out file for FireAndForgetFunctionOnAllServers function. GEODE-1653: Adding @Override to ExplicitConnectionSourceImpl's getAllServers() method. GEODE-1653: fix the test code to double check the getCurrentServer only returns 1 server > Executing a fire-and-forget function on all servers doesn't actually execute > on all servers > --- > > Key: GEODE-1653 > URL: https://issues.apache.org/jira/browse/GEODE-1653 > Project: Geode > Issue Type: Bug > Components: functions >Reporter: Barry Oglesby >Assignee: Amey Barve > > Executing a fire-and-forget function on all servers only executes on the ones > the client is currently connected to. > The two {{ExecuteFunctionNoAckOp execute}} methods get the servers to execute > against using code like: > {noformat} > pool.getCurrentServers(); > {noformat} > This method just gets all the {{EndpointManager's endpointMap's > ServerLocations}}. > What should be done is more like what the {{ExecuteFunctionOp execute}} > methods do: > {noformat} > private static List getAllServers(PoolImpl pool) { > List servers = null; > if (pool.getLocators() == null || pool.getLocators().isEmpty()) { > servers = ((ExplicitConnectionSourceImpl) > pool.getConnectionSource()).getAllServers(); > } else { > servers = ((AutoConnectionSourceImpl) > pool.getConnectionSource()).findAllServers(); // n/w call on locator > } > return servers; > } > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1653) Executing a fire-and-forget function on all servers doesn't actually execute on all servers
[ https://issues.apache.org/jira/browse/GEODE-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15713532#comment-15713532 ] ASF GitHub Bot commented on GEODE-1653: --- Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/293 > Executing a fire-and-forget function on all servers doesn't actually execute > on all servers > --- > > Key: GEODE-1653 > URL: https://issues.apache.org/jira/browse/GEODE-1653 > Project: Geode > Issue Type: Bug > Components: functions >Reporter: Barry Oglesby >Assignee: Amey Barve > > Executing a fire-and-forget function on all servers only executes on the ones > the client is currently connected to. > The two {{ExecuteFunctionNoAckOp execute}} methods get the servers to execute > against using code like: > {noformat} > pool.getCurrentServers(); > {noformat} > This method just gets all the {{EndpointManager's endpointMap's > ServerLocations}}. > What should be done is more like what the {{ExecuteFunctionOp execute}} > methods do: > {noformat} > private static List getAllServers(PoolImpl pool) { > List servers = null; > if (pool.getLocators() == null || pool.getLocators().isEmpty()) { > servers = ((ExplicitConnectionSourceImpl) > pool.getConnectionSource()).getAllServers(); > } else { > servers = ((AutoConnectionSourceImpl) > pool.getConnectionSource()).findAllServers(); // n/w call on locator > } > return servers; > } > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1653) Executing a fire-and-forget function on all servers doesn't actually execute on all servers
[ https://issues.apache.org/jira/browse/GEODE-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15713533#comment-15713533 ] ASF subversion and git services commented on GEODE-1653: Commit c61028966d51db436e75ba228465767cb1a0bd21 in incubator-geode's branch refs/heads/develop from [~abarve] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=c610289 ] This closes #293 GEODE-1653: Added helper method getAllServers in ExecuteFunctionNoAckOp to get all available servers, instead executing Fire and Forget only on the ones the client is currently connected to. GEODE-1653: Dunit test for Executing a fire-and-forget function on all servers as opposed to only executing on the ones the client is currently connected to. GEODE-1653: changes after spotlessApply. GEODE-1653: 1. renamed test file to FireAndForgetFunctionOnAllServersDUnitTest and test to testFireAndForgetFunctionOnAllServers 2. replaced thread sleep with waitUntilDeterministic function before verifying results after Fire and Forget Function execution 3. removed commented testServerSingleKeyExecution_Bug43513_OnServer test. GEODE-1653: Replacing Thread's sleep with Awatility, if the condition is not met during the timeout, a ConditionTimeoutException will be thrown. This makes analyzing the failure much simpler. GEODE-1653: Use a larger timeout value such as 60 seconds to prevent test from failing on slower machines or garbage collection during the test. GEODE-1653: 1. Code changes a. Added getAllServers() method to connection source, and converted AutoConnectionSourceImpl's findAllServers logic into it. b. Made relevant changes to both ExecuteFunctionNoAckOp and ExecuteFunctionOp classes 2. Test changes a. removed author tag in the test. b. created a new function (FireAndForgetFunctionOnAllServers) for test and removed it from TestFunction. c. test change about awaitility and actual assertion. d. asserted for pool's current server size after starting a new server and stopping existing server. GEODE-1653: Adding missed out file for FireAndForgetFunctionOnAllServers function. GEODE-1653: Adding @Override to ExplicitConnectionSourceImpl's getAllServers() method. GEODE-1653: fix the test code to double check the getCurrentServer only returns 1 server > Executing a fire-and-forget function on all servers doesn't actually execute > on all servers > --- > > Key: GEODE-1653 > URL: https://issues.apache.org/jira/browse/GEODE-1653 > Project: Geode > Issue Type: Bug > Components: functions >Reporter: Barry Oglesby >Assignee: Amey Barve > > Executing a fire-and-forget function on all servers only executes on the ones > the client is currently connected to. > The two {{ExecuteFunctionNoAckOp execute}} methods get the servers to execute > against using code like: > {noformat} > pool.getCurrentServers(); > {noformat} > This method just gets all the {{EndpointManager's endpointMap's > ServerLocations}}. > What should be done is more like what the {{ExecuteFunctionOp execute}} > methods do: > {noformat} > private static List getAllServers(PoolImpl pool) { > List servers = null; > if (pool.getLocators() == null || pool.getLocators().isEmpty()) { > servers = ((ExplicitConnectionSourceImpl) > pool.getConnectionSource()).getAllServers(); > } else { > servers = ((AutoConnectionSourceImpl) > pool.getConnectionSource()).findAllServers(); // n/w call on locator > } > return servers; > } > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1653) Executing a fire-and-forget function on all servers doesn't actually execute on all servers
[ https://issues.apache.org/jira/browse/GEODE-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15713536#comment-15713536 ] ASF subversion and git services commented on GEODE-1653: Commit c61028966d51db436e75ba228465767cb1a0bd21 in incubator-geode's branch refs/heads/develop from [~abarve] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=c610289 ] This closes #293 GEODE-1653: Added helper method getAllServers in ExecuteFunctionNoAckOp to get all available servers, instead executing Fire and Forget only on the ones the client is currently connected to. GEODE-1653: Dunit test for Executing a fire-and-forget function on all servers as opposed to only executing on the ones the client is currently connected to. GEODE-1653: changes after spotlessApply. GEODE-1653: 1. renamed test file to FireAndForgetFunctionOnAllServersDUnitTest and test to testFireAndForgetFunctionOnAllServers 2. replaced thread sleep with waitUntilDeterministic function before verifying results after Fire and Forget Function execution 3. removed commented testServerSingleKeyExecution_Bug43513_OnServer test. GEODE-1653: Replacing Thread's sleep with Awatility, if the condition is not met during the timeout, a ConditionTimeoutException will be thrown. This makes analyzing the failure much simpler. GEODE-1653: Use a larger timeout value such as 60 seconds to prevent test from failing on slower machines or garbage collection during the test. GEODE-1653: 1. Code changes a. Added getAllServers() method to connection source, and converted AutoConnectionSourceImpl's findAllServers logic into it. b. Made relevant changes to both ExecuteFunctionNoAckOp and ExecuteFunctionOp classes 2. Test changes a. removed author tag in the test. b. created a new function (FireAndForgetFunctionOnAllServers) for test and removed it from TestFunction. c. test change about awaitility and actual assertion. d. asserted for pool's current server size after starting a new server and stopping existing server. GEODE-1653: Adding missed out file for FireAndForgetFunctionOnAllServers function. GEODE-1653: Adding @Override to ExplicitConnectionSourceImpl's getAllServers() method. GEODE-1653: fix the test code to double check the getCurrentServer only returns 1 server > Executing a fire-and-forget function on all servers doesn't actually execute > on all servers > --- > > Key: GEODE-1653 > URL: https://issues.apache.org/jira/browse/GEODE-1653 > Project: Geode > Issue Type: Bug > Components: functions >Reporter: Barry Oglesby >Assignee: Amey Barve > > Executing a fire-and-forget function on all servers only executes on the ones > the client is currently connected to. > The two {{ExecuteFunctionNoAckOp execute}} methods get the servers to execute > against using code like: > {noformat} > pool.getCurrentServers(); > {noformat} > This method just gets all the {{EndpointManager's endpointMap's > ServerLocations}}. > What should be done is more like what the {{ExecuteFunctionOp execute}} > methods do: > {noformat} > private static List getAllServers(PoolImpl pool) { > List servers = null; > if (pool.getLocators() == null || pool.getLocators().isEmpty()) { > servers = ((ExplicitConnectionSourceImpl) > pool.getConnectionSource()).getAllServers(); > } else { > servers = ((AutoConnectionSourceImpl) > pool.getConnectionSource()).findAllServers(); // n/w call on locator > } > return servers; > } > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1653) Executing a fire-and-forget function on all servers doesn't actually execute on all servers
[ https://issues.apache.org/jira/browse/GEODE-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15713526#comment-15713526 ] ASF subversion and git services commented on GEODE-1653: Commit c61028966d51db436e75ba228465767cb1a0bd21 in incubator-geode's branch refs/heads/develop from [~abarve] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=c610289 ] This closes #293 GEODE-1653: Added helper method getAllServers in ExecuteFunctionNoAckOp to get all available servers, instead executing Fire and Forget only on the ones the client is currently connected to. GEODE-1653: Dunit test for Executing a fire-and-forget function on all servers as opposed to only executing on the ones the client is currently connected to. GEODE-1653: changes after spotlessApply. GEODE-1653: 1. renamed test file to FireAndForgetFunctionOnAllServersDUnitTest and test to testFireAndForgetFunctionOnAllServers 2. replaced thread sleep with waitUntilDeterministic function before verifying results after Fire and Forget Function execution 3. removed commented testServerSingleKeyExecution_Bug43513_OnServer test. GEODE-1653: Replacing Thread's sleep with Awatility, if the condition is not met during the timeout, a ConditionTimeoutException will be thrown. This makes analyzing the failure much simpler. GEODE-1653: Use a larger timeout value such as 60 seconds to prevent test from failing on slower machines or garbage collection during the test. GEODE-1653: 1. Code changes a. Added getAllServers() method to connection source, and converted AutoConnectionSourceImpl's findAllServers logic into it. b. Made relevant changes to both ExecuteFunctionNoAckOp and ExecuteFunctionOp classes 2. Test changes a. removed author tag in the test. b. created a new function (FireAndForgetFunctionOnAllServers) for test and removed it from TestFunction. c. test change about awaitility and actual assertion. d. asserted for pool's current server size after starting a new server and stopping existing server. GEODE-1653: Adding missed out file for FireAndForgetFunctionOnAllServers function. GEODE-1653: Adding @Override to ExplicitConnectionSourceImpl's getAllServers() method. GEODE-1653: fix the test code to double check the getCurrentServer only returns 1 server > Executing a fire-and-forget function on all servers doesn't actually execute > on all servers > --- > > Key: GEODE-1653 > URL: https://issues.apache.org/jira/browse/GEODE-1653 > Project: Geode > Issue Type: Bug > Components: functions >Reporter: Barry Oglesby >Assignee: Amey Barve > > Executing a fire-and-forget function on all servers only executes on the ones > the client is currently connected to. > The two {{ExecuteFunctionNoAckOp execute}} methods get the servers to execute > against using code like: > {noformat} > pool.getCurrentServers(); > {noformat} > This method just gets all the {{EndpointManager's endpointMap's > ServerLocations}}. > What should be done is more like what the {{ExecuteFunctionOp execute}} > methods do: > {noformat} > private static List getAllServers(PoolImpl pool) { > List servers = null; > if (pool.getLocators() == null || pool.getLocators().isEmpty()) { > servers = ((ExplicitConnectionSourceImpl) > pool.getConnectionSource()).getAllServers(); > } else { > servers = ((AutoConnectionSourceImpl) > pool.getConnectionSource()).findAllServers(); // n/w call on locator > } > return servers; > } > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1653) Executing a fire-and-forget function on all servers doesn't actually execute on all servers
[ https://issues.apache.org/jira/browse/GEODE-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15713527#comment-15713527 ] ASF subversion and git services commented on GEODE-1653: Commit c61028966d51db436e75ba228465767cb1a0bd21 in incubator-geode's branch refs/heads/develop from [~abarve] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=c610289 ] This closes #293 GEODE-1653: Added helper method getAllServers in ExecuteFunctionNoAckOp to get all available servers, instead executing Fire and Forget only on the ones the client is currently connected to. GEODE-1653: Dunit test for Executing a fire-and-forget function on all servers as opposed to only executing on the ones the client is currently connected to. GEODE-1653: changes after spotlessApply. GEODE-1653: 1. renamed test file to FireAndForgetFunctionOnAllServersDUnitTest and test to testFireAndForgetFunctionOnAllServers 2. replaced thread sleep with waitUntilDeterministic function before verifying results after Fire and Forget Function execution 3. removed commented testServerSingleKeyExecution_Bug43513_OnServer test. GEODE-1653: Replacing Thread's sleep with Awatility, if the condition is not met during the timeout, a ConditionTimeoutException will be thrown. This makes analyzing the failure much simpler. GEODE-1653: Use a larger timeout value such as 60 seconds to prevent test from failing on slower machines or garbage collection during the test. GEODE-1653: 1. Code changes a. Added getAllServers() method to connection source, and converted AutoConnectionSourceImpl's findAllServers logic into it. b. Made relevant changes to both ExecuteFunctionNoAckOp and ExecuteFunctionOp classes 2. Test changes a. removed author tag in the test. b. created a new function (FireAndForgetFunctionOnAllServers) for test and removed it from TestFunction. c. test change about awaitility and actual assertion. d. asserted for pool's current server size after starting a new server and stopping existing server. GEODE-1653: Adding missed out file for FireAndForgetFunctionOnAllServers function. GEODE-1653: Adding @Override to ExplicitConnectionSourceImpl's getAllServers() method. GEODE-1653: fix the test code to double check the getCurrentServer only returns 1 server > Executing a fire-and-forget function on all servers doesn't actually execute > on all servers > --- > > Key: GEODE-1653 > URL: https://issues.apache.org/jira/browse/GEODE-1653 > Project: Geode > Issue Type: Bug > Components: functions >Reporter: Barry Oglesby >Assignee: Amey Barve > > Executing a fire-and-forget function on all servers only executes on the ones > the client is currently connected to. > The two {{ExecuteFunctionNoAckOp execute}} methods get the servers to execute > against using code like: > {noformat} > pool.getCurrentServers(); > {noformat} > This method just gets all the {{EndpointManager's endpointMap's > ServerLocations}}. > What should be done is more like what the {{ExecuteFunctionOp execute}} > methods do: > {noformat} > private static List getAllServers(PoolImpl pool) { > List servers = null; > if (pool.getLocators() == null || pool.getLocators().isEmpty()) { > servers = ((ExplicitConnectionSourceImpl) > pool.getConnectionSource()).getAllServers(); > } else { > servers = ((AutoConnectionSourceImpl) > pool.getConnectionSource()).findAllServers(); // n/w call on locator > } > return servers; > } > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1653) Executing a fire-and-forget function on all servers doesn't actually execute on all servers
[ https://issues.apache.org/jira/browse/GEODE-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15713534#comment-15713534 ] ASF subversion and git services commented on GEODE-1653: Commit c61028966d51db436e75ba228465767cb1a0bd21 in incubator-geode's branch refs/heads/develop from [~abarve] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=c610289 ] This closes #293 GEODE-1653: Added helper method getAllServers in ExecuteFunctionNoAckOp to get all available servers, instead executing Fire and Forget only on the ones the client is currently connected to. GEODE-1653: Dunit test for Executing a fire-and-forget function on all servers as opposed to only executing on the ones the client is currently connected to. GEODE-1653: changes after spotlessApply. GEODE-1653: 1. renamed test file to FireAndForgetFunctionOnAllServersDUnitTest and test to testFireAndForgetFunctionOnAllServers 2. replaced thread sleep with waitUntilDeterministic function before verifying results after Fire and Forget Function execution 3. removed commented testServerSingleKeyExecution_Bug43513_OnServer test. GEODE-1653: Replacing Thread's sleep with Awatility, if the condition is not met during the timeout, a ConditionTimeoutException will be thrown. This makes analyzing the failure much simpler. GEODE-1653: Use a larger timeout value such as 60 seconds to prevent test from failing on slower machines or garbage collection during the test. GEODE-1653: 1. Code changes a. Added getAllServers() method to connection source, and converted AutoConnectionSourceImpl's findAllServers logic into it. b. Made relevant changes to both ExecuteFunctionNoAckOp and ExecuteFunctionOp classes 2. Test changes a. removed author tag in the test. b. created a new function (FireAndForgetFunctionOnAllServers) for test and removed it from TestFunction. c. test change about awaitility and actual assertion. d. asserted for pool's current server size after starting a new server and stopping existing server. GEODE-1653: Adding missed out file for FireAndForgetFunctionOnAllServers function. GEODE-1653: Adding @Override to ExplicitConnectionSourceImpl's getAllServers() method. GEODE-1653: fix the test code to double check the getCurrentServer only returns 1 server > Executing a fire-and-forget function on all servers doesn't actually execute > on all servers > --- > > Key: GEODE-1653 > URL: https://issues.apache.org/jira/browse/GEODE-1653 > Project: Geode > Issue Type: Bug > Components: functions >Reporter: Barry Oglesby >Assignee: Amey Barve > > Executing a fire-and-forget function on all servers only executes on the ones > the client is currently connected to. > The two {{ExecuteFunctionNoAckOp execute}} methods get the servers to execute > against using code like: > {noformat} > pool.getCurrentServers(); > {noformat} > This method just gets all the {{EndpointManager's endpointMap's > ServerLocations}}. > What should be done is more like what the {{ExecuteFunctionOp execute}} > methods do: > {noformat} > private static List getAllServers(PoolImpl pool) { > List servers = null; > if (pool.getLocators() == null || pool.getLocators().isEmpty()) { > servers = ((ExplicitConnectionSourceImpl) > pool.getConnectionSource()).getAllServers(); > } else { > servers = ((AutoConnectionSourceImpl) > pool.getConnectionSource()).findAllServers(); // n/w call on locator > } > return servers; > } > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1653) Executing a fire-and-forget function on all servers doesn't actually execute on all servers
[ https://issues.apache.org/jira/browse/GEODE-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15712735#comment-15712735 ] ASF GitHub Bot commented on GEODE-1653: --- Github user kirklund commented on the issue: https://github.com/apache/incubator-geode/pull/293 Oops, looks like the LocatorDUnitTest format problem is on develop, not in this PR. Sorry about my confusion. > Executing a fire-and-forget function on all servers doesn't actually execute > on all servers > --- > > Key: GEODE-1653 > URL: https://issues.apache.org/jira/browse/GEODE-1653 > Project: Geode > Issue Type: Bug > Components: functions >Reporter: Barry Oglesby >Assignee: Amey Barve > > Executing a fire-and-forget function on all servers only executes on the ones > the client is currently connected to. > The two {{ExecuteFunctionNoAckOp execute}} methods get the servers to execute > against using code like: > {noformat} > pool.getCurrentServers(); > {noformat} > This method just gets all the {{EndpointManager's endpointMap's > ServerLocations}}. > What should be done is more like what the {{ExecuteFunctionOp execute}} > methods do: > {noformat} > private static List getAllServers(PoolImpl pool) { > List servers = null; > if (pool.getLocators() == null || pool.getLocators().isEmpty()) { > servers = ((ExplicitConnectionSourceImpl) > pool.getConnectionSource()).getAllServers(); > } else { > servers = ((AutoConnectionSourceImpl) > pool.getConnectionSource()).findAllServers(); // n/w call on locator > } > return servers; > } > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1653) Executing a fire-and-forget function on all servers doesn't actually execute on all servers
[ https://issues.apache.org/jira/browse/GEODE-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15712565#comment-15712565 ] ASF GitHub Bot commented on GEODE-1653: --- Github user kirklund commented on the issue: https://github.com/apache/incubator-geode/pull/293 The Travis failure is caused by the format not matching spotless. Unfortunately, the IntelliJ formatter doesn't currently match, so the easiest way to fix the format is to run: `$ ./gradlew spotlessApply` After that rebase your branch against origin/develop to squash the format change and 'git push -f' your branch. > Executing a fire-and-forget function on all servers doesn't actually execute > on all servers > --- > > Key: GEODE-1653 > URL: https://issues.apache.org/jira/browse/GEODE-1653 > Project: Geode > Issue Type: Bug > Components: functions >Reporter: Barry Oglesby >Assignee: Amey Barve > > Executing a fire-and-forget function on all servers only executes on the ones > the client is currently connected to. > The two {{ExecuteFunctionNoAckOp execute}} methods get the servers to execute > against using code like: > {noformat} > pool.getCurrentServers(); > {noformat} > This method just gets all the {{EndpointManager's endpointMap's > ServerLocations}}. > What should be done is more like what the {{ExecuteFunctionOp execute}} > methods do: > {noformat} > private static List getAllServers(PoolImpl pool) { > List servers = null; > if (pool.getLocators() == null || pool.getLocators().isEmpty()) { > servers = ((ExplicitConnectionSourceImpl) > pool.getConnectionSource()).getAllServers(); > } else { > servers = ((AutoConnectionSourceImpl) > pool.getConnectionSource()).findAllServers(); // n/w call on locator > } > return servers; > } > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1653) Executing a fire-and-forget function on all servers doesn't actually execute on all servers
[ https://issues.apache.org/jira/browse/GEODE-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15709358#comment-15709358 ] ASF GitHub Bot commented on GEODE-1653: --- Github user gesterzhou commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/293#discussion_r90296214 --- Diff: geode-core/src/test/java/org/apache/geode/internal/cache/FireAndForgetFunctionOnAllServersDUnitTest.java --- @@ -92,22 +90,23 @@ public void testFireAndForgetFunctionOnAllServers() { // Step 4. Execute the function to put DistributedMemberID into above created replicated // region. - Function function = - new TestFunction(false, TestFunction.TEST_FUNCTION_FIREANDFORGET_ONALL_SERVERS); + Function function = new FireAndForgetFunctionOnAllServers(); FunctionService.registerFunction(function); + PoolImpl pool = (PoolImpl) pool1; + + await().atMost(60, SECONDS) + .until(() -> Assert.assertEquals(1, pool.getCurrentServers().size())); --- End diff -- The 2 lines should be moved to line 120. Otherwise, I wonder why the test will pass. > Executing a fire-and-forget function on all servers doesn't actually execute > on all servers > --- > > Key: GEODE-1653 > URL: https://issues.apache.org/jira/browse/GEODE-1653 > Project: Geode > Issue Type: Bug > Components: functions >Reporter: Barry Oglesby >Assignee: Amey Barve > > Executing a fire-and-forget function on all servers only executes on the ones > the client is currently connected to. > The two {{ExecuteFunctionNoAckOp execute}} methods get the servers to execute > against using code like: > {noformat} > pool.getCurrentServers(); > {noformat} > This method just gets all the {{EndpointManager's endpointMap's > ServerLocations}}. > What should be done is more like what the {{ExecuteFunctionOp execute}} > methods do: > {noformat} > private static List getAllServers(PoolImpl pool) { > List servers = null; > if (pool.getLocators() == null || pool.getLocators().isEmpty()) { > servers = ((ExplicitConnectionSourceImpl) > pool.getConnectionSource()).getAllServers(); > } else { > servers = ((AutoConnectionSourceImpl) > pool.getConnectionSource()).findAllServers(); // n/w call on locator > } > return servers; > } > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1653) Executing a fire-and-forget function on all servers doesn't actually execute on all servers
[ https://issues.apache.org/jira/browse/GEODE-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15709343#comment-15709343 ] ASF GitHub Bot commented on GEODE-1653: --- Github user gesterzhou commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/293#discussion_r90295325 --- Diff: geode-core/src/main/java/org/apache/geode/cache/client/internal/ExplicitConnectionSourceImpl.java --- @@ -257,7 +257,7 @@ public String toString() { return sb.toString(); } - ArrayList getAllServers() { + public ArrayList getAllServers() { --- End diff -- Better to add @Override here > Executing a fire-and-forget function on all servers doesn't actually execute > on all servers > --- > > Key: GEODE-1653 > URL: https://issues.apache.org/jira/browse/GEODE-1653 > Project: Geode > Issue Type: Bug > Components: functions >Reporter: Barry Oglesby >Assignee: Amey Barve > > Executing a fire-and-forget function on all servers only executes on the ones > the client is currently connected to. > The two {{ExecuteFunctionNoAckOp execute}} methods get the servers to execute > against using code like: > {noformat} > pool.getCurrentServers(); > {noformat} > This method just gets all the {{EndpointManager's endpointMap's > ServerLocations}}. > What should be done is more like what the {{ExecuteFunctionOp execute}} > methods do: > {noformat} > private static List getAllServers(PoolImpl pool) { > List servers = null; > if (pool.getLocators() == null || pool.getLocators().isEmpty()) { > servers = ((ExplicitConnectionSourceImpl) > pool.getConnectionSource()).getAllServers(); > } else { > servers = ((AutoConnectionSourceImpl) > pool.getConnectionSource()).findAllServers(); // n/w call on locator > } > return servers; > } > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1653) Executing a fire-and-forget function on all servers doesn't actually execute on all servers
[ https://issues.apache.org/jira/browse/GEODE-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15706567#comment-15706567 ] ASF GitHub Bot commented on GEODE-1653: --- Github user jhuynh1 commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/293#discussion_r90116715 --- Diff: geode-core/src/test/java/org/apache/geode/internal/cache/FireAndForgetFunctionOnAllServersDUnitTest.java --- @@ -0,0 +1,164 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license + * agreements. See the NOTICE file distributed with this work for additional information regarding + * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. You may obtain a + * copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + * or implied. See the License for the specific language governing permissions and limitations under + * the License. + */ + +package org.apache.geode.internal.cache; + +import org.apache.geode.cache.Region; +import org.apache.geode.cache.client.*; +import org.apache.geode.cache.client.internal.LocatorTestBase; +import org.apache.geode.cache.execute.Execution; +import org.apache.geode.cache.execute.Function; +import org.apache.geode.cache.execute.FunctionService; +import org.apache.geode.internal.AvailablePort; +import org.apache.geode.internal.cache.functions.TestFunction; +import org.apache.geode.test.dunit.Assert; +import org.apache.geode.test.dunit.Host; +import org.apache.geode.test.dunit.NetworkUtils; +import org.apache.geode.test.dunit.VM; +import org.apache.geode.test.junit.categories.DistributedTest; +import org.junit.Test; +import org.junit.experimental.categories.Category; + +import static com.jayway.awaitility.Awaitility.*; +import static java.util.concurrent.TimeUnit.*; + +/** + * Created by amey on 22/11/16. --- End diff -- Minor nitpick, would you be able to remove the author tags? > Executing a fire-and-forget function on all servers doesn't actually execute > on all servers > --- > > Key: GEODE-1653 > URL: https://issues.apache.org/jira/browse/GEODE-1653 > Project: Geode > Issue Type: Bug > Components: functions >Reporter: Barry Oglesby >Assignee: Amey Barve > > Executing a fire-and-forget function on all servers only executes on the ones > the client is currently connected to. > The two {{ExecuteFunctionNoAckOp execute}} methods get the servers to execute > against using code like: > {noformat} > pool.getCurrentServers(); > {noformat} > This method just gets all the {{EndpointManager's endpointMap's > ServerLocations}}. > What should be done is more like what the {{ExecuteFunctionOp execute}} > methods do: > {noformat} > private static List getAllServers(PoolImpl pool) { > List servers = null; > if (pool.getLocators() == null || pool.getLocators().isEmpty()) { > servers = ((ExplicitConnectionSourceImpl) > pool.getConnectionSource()).getAllServers(); > } else { > servers = ((AutoConnectionSourceImpl) > pool.getConnectionSource()).findAllServers(); // n/w call on locator > } > return servers; > } > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)