[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254553#comment-16254553
 ] 

ASF subversion and git services commented on GEODE-3149:


Commit ca8d4a5f87c862732b1026bcfbf02b9d4cf6e839 in geode-native's branch 
refs/heads/develop from [~mhansonp]
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=ca8d4a5 ]

GEODE-3149: Removing unneeded file (#153)



> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254309#comment-16254309
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

mhansonp closed pull request #151: GEODE-3149: Removing unneeded file
URL: https://github.com/apache/geode-native/pull/151
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/clicache/src/IGeodeSerializable.hpp 
b/clicache/src/IGeodeSerializable.hpp
index 3055f478..ff34a148 100644
--- a/clicache/src/IGeodeSerializable.hpp
+++ b/clicache/src/IGeodeSerializable.hpp
@@ -19,7 +19,7 @@
 
 #include "geode_defs.hpp"
 #include "begin_native.hpp"
-#include 
+#include 
 #include "end_native.hpp"
 
 using namespace System;
diff --git a/cppcache/include/geode/AttributesFactory.hpp 
b/cppcache/include/geode/AttributesFactory.hpp
index 22941b6e..fad65c38 100644
--- a/cppcache/include/geode/AttributesFactory.hpp
+++ b/cppcache/include/geode/AttributesFactory.hpp
@@ -23,7 +23,6 @@
 #include 
 
 #include "geode_globals.hpp"
-#include "geode_types.hpp"
 #include "ExceptionTypes.hpp"
 #include "ExpirationAction.hpp"
 #include "CacheLoader.hpp"
diff --git a/cppcache/include/geode/AttributesMutator.hpp 
b/cppcache/include/geode/AttributesMutator.hpp
index 363d2712..491732f9 100644
--- a/cppcache/include/geode/AttributesMutator.hpp
+++ b/cppcache/include/geode/AttributesMutator.hpp
@@ -23,7 +23,6 @@
 #include 
 
 #include "geode_globals.hpp"
-#include "geode_types.hpp"
 #include "ExpirationAction.hpp"
 #include "util/chrono/duration.hpp"
 
diff --git a/cppcache/include/geode/AuthInitialize.hpp 
b/cppcache/include/geode/AuthInitialize.hpp
index 0fab2da3..9f746a90 100644
--- a/cppcache/include/geode/AuthInitialize.hpp
+++ b/cppcache/include/geode/AuthInitialize.hpp
@@ -25,7 +25,7 @@
  */
 
 #include "geode_globals.hpp"
-#include "geode_types.hpp"
+#include 
 
 namespace apache {
 namespace geode {
diff --git a/cppcache/include/geode/Cache.hpp b/cppcache/include/geode/Cache.hpp
index f7bb2148..e88766fd 100644
--- a/cppcache/include/geode/Cache.hpp
+++ b/cppcache/include/geode/Cache.hpp
@@ -23,9 +23,7 @@
 #include 
 
 #include "geode_globals.hpp"
-#include "geode_types.hpp"
 #include "GeodeCache.hpp"
-#include "geode_types.hpp"
 #include "Region.hpp"
 #include "DistributedSystem.hpp"
 #include "QueryService.hpp"
diff --git a/cppcache/include/geode/CacheAttributes.hpp 
b/cppcache/include/geode/CacheAttributes.hpp
index da1cae8a..0416dde4 100644
--- a/cppcache/include/geode/CacheAttributes.hpp
+++ b/cppcache/include/geode/CacheAttributes.hpp
@@ -25,7 +25,6 @@
  */
 
 #include "geode_globals.hpp"
-#include "geode_types.hpp"
 
 namespace apache {
 namespace geode {
diff --git a/cppcache/include/geode/CacheFactory.hpp 
b/cppcache/include/geode/CacheFactory.hpp
index f3397af5..2a5211fb 100644
--- a/cppcache/include/geode/CacheFactory.hpp
+++ b/cppcache/include/geode/CacheFactory.hpp
@@ -23,7 +23,6 @@
 #include 
 
 #include "geode_globals.hpp"
-#include "geode_types.hpp"
 #include "util/chrono/duration.hpp"
 #include "DistributedSystem.hpp"
 #include "Cache.hpp"
diff --git a/cppcache/include/geode/CacheListener.hpp 
b/cppcache/include/geode/CacheListener.hpp
index dd51ab9d..d93ec8ab 100644
--- a/cppcache/include/geode/CacheListener.hpp
+++ b/cppcache/include/geode/CacheListener.hpp
@@ -21,7 +21,6 @@
  */
 
 #include "geode_globals.hpp"
-#include "geode_types.hpp"
 #include 
 
 /**
diff --git a/cppcache/include/geode/CacheLoader.hpp 
b/cppcache/include/geode/CacheLoader.hpp
index 044bf13f..446dc9de 100644
--- a/cppcache/include/geode/CacheLoader.hpp
+++ b/cppcache/include/geode/CacheLoader.hpp
@@ -25,7 +25,6 @@
  */
 
 #include "geode_globals.hpp"
-#include "geode_types.hpp"
 #include "CacheableKey.hpp"
 #include "Cacheable.hpp"
 
diff --git a/cppcache/include/geode/CacheStatistics.hpp 
b/cppcache/include/geode/CacheStatistics.hpp
index f127b104..cd38601a 100644
--- a/cppcache/include/geode/CacheStatistics.hpp
+++ b/cppcache/include/geode/CacheStatistics.hpp
@@ -24,7 +24,6 @@
 #include 
 
 #include "geode_globals.hpp"
-#include "geode_types.hpp"
 
 /**
  * @file
diff --git a/cppcache/include/geode/CacheTransactionManager.hpp 
b/cppcache/include/geode/CacheTransactionManager.hpp
index b43175ae..0f9e1f98 100644
--- a/cppcache/include/geode/CacheTransactionManager.hpp
+++ b/cppcache/include/geode/CacheTransactionManager.hpp
@@ -23,8 +23,8 @@
 // Warning: DO NOT directly include Region.hpp, include Cache.hpp instead.
 
 #include 
+#include 
 #include "geode_globals.hpp"
-#include "geode_types.hpp"
 
 namespace apache {
 namespace geode {
diff --git a/cppcache/include/geode/CacheWriter.hpp 
b/cppcache/include/geode/CacheWriter.hpp
index d8692adc..f5854805 100644
--- 

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254308#comment-16254308
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

mhansonp commented on issue #151: GEODE-3149: Removing unneeded file
URL: https://github.com/apache/geode-native/pull/151#issuecomment-344746091
 
 
   need to make some more changes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16253854#comment-16253854
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

mhansonp opened a new pull request #151: GEODE-3149: Removing unneeded file
URL: https://github.com/apache/geode-native/pull/151
 
 
   -HashFunction.hpp is no longer needed


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16252690#comment-16252690
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

mhansonp opened a new pull request #149: GEODE-3149: Code cleanup
URL: https://github.com/apache/geode-native/pull/149
 
 
   -Removed VectorT.hpp
   -Removed GeodeCppCache.hpp
   -Cleaned out geode_types.hpp
   -Converted *Ptr types to shared_ptr<*> types
   -Variable conversion to auto


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250457#comment-16250457
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

mhansonp commented on issue #148: GEODE-3149: Removing the VectorT.hpp header 
file and typedefs
URL: https://github.com/apache/geode-native/pull/148#issuecomment-344089318
 
 
   Actually, I think it will be easier to start over. I am working on plan B 
approach now that I have more regex powers. I am hoping to have this wrapped up 
by the end of the day vs, spending another day or two on the rebase with all 
the conflicts.
   
   Thanks,
   Mark
   
   > On Nov 13, 2017, at 12:22 PM, Jacob Barrett  
wrote:
   > 
   > @mhansonp  Please resolve merge conflicts 
(rebase) and push.
   > 
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub 
, or 
mute the thread 
.
   > 
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250175#comment-16250175
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

pivotal-jbarrett commented on issue #148: GEODE-3149: Removing the VectorT.hpp 
header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#issuecomment-344045796
 
 
   @mhansonp Please resolve merge conflicts (rebase) and push.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248218#comment-16248218
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

mhansonp commented on a change in pull request #148: GEODE-3149: Removing the 
VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150364303
 
 

 ##
 File path: clicache/src/impl/ManagedString.hpp
 ##
 @@ -40,7 +40,7 @@ namespace Apache
 {
 private:
 
-  IntPtr m_str;
+ IntPtr m_str;
 
 Review comment:
   Agreed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248216#comment-16248216
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

dgkimura commented on a change in pull request #148: GEODE-3149: Removing the 
VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150363896
 
 

 ##
 File path: clicache/src/CacheableBuiltins.hpp
 ##
 @@ -386,20 +386,20 @@ namespace Apache
}   
  \
\
internal:   
\
-   static IGeodeSerializable^ Create(native::SerializablePtr obj)  
  \
+   static IGeodeSerializable^ 
Create(std::shared_ptr obj)\
{   
  \
return (obj != nullptr ? gcnew m(obj) : nullptr);   
\
}   
  \
\
private:
\
- inline m(native::SerializablePtr nativeptr)   
 \
+ inline m(std::shared_ptr nativeptr) 
   \
   : CacheableBuiltinKey(nativeptr) { } 
   \
   };
 
 
 #define _GFCLI_CACHEABLE_ARRAY_DEF_NEW(m, mt)  
  \
   ref class m : public CacheableBuiltinArray<\
-native::m, native::m##Ptr, mt, GeodeClassIds::m>  \
 
 Review comment:
   Perhaps I'm missing something.  Why wasn't the line changed to `native::m, 
std::shared_ptr, mt, GeodeClassIds::m>`?  Did you change the second 
parameter in the `CacheableBuiltinArray` template away from a shared_ptr?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248213#comment-16248213
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

pivotal-jbarrett commented on a change in pull request #148: GEODE-3149: 
Removing the VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150363582
 
 

 ##
 File path: .gitignore
 ##
 @@ -4,3 +4,6 @@
 /.settings/
 /.cproject
 /.project
+/.idea/
+/Testing/
 
 Review comment:
   Do not ignore personal directories like this. Ignoring `.idea` is acceptable 
since it is created by a commonly used IDE.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248205#comment-16248205
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

pivotal-jbarrett commented on a change in pull request #148: GEODE-3149: 
Removing the VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150362727
 
 

 ##
 File path: clicache/src/LocalRegion.cpp
 ##
 @@ -893,7 +893,7 @@ namespace Apache
 
 _GF_MG_EXCEPTION_TRY2/* due to auto replace */
 
-   
std::vector vc;
 
 Review comment:
   Your editor is using TAB not SPACE.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248116#comment-16248116
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

dgkimura commented on a change in pull request #148: GEODE-3149: Removing the 
VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150353786
 
 

 ##
 File path: cppcache/include/geode/PersistenceManager.hpp
 ##
 @@ -132,8 +133,12 @@ class CPPCACHE_EXPORT PersistenceManager {
  protected:
   /** Region for this persistence manager.
*/
-  const RegionPtr m_regionPtr;
+  const std::shared_ptr m_regionPtr;
 };
+
+
+typedef std::shared_ptr (*getPersistenceManagerInstance)(
 
 Review comment:
   Seems like this is defined twice


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248103#comment-16248103
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

mhansonp commented on a change in pull request #148: GEODE-3149: Removing the 
VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150352172
 
 

 ##
 File path: clicache/src/impl/CacheLoader.hpp
 ##
 @@ -41,13 +35,14 @@ namespace Apache
   {
   public:
 std::shared_ptr load( const 
std::shared_ptr& region,
-  const std::shared_ptr& key, 
const std::shared_ptr& helper );
+const 
std::shared_ptr& key,
 
 Review comment:
   This looks fine in the editor as well... Not sure what is going on...


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248100#comment-16248100
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

mhansonp commented on a change in pull request #148: GEODE-3149: Removing the 
VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150351974
 
 

 ##
 File path: clicache/src/CacheableBuiltins.hpp
 ##
 @@ -386,20 +386,20 @@ namespace Apache
}   
  \
\
internal:   
\
-   static IGeodeSerializable^ Create(native::SerializablePtr obj)  
  \
+   static IGeodeSerializable^ 
Create(std::shared_ptr obj)\
{   
  \
return (obj != nullptr ? gcnew m(obj) : nullptr);   
\
}   
  \
\
private:
\
- inline m(native::SerializablePtr nativeptr)   
 \
+ inline m(std::shared_ptr nativeptr) 
   \
   : CacheableBuiltinKey(nativeptr) { } 
   \
   };
 
 
 #define _GFCLI_CACHEABLE_ARRAY_DEF_NEW(m, mt)  
  \
   ref class m : public CacheableBuiltinArray<\
-native::m, native::m##Ptr, mt, GeodeClassIds::m>  \
 
 Review comment:
   In the changes below this line, we went from "somethingPtr" to 
std::shared_ptr<"something"> var... So the ##Ptr was no longer required.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248101#comment-16248101
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

mhansonp commented on a change in pull request #148: GEODE-3149: Removing the 
VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150352082
 
 

 ##
 File path: clicache/src/LocalRegion.cpp
 ##
 @@ -893,7 +893,7 @@ namespace Apache
 
 _GF_MG_EXCEPTION_TRY2/* due to auto replace */
 
-   
std::vector vc;
 
 Review comment:
   This looks fine in the editor Not sure what the deal is here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247992#comment-16247992
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

mhansonp commented on a change in pull request #148: GEODE-3149: Removing the 
VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150325958
 
 

 ##
 File path: clicache/src/impl/SafeConvert.hpp
 ##
 @@ -132,13 +132,13 @@ namespace Apache
   }
 
   template
-  inline static NativeType* GetNativePtr( ManagedType^ mg_obj )
+  inline static NativeType*std::GetNativePtr( ManagedType^ mg_obj )
 
 Review comment:
   fixed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247991#comment-16247991
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

mhansonp commented on a change in pull request #148: GEODE-3149: Removing the 
VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150325937
 
 

 ##
 File path: cppcache/include/geode/CacheLoader.hpp
 ##
 @@ -67,8 +68,8 @@ class CPPCACHE_EXPORT CacheLoader  {
*
*@see Region::get .
*/
-  virtual CacheablePtr load(const RegionPtr& rp, const CacheableKeyPtr& key,
-const SerializablePtr& aCallbackArgument) = 0;
+  virtual std::shared_ptr load(const std::shared_ptr& rp, 
const std::shared_ptr& key,
+const std::shared_ptr& 
aCallbackArgument) = 0;
 
 Review comment:
   fixed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247988#comment-16247988
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

dgkimura commented on a change in pull request #148: GEODE-3149: Removing the 
VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150325005
 
 

 ##
 File path: cppcache/include/geode/CacheFactory.hpp
 ##
 @@ -127,24 +128,24 @@ class CPPCACHE_EXPORT CacheFactory
* @return a reference to this
* @since 3.5
*/
-  CacheFactoryPtr set(const char* name, const char* value);
+  std::shared_ptr set(const char* name, const char* value);
 
  private:
-  PropertiesPtr dsProp;
+  std::shared_ptr dsProp;
   bool ignorePdxUnreadFields;
   bool pdxReadSerialized;
-  AuthInitializePtr authInitialize;
+  std::shared_ptr authInitialize;
 
-  CachePtr create(const char* name,
-  const CacheAttributesPtr& attrs = nullptr);
+  std::shared_ptr create(const char* name,
+  const std::shared_ptr& attrs = nullptr);
 
 Review comment:
   format


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247989#comment-16247989
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

dgkimura commented on a change in pull request #148: GEODE-3149: Removing the 
VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150325113
 
 

 ##
 File path: cppcache/include/geode/CacheLoader.hpp
 ##
 @@ -67,8 +68,8 @@ class CPPCACHE_EXPORT CacheLoader  {
*
*@see Region::get .
*/
-  virtual CacheablePtr load(const RegionPtr& rp, const CacheableKeyPtr& key,
-const SerializablePtr& aCallbackArgument) = 0;
+  virtual std::shared_ptr load(const std::shared_ptr& rp, 
const std::shared_ptr& key,
+const std::shared_ptr& 
aCallbackArgument) = 0;
 
 Review comment:
   format


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247985#comment-16247985
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

mhansonp commented on a change in pull request #148: GEODE-3149: Removing the 
VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150324486
 
 

 ##
 File path: Testing/Temporary/CTestCostData.txt
 ##
 @@ -0,0 +1 @@
+---
 
 Review comment:
   removed in new commit.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247984#comment-16247984
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

mhansonp commented on a change in pull request #148: GEODE-3149: Removing the 
VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150324448
 
 

 ##
 File path: Testing/Temporary/LastTest.log
 ##
 @@ -0,0 +1,3 @@
+Start testing: Nov 01 15:14 PDT
+--
 
 Review comment:
   removed in new commit.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247983#comment-16247983
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

dgkimura commented on a change in pull request #148: GEODE-3149: Removing the 
VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150324353
 
 

 ##
 File path: clicache/src/impl/SafeConvert.hpp
 ##
 @@ -132,13 +132,13 @@ namespace Apache
   }
 
   template
-  inline static NativeType* GetNativePtr( ManagedType^ mg_obj )
+  inline static NativeType*std::GetNativePtr( ManagedType^ mg_obj )
 
 Review comment:
   Ehh?!  This doesn't look right...?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247981#comment-16247981
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

dgkimura commented on a change in pull request #148: GEODE-3149: Removing the 
VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150324173
 
 

 ##
 File path: clicache/src/impl/PersistenceManagerProxy.hpp
 ##
 @@ -20,23 +20,26 @@
 #include "SafeConvert.hpp"
 #include "../Region.hpp"
 #include "../Properties.hpp"
+#include "begin_native.hpp"
+#include 
+#include "end_native.hpp"
 using namespace System;
 namespace Apache
 {
   namespace Geode
   {
 namespace Client
 {
-
+   namespace native = apache::geode::client;
 
 Review comment:
   format


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247979#comment-16247979
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

dgkimura commented on a change in pull request #148: GEODE-3149: Removing the 
VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150323926
 
 

 ##
 File path: clicache/src/impl/ManagedString.hpp
 ##
 @@ -40,7 +40,7 @@ namespace Apache
 {
 private:
 
-  IntPtr m_str;
+ IntPtr m_str;
 
 Review comment:
   None of the edits in this file seem to add value.  If that's the case then 
let's revert this file.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247972#comment-16247972
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

dgkimura commented on a change in pull request #148: GEODE-3149: Removing the 
VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150323080
 
 

 ##
 File path: clicache/src/impl/ManagedCacheWriter.hpp
 ##
 @@ -33,7 +33,7 @@ namespace apache
   {
 namespace client
 {
-
+   namespace native = apache::geode::client;
 
 Review comment:
   Formatting.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247971#comment-16247971
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

dgkimura commented on a change in pull request #148: GEODE-3149: Removing the 
VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150322968
 
 

 ##
 File path: clicache/src/impl/ManagedCacheLoader.cpp
 ##
 @@ -214,8 +214,8 @@ namespace apache
 return NULL;
   }
 
-  CacheablePtr ManagedCacheLoaderGeneric::load(const RegionPtr& region,
-   const CacheableKeyPtr& key, 
const SerializablePtr& aCallbackArgument)
+ std::shared_ptr ManagedCacheLoaderGeneric::load(const 
std::shared_ptr& region,
+   const 
std::shared_ptr& key, const 
std::shared_ptr& aCallbackArgument)
 
 Review comment:
   Formatting is kinda awkward here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247966#comment-16247966
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

dgkimura commented on a change in pull request #148: GEODE-3149: Removing the 
VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150321960
 
 

 ##
 File path: clicache/src/Cache.cpp
 ##
 @@ -181,7 +181,7 @@ namespace Apache
   generic
   array^>^ Cache::RootRegions( )
   {
-apache::geode::client::VectorOfRegion vrr;
+std::vector vrr;
 
 Review comment:
   While you're in the file, it would be nice to have some consistency.  Can we 
switch to use the `native` namespace?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247962#comment-16247962
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

dgkimura commented on a change in pull request #148: GEODE-3149: Removing the 
VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150321519
 
 

 ##
 File path: Testing/Temporary/CTestCostData.txt
 ##
 @@ -0,0 +1 @@
+---
 
 Review comment:
   I assume you did a `git add .`  Please double check that you didn't add any 
other files by mistake.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247963#comment-16247963
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

dgkimura commented on a change in pull request #148: GEODE-3149: Removing the 
VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150321543
 
 

 ##
 File path: Testing/Temporary/LastTest.log
 ##
 @@ -0,0 +1,3 @@
+Start testing: Nov 01 15:14 PDT
+--
 
 Review comment:
   I assume you did a `git add .`  Please double check that you didn't add any 
other files by mistake.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247957#comment-16247957
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

dgkimura commented on a change in pull request #148: GEODE-3149: Removing the 
VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150320492
 
 

 ##
 File path: clicache/src/CacheableBuiltins.hpp
 ##
 @@ -386,20 +386,20 @@ namespace Apache
}   
  \
\
internal:   
\
-   static IGeodeSerializable^ Create(native::SerializablePtr obj)  
  \
+   static IGeodeSerializable^ 
Create(std::shared_ptr obj)\
{   
  \
return (obj != nullptr ? gcnew m(obj) : nullptr);   
\
}   
  \
\
private:
\
- inline m(native::SerializablePtr nativeptr)   
 \
+ inline m(std::shared_ptr nativeptr) 
   \
   : CacheableBuiltinKey(nativeptr) { } 
   \
   };
 
 
 #define _GFCLI_CACHEABLE_ARRAY_DEF_NEW(m, mt)  
  \
   ref class m : public CacheableBuiltinArray<\
-native::m, native::m##Ptr, mt, GeodeClassIds::m>  \
 
 Review comment:
   Why is this type changing away from shared_ptr?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247934#comment-16247934
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

mhansonp opened a new pull request #148: GEODE-3149: Removing the VectorT.hpp 
header file and typedefs
URL: https://github.com/apache/geode-native/pull/148
 
 
   -Changing (somthing)Ptr to std::shared_ptr<(something>
   -Changing unnecessary declarations to auto
   -Cleaning up Macro defines that were no longer needed


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)