[jira] [Commented] (GEODE-3261) Refactor GfshHelpCommands

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16145605#comment-16145605
 ] 

ASF subversion and git services commented on GEODE-3261:


Commit 4fc3ffe07e2a326d765240d5fd7e65f27b6ed3cf in geode's branch 
refs/heads/develop from YehEmily
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=4fc3ffe ]

GEODE-3436: Restore refactoring of GfshHelpCommands

* See initial commit GEODE-3261 (cf91426692349d0c81ce77394935576d9cc336e8)


> Refactor GfshHelpCommands
> -
>
> Key: GEODE-3261
> URL: https://issues.apache.org/jira/browse/GEODE-3261
> Project: Geode
>  Issue Type: Sub-task
>  Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{GfshHelpCommands.java}} is a class that contains multiple commands. Each 
> command should be refactored into a separate class, and the methods shared by 
> the commands should be refactored into a new and appropriately named class of 
> their own.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3261) Refactor GfshHelpCommands

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124155#comment-16124155
 ] 

ASF subversion and git services commented on GEODE-3261:


Commit cf91426692349d0c81ce77394935576d9cc336e8 in geode's branch 
refs/heads/develop from YehEmily
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=cf91426 ]

GEODE-3261: Refactoring GfshHelpCommands

This closes #685


> Refactor GfshHelpCommands
> -
>
> Key: GEODE-3261
> URL: https://issues.apache.org/jira/browse/GEODE-3261
> Project: Geode
>  Issue Type: Sub-task
>  Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{GfshHelpCommands.java}} is a class that contains multiple commands. Each 
> command should be refactored into a separate class, and the methods shared by 
> the commands should be refactored into a new and appropriately named class of 
> their own.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3261) Refactor GfshHelpCommands

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116842#comment-16116842
 ] 

ASF GitHub Bot commented on GEODE-3261:
---

Github user YehEmily commented on a diff in the pull request:

https://github.com/apache/geode/pull/685#discussion_r131705221
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/management/internal/cli/help/HelperIntegrationTest.java
 ---
@@ -34,7 +36,7 @@
   public static void beforeClass() {
 helper = new Helper();
 // use GfshHelpCommand for testing
-Method[] methods = GfshHelpCommands.class.getMethods();
+Method[] methods = GfshHelpCommand.class.getMethods();
--- End diff --

Good idea - thank you for your feedback! I don't think the original test 
ever actually tested the hint command, so I wrote two completely new tests: 
`HelperIntegrationTest.TestHintWithInput` and 
`HelperIntegrationTest.TestHintWithoutInput`. PR has also been updated!


> Refactor GfshHelpCommands
> -
>
> Key: GEODE-3261
> URL: https://issues.apache.org/jira/browse/GEODE-3261
> Project: Geode
>  Issue Type: Sub-task
>  Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{GfshHelpCommands.java}} is a class that contains multiple commands. Each 
> command should be refactored into a separate class, and the methods shared by 
> the commands should be refactored into a new and appropriately named class of 
> their own.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3261) Refactor GfshHelpCommands

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114930#comment-16114930
 ] 

ASF GitHub Bot commented on GEODE-3261:
---

Github user pdxrunner commented on a diff in the pull request:

https://github.com/apache/geode/pull/685#discussion_r131479491
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/management/internal/cli/help/HelperIntegrationTest.java
 ---
@@ -34,7 +36,7 @@
   public static void beforeClass() {
 helper = new Helper();
 // use GfshHelpCommand for testing
-Method[] methods = GfshHelpCommands.class.getMethods();
+Method[] methods = GfshHelpCommand.class.getMethods();
--- End diff --

With the original multiple-command class being split, this test now only 
checks one of the two commands. Add a second test for GfshHintCommand. I would 
add it to this test class, refactoring the beforeClass functionality into 
separate imnplementations in each test.


> Refactor GfshHelpCommands
> -
>
> Key: GEODE-3261
> URL: https://issues.apache.org/jira/browse/GEODE-3261
> Project: Geode
>  Issue Type: Sub-task
>  Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{GfshHelpCommands.java}} is a class that contains multiple commands. Each 
> command should be refactored into a separate class, and the methods shared by 
> the commands should be refactored into a new and appropriately named class of 
> their own.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3261) Refactor GfshHelpCommands

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114756#comment-16114756
 ] 

ASF GitHub Bot commented on GEODE-3261:
---

GitHub user YehEmily opened a pull request:

https://github.com/apache/geode/pull/685

GEODE-3261: Refactoring GfshHelpCommands

[View the JIRA ticket 
here.](https://issues.apache.org/jira/browse/GEODE-3261)

`GfshHelpCommands` has been split into two new command classes, 
`GfshHelpCommand` and `GfshHintCommand`. One associated test, 
`HelperIntegrationTest`, has been updated to reflect this change.

**TESTING STATUS: Precheckin in progress**

- [x] JIRA ticket referenced

- [x] PR rebased

- [x] Commit single and squashed

- [x] `gradlew build` runs cleanly

- [ ] Tests updated

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/YehEmily/geode GEODE-3261

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/685.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #685


commit c02976dd103967f9eda3dfb59669bc1096d7dbb8
Author: YehEmily 
Date:   2017-08-04T18:12:50Z

GEODE-3261: Refactoring GfshHelpCommands




> Refactor GfshHelpCommands
> -
>
> Key: GEODE-3261
> URL: https://issues.apache.org/jira/browse/GEODE-3261
> Project: Geode
>  Issue Type: Sub-task
>  Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{GfshHelpCommands.java}} is a class that contains multiple commands. Each 
> command should be refactored into a separate class, and the methods shared by 
> the commands should be refactored into a new and appropriately named class of 
> their own.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)