[jira] [Commented] (GEODE-3410) Document new Query command

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173596#comment-16173596
 ] 

ASF subversion and git services commented on GEODE-3410:


Commit 828b24697823ee665b301ce3c54dbb15d0ccbce5 in geode's branch 
refs/heads/master from [~karensmolermiller]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=828b246 ]

GEODE-3410 Doc update for gfsh query command changes

- the --interactive option is gone
- there is a new --file option
- correct default value for APP_FETCH_SIZE gfsh env var
- gfsh env var APP_COLLECTION_LIMIT is no longer used

This closes #708

(cherry picked from commit 7528f1290aa8fc343787432d163cf43dd3fdfe21)


> Document new Query command
> --
>
> Key: GEODE-3410
> URL: https://issues.apache.org/jira/browse/GEODE-3410
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Jared Stewart
>Assignee: Karen Smoler Miller
> Fix For: 1.2.1
>
>
> The GFSH query command was recently changed and the docs need to be updated 
> to reflect the new parameters.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3410) Document new Query command

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16135668#comment-16135668
 ] 

ASF subversion and git services commented on GEODE-3410:


Commit 828b24697823ee665b301ce3c54dbb15d0ccbce5 in geode's branch 
refs/heads/release/1.2.1 from [~karensmolermiller]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=828b246 ]

GEODE-3410 Doc update for gfsh query command changes

- the --interactive option is gone
- there is a new --file option
- correct default value for APP_FETCH_SIZE gfsh env var
- gfsh env var APP_COLLECTION_LIMIT is no longer used

This closes #708

(cherry picked from commit 7528f1290aa8fc343787432d163cf43dd3fdfe21)


> Document new Query command
> --
>
> Key: GEODE-3410
> URL: https://issues.apache.org/jira/browse/GEODE-3410
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Jared Stewart
>Assignee: Karen Smoler Miller
> Fix For: 1.2.1
>
>
> The GFSH query command was recently changed and the docs need to be updated 
> to reflect the new parameters.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3410) Document new Query command

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123703#comment-16123703
 ] 

ASF subversion and git services commented on GEODE-3410:


Commit 7528f1290aa8fc343787432d163cf43dd3fdfe21 in geode's branch 
refs/heads/develop from [~karensmolermiller]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=7528f12 ]

GEODE-3410 Doc update for gfsh query command changes

- the --interactive option is gone
- there is a new --file option
- correct default value for APP_FETCH_SIZE gfsh env var
- gfsh env var APP_COLLECTION_LIMIT is no longer used

This closes #708


> Document new Query command
> --
>
> Key: GEODE-3410
> URL: https://issues.apache.org/jira/browse/GEODE-3410
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Jared Stewart
>Assignee: Karen Smoler Miller
> Fix For: 1.2.1
>
>
> The GFSH query command was recently changed and the docs need to be updated 
> to reflect the new parameters.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3410) Document new Query command

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123704#comment-16123704
 ] 

ASF GitHub Bot commented on GEODE-3410:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/708


> Document new Query command
> --
>
> Key: GEODE-3410
> URL: https://issues.apache.org/jira/browse/GEODE-3410
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Jared Stewart
>Assignee: Karen Smoler Miller
> Fix For: 1.2.1
>
>
> The GFSH query command was recently changed and the docs need to be updated 
> to reflect the new parameters.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3410) Document new Query command

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122511#comment-16122511
 ] 

ASF GitHub Bot commented on GEODE-3410:
---

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/708#discussion_r132591921
  
--- Diff: geode-docs/tools_modules/gfsh/command-pages/query.html.md.erb ---
@@ -21,7 +21,11 @@ limitations under the License.
 
 Run queries against Geode regions.
 
-Run the specified OQL query as a single quoted string and displays results 
in pages allows to move between pages. If limit is not set in the query, then a 
default limit of 1000 (derived from GFSH environment variable APP\_FETCH\_SIZE) 
will be applied. Page size is derived from GFSH environment variable 
APP\_COLLECTION\_LIMIT (default value=20).
+If a limit restricting the result size is not set in the query,
+then a default limit of the gfsh environment variable `APP_FETCH_SIZE`
--- End diff --

Would it be much work to add a link to that section here in that case?  I 
just suspect if I was a user I would have no idea what "the gfsh environment 
variable `APP_FETCH_SIZE`" means.


> Document new Query command
> --
>
> Key: GEODE-3410
> URL: https://issues.apache.org/jira/browse/GEODE-3410
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Jared Stewart
>Assignee: Karen Smoler Miller
> Fix For: 1.2.1
>
>
> The GFSH query command was recently changed and the docs need to be updated 
> to reflect the new parameters.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3410) Document new Query command

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122504#comment-16122504
 ] 

ASF GitHub Bot commented on GEODE-3410:
---

Github user karensmolermiller commented on a diff in the pull request:

https://github.com/apache/geode/pull/708#discussion_r132590875
  
--- Diff: geode-docs/tools_modules/gfsh/command-pages/query.html.md.erb ---
@@ -21,7 +21,11 @@ limitations under the License.
 
 Run queries against Geode regions.
 
-Run the specified OQL query as a single quoted string and displays results 
in pages allows to move between pages. If limit is not set in the query, then a 
default limit of 1000 (derived from GFSH environment variable APP\_FETCH\_SIZE) 
will be applied. Page size is derived from GFSH environment variable 
APP\_COLLECTION\_LIMIT (default value=20).
+If a limit restricting the result size is not set in the query,
+then a default limit of the gfsh environment variable `APP_FETCH_SIZE`
--- End diff --

The default size is given in the gfsh section titled 'Useful gfsh Shell 
Variables.'  I'd like to have that default value given in only 1 place in the 
documentation, such that if the value ever changes, we only need to update a 
single location.  If that is OK with you, I'll consider that you approve this 
PR.


> Document new Query command
> --
>
> Key: GEODE-3410
> URL: https://issues.apache.org/jira/browse/GEODE-3410
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Jared Stewart
>Assignee: Karen Smoler Miller
> Fix For: 1.2.1
>
>
> The GFSH query command was recently changed and the docs need to be updated 
> to reflect the new parameters.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3410) Document new Query command

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122490#comment-16122490
 ] 

ASF GitHub Bot commented on GEODE-3410:
---

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/708#discussion_r132589415
  
--- Diff: geode-docs/tools_modules/gfsh/command-pages/query.html.md.erb ---
@@ -21,7 +21,11 @@ limitations under the License.
 
 Run queries against Geode regions.
 
-Run the specified OQL query as a single quoted string and displays results 
in pages allows to move between pages. If limit is not set in the query, then a 
default limit of 1000 (derived from GFSH environment variable APP\_FETCH\_SIZE) 
will be applied. Page size is derived from GFSH environment variable 
APP\_COLLECTION\_LIMIT (default value=20).
+If a limit restricting the result size is not set in the query,
+then a default limit of the gfsh environment variable `APP_FETCH_SIZE`
--- End diff --

It might be nice to also mention that `APP_FETCH_SIZE` has a default value 
of 100 if not explicitly set by the user.


> Document new Query command
> --
>
> Key: GEODE-3410
> URL: https://issues.apache.org/jira/browse/GEODE-3410
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Jared Stewart
>Assignee: Karen Smoler Miller
> Fix For: 1.2.1
>
>
> The GFSH query command was recently changed and the docs need to be updated 
> to reflect the new parameters.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3410) Document new Query command

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1616#comment-1616
 ] 

ASF GitHub Bot commented on GEODE-3410:
---

GitHub user karensmolermiller opened a pull request:

https://github.com/apache/geode/pull/708

GEODE-3410 Doc update for gfsh query command changes

- the --interactive option is gone
- there is a new --file option
- correct default value for APP_FETCH_SIZE gfsh env var
- gfsh env var APP_COLLECTION_LIMIT is no longer used

@jaredjstewart @jinmeiliao @kirklund @davebarnes97 @joeymcallister Please 
review.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karensmolermiller/geode feature/GEODE-3410

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/708.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #708


commit 75ca6ab8cc41db02d0240d62ac6c034d94727e76
Author: Karen Miller 
Date:   2017-08-10T19:53:25Z

GEODE-3410 Doc update for gfsh query command changes

- the --interactive option is gone
- there is a new --file option
- correct default value for APP_FETCH_SIZE gfsh env var
- gfsh env var APP_COLLECTION_LIMIT is no longer used




> Document new Query command
> --
>
> Key: GEODE-3410
> URL: https://issues.apache.org/jira/browse/GEODE-3410
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Jared Stewart
>Assignee: Karen Smoler Miller
> Fix For: 1.2.1
>
>
> The GFSH query command was recently changed and the docs need to be updated 
> to reflect the new parameters.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)