[jira] [Commented] (GEODE-3436) GFSH commands tests are failing after committing refactorings of command classes

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145621#comment-16145621
 ] 

ASF subversion and git services commented on GEODE-3436:


Commit 851932ec10ea3146308710f274aa9b7a17d4dbab in geode's branch 
refs/heads/develop from YehEmily
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=851932e ]

GEODE-3436: Restore refactoring of StatusCommands

* See initial commit GEODE-3270 (359e3fff6482ecfb375939d387f4dad3a636246b)


> GFSH commands tests are failing after committing refactorings of command 
> classes
> 
>
> Key: GEODE-3436
> URL: https://issues.apache.org/jira/browse/GEODE-3436
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, tests
>Reporter: Kirk Lund
>
> Tests failing in geode-core:
> * HelperIntegrationTest.testHelpWithNoInput
> * HelperIntegrationTest.testHintWithNoInput
> * GfshParserConverterTest.testHintConverter
> * CliCommandsSecurityTest.testNoAccess
> * GfshCommandsSecurityTest.testRegionAReader
> * GfshCommandsSecurityTest.testRegionAWriter
> * GfshCommandsSecurityTest.testClusterReader
> * GfshCommandsSecurityTest.testClusterWriter
> * GfshCommandsSecurityTest.testClusterManager
> * GfshCommandsSecurityTest.testDataReader
> * GfshCommandsSecurityTest.testRegionAManager
> * GfshCommandsSecurityTest.testDataWriter
> * AnalyzeSerializablesJUnitTest.testSerializables (ParallelSnapshotFileMapper)
> Stack traces for the geode-core failures:
> {noformat}
> :geode-core:integrationTest
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHelpWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<2> but was:<4> in:
> <["help (Available)",
> "Display syntax and usage information for all commands or list all 
> available commands if  isn't specified.",
> "hint (Available)",
> "Provide hints for a topic or list all available topics if "topic" 
> isn't specified."]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHelpWithNoInput(HelperIntegrationTest.java:69)
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHintWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<21> but was:<22> in:
> <["Hints are available for the following topics. Use "hint " 
> for a specific hint.",
> "",
> "Client",
> "Cluster Configuration",
> "Configuration",
> "Data",
> "Debug-Utility",
> "Disk Store",
> "Function Execution",
> "GFSH",
> "Geode",
> "Help",
> "JMX",
> "Lifecycle",
> "Locator",
> "Logs",
> "Management-Monitoring",
> "Manager",
> "Region",
> "Server",
> "Statistics",
> "WAN"]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHintWithNoInput(HelperIntegrationTest.java:96)
> org.apache.geode.management.internal.cli.GfshParserConverterTest > 
> testHintConverter FAILED
> java.lang.StringIndexOutOfBoundsException: String index out of range: -1
> at java.lang.String.substring(String.java:1931)
> at 
> org.apache.geode.management.internal.cli.GfshParser.lambda$completeAdvanced$0(GfshParser.java:265)
> at java.util.ArrayList.replaceAll(ArrayList.java:1442)
> at 
> org.apache.geode.management.internal.cli.GfshParser.completeAdvanced(GfshParser.java:264)
> at 
> org.apache.geode.test.dunit.rules.GfshParserRule.complete(GfshParserRule.java:58)
> at 
> org.apache.geode.management.internal.cli.GfshParserConverterTest.testHintConverter(GfshParserConverterTest.java:126)
> org.apache.geode.management.internal.security.CliCommandsSecurityTest > 
> testNoAccess FAILED
> org.assertj.core.api.SoftAssertionError: 
> The following assertion failed:
> 1) [destroy function --id=InterestCalculations] 
> Expecting:
>  <"stranger not authorized for CLUSTER:MANAGE:JAR">
> to contain:
>  <"DATA:MANAGE"> 
> at CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:74)
> at 
> org.assertj.core.api.SoftAssertions.assertAll(SoftAssertions.java:134)
> at 
> org.apache.geode.management.internal.security.CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:78)
> org.apache.geode.management.internal.security.GfshCommandsSecurityTest > 
> testRegionAReader FAILED
> org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] 
> expected:<[110]> but was:<[415]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorA

[jira] [Commented] (GEODE-3436) GFSH commands tests are failing after committing refactorings of command classes

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145623#comment-16145623
 ] 

ASF subversion and git services commented on GEODE-3436:


Commit be8a135681d2fe156559c2dd60a501beb07b1ab8 in geode's branch 
refs/heads/develop from [~prhomberg]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=be8a135 ]

GEODE-3436: Suggested improvements to touched files.

* this closes #745


> GFSH commands tests are failing after committing refactorings of command 
> classes
> 
>
> Key: GEODE-3436
> URL: https://issues.apache.org/jira/browse/GEODE-3436
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, tests
>Reporter: Kirk Lund
>
> Tests failing in geode-core:
> * HelperIntegrationTest.testHelpWithNoInput
> * HelperIntegrationTest.testHintWithNoInput
> * GfshParserConverterTest.testHintConverter
> * CliCommandsSecurityTest.testNoAccess
> * GfshCommandsSecurityTest.testRegionAReader
> * GfshCommandsSecurityTest.testRegionAWriter
> * GfshCommandsSecurityTest.testClusterReader
> * GfshCommandsSecurityTest.testClusterWriter
> * GfshCommandsSecurityTest.testClusterManager
> * GfshCommandsSecurityTest.testDataReader
> * GfshCommandsSecurityTest.testRegionAManager
> * GfshCommandsSecurityTest.testDataWriter
> * AnalyzeSerializablesJUnitTest.testSerializables (ParallelSnapshotFileMapper)
> Stack traces for the geode-core failures:
> {noformat}
> :geode-core:integrationTest
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHelpWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<2> but was:<4> in:
> <["help (Available)",
> "Display syntax and usage information for all commands or list all 
> available commands if  isn't specified.",
> "hint (Available)",
> "Provide hints for a topic or list all available topics if "topic" 
> isn't specified."]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHelpWithNoInput(HelperIntegrationTest.java:69)
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHintWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<21> but was:<22> in:
> <["Hints are available for the following topics. Use "hint " 
> for a specific hint.",
> "",
> "Client",
> "Cluster Configuration",
> "Configuration",
> "Data",
> "Debug-Utility",
> "Disk Store",
> "Function Execution",
> "GFSH",
> "Geode",
> "Help",
> "JMX",
> "Lifecycle",
> "Locator",
> "Logs",
> "Management-Monitoring",
> "Manager",
> "Region",
> "Server",
> "Statistics",
> "WAN"]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHintWithNoInput(HelperIntegrationTest.java:96)
> org.apache.geode.management.internal.cli.GfshParserConverterTest > 
> testHintConverter FAILED
> java.lang.StringIndexOutOfBoundsException: String index out of range: -1
> at java.lang.String.substring(String.java:1931)
> at 
> org.apache.geode.management.internal.cli.GfshParser.lambda$completeAdvanced$0(GfshParser.java:265)
> at java.util.ArrayList.replaceAll(ArrayList.java:1442)
> at 
> org.apache.geode.management.internal.cli.GfshParser.completeAdvanced(GfshParser.java:264)
> at 
> org.apache.geode.test.dunit.rules.GfshParserRule.complete(GfshParserRule.java:58)
> at 
> org.apache.geode.management.internal.cli.GfshParserConverterTest.testHintConverter(GfshParserConverterTest.java:126)
> org.apache.geode.management.internal.security.CliCommandsSecurityTest > 
> testNoAccess FAILED
> org.assertj.core.api.SoftAssertionError: 
> The following assertion failed:
> 1) [destroy function --id=InterestCalculations] 
> Expecting:
>  <"stranger not authorized for CLUSTER:MANAGE:JAR">
> to contain:
>  <"DATA:MANAGE"> 
> at CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:74)
> at 
> org.assertj.core.api.SoftAssertions.assertAll(SoftAssertions.java:134)
> at 
> org.apache.geode.management.internal.security.CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:78)
> org.apache.geode.management.internal.security.GfshCommandsSecurityTest > 
> testRegionAReader FAILED
> org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] 
> expected:<[110]> but was:<[415]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at 
> sun.reflect.

[jira] [Commented] (GEODE-3436) GFSH commands tests are failing after committing refactorings of command classes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145611#comment-16145611
 ] 

ASF GitHub Bot commented on GEODE-3436:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/745


> GFSH commands tests are failing after committing refactorings of command 
> classes
> 
>
> Key: GEODE-3436
> URL: https://issues.apache.org/jira/browse/GEODE-3436
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, tests
>Reporter: Kirk Lund
>
> Tests failing in geode-core:
> * HelperIntegrationTest.testHelpWithNoInput
> * HelperIntegrationTest.testHintWithNoInput
> * GfshParserConverterTest.testHintConverter
> * CliCommandsSecurityTest.testNoAccess
> * GfshCommandsSecurityTest.testRegionAReader
> * GfshCommandsSecurityTest.testRegionAWriter
> * GfshCommandsSecurityTest.testClusterReader
> * GfshCommandsSecurityTest.testClusterWriter
> * GfshCommandsSecurityTest.testClusterManager
> * GfshCommandsSecurityTest.testDataReader
> * GfshCommandsSecurityTest.testRegionAManager
> * GfshCommandsSecurityTest.testDataWriter
> * AnalyzeSerializablesJUnitTest.testSerializables (ParallelSnapshotFileMapper)
> Stack traces for the geode-core failures:
> {noformat}
> :geode-core:integrationTest
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHelpWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<2> but was:<4> in:
> <["help (Available)",
> "Display syntax and usage information for all commands or list all 
> available commands if  isn't specified.",
> "hint (Available)",
> "Provide hints for a topic or list all available topics if "topic" 
> isn't specified."]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHelpWithNoInput(HelperIntegrationTest.java:69)
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHintWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<21> but was:<22> in:
> <["Hints are available for the following topics. Use "hint " 
> for a specific hint.",
> "",
> "Client",
> "Cluster Configuration",
> "Configuration",
> "Data",
> "Debug-Utility",
> "Disk Store",
> "Function Execution",
> "GFSH",
> "Geode",
> "Help",
> "JMX",
> "Lifecycle",
> "Locator",
> "Logs",
> "Management-Monitoring",
> "Manager",
> "Region",
> "Server",
> "Statistics",
> "WAN"]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHintWithNoInput(HelperIntegrationTest.java:96)
> org.apache.geode.management.internal.cli.GfshParserConverterTest > 
> testHintConverter FAILED
> java.lang.StringIndexOutOfBoundsException: String index out of range: -1
> at java.lang.String.substring(String.java:1931)
> at 
> org.apache.geode.management.internal.cli.GfshParser.lambda$completeAdvanced$0(GfshParser.java:265)
> at java.util.ArrayList.replaceAll(ArrayList.java:1442)
> at 
> org.apache.geode.management.internal.cli.GfshParser.completeAdvanced(GfshParser.java:264)
> at 
> org.apache.geode.test.dunit.rules.GfshParserRule.complete(GfshParserRule.java:58)
> at 
> org.apache.geode.management.internal.cli.GfshParserConverterTest.testHintConverter(GfshParserConverterTest.java:126)
> org.apache.geode.management.internal.security.CliCommandsSecurityTest > 
> testNoAccess FAILED
> org.assertj.core.api.SoftAssertionError: 
> The following assertion failed:
> 1) [destroy function --id=InterestCalculations] 
> Expecting:
>  <"stranger not authorized for CLUSTER:MANAGE:JAR">
> to contain:
>  <"DATA:MANAGE"> 
> at CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:74)
> at 
> org.assertj.core.api.SoftAssertions.assertAll(SoftAssertions.java:134)
> at 
> org.apache.geode.management.internal.security.CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:78)
> org.apache.geode.management.internal.security.GfshCommandsSecurityTest > 
> testRegionAReader FAILED
> org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] 
> expected:<[110]> but was:<[415]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at 
> org.apache.geode.management.internal.security.GfshCommandsSecurityTest.runComman

[jira] [Commented] (GEODE-3436) GFSH commands tests are failing after committing refactorings of command classes

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145604#comment-16145604
 ] 

ASF subversion and git services commented on GEODE-3436:


Commit 4fc3ffe07e2a326d765240d5fd7e65f27b6ed3cf in geode's branch 
refs/heads/develop from YehEmily
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=4fc3ffe ]

GEODE-3436: Restore refactoring of GfshHelpCommands

* See initial commit GEODE-3261 (cf91426692349d0c81ce77394935576d9cc336e8)


> GFSH commands tests are failing after committing refactorings of command 
> classes
> 
>
> Key: GEODE-3436
> URL: https://issues.apache.org/jira/browse/GEODE-3436
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, tests
>Reporter: Kirk Lund
>
> Tests failing in geode-core:
> * HelperIntegrationTest.testHelpWithNoInput
> * HelperIntegrationTest.testHintWithNoInput
> * GfshParserConverterTest.testHintConverter
> * CliCommandsSecurityTest.testNoAccess
> * GfshCommandsSecurityTest.testRegionAReader
> * GfshCommandsSecurityTest.testRegionAWriter
> * GfshCommandsSecurityTest.testClusterReader
> * GfshCommandsSecurityTest.testClusterWriter
> * GfshCommandsSecurityTest.testClusterManager
> * GfshCommandsSecurityTest.testDataReader
> * GfshCommandsSecurityTest.testRegionAManager
> * GfshCommandsSecurityTest.testDataWriter
> * AnalyzeSerializablesJUnitTest.testSerializables (ParallelSnapshotFileMapper)
> Stack traces for the geode-core failures:
> {noformat}
> :geode-core:integrationTest
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHelpWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<2> but was:<4> in:
> <["help (Available)",
> "Display syntax and usage information for all commands or list all 
> available commands if  isn't specified.",
> "hint (Available)",
> "Provide hints for a topic or list all available topics if "topic" 
> isn't specified."]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHelpWithNoInput(HelperIntegrationTest.java:69)
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHintWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<21> but was:<22> in:
> <["Hints are available for the following topics. Use "hint " 
> for a specific hint.",
> "",
> "Client",
> "Cluster Configuration",
> "Configuration",
> "Data",
> "Debug-Utility",
> "Disk Store",
> "Function Execution",
> "GFSH",
> "Geode",
> "Help",
> "JMX",
> "Lifecycle",
> "Locator",
> "Logs",
> "Management-Monitoring",
> "Manager",
> "Region",
> "Server",
> "Statistics",
> "WAN"]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHintWithNoInput(HelperIntegrationTest.java:96)
> org.apache.geode.management.internal.cli.GfshParserConverterTest > 
> testHintConverter FAILED
> java.lang.StringIndexOutOfBoundsException: String index out of range: -1
> at java.lang.String.substring(String.java:1931)
> at 
> org.apache.geode.management.internal.cli.GfshParser.lambda$completeAdvanced$0(GfshParser.java:265)
> at java.util.ArrayList.replaceAll(ArrayList.java:1442)
> at 
> org.apache.geode.management.internal.cli.GfshParser.completeAdvanced(GfshParser.java:264)
> at 
> org.apache.geode.test.dunit.rules.GfshParserRule.complete(GfshParserRule.java:58)
> at 
> org.apache.geode.management.internal.cli.GfshParserConverterTest.testHintConverter(GfshParserConverterTest.java:126)
> org.apache.geode.management.internal.security.CliCommandsSecurityTest > 
> testNoAccess FAILED
> org.assertj.core.api.SoftAssertionError: 
> The following assertion failed:
> 1) [destroy function --id=InterestCalculations] 
> Expecting:
>  <"stranger not authorized for CLUSTER:MANAGE:JAR">
> to contain:
>  <"DATA:MANAGE"> 
> at CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:74)
> at 
> org.assertj.core.api.SoftAssertions.assertAll(SoftAssertions.java:134)
> at 
> org.apache.geode.management.internal.security.CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:78)
> org.apache.geode.management.internal.security.GfshCommandsSecurityTest > 
> testRegionAReader FAILED
> org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] 
> expected:<[110]> but was:<[415]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructo

[jira] [Commented] (GEODE-3436) GFSH commands tests are failing after committing refactorings of command classes

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145615#comment-16145615
 ] 

ASF subversion and git services commented on GEODE-3436:


Commit 0dc67f0e7798a38afff906aa26e9bb89ab42b53c in geode's branch 
refs/heads/develop from YehEmily
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=0dc67f0 ]

GEODE-3436: Restore refactoring of IndexCommands

* See initial commit GEODE-3262 (ed293e817e547fb5ecd399bf4ba10d694af51e0a)


> GFSH commands tests are failing after committing refactorings of command 
> classes
> 
>
> Key: GEODE-3436
> URL: https://issues.apache.org/jira/browse/GEODE-3436
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, tests
>Reporter: Kirk Lund
>
> Tests failing in geode-core:
> * HelperIntegrationTest.testHelpWithNoInput
> * HelperIntegrationTest.testHintWithNoInput
> * GfshParserConverterTest.testHintConverter
> * CliCommandsSecurityTest.testNoAccess
> * GfshCommandsSecurityTest.testRegionAReader
> * GfshCommandsSecurityTest.testRegionAWriter
> * GfshCommandsSecurityTest.testClusterReader
> * GfshCommandsSecurityTest.testClusterWriter
> * GfshCommandsSecurityTest.testClusterManager
> * GfshCommandsSecurityTest.testDataReader
> * GfshCommandsSecurityTest.testRegionAManager
> * GfshCommandsSecurityTest.testDataWriter
> * AnalyzeSerializablesJUnitTest.testSerializables (ParallelSnapshotFileMapper)
> Stack traces for the geode-core failures:
> {noformat}
> :geode-core:integrationTest
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHelpWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<2> but was:<4> in:
> <["help (Available)",
> "Display syntax and usage information for all commands or list all 
> available commands if  isn't specified.",
> "hint (Available)",
> "Provide hints for a topic or list all available topics if "topic" 
> isn't specified."]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHelpWithNoInput(HelperIntegrationTest.java:69)
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHintWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<21> but was:<22> in:
> <["Hints are available for the following topics. Use "hint " 
> for a specific hint.",
> "",
> "Client",
> "Cluster Configuration",
> "Configuration",
> "Data",
> "Debug-Utility",
> "Disk Store",
> "Function Execution",
> "GFSH",
> "Geode",
> "Help",
> "JMX",
> "Lifecycle",
> "Locator",
> "Logs",
> "Management-Monitoring",
> "Manager",
> "Region",
> "Server",
> "Statistics",
> "WAN"]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHintWithNoInput(HelperIntegrationTest.java:96)
> org.apache.geode.management.internal.cli.GfshParserConverterTest > 
> testHintConverter FAILED
> java.lang.StringIndexOutOfBoundsException: String index out of range: -1
> at java.lang.String.substring(String.java:1931)
> at 
> org.apache.geode.management.internal.cli.GfshParser.lambda$completeAdvanced$0(GfshParser.java:265)
> at java.util.ArrayList.replaceAll(ArrayList.java:1442)
> at 
> org.apache.geode.management.internal.cli.GfshParser.completeAdvanced(GfshParser.java:264)
> at 
> org.apache.geode.test.dunit.rules.GfshParserRule.complete(GfshParserRule.java:58)
> at 
> org.apache.geode.management.internal.cli.GfshParserConverterTest.testHintConverter(GfshParserConverterTest.java:126)
> org.apache.geode.management.internal.security.CliCommandsSecurityTest > 
> testNoAccess FAILED
> org.assertj.core.api.SoftAssertionError: 
> The following assertion failed:
> 1) [destroy function --id=InterestCalculations] 
> Expecting:
>  <"stranger not authorized for CLUSTER:MANAGE:JAR">
> to contain:
>  <"DATA:MANAGE"> 
> at CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:74)
> at 
> org.assertj.core.api.SoftAssertions.assertAll(SoftAssertions.java:134)
> at 
> org.apache.geode.management.internal.security.CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:78)
> org.apache.geode.management.internal.security.GfshCommandsSecurityTest > 
> testRegionAReader FAILED
> org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] 
> expected:<[110]> but was:<[415]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAc

[jira] [Commented] (GEODE-3436) GFSH commands tests are failing after committing refactorings of command classes

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145606#comment-16145606
 ] 

ASF subversion and git services commented on GEODE-3436:


Commit 0c124b77a86e1144cd6a84ae6d7d61f75a132258 in geode's branch 
refs/heads/develop from YehEmily
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=0c124b7 ]

GEODE-3436: Restore refactoring of CreateAlterDestroyRegionCommands

* See initial commit GEODE-3255 (756efe77c86bb03ac9984655e7bd040659e85890)


> GFSH commands tests are failing after committing refactorings of command 
> classes
> 
>
> Key: GEODE-3436
> URL: https://issues.apache.org/jira/browse/GEODE-3436
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, tests
>Reporter: Kirk Lund
>
> Tests failing in geode-core:
> * HelperIntegrationTest.testHelpWithNoInput
> * HelperIntegrationTest.testHintWithNoInput
> * GfshParserConverterTest.testHintConverter
> * CliCommandsSecurityTest.testNoAccess
> * GfshCommandsSecurityTest.testRegionAReader
> * GfshCommandsSecurityTest.testRegionAWriter
> * GfshCommandsSecurityTest.testClusterReader
> * GfshCommandsSecurityTest.testClusterWriter
> * GfshCommandsSecurityTest.testClusterManager
> * GfshCommandsSecurityTest.testDataReader
> * GfshCommandsSecurityTest.testRegionAManager
> * GfshCommandsSecurityTest.testDataWriter
> * AnalyzeSerializablesJUnitTest.testSerializables (ParallelSnapshotFileMapper)
> Stack traces for the geode-core failures:
> {noformat}
> :geode-core:integrationTest
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHelpWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<2> but was:<4> in:
> <["help (Available)",
> "Display syntax and usage information for all commands or list all 
> available commands if  isn't specified.",
> "hint (Available)",
> "Provide hints for a topic or list all available topics if "topic" 
> isn't specified."]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHelpWithNoInput(HelperIntegrationTest.java:69)
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHintWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<21> but was:<22> in:
> <["Hints are available for the following topics. Use "hint " 
> for a specific hint.",
> "",
> "Client",
> "Cluster Configuration",
> "Configuration",
> "Data",
> "Debug-Utility",
> "Disk Store",
> "Function Execution",
> "GFSH",
> "Geode",
> "Help",
> "JMX",
> "Lifecycle",
> "Locator",
> "Logs",
> "Management-Monitoring",
> "Manager",
> "Region",
> "Server",
> "Statistics",
> "WAN"]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHintWithNoInput(HelperIntegrationTest.java:96)
> org.apache.geode.management.internal.cli.GfshParserConverterTest > 
> testHintConverter FAILED
> java.lang.StringIndexOutOfBoundsException: String index out of range: -1
> at java.lang.String.substring(String.java:1931)
> at 
> org.apache.geode.management.internal.cli.GfshParser.lambda$completeAdvanced$0(GfshParser.java:265)
> at java.util.ArrayList.replaceAll(ArrayList.java:1442)
> at 
> org.apache.geode.management.internal.cli.GfshParser.completeAdvanced(GfshParser.java:264)
> at 
> org.apache.geode.test.dunit.rules.GfshParserRule.complete(GfshParserRule.java:58)
> at 
> org.apache.geode.management.internal.cli.GfshParserConverterTest.testHintConverter(GfshParserConverterTest.java:126)
> org.apache.geode.management.internal.security.CliCommandsSecurityTest > 
> testNoAccess FAILED
> org.assertj.core.api.SoftAssertionError: 
> The following assertion failed:
> 1) [destroy function --id=InterestCalculations] 
> Expecting:
>  <"stranger not authorized for CLUSTER:MANAGE:JAR">
> to contain:
>  <"DATA:MANAGE"> 
> at CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:74)
> at 
> org.assertj.core.api.SoftAssertions.assertAll(SoftAssertions.java:134)
> at 
> org.apache.geode.management.internal.security.CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:78)
> org.apache.geode.management.internal.security.GfshCommandsSecurityTest > 
> testRegionAReader FAILED
> org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] 
> expected:<[110]> but was:<[415]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(

[jira] [Commented] (GEODE-3436) GFSH commands tests are failing after committing refactorings of command classes

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145619#comment-16145619
 ] 

ASF subversion and git services commented on GEODE-3436:


Commit 18f65de782bc1eec2e72a9209d3adc7e7e5c19cc in geode's branch 
refs/heads/develop from YehEmily
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=18f65de ]

GEODE-3436: Restore refactoring of DeployCommands

* See initial commit GEODE-3257 (9d967446a44a78b612f605b6a8f8eedcfc625b3a)


> GFSH commands tests are failing after committing refactorings of command 
> classes
> 
>
> Key: GEODE-3436
> URL: https://issues.apache.org/jira/browse/GEODE-3436
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, tests
>Reporter: Kirk Lund
>
> Tests failing in geode-core:
> * HelperIntegrationTest.testHelpWithNoInput
> * HelperIntegrationTest.testHintWithNoInput
> * GfshParserConverterTest.testHintConverter
> * CliCommandsSecurityTest.testNoAccess
> * GfshCommandsSecurityTest.testRegionAReader
> * GfshCommandsSecurityTest.testRegionAWriter
> * GfshCommandsSecurityTest.testClusterReader
> * GfshCommandsSecurityTest.testClusterWriter
> * GfshCommandsSecurityTest.testClusterManager
> * GfshCommandsSecurityTest.testDataReader
> * GfshCommandsSecurityTest.testRegionAManager
> * GfshCommandsSecurityTest.testDataWriter
> * AnalyzeSerializablesJUnitTest.testSerializables (ParallelSnapshotFileMapper)
> Stack traces for the geode-core failures:
> {noformat}
> :geode-core:integrationTest
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHelpWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<2> but was:<4> in:
> <["help (Available)",
> "Display syntax and usage information for all commands or list all 
> available commands if  isn't specified.",
> "hint (Available)",
> "Provide hints for a topic or list all available topics if "topic" 
> isn't specified."]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHelpWithNoInput(HelperIntegrationTest.java:69)
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHintWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<21> but was:<22> in:
> <["Hints are available for the following topics. Use "hint " 
> for a specific hint.",
> "",
> "Client",
> "Cluster Configuration",
> "Configuration",
> "Data",
> "Debug-Utility",
> "Disk Store",
> "Function Execution",
> "GFSH",
> "Geode",
> "Help",
> "JMX",
> "Lifecycle",
> "Locator",
> "Logs",
> "Management-Monitoring",
> "Manager",
> "Region",
> "Server",
> "Statistics",
> "WAN"]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHintWithNoInput(HelperIntegrationTest.java:96)
> org.apache.geode.management.internal.cli.GfshParserConverterTest > 
> testHintConverter FAILED
> java.lang.StringIndexOutOfBoundsException: String index out of range: -1
> at java.lang.String.substring(String.java:1931)
> at 
> org.apache.geode.management.internal.cli.GfshParser.lambda$completeAdvanced$0(GfshParser.java:265)
> at java.util.ArrayList.replaceAll(ArrayList.java:1442)
> at 
> org.apache.geode.management.internal.cli.GfshParser.completeAdvanced(GfshParser.java:264)
> at 
> org.apache.geode.test.dunit.rules.GfshParserRule.complete(GfshParserRule.java:58)
> at 
> org.apache.geode.management.internal.cli.GfshParserConverterTest.testHintConverter(GfshParserConverterTest.java:126)
> org.apache.geode.management.internal.security.CliCommandsSecurityTest > 
> testNoAccess FAILED
> org.assertj.core.api.SoftAssertionError: 
> The following assertion failed:
> 1) [destroy function --id=InterestCalculations] 
> Expecting:
>  <"stranger not authorized for CLUSTER:MANAGE:JAR">
> to contain:
>  <"DATA:MANAGE"> 
> at CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:74)
> at 
> org.assertj.core.api.SoftAssertions.assertAll(SoftAssertions.java:134)
> at 
> org.apache.geode.management.internal.security.CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:78)
> org.apache.geode.management.internal.security.GfshCommandsSecurityTest > 
> testRegionAReader FAILED
> org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] 
> expected:<[110]> but was:<[415]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorA

[jira] [Commented] (GEODE-3436) GFSH commands tests are failing after committing refactorings of command classes

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145608#comment-16145608
 ] 

ASF subversion and git services commented on GEODE-3436:


Commit 39fff4544c8ddc0b96ff58ed56c7394b1e9e10e4 in geode's branch 
refs/heads/develop from YehEmily
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=39fff45 ]

GEODE-3436: Restore refactoring of Refactoring FunctionCommands

* See initial commit GEODE-3260 (90f5440de8ec747f301a309a0a34101e8defcd29)


> GFSH commands tests are failing after committing refactorings of command 
> classes
> 
>
> Key: GEODE-3436
> URL: https://issues.apache.org/jira/browse/GEODE-3436
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, tests
>Reporter: Kirk Lund
>
> Tests failing in geode-core:
> * HelperIntegrationTest.testHelpWithNoInput
> * HelperIntegrationTest.testHintWithNoInput
> * GfshParserConverterTest.testHintConverter
> * CliCommandsSecurityTest.testNoAccess
> * GfshCommandsSecurityTest.testRegionAReader
> * GfshCommandsSecurityTest.testRegionAWriter
> * GfshCommandsSecurityTest.testClusterReader
> * GfshCommandsSecurityTest.testClusterWriter
> * GfshCommandsSecurityTest.testClusterManager
> * GfshCommandsSecurityTest.testDataReader
> * GfshCommandsSecurityTest.testRegionAManager
> * GfshCommandsSecurityTest.testDataWriter
> * AnalyzeSerializablesJUnitTest.testSerializables (ParallelSnapshotFileMapper)
> Stack traces for the geode-core failures:
> {noformat}
> :geode-core:integrationTest
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHelpWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<2> but was:<4> in:
> <["help (Available)",
> "Display syntax and usage information for all commands or list all 
> available commands if  isn't specified.",
> "hint (Available)",
> "Provide hints for a topic or list all available topics if "topic" 
> isn't specified."]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHelpWithNoInput(HelperIntegrationTest.java:69)
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHintWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<21> but was:<22> in:
> <["Hints are available for the following topics. Use "hint " 
> for a specific hint.",
> "",
> "Client",
> "Cluster Configuration",
> "Configuration",
> "Data",
> "Debug-Utility",
> "Disk Store",
> "Function Execution",
> "GFSH",
> "Geode",
> "Help",
> "JMX",
> "Lifecycle",
> "Locator",
> "Logs",
> "Management-Monitoring",
> "Manager",
> "Region",
> "Server",
> "Statistics",
> "WAN"]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHintWithNoInput(HelperIntegrationTest.java:96)
> org.apache.geode.management.internal.cli.GfshParserConverterTest > 
> testHintConverter FAILED
> java.lang.StringIndexOutOfBoundsException: String index out of range: -1
> at java.lang.String.substring(String.java:1931)
> at 
> org.apache.geode.management.internal.cli.GfshParser.lambda$completeAdvanced$0(GfshParser.java:265)
> at java.util.ArrayList.replaceAll(ArrayList.java:1442)
> at 
> org.apache.geode.management.internal.cli.GfshParser.completeAdvanced(GfshParser.java:264)
> at 
> org.apache.geode.test.dunit.rules.GfshParserRule.complete(GfshParserRule.java:58)
> at 
> org.apache.geode.management.internal.cli.GfshParserConverterTest.testHintConverter(GfshParserConverterTest.java:126)
> org.apache.geode.management.internal.security.CliCommandsSecurityTest > 
> testNoAccess FAILED
> org.assertj.core.api.SoftAssertionError: 
> The following assertion failed:
> 1) [destroy function --id=InterestCalculations] 
> Expecting:
>  <"stranger not authorized for CLUSTER:MANAGE:JAR">
> to contain:
>  <"DATA:MANAGE"> 
> at CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:74)
> at 
> org.assertj.core.api.SoftAssertions.assertAll(SoftAssertions.java:134)
> at 
> org.apache.geode.management.internal.security.CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:78)
> org.apache.geode.management.internal.security.GfshCommandsSecurityTest > 
> testRegionAReader FAILED
> org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] 
> expected:<[110]> but was:<[415]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(Nati

[jira] [Commented] (GEODE-3436) GFSH commands tests are failing after committing refactorings of command classes

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145617#comment-16145617
 ] 

ASF subversion and git services commented on GEODE-3436:


Commit ca808714ef93ba5232ce5be5f7e2533106bcfc34 in geode's branch 
refs/heads/develop from YehEmily
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=ca80871 ]

GEODE-3436: Restore refactoring of DiskStoreCommands

* See initial commit GEODE-3258 (5d6cad7755ec3c4fe931e3d0f8e89fb181038543)


> GFSH commands tests are failing after committing refactorings of command 
> classes
> 
>
> Key: GEODE-3436
> URL: https://issues.apache.org/jira/browse/GEODE-3436
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, tests
>Reporter: Kirk Lund
>
> Tests failing in geode-core:
> * HelperIntegrationTest.testHelpWithNoInput
> * HelperIntegrationTest.testHintWithNoInput
> * GfshParserConverterTest.testHintConverter
> * CliCommandsSecurityTest.testNoAccess
> * GfshCommandsSecurityTest.testRegionAReader
> * GfshCommandsSecurityTest.testRegionAWriter
> * GfshCommandsSecurityTest.testClusterReader
> * GfshCommandsSecurityTest.testClusterWriter
> * GfshCommandsSecurityTest.testClusterManager
> * GfshCommandsSecurityTest.testDataReader
> * GfshCommandsSecurityTest.testRegionAManager
> * GfshCommandsSecurityTest.testDataWriter
> * AnalyzeSerializablesJUnitTest.testSerializables (ParallelSnapshotFileMapper)
> Stack traces for the geode-core failures:
> {noformat}
> :geode-core:integrationTest
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHelpWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<2> but was:<4> in:
> <["help (Available)",
> "Display syntax and usage information for all commands or list all 
> available commands if  isn't specified.",
> "hint (Available)",
> "Provide hints for a topic or list all available topics if "topic" 
> isn't specified."]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHelpWithNoInput(HelperIntegrationTest.java:69)
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHintWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<21> but was:<22> in:
> <["Hints are available for the following topics. Use "hint " 
> for a specific hint.",
> "",
> "Client",
> "Cluster Configuration",
> "Configuration",
> "Data",
> "Debug-Utility",
> "Disk Store",
> "Function Execution",
> "GFSH",
> "Geode",
> "Help",
> "JMX",
> "Lifecycle",
> "Locator",
> "Logs",
> "Management-Monitoring",
> "Manager",
> "Region",
> "Server",
> "Statistics",
> "WAN"]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHintWithNoInput(HelperIntegrationTest.java:96)
> org.apache.geode.management.internal.cli.GfshParserConverterTest > 
> testHintConverter FAILED
> java.lang.StringIndexOutOfBoundsException: String index out of range: -1
> at java.lang.String.substring(String.java:1931)
> at 
> org.apache.geode.management.internal.cli.GfshParser.lambda$completeAdvanced$0(GfshParser.java:265)
> at java.util.ArrayList.replaceAll(ArrayList.java:1442)
> at 
> org.apache.geode.management.internal.cli.GfshParser.completeAdvanced(GfshParser.java:264)
> at 
> org.apache.geode.test.dunit.rules.GfshParserRule.complete(GfshParserRule.java:58)
> at 
> org.apache.geode.management.internal.cli.GfshParserConverterTest.testHintConverter(GfshParserConverterTest.java:126)
> org.apache.geode.management.internal.security.CliCommandsSecurityTest > 
> testNoAccess FAILED
> org.assertj.core.api.SoftAssertionError: 
> The following assertion failed:
> 1) [destroy function --id=InterestCalculations] 
> Expecting:
>  <"stranger not authorized for CLUSTER:MANAGE:JAR">
> to contain:
>  <"DATA:MANAGE"> 
> at CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:74)
> at 
> org.assertj.core.api.SoftAssertions.assertAll(SoftAssertions.java:134)
> at 
> org.apache.geode.management.internal.security.CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:78)
> org.apache.geode.management.internal.security.GfshCommandsSecurityTest > 
> testRegionAReader FAILED
> org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] 
> expected:<[110]> but was:<[415]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstruct

[jira] [Commented] (GEODE-3436) GFSH commands tests are failing after committing refactorings of command classes

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145613#comment-16145613
 ] 

ASF subversion and git services commented on GEODE-3436:


Commit 3bfe7a201ce77365f6197be36a3947afea749f10 in geode's branch 
refs/heads/develop from YehEmily
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=3bfe7a2 ]

GEODE-3436: Restore refactoring of ConfigCommands

* See initial commit GEODE-3254 (97c4e9a59f17c7bc914e39dd048b0a4cd96293c4)


> GFSH commands tests are failing after committing refactorings of command 
> classes
> 
>
> Key: GEODE-3436
> URL: https://issues.apache.org/jira/browse/GEODE-3436
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, tests
>Reporter: Kirk Lund
>
> Tests failing in geode-core:
> * HelperIntegrationTest.testHelpWithNoInput
> * HelperIntegrationTest.testHintWithNoInput
> * GfshParserConverterTest.testHintConverter
> * CliCommandsSecurityTest.testNoAccess
> * GfshCommandsSecurityTest.testRegionAReader
> * GfshCommandsSecurityTest.testRegionAWriter
> * GfshCommandsSecurityTest.testClusterReader
> * GfshCommandsSecurityTest.testClusterWriter
> * GfshCommandsSecurityTest.testClusterManager
> * GfshCommandsSecurityTest.testDataReader
> * GfshCommandsSecurityTest.testRegionAManager
> * GfshCommandsSecurityTest.testDataWriter
> * AnalyzeSerializablesJUnitTest.testSerializables (ParallelSnapshotFileMapper)
> Stack traces for the geode-core failures:
> {noformat}
> :geode-core:integrationTest
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHelpWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<2> but was:<4> in:
> <["help (Available)",
> "Display syntax and usage information for all commands or list all 
> available commands if  isn't specified.",
> "hint (Available)",
> "Provide hints for a topic or list all available topics if "topic" 
> isn't specified."]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHelpWithNoInput(HelperIntegrationTest.java:69)
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHintWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<21> but was:<22> in:
> <["Hints are available for the following topics. Use "hint " 
> for a specific hint.",
> "",
> "Client",
> "Cluster Configuration",
> "Configuration",
> "Data",
> "Debug-Utility",
> "Disk Store",
> "Function Execution",
> "GFSH",
> "Geode",
> "Help",
> "JMX",
> "Lifecycle",
> "Locator",
> "Logs",
> "Management-Monitoring",
> "Manager",
> "Region",
> "Server",
> "Statistics",
> "WAN"]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHintWithNoInput(HelperIntegrationTest.java:96)
> org.apache.geode.management.internal.cli.GfshParserConverterTest > 
> testHintConverter FAILED
> java.lang.StringIndexOutOfBoundsException: String index out of range: -1
> at java.lang.String.substring(String.java:1931)
> at 
> org.apache.geode.management.internal.cli.GfshParser.lambda$completeAdvanced$0(GfshParser.java:265)
> at java.util.ArrayList.replaceAll(ArrayList.java:1442)
> at 
> org.apache.geode.management.internal.cli.GfshParser.completeAdvanced(GfshParser.java:264)
> at 
> org.apache.geode.test.dunit.rules.GfshParserRule.complete(GfshParserRule.java:58)
> at 
> org.apache.geode.management.internal.cli.GfshParserConverterTest.testHintConverter(GfshParserConverterTest.java:126)
> org.apache.geode.management.internal.security.CliCommandsSecurityTest > 
> testNoAccess FAILED
> org.assertj.core.api.SoftAssertionError: 
> The following assertion failed:
> 1) [destroy function --id=InterestCalculations] 
> Expecting:
>  <"stranger not authorized for CLUSTER:MANAGE:JAR">
> to contain:
>  <"DATA:MANAGE"> 
> at CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:74)
> at 
> org.assertj.core.api.SoftAssertions.assertAll(SoftAssertions.java:134)
> at 
> org.apache.geode.management.internal.security.CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:78)
> org.apache.geode.management.internal.security.GfshCommandsSecurityTest > 
> testRegionAReader FAILED
> org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] 
> expected:<[110]> but was:<[415]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorA

[jira] [Commented] (GEODE-3436) GFSH commands tests are failing after committing refactorings of command classes

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145610#comment-16145610
 ] 

ASF subversion and git services commented on GEODE-3436:


Commit 611095f0a196ee58a51da6a75367791eff18ca19 in geode's branch 
refs/heads/develop from YehEmily
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=611095f ]

GEODE-3436: Restore refactoring of Refactoring MiscellaneousCommands

* See initial commit GEODE-3265 (63169699e933f6e0fdd90b95ed039e4e3c92c32c)


> GFSH commands tests are failing after committing refactorings of command 
> classes
> 
>
> Key: GEODE-3436
> URL: https://issues.apache.org/jira/browse/GEODE-3436
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, tests
>Reporter: Kirk Lund
>
> Tests failing in geode-core:
> * HelperIntegrationTest.testHelpWithNoInput
> * HelperIntegrationTest.testHintWithNoInput
> * GfshParserConverterTest.testHintConverter
> * CliCommandsSecurityTest.testNoAccess
> * GfshCommandsSecurityTest.testRegionAReader
> * GfshCommandsSecurityTest.testRegionAWriter
> * GfshCommandsSecurityTest.testClusterReader
> * GfshCommandsSecurityTest.testClusterWriter
> * GfshCommandsSecurityTest.testClusterManager
> * GfshCommandsSecurityTest.testDataReader
> * GfshCommandsSecurityTest.testRegionAManager
> * GfshCommandsSecurityTest.testDataWriter
> * AnalyzeSerializablesJUnitTest.testSerializables (ParallelSnapshotFileMapper)
> Stack traces for the geode-core failures:
> {noformat}
> :geode-core:integrationTest
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHelpWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<2> but was:<4> in:
> <["help (Available)",
> "Display syntax and usage information for all commands or list all 
> available commands if  isn't specified.",
> "hint (Available)",
> "Provide hints for a topic or list all available topics if "topic" 
> isn't specified."]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHelpWithNoInput(HelperIntegrationTest.java:69)
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHintWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<21> but was:<22> in:
> <["Hints are available for the following topics. Use "hint " 
> for a specific hint.",
> "",
> "Client",
> "Cluster Configuration",
> "Configuration",
> "Data",
> "Debug-Utility",
> "Disk Store",
> "Function Execution",
> "GFSH",
> "Geode",
> "Help",
> "JMX",
> "Lifecycle",
> "Locator",
> "Logs",
> "Management-Monitoring",
> "Manager",
> "Region",
> "Server",
> "Statistics",
> "WAN"]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHintWithNoInput(HelperIntegrationTest.java:96)
> org.apache.geode.management.internal.cli.GfshParserConverterTest > 
> testHintConverter FAILED
> java.lang.StringIndexOutOfBoundsException: String index out of range: -1
> at java.lang.String.substring(String.java:1931)
> at 
> org.apache.geode.management.internal.cli.GfshParser.lambda$completeAdvanced$0(GfshParser.java:265)
> at java.util.ArrayList.replaceAll(ArrayList.java:1442)
> at 
> org.apache.geode.management.internal.cli.GfshParser.completeAdvanced(GfshParser.java:264)
> at 
> org.apache.geode.test.dunit.rules.GfshParserRule.complete(GfshParserRule.java:58)
> at 
> org.apache.geode.management.internal.cli.GfshParserConverterTest.testHintConverter(GfshParserConverterTest.java:126)
> org.apache.geode.management.internal.security.CliCommandsSecurityTest > 
> testNoAccess FAILED
> org.assertj.core.api.SoftAssertionError: 
> The following assertion failed:
> 1) [destroy function --id=InterestCalculations] 
> Expecting:
>  <"stranger not authorized for CLUSTER:MANAGE:JAR">
> to contain:
>  <"DATA:MANAGE"> 
> at CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:74)
> at 
> org.assertj.core.api.SoftAssertions.assertAll(SoftAssertions.java:134)
> at 
> org.apache.geode.management.internal.security.CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:78)
> org.apache.geode.management.internal.security.GfshCommandsSecurityTest > 
> testRegionAReader FAILED
> org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] 
> expected:<[110]> but was:<[415]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance

[jira] [Commented] (GEODE-3436) GFSH commands tests are failing after committing refactorings of command classes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145586#comment-16145586
 ] 

ASF GitHub Bot commented on GEODE-3436:
---

Github user PurelyApplied commented on the issue:

https://github.com/apache/geode/pull/745
  
Precheckin fully green.


> GFSH commands tests are failing after committing refactorings of command 
> classes
> 
>
> Key: GEODE-3436
> URL: https://issues.apache.org/jira/browse/GEODE-3436
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, tests
>Reporter: Kirk Lund
>
> Tests failing in geode-core:
> * HelperIntegrationTest.testHelpWithNoInput
> * HelperIntegrationTest.testHintWithNoInput
> * GfshParserConverterTest.testHintConverter
> * CliCommandsSecurityTest.testNoAccess
> * GfshCommandsSecurityTest.testRegionAReader
> * GfshCommandsSecurityTest.testRegionAWriter
> * GfshCommandsSecurityTest.testClusterReader
> * GfshCommandsSecurityTest.testClusterWriter
> * GfshCommandsSecurityTest.testClusterManager
> * GfshCommandsSecurityTest.testDataReader
> * GfshCommandsSecurityTest.testRegionAManager
> * GfshCommandsSecurityTest.testDataWriter
> * AnalyzeSerializablesJUnitTest.testSerializables (ParallelSnapshotFileMapper)
> Stack traces for the geode-core failures:
> {noformat}
> :geode-core:integrationTest
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHelpWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<2> but was:<4> in:
> <["help (Available)",
> "Display syntax and usage information for all commands or list all 
> available commands if  isn't specified.",
> "hint (Available)",
> "Provide hints for a topic or list all available topics if "topic" 
> isn't specified."]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHelpWithNoInput(HelperIntegrationTest.java:69)
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHintWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<21> but was:<22> in:
> <["Hints are available for the following topics. Use "hint " 
> for a specific hint.",
> "",
> "Client",
> "Cluster Configuration",
> "Configuration",
> "Data",
> "Debug-Utility",
> "Disk Store",
> "Function Execution",
> "GFSH",
> "Geode",
> "Help",
> "JMX",
> "Lifecycle",
> "Locator",
> "Logs",
> "Management-Monitoring",
> "Manager",
> "Region",
> "Server",
> "Statistics",
> "WAN"]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHintWithNoInput(HelperIntegrationTest.java:96)
> org.apache.geode.management.internal.cli.GfshParserConverterTest > 
> testHintConverter FAILED
> java.lang.StringIndexOutOfBoundsException: String index out of range: -1
> at java.lang.String.substring(String.java:1931)
> at 
> org.apache.geode.management.internal.cli.GfshParser.lambda$completeAdvanced$0(GfshParser.java:265)
> at java.util.ArrayList.replaceAll(ArrayList.java:1442)
> at 
> org.apache.geode.management.internal.cli.GfshParser.completeAdvanced(GfshParser.java:264)
> at 
> org.apache.geode.test.dunit.rules.GfshParserRule.complete(GfshParserRule.java:58)
> at 
> org.apache.geode.management.internal.cli.GfshParserConverterTest.testHintConverter(GfshParserConverterTest.java:126)
> org.apache.geode.management.internal.security.CliCommandsSecurityTest > 
> testNoAccess FAILED
> org.assertj.core.api.SoftAssertionError: 
> The following assertion failed:
> 1) [destroy function --id=InterestCalculations] 
> Expecting:
>  <"stranger not authorized for CLUSTER:MANAGE:JAR">
> to contain:
>  <"DATA:MANAGE"> 
> at CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:74)
> at 
> org.assertj.core.api.SoftAssertions.assertAll(SoftAssertions.java:134)
> at 
> org.apache.geode.management.internal.security.CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:78)
> org.apache.geode.management.internal.security.GfshCommandsSecurityTest > 
> testRegionAReader FAILED
> org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] 
> expected:<[110]> but was:<[415]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at 
> org.apache.geode.management.internal.security.

[jira] [Commented] (GEODE-3436) GFSH commands tests are failing after committing refactorings of command classes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144528#comment-16144528
 ] 

ASF GitHub Bot commented on GEODE-3436:
---

GitHub user PurelyApplied reopened a pull request:

https://github.com/apache/geode/pull/745

GEODE-3436: Restore reverted GFSH command refactoring

Given that this would restore multiple tickets worth of commits, it was 
unclear if this PR should squash all commits or if the history would be clearer 
without one enormous commit.

Precheckin returned green excepting spotless and some other minor 
adjustments (import ordering correction, etc).  Running another precheckin for 
due course.

-

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [n/a] Have you written or updated unit tests to verify your changes? 
[Existing tests provide coverage for refactored code.]

- [n/a] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to d...@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PurelyApplied/geode geode-3436

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/745.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #745


commit caeb8375db68d68ec0ddbca6b81fd6ca6c91a73f
Author: YehEmily 
Date:   2017-08-22T17:57:05Z

GEODE-3436: Restore refactoring of MemberCommands

* See initial commit GEODE-3264 (d27f8b956de7d9c5d95ebdc68dfc67ee8b2d7b51)

commit 44cc0e8bb7927e61bb3e7613612703518fc87db6
Author: YehEmily 
Date:   2017-08-07T18:52:14Z

GEODE-3436: Restore refactoring of DurableClientCommands

* See initial commit GEODE-3259 (440c87f81fab96f9ce38a2d53ded75e5fe8390d7)

commit 1e9eea1f1b2d2c620679283aaf6e6c5ac12e1728
Author: YehEmily 
Date:   2017-08-04T17:47:48Z

GEODE-3436: Restore refactoring of PDXCommands

* See initial commit GEODE-3266 (67185abcdd68b908dea6888cb94286b8aa9ea49f)

commit 691700c2e51aef5b18ba5feec711bddf5ae9a05e
Author: YehEmily 
Date:   2017-08-07T20:58:08Z

GEODE-3436: Restore refactoring of RegionCommands

* See initial commits GEODE-3268 
(64de3b69c2aecb4930bcfd0a1161569b1d5fda89), GEODE-3255 
(756efe77c86bb03ac9984655e7bd040659e85890)

commit 0acf8be27f5ab5f6d9d5009bb7ec6740c1f7ae1b
Author: YehEmily 
Date:   2017-08-07T21:47:15Z

GEODE-3436: Restore refactoring of QueueCommands

* See initial commit GEODE-3267 (fd47ed660168864a6f81b2a4cd7dbceebc99a282)

commit 7594ebdd5e593179f0b33a94c30c7d5949fabf96
Author: YehEmily 
Date:   2017-08-24T22:42:12Z

GEODE-3436: Restore refactoring of GfshHelpCommands

* See initial commit GEODE-3261 (cf91426692349d0c81ce77394935576d9cc336e8)

commit 5daeb011cbeebfa2a71c225ed3dc3abc2047e3dd
Author: YehEmily 
Date:   2017-08-24T23:11:13Z

GEODE-3436: Restore refactoring of CreateAlterDestroyRegionCommands

* See initial commit GEODE-3255 (756efe77c86bb03ac9984655e7bd040659e85890)

commit a1823d323c26adebacf7536448e2cadf054d9528
Author: YehEmily 
Date:   2017-07-26T18:07:09Z

GEODE-3436: Restore refactoring of ConfigCommands

* See initial commit GEODE-3254 (97c4e9a59f17c7bc914e39dd048b0a4cd96293c4)

commit 78ec3cb687313799a911ed3d1ca6e560cb358de8
Author: YehEmily 
Date:   2017-08-03T16:00:08Z

GEODE-3436: Restore refactoring of DiskStoreCommands

* See initial commit GEODE-3258 (5d6cad7755ec3c4fe931e3d0f8e89fb181038543)

commit 1ecbd6fa08343a8de50bf30839c9ef47c02e73aa
Author: YehEmily 
Date:   2017-08-07T19:35:14Z

GEODE-3436: Restore refactoring of IndexCommands

* See initial commit GEODE-3262 (ed293e817e547fb5ecd399bf4ba10d694af51e0a)

commit b562bdafc46045bd2679c233cf591549fb016d8b
Author: YehEmily 
Date:   2017-08-07T19:56:17Z

GEODE-3436: Restore refactoring of Refactoring FunctionCommands

* See initial commit GEODE-3260 (90f5440de8ec747f301a309a0a34101e8def

[jira] [Commented] (GEODE-3436) GFSH commands tests are failing after committing refactorings of command classes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144527#comment-16144527
 ] 

ASF GitHub Bot commented on GEODE-3436:
---

Github user PurelyApplied closed the pull request at:

https://github.com/apache/geode/pull/745


> GFSH commands tests are failing after committing refactorings of command 
> classes
> 
>
> Key: GEODE-3436
> URL: https://issues.apache.org/jira/browse/GEODE-3436
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, tests
>Reporter: Kirk Lund
>
> Tests failing in geode-core:
> * HelperIntegrationTest.testHelpWithNoInput
> * HelperIntegrationTest.testHintWithNoInput
> * GfshParserConverterTest.testHintConverter
> * CliCommandsSecurityTest.testNoAccess
> * GfshCommandsSecurityTest.testRegionAReader
> * GfshCommandsSecurityTest.testRegionAWriter
> * GfshCommandsSecurityTest.testClusterReader
> * GfshCommandsSecurityTest.testClusterWriter
> * GfshCommandsSecurityTest.testClusterManager
> * GfshCommandsSecurityTest.testDataReader
> * GfshCommandsSecurityTest.testRegionAManager
> * GfshCommandsSecurityTest.testDataWriter
> * AnalyzeSerializablesJUnitTest.testSerializables (ParallelSnapshotFileMapper)
> Stack traces for the geode-core failures:
> {noformat}
> :geode-core:integrationTest
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHelpWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<2> but was:<4> in:
> <["help (Available)",
> "Display syntax and usage information for all commands or list all 
> available commands if  isn't specified.",
> "hint (Available)",
> "Provide hints for a topic or list all available topics if "topic" 
> isn't specified."]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHelpWithNoInput(HelperIntegrationTest.java:69)
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHintWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<21> but was:<22> in:
> <["Hints are available for the following topics. Use "hint " 
> for a specific hint.",
> "",
> "Client",
> "Cluster Configuration",
> "Configuration",
> "Data",
> "Debug-Utility",
> "Disk Store",
> "Function Execution",
> "GFSH",
> "Geode",
> "Help",
> "JMX",
> "Lifecycle",
> "Locator",
> "Logs",
> "Management-Monitoring",
> "Manager",
> "Region",
> "Server",
> "Statistics",
> "WAN"]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHintWithNoInput(HelperIntegrationTest.java:96)
> org.apache.geode.management.internal.cli.GfshParserConverterTest > 
> testHintConverter FAILED
> java.lang.StringIndexOutOfBoundsException: String index out of range: -1
> at java.lang.String.substring(String.java:1931)
> at 
> org.apache.geode.management.internal.cli.GfshParser.lambda$completeAdvanced$0(GfshParser.java:265)
> at java.util.ArrayList.replaceAll(ArrayList.java:1442)
> at 
> org.apache.geode.management.internal.cli.GfshParser.completeAdvanced(GfshParser.java:264)
> at 
> org.apache.geode.test.dunit.rules.GfshParserRule.complete(GfshParserRule.java:58)
> at 
> org.apache.geode.management.internal.cli.GfshParserConverterTest.testHintConverter(GfshParserConverterTest.java:126)
> org.apache.geode.management.internal.security.CliCommandsSecurityTest > 
> testNoAccess FAILED
> org.assertj.core.api.SoftAssertionError: 
> The following assertion failed:
> 1) [destroy function --id=InterestCalculations] 
> Expecting:
>  <"stranger not authorized for CLUSTER:MANAGE:JAR">
> to contain:
>  <"DATA:MANAGE"> 
> at CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:74)
> at 
> org.assertj.core.api.SoftAssertions.assertAll(SoftAssertions.java:134)
> at 
> org.apache.geode.management.internal.security.CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:78)
> org.apache.geode.management.internal.security.GfshCommandsSecurityTest > 
> testRegionAReader FAILED
> org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] 
> expected:<[110]> but was:<[415]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at 
> org.apache.geode.management.internal.security.GfshCommandsSecurityTest.ru

[jira] [Commented] (GEODE-3436) GFSH commands tests are failing after committing refactorings of command classes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144382#comment-16144382
 ] 

ASF GitHub Bot commented on GEODE-3436:
---

Github user PurelyApplied commented on a diff in the pull request:

https://github.com/apache/geode/pull/745#discussion_r135641458
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/management/internal/security/TestCommand.java
 ---
@@ -171,28 +171,37 @@ private static void init() {
 createTestCommand("alter disk-store --name=foo --region=xyz 
--disk-dirs=bar");
 createTestCommand("destroy disk-store --name=foo", clusterManageDisk);
 
-// DurableClientCommands
+// CloseDurableClientCommand, CloseDurableCQsCommand, 
CountDurableCQEventsCommand,
+// ListDurableClientCQsCommand
 createTestCommand("close durable-client --durable-client-id=client1", 
clusterManageQuery);
 createTestCommand("close durable-cq --durable-client-id=client1 
--durable-cq-name=cq1",
 clusterManageQuery);
 createTestCommand("show subscription-queue-size 
--durable-client-id=client1", clusterRead);
 createTestCommand("list durable-cqs --durable-client-id=client1", 
clusterRead);
 
-// ExportIMportSharedConfigurationCommands
+// ExportImportSharedConfigurationCommands
 createTestCommand("export cluster-configuration 
--zip-file-name=mySharedConfig.zip",
 clusterRead);
 createTestCommand("import cluster-configuration 
--zip-file-name=value.zip", clusterManage);
 
-// FunctionCommands
+// DestroyFunctionCommand, ExecuteFunctionCommand, ListFunctionCommand
+// TODO PSR: the `destroy function` command is interactive (in its 
interceptor) when both
--- End diff --

Killed the TODO, left the function commented out since it'll throw an error 
before authentication in that test.

I think that and the associated classes need a refactor in any case.  I'll 
address the commented-out-ness of the several functions then.


> GFSH commands tests are failing after committing refactorings of command 
> classes
> 
>
> Key: GEODE-3436
> URL: https://issues.apache.org/jira/browse/GEODE-3436
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, tests
>Reporter: Kirk Lund
>
> Tests failing in geode-core:
> * HelperIntegrationTest.testHelpWithNoInput
> * HelperIntegrationTest.testHintWithNoInput
> * GfshParserConverterTest.testHintConverter
> * CliCommandsSecurityTest.testNoAccess
> * GfshCommandsSecurityTest.testRegionAReader
> * GfshCommandsSecurityTest.testRegionAWriter
> * GfshCommandsSecurityTest.testClusterReader
> * GfshCommandsSecurityTest.testClusterWriter
> * GfshCommandsSecurityTest.testClusterManager
> * GfshCommandsSecurityTest.testDataReader
> * GfshCommandsSecurityTest.testRegionAManager
> * GfshCommandsSecurityTest.testDataWriter
> * AnalyzeSerializablesJUnitTest.testSerializables (ParallelSnapshotFileMapper)
> Stack traces for the geode-core failures:
> {noformat}
> :geode-core:integrationTest
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHelpWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<2> but was:<4> in:
> <["help (Available)",
> "Display syntax and usage information for all commands or list all 
> available commands if  isn't specified.",
> "hint (Available)",
> "Provide hints for a topic or list all available topics if "topic" 
> isn't specified."]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHelpWithNoInput(HelperIntegrationTest.java:69)
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHintWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<21> but was:<22> in:
> <["Hints are available for the following topics. Use "hint " 
> for a specific hint.",
> "",
> "Client",
> "Cluster Configuration",
> "Configuration",
> "Data",
> "Debug-Utility",
> "Disk Store",
> "Function Execution",
> "GFSH",
> "Geode",
> "Help",
> "JMX",
> "Lifecycle",
> "Locator",
> "Logs",
> "Management-Monitoring",
> "Manager",
> "Region",
> "Server",
> "Statistics",
> "WAN"]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHintWithNoInput(HelperIntegrationTest.java:96)
> org.apache.geode.management.internal.cli.GfshParserConverterTest > 
> testHintConverter FAILED
> java.lang.StringIndexOutOfBoundsException: String index out of range: -1
> at java.lang.String.substring(St

[jira] [Commented] (GEODE-3436) GFSH commands tests are failing after committing refactorings of command classes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144373#comment-16144373
 ] 

ASF GitHub Bot commented on GEODE-3436:
---

Github user pdxrunner commented on a diff in the pull request:

https://github.com/apache/geode/pull/745#discussion_r135639047
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/management/internal/security/TestCommand.java
 ---
@@ -171,28 +171,37 @@ private static void init() {
 createTestCommand("alter disk-store --name=foo --region=xyz 
--disk-dirs=bar");
 createTestCommand("destroy disk-store --name=foo", clusterManageDisk);
 
-// DurableClientCommands
+// CloseDurableClientCommand, CloseDurableCQsCommand, 
CountDurableCQEventsCommand,
+// ListDurableClientCQsCommand
 createTestCommand("close durable-client --durable-client-id=client1", 
clusterManageQuery);
 createTestCommand("close durable-cq --durable-client-id=client1 
--durable-cq-name=cq1",
 clusterManageQuery);
 createTestCommand("show subscription-queue-size 
--durable-client-id=client1", clusterRead);
 createTestCommand("list durable-cqs --durable-client-id=client1", 
clusterRead);
 
-// ExportIMportSharedConfigurationCommands
+// ExportImportSharedConfigurationCommands
 createTestCommand("export cluster-configuration 
--zip-file-name=mySharedConfig.zip",
 clusterRead);
 createTestCommand("import cluster-configuration 
--zip-file-name=value.zip", clusterManage);
 
-// FunctionCommands
+// DestroyFunctionCommand, ExecuteFunctionCommand, ListFunctionCommand
+// TODO PSR: the `destroy function` command is interactive (in its 
interceptor) when both
--- End diff --

Have got a resolution on these TODO's?


> GFSH commands tests are failing after committing refactorings of command 
> classes
> 
>
> Key: GEODE-3436
> URL: https://issues.apache.org/jira/browse/GEODE-3436
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, tests
>Reporter: Kirk Lund
>
> Tests failing in geode-core:
> * HelperIntegrationTest.testHelpWithNoInput
> * HelperIntegrationTest.testHintWithNoInput
> * GfshParserConverterTest.testHintConverter
> * CliCommandsSecurityTest.testNoAccess
> * GfshCommandsSecurityTest.testRegionAReader
> * GfshCommandsSecurityTest.testRegionAWriter
> * GfshCommandsSecurityTest.testClusterReader
> * GfshCommandsSecurityTest.testClusterWriter
> * GfshCommandsSecurityTest.testClusterManager
> * GfshCommandsSecurityTest.testDataReader
> * GfshCommandsSecurityTest.testRegionAManager
> * GfshCommandsSecurityTest.testDataWriter
> * AnalyzeSerializablesJUnitTest.testSerializables (ParallelSnapshotFileMapper)
> Stack traces for the geode-core failures:
> {noformat}
> :geode-core:integrationTest
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHelpWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<2> but was:<4> in:
> <["help (Available)",
> "Display syntax and usage information for all commands or list all 
> available commands if  isn't specified.",
> "hint (Available)",
> "Provide hints for a topic or list all available topics if "topic" 
> isn't specified."]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHelpWithNoInput(HelperIntegrationTest.java:69)
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHintWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<21> but was:<22> in:
> <["Hints are available for the following topics. Use "hint " 
> for a specific hint.",
> "",
> "Client",
> "Cluster Configuration",
> "Configuration",
> "Data",
> "Debug-Utility",
> "Disk Store",
> "Function Execution",
> "GFSH",
> "Geode",
> "Help",
> "JMX",
> "Lifecycle",
> "Locator",
> "Logs",
> "Management-Monitoring",
> "Manager",
> "Region",
> "Server",
> "Statistics",
> "WAN"]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHintWithNoInput(HelperIntegrationTest.java:96)
> org.apache.geode.management.internal.cli.GfshParserConverterTest > 
> testHintConverter FAILED
> java.lang.StringIndexOutOfBoundsException: String index out of range: -1
> at java.lang.String.substring(String.java:1931)
> at 
> org.apache.geode.management.internal.cli.GfshParser.lambda$completeAdvanced$0(GfshParser.java:265)
> at java.util.ArrayList.replaceAll(ArrayList.java:1442)
> at 
> org.apache.ge

[jira] [Commented] (GEODE-3436) GFSH commands tests are failing after committing refactorings of command classes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144354#comment-16144354
 ] 

ASF GitHub Bot commented on GEODE-3436:
---

Github user PurelyApplied commented on a diff in the pull request:

https://github.com/apache/geode/pull/745#discussion_r135635781
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ShowMetricsCommand.java
 ---
@@ -794,7 +84,7 @@ public Result showMetrics(
   }
   if (regionName != null && !regionName.isEmpty()) {
 
-if 
(!org.apache.geode.internal.lang.StringUtils.isBlank(cacheServerPortString)) {
+if (!StringUtils.isBlank(cacheServerPortString)) {
--- End diff --

One step closer to purging that class altogether!


> GFSH commands tests are failing after committing refactorings of command 
> classes
> 
>
> Key: GEODE-3436
> URL: https://issues.apache.org/jira/browse/GEODE-3436
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, tests
>Reporter: Kirk Lund
>
> Tests failing in geode-core:
> * HelperIntegrationTest.testHelpWithNoInput
> * HelperIntegrationTest.testHintWithNoInput
> * GfshParserConverterTest.testHintConverter
> * CliCommandsSecurityTest.testNoAccess
> * GfshCommandsSecurityTest.testRegionAReader
> * GfshCommandsSecurityTest.testRegionAWriter
> * GfshCommandsSecurityTest.testClusterReader
> * GfshCommandsSecurityTest.testClusterWriter
> * GfshCommandsSecurityTest.testClusterManager
> * GfshCommandsSecurityTest.testDataReader
> * GfshCommandsSecurityTest.testRegionAManager
> * GfshCommandsSecurityTest.testDataWriter
> * AnalyzeSerializablesJUnitTest.testSerializables (ParallelSnapshotFileMapper)
> Stack traces for the geode-core failures:
> {noformat}
> :geode-core:integrationTest
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHelpWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<2> but was:<4> in:
> <["help (Available)",
> "Display syntax and usage information for all commands or list all 
> available commands if  isn't specified.",
> "hint (Available)",
> "Provide hints for a topic or list all available topics if "topic" 
> isn't specified."]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHelpWithNoInput(HelperIntegrationTest.java:69)
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHintWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<21> but was:<22> in:
> <["Hints are available for the following topics. Use "hint " 
> for a specific hint.",
> "",
> "Client",
> "Cluster Configuration",
> "Configuration",
> "Data",
> "Debug-Utility",
> "Disk Store",
> "Function Execution",
> "GFSH",
> "Geode",
> "Help",
> "JMX",
> "Lifecycle",
> "Locator",
> "Logs",
> "Management-Monitoring",
> "Manager",
> "Region",
> "Server",
> "Statistics",
> "WAN"]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHintWithNoInput(HelperIntegrationTest.java:96)
> org.apache.geode.management.internal.cli.GfshParserConverterTest > 
> testHintConverter FAILED
> java.lang.StringIndexOutOfBoundsException: String index out of range: -1
> at java.lang.String.substring(String.java:1931)
> at 
> org.apache.geode.management.internal.cli.GfshParser.lambda$completeAdvanced$0(GfshParser.java:265)
> at java.util.ArrayList.replaceAll(ArrayList.java:1442)
> at 
> org.apache.geode.management.internal.cli.GfshParser.completeAdvanced(GfshParser.java:264)
> at 
> org.apache.geode.test.dunit.rules.GfshParserRule.complete(GfshParserRule.java:58)
> at 
> org.apache.geode.management.internal.cli.GfshParserConverterTest.testHintConverter(GfshParserConverterTest.java:126)
> org.apache.geode.management.internal.security.CliCommandsSecurityTest > 
> testNoAccess FAILED
> org.assertj.core.api.SoftAssertionError: 
> The following assertion failed:
> 1) [destroy function --id=InterestCalculations] 
> Expecting:
>  <"stranger not authorized for CLUSTER:MANAGE:JAR">
> to contain:
>  <"DATA:MANAGE"> 
> at CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:74)
> at 
> org.assertj.core.api.SoftAssertions.assertAll(SoftAssertions.java:134)
> at 
> org.apache.geode.management.internal.security.CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:78)
> org.apache.geode.management.internal.security.GfshCommandsSecurityTest > 
> testRegionARead

[jira] [Commented] (GEODE-3436) GFSH commands tests are failing after committing refactorings of command classes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144355#comment-16144355
 ] 

ASF GitHub Bot commented on GEODE-3436:
---

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/geode/pull/745#discussion_r135635795
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ShowMetricsCommand.java
 ---
@@ -794,7 +84,7 @@ public Result showMetrics(
   }
   if (regionName != null && !regionName.isEmpty()) {
 
-if 
(!org.apache.geode.internal.lang.StringUtils.isBlank(cacheServerPortString)) {
+if (!StringUtils.isBlank(cacheServerPortString)) {
--- End diff --

Let's leave these things for other cleanup tasks. The focus of this change 
set is to break these command into separate classes. I know we all can't resist 
the urge of making everything perfect from time to time, but one thing at a 
time.


> GFSH commands tests are failing after committing refactorings of command 
> classes
> 
>
> Key: GEODE-3436
> URL: https://issues.apache.org/jira/browse/GEODE-3436
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, tests
>Reporter: Kirk Lund
>
> Tests failing in geode-core:
> * HelperIntegrationTest.testHelpWithNoInput
> * HelperIntegrationTest.testHintWithNoInput
> * GfshParserConverterTest.testHintConverter
> * CliCommandsSecurityTest.testNoAccess
> * GfshCommandsSecurityTest.testRegionAReader
> * GfshCommandsSecurityTest.testRegionAWriter
> * GfshCommandsSecurityTest.testClusterReader
> * GfshCommandsSecurityTest.testClusterWriter
> * GfshCommandsSecurityTest.testClusterManager
> * GfshCommandsSecurityTest.testDataReader
> * GfshCommandsSecurityTest.testRegionAManager
> * GfshCommandsSecurityTest.testDataWriter
> * AnalyzeSerializablesJUnitTest.testSerializables (ParallelSnapshotFileMapper)
> Stack traces for the geode-core failures:
> {noformat}
> :geode-core:integrationTest
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHelpWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<2> but was:<4> in:
> <["help (Available)",
> "Display syntax and usage information for all commands or list all 
> available commands if  isn't specified.",
> "hint (Available)",
> "Provide hints for a topic or list all available topics if "topic" 
> isn't specified."]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHelpWithNoInput(HelperIntegrationTest.java:69)
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHintWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<21> but was:<22> in:
> <["Hints are available for the following topics. Use "hint " 
> for a specific hint.",
> "",
> "Client",
> "Cluster Configuration",
> "Configuration",
> "Data",
> "Debug-Utility",
> "Disk Store",
> "Function Execution",
> "GFSH",
> "Geode",
> "Help",
> "JMX",
> "Lifecycle",
> "Locator",
> "Logs",
> "Management-Monitoring",
> "Manager",
> "Region",
> "Server",
> "Statistics",
> "WAN"]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHintWithNoInput(HelperIntegrationTest.java:96)
> org.apache.geode.management.internal.cli.GfshParserConverterTest > 
> testHintConverter FAILED
> java.lang.StringIndexOutOfBoundsException: String index out of range: -1
> at java.lang.String.substring(String.java:1931)
> at 
> org.apache.geode.management.internal.cli.GfshParser.lambda$completeAdvanced$0(GfshParser.java:265)
> at java.util.ArrayList.replaceAll(ArrayList.java:1442)
> at 
> org.apache.geode.management.internal.cli.GfshParser.completeAdvanced(GfshParser.java:264)
> at 
> org.apache.geode.test.dunit.rules.GfshParserRule.complete(GfshParserRule.java:58)
> at 
> org.apache.geode.management.internal.cli.GfshParserConverterTest.testHintConverter(GfshParserConverterTest.java:126)
> org.apache.geode.management.internal.security.CliCommandsSecurityTest > 
> testNoAccess FAILED
> org.assertj.core.api.SoftAssertionError: 
> The following assertion failed:
> 1) [destroy function --id=InterestCalculations] 
> Expecting:
>  <"stranger not authorized for CLUSTER:MANAGE:JAR">
> to contain:
>  <"DATA:MANAGE"> 
> at CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:74)
> at 
> org.assertj.core.api.SoftAssertions.assertAll(SoftAssertions.java:134)
> at 
> org.apache.geode.manag

[jira] [Commented] (GEODE-3436) GFSH commands tests are failing after committing refactorings of command classes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144348#comment-16144348
 ] 

ASF GitHub Bot commented on GEODE-3436:
---

Github user pdxrunner commented on a diff in the pull request:

https://github.com/apache/geode/pull/745#discussion_r135634811
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ShowMetricsCommand.java
 ---
@@ -794,7 +84,7 @@ public Result showMetrics(
   }
   if (regionName != null && !regionName.isEmpty()) {
 
-if 
(!org.apache.geode.internal.lang.StringUtils.isBlank(cacheServerPortString)) {
+if (!StringUtils.isBlank(cacheServerPortString)) {
--- End diff --

Use apache.commons.StringUtils.isNotBlank() instead of the deprecated Geode 
version of StringUtils


> GFSH commands tests are failing after committing refactorings of command 
> classes
> 
>
> Key: GEODE-3436
> URL: https://issues.apache.org/jira/browse/GEODE-3436
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, tests
>Reporter: Kirk Lund
>
> Tests failing in geode-core:
> * HelperIntegrationTest.testHelpWithNoInput
> * HelperIntegrationTest.testHintWithNoInput
> * GfshParserConverterTest.testHintConverter
> * CliCommandsSecurityTest.testNoAccess
> * GfshCommandsSecurityTest.testRegionAReader
> * GfshCommandsSecurityTest.testRegionAWriter
> * GfshCommandsSecurityTest.testClusterReader
> * GfshCommandsSecurityTest.testClusterWriter
> * GfshCommandsSecurityTest.testClusterManager
> * GfshCommandsSecurityTest.testDataReader
> * GfshCommandsSecurityTest.testRegionAManager
> * GfshCommandsSecurityTest.testDataWriter
> * AnalyzeSerializablesJUnitTest.testSerializables (ParallelSnapshotFileMapper)
> Stack traces for the geode-core failures:
> {noformat}
> :geode-core:integrationTest
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHelpWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<2> but was:<4> in:
> <["help (Available)",
> "Display syntax and usage information for all commands or list all 
> available commands if  isn't specified.",
> "hint (Available)",
> "Provide hints for a topic or list all available topics if "topic" 
> isn't specified."]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHelpWithNoInput(HelperIntegrationTest.java:69)
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHintWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<21> but was:<22> in:
> <["Hints are available for the following topics. Use "hint " 
> for a specific hint.",
> "",
> "Client",
> "Cluster Configuration",
> "Configuration",
> "Data",
> "Debug-Utility",
> "Disk Store",
> "Function Execution",
> "GFSH",
> "Geode",
> "Help",
> "JMX",
> "Lifecycle",
> "Locator",
> "Logs",
> "Management-Monitoring",
> "Manager",
> "Region",
> "Server",
> "Statistics",
> "WAN"]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHintWithNoInput(HelperIntegrationTest.java:96)
> org.apache.geode.management.internal.cli.GfshParserConverterTest > 
> testHintConverter FAILED
> java.lang.StringIndexOutOfBoundsException: String index out of range: -1
> at java.lang.String.substring(String.java:1931)
> at 
> org.apache.geode.management.internal.cli.GfshParser.lambda$completeAdvanced$0(GfshParser.java:265)
> at java.util.ArrayList.replaceAll(ArrayList.java:1442)
> at 
> org.apache.geode.management.internal.cli.GfshParser.completeAdvanced(GfshParser.java:264)
> at 
> org.apache.geode.test.dunit.rules.GfshParserRule.complete(GfshParserRule.java:58)
> at 
> org.apache.geode.management.internal.cli.GfshParserConverterTest.testHintConverter(GfshParserConverterTest.java:126)
> org.apache.geode.management.internal.security.CliCommandsSecurityTest > 
> testNoAccess FAILED
> org.assertj.core.api.SoftAssertionError: 
> The following assertion failed:
> 1) [destroy function --id=InterestCalculations] 
> Expecting:
>  <"stranger not authorized for CLUSTER:MANAGE:JAR">
> to contain:
>  <"DATA:MANAGE"> 
> at CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:74)
> at 
> org.assertj.core.api.SoftAssertions.assertAll(SoftAssertions.java:134)
> at 
> org.apache.geode.management.internal.security.CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:78)
> org.apache.geode.management.internal.security

[jira] [Commented] (GEODE-3436) GFSH commands tests are failing after committing refactorings of command classes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144341#comment-16144341
 ] 

ASF GitHub Bot commented on GEODE-3436:
---

Github user pdxrunner commented on a diff in the pull request:

https://github.com/apache/geode/pull/745#discussion_r135633281
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExecuteFunctionCommand.java
 ---
@@ -156,7 +132,7 @@ public Result executeFunction(
 // if user wish to execute on locator then he can choose --member 
or --group option
 Set dsMembers = 
CliUtil.getAllNormalMembers(cache);
 if (dsMembers.size() > 0) {
-  function = new UserFunctionExecution();
+  new UserFunctionExecution();
--- End diff --

Where is this object used?


> GFSH commands tests are failing after committing refactorings of command 
> classes
> 
>
> Key: GEODE-3436
> URL: https://issues.apache.org/jira/browse/GEODE-3436
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, tests
>Reporter: Kirk Lund
>
> Tests failing in geode-core:
> * HelperIntegrationTest.testHelpWithNoInput
> * HelperIntegrationTest.testHintWithNoInput
> * GfshParserConverterTest.testHintConverter
> * CliCommandsSecurityTest.testNoAccess
> * GfshCommandsSecurityTest.testRegionAReader
> * GfshCommandsSecurityTest.testRegionAWriter
> * GfshCommandsSecurityTest.testClusterReader
> * GfshCommandsSecurityTest.testClusterWriter
> * GfshCommandsSecurityTest.testClusterManager
> * GfshCommandsSecurityTest.testDataReader
> * GfshCommandsSecurityTest.testRegionAManager
> * GfshCommandsSecurityTest.testDataWriter
> * AnalyzeSerializablesJUnitTest.testSerializables (ParallelSnapshotFileMapper)
> Stack traces for the geode-core failures:
> {noformat}
> :geode-core:integrationTest
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHelpWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<2> but was:<4> in:
> <["help (Available)",
> "Display syntax and usage information for all commands or list all 
> available commands if  isn't specified.",
> "hint (Available)",
> "Provide hints for a topic or list all available topics if "topic" 
> isn't specified."]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHelpWithNoInput(HelperIntegrationTest.java:69)
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHintWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<21> but was:<22> in:
> <["Hints are available for the following topics. Use "hint " 
> for a specific hint.",
> "",
> "Client",
> "Cluster Configuration",
> "Configuration",
> "Data",
> "Debug-Utility",
> "Disk Store",
> "Function Execution",
> "GFSH",
> "Geode",
> "Help",
> "JMX",
> "Lifecycle",
> "Locator",
> "Logs",
> "Management-Monitoring",
> "Manager",
> "Region",
> "Server",
> "Statistics",
> "WAN"]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHintWithNoInput(HelperIntegrationTest.java:96)
> org.apache.geode.management.internal.cli.GfshParserConverterTest > 
> testHintConverter FAILED
> java.lang.StringIndexOutOfBoundsException: String index out of range: -1
> at java.lang.String.substring(String.java:1931)
> at 
> org.apache.geode.management.internal.cli.GfshParser.lambda$completeAdvanced$0(GfshParser.java:265)
> at java.util.ArrayList.replaceAll(ArrayList.java:1442)
> at 
> org.apache.geode.management.internal.cli.GfshParser.completeAdvanced(GfshParser.java:264)
> at 
> org.apache.geode.test.dunit.rules.GfshParserRule.complete(GfshParserRule.java:58)
> at 
> org.apache.geode.management.internal.cli.GfshParserConverterTest.testHintConverter(GfshParserConverterTest.java:126)
> org.apache.geode.management.internal.security.CliCommandsSecurityTest > 
> testNoAccess FAILED
> org.assertj.core.api.SoftAssertionError: 
> The following assertion failed:
> 1) [destroy function --id=InterestCalculations] 
> Expecting:
>  <"stranger not authorized for CLUSTER:MANAGE:JAR">
> to contain:
>  <"DATA:MANAGE"> 
> at CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:74)
> at 
> org.assertj.core.api.SoftAssertions.assertAll(SoftAssertions.java:134)
> at 
> org.apache.geode.management.internal.security.CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:78)
> org.apache.geode.management.internal.security.

[jira] [Commented] (GEODE-3436) GFSH commands tests are failing after committing refactorings of command classes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144332#comment-16144332
 ] 

ASF GitHub Bot commented on GEODE-3436:
---

Github user PurelyApplied commented on a diff in the pull request:

https://github.com/apache/geode/pull/745#discussion_r135632737
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateRegionCommand.java
 ---
@@ -247,7 +207,7 @@ public Result createRegion(
   new Object[] {CliStrings.CREATE_REGION__USEATTRIBUTESFROM, 
useAttributesFrom}));
--- End diff --

If there is one person to whom you need not apologize for nit-picking, it's 
this guy.

Inspections find six cases across `RegionCreateFunction` and 
`CreateRegionCommand`.  Done and done.


> GFSH commands tests are failing after committing refactorings of command 
> classes
> 
>
> Key: GEODE-3436
> URL: https://issues.apache.org/jira/browse/GEODE-3436
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, tests
>Reporter: Kirk Lund
>
> Tests failing in geode-core:
> * HelperIntegrationTest.testHelpWithNoInput
> * HelperIntegrationTest.testHintWithNoInput
> * GfshParserConverterTest.testHintConverter
> * CliCommandsSecurityTest.testNoAccess
> * GfshCommandsSecurityTest.testRegionAReader
> * GfshCommandsSecurityTest.testRegionAWriter
> * GfshCommandsSecurityTest.testClusterReader
> * GfshCommandsSecurityTest.testClusterWriter
> * GfshCommandsSecurityTest.testClusterManager
> * GfshCommandsSecurityTest.testDataReader
> * GfshCommandsSecurityTest.testRegionAManager
> * GfshCommandsSecurityTest.testDataWriter
> * AnalyzeSerializablesJUnitTest.testSerializables (ParallelSnapshotFileMapper)
> Stack traces for the geode-core failures:
> {noformat}
> :geode-core:integrationTest
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHelpWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<2> but was:<4> in:
> <["help (Available)",
> "Display syntax and usage information for all commands or list all 
> available commands if  isn't specified.",
> "hint (Available)",
> "Provide hints for a topic or list all available topics if "topic" 
> isn't specified."]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHelpWithNoInput(HelperIntegrationTest.java:69)
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHintWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<21> but was:<22> in:
> <["Hints are available for the following topics. Use "hint " 
> for a specific hint.",
> "",
> "Client",
> "Cluster Configuration",
> "Configuration",
> "Data",
> "Debug-Utility",
> "Disk Store",
> "Function Execution",
> "GFSH",
> "Geode",
> "Help",
> "JMX",
> "Lifecycle",
> "Locator",
> "Logs",
> "Management-Monitoring",
> "Manager",
> "Region",
> "Server",
> "Statistics",
> "WAN"]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHintWithNoInput(HelperIntegrationTest.java:96)
> org.apache.geode.management.internal.cli.GfshParserConverterTest > 
> testHintConverter FAILED
> java.lang.StringIndexOutOfBoundsException: String index out of range: -1
> at java.lang.String.substring(String.java:1931)
> at 
> org.apache.geode.management.internal.cli.GfshParser.lambda$completeAdvanced$0(GfshParser.java:265)
> at java.util.ArrayList.replaceAll(ArrayList.java:1442)
> at 
> org.apache.geode.management.internal.cli.GfshParser.completeAdvanced(GfshParser.java:264)
> at 
> org.apache.geode.test.dunit.rules.GfshParserRule.complete(GfshParserRule.java:58)
> at 
> org.apache.geode.management.internal.cli.GfshParserConverterTest.testHintConverter(GfshParserConverterTest.java:126)
> org.apache.geode.management.internal.security.CliCommandsSecurityTest > 
> testNoAccess FAILED
> org.assertj.core.api.SoftAssertionError: 
> The following assertion failed:
> 1) [destroy function --id=InterestCalculations] 
> Expecting:
>  <"stranger not authorized for CLUSTER:MANAGE:JAR">
> to contain:
>  <"DATA:MANAGE"> 
> at CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:74)
> at 
> org.assertj.core.api.SoftAssertions.assertAll(SoftAssertions.java:134)
> at 
> org.apache.geode.management.internal.security.CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:78)
> org.apache.geode.management.internal.security.GfshCommandsSecurityTest > 
> testR

[jira] [Commented] (GEODE-3436) GFSH commands tests are failing after committing refactorings of command classes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144311#comment-16144311
 ] 

ASF GitHub Bot commented on GEODE-3436:
---

Github user pdxrunner commented on a diff in the pull request:

https://github.com/apache/geode/pull/745#discussion_r135629055
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateRegionCommand.java
 ---
@@ -247,7 +207,7 @@ public Result createRegion(
   new Object[] {CliStrings.CREATE_REGION__USEATTRIBUTESFROM, 
useAttributesFrom}));
--- End diff --

Bit of a nit-pick, but we have been trying to clean up these cases where we 
unnecessarily create new object arrays to pass to varargs methods. This occurs 
several places in the class


> GFSH commands tests are failing after committing refactorings of command 
> classes
> 
>
> Key: GEODE-3436
> URL: https://issues.apache.org/jira/browse/GEODE-3436
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, tests
>Reporter: Kirk Lund
>
> Tests failing in geode-core:
> * HelperIntegrationTest.testHelpWithNoInput
> * HelperIntegrationTest.testHintWithNoInput
> * GfshParserConverterTest.testHintConverter
> * CliCommandsSecurityTest.testNoAccess
> * GfshCommandsSecurityTest.testRegionAReader
> * GfshCommandsSecurityTest.testRegionAWriter
> * GfshCommandsSecurityTest.testClusterReader
> * GfshCommandsSecurityTest.testClusterWriter
> * GfshCommandsSecurityTest.testClusterManager
> * GfshCommandsSecurityTest.testDataReader
> * GfshCommandsSecurityTest.testRegionAManager
> * GfshCommandsSecurityTest.testDataWriter
> * AnalyzeSerializablesJUnitTest.testSerializables (ParallelSnapshotFileMapper)
> Stack traces for the geode-core failures:
> {noformat}
> :geode-core:integrationTest
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHelpWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<2> but was:<4> in:
> <["help (Available)",
> "Display syntax and usage information for all commands or list all 
> available commands if  isn't specified.",
> "hint (Available)",
> "Provide hints for a topic or list all available topics if "topic" 
> isn't specified."]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHelpWithNoInput(HelperIntegrationTest.java:69)
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHintWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<21> but was:<22> in:
> <["Hints are available for the following topics. Use "hint " 
> for a specific hint.",
> "",
> "Client",
> "Cluster Configuration",
> "Configuration",
> "Data",
> "Debug-Utility",
> "Disk Store",
> "Function Execution",
> "GFSH",
> "Geode",
> "Help",
> "JMX",
> "Lifecycle",
> "Locator",
> "Logs",
> "Management-Monitoring",
> "Manager",
> "Region",
> "Server",
> "Statistics",
> "WAN"]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHintWithNoInput(HelperIntegrationTest.java:96)
> org.apache.geode.management.internal.cli.GfshParserConverterTest > 
> testHintConverter FAILED
> java.lang.StringIndexOutOfBoundsException: String index out of range: -1
> at java.lang.String.substring(String.java:1931)
> at 
> org.apache.geode.management.internal.cli.GfshParser.lambda$completeAdvanced$0(GfshParser.java:265)
> at java.util.ArrayList.replaceAll(ArrayList.java:1442)
> at 
> org.apache.geode.management.internal.cli.GfshParser.completeAdvanced(GfshParser.java:264)
> at 
> org.apache.geode.test.dunit.rules.GfshParserRule.complete(GfshParserRule.java:58)
> at 
> org.apache.geode.management.internal.cli.GfshParserConverterTest.testHintConverter(GfshParserConverterTest.java:126)
> org.apache.geode.management.internal.security.CliCommandsSecurityTest > 
> testNoAccess FAILED
> org.assertj.core.api.SoftAssertionError: 
> The following assertion failed:
> 1) [destroy function --id=InterestCalculations] 
> Expecting:
>  <"stranger not authorized for CLUSTER:MANAGE:JAR">
> to contain:
>  <"DATA:MANAGE"> 
> at CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:74)
> at 
> org.assertj.core.api.SoftAssertions.assertAll(SoftAssertions.java:134)
> at 
> org.apache.geode.management.internal.security.CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:78)
> org.apache.geode.management.internal.security.GfshCommandsSecurityTest > 
> testRegionAReader FAI

[jira] [Commented] (GEODE-3436) GFSH commands tests are failing after committing refactorings of command classes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144204#comment-16144204
 ] 

ASF GitHub Bot commented on GEODE-3436:
---

Github user kirklund commented on a diff in the pull request:

https://github.com/apache/geode/pull/745#discussion_r135605262
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateDefinedIndexesCommand.java
 ---
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+
+package org.apache.geode.management.internal.cli.commands;
+
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.TreeSet;
+import java.util.concurrent.atomic.AtomicReference;
+
+import org.springframework.shell.core.annotation.CliCommand;
+import org.springframework.shell.core.annotation.CliOption;
+
+import org.apache.geode.cache.CacheFactory;
+import org.apache.geode.cache.execute.ResultCollector;
+import org.apache.geode.distributed.DistributedMember;
+import org.apache.geode.management.cli.CliMetaData;
+import org.apache.geode.management.cli.ConverterHint;
+import org.apache.geode.management.cli.Result;
+import org.apache.geode.management.internal.cli.CliUtil;
+import 
org.apache.geode.management.internal.cli.functions.CliFunctionResult;
+import 
org.apache.geode.management.internal.cli.functions.CreateDefinedIndexesFunction;
+import org.apache.geode.management.internal.cli.i18n.CliStrings;
+import org.apache.geode.management.internal.cli.result.ErrorResultData;
+import org.apache.geode.management.internal.cli.result.InfoResultData;
+import org.apache.geode.management.internal.cli.result.ResultBuilder;
+import org.apache.geode.management.internal.configuration.domain.XmlEntity;
+import org.apache.geode.management.internal.security.ResourceOperation;
+import org.apache.geode.security.ResourcePermission;
+
+public class CreateDefinedIndexesCommand implements GfshCommand {
+  private static final CreateDefinedIndexesFunction 
createDefinedIndexesFunction =
+  new CreateDefinedIndexesFunction();
+
+  @CliCommand(value = CliStrings.CREATE_DEFINED_INDEXES, help = 
CliStrings.CREATE_DEFINED__HELP)
+  @CliMetaData(relatedTopic = {CliStrings.TOPIC_GEODE_REGION, 
CliStrings.TOPIC_GEODE_DATA})
+  @ResourceOperation(resource = ResourcePermission.Resource.CLUSTER,
+  operation = ResourcePermission.Operation.MANAGE, target = 
ResourcePermission.Target.QUERY)
+  // TODO : Add optionContext for indexName
+  public Result createDefinedIndexes(
+
+  @CliOption(key = {CliStrings.MEMBER, CliStrings.MEMBERS},
+  optionContext = ConverterHint.MEMBERIDNAME,
+  help = CliStrings.CREATE_DEFINED_INDEXES__MEMBER__HELP) final 
String[] memberNameOrID,
+
+  @CliOption(key = {CliStrings.GROUP, CliStrings.GROUPS},
+  optionContext = ConverterHint.MEMBERGROUP,
+  help = CliStrings.CREATE_DEFINED_INDEXES__GROUP__HELP) final 
String[] group) {
+
+Result result;
+AtomicReference xmlEntity = new AtomicReference<>();
+
+if (IndexDefinition.indexDefinitions.isEmpty()) {
+  final InfoResultData infoResult = 
ResultBuilder.createInfoResultData();
+  infoResult.addLine(CliStrings.DEFINE_INDEX__FAILURE__MSG);
+  return ResultBuilder.buildResult(infoResult);
+}
+
+try {
+  final Set targetMembers = 
CliUtil.findMembers(group, memberNameOrID);
+
+  if (targetMembers.isEmpty()) {
+return 
ResultBuilder.createUserErrorResult(CliStrings.NO_MEMBERS_FOUND_MESSAGE);
+  }
+
+  // TODO PSR: is this safe to remove?
+  CacheFactory.getAnyInstance();
--- End diff --

I favor removal of all CacheFactory.getAnyInstance() calls anywhere in 
which the return is not used.


> GFSH commands tests are failing after committing refactorings 

[jira] [Commented] (GEODE-3436) GFSH commands tests are failing after committing refactorings of command classes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144173#comment-16144173
 ] 

ASF GitHub Bot commented on GEODE-3436:
---

Github user PurelyApplied commented on a diff in the pull request:

https://github.com/apache/geode/pull/745#discussion_r135599224
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateDefinedIndexesCommand.java
 ---
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+
+package org.apache.geode.management.internal.cli.commands;
+
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.TreeSet;
+import java.util.concurrent.atomic.AtomicReference;
+
+import org.springframework.shell.core.annotation.CliCommand;
+import org.springframework.shell.core.annotation.CliOption;
+
+import org.apache.geode.cache.CacheFactory;
+import org.apache.geode.cache.execute.ResultCollector;
+import org.apache.geode.distributed.DistributedMember;
+import org.apache.geode.management.cli.CliMetaData;
+import org.apache.geode.management.cli.ConverterHint;
+import org.apache.geode.management.cli.Result;
+import org.apache.geode.management.internal.cli.CliUtil;
+import 
org.apache.geode.management.internal.cli.functions.CliFunctionResult;
+import 
org.apache.geode.management.internal.cli.functions.CreateDefinedIndexesFunction;
+import org.apache.geode.management.internal.cli.i18n.CliStrings;
+import org.apache.geode.management.internal.cli.result.ErrorResultData;
+import org.apache.geode.management.internal.cli.result.InfoResultData;
+import org.apache.geode.management.internal.cli.result.ResultBuilder;
+import org.apache.geode.management.internal.configuration.domain.XmlEntity;
+import org.apache.geode.management.internal.security.ResourceOperation;
+import org.apache.geode.security.ResourcePermission;
+
+public class CreateDefinedIndexesCommand implements GfshCommand {
+  private static final CreateDefinedIndexesFunction 
createDefinedIndexesFunction =
+  new CreateDefinedIndexesFunction();
+
+  @CliCommand(value = CliStrings.CREATE_DEFINED_INDEXES, help = 
CliStrings.CREATE_DEFINED__HELP)
+  @CliMetaData(relatedTopic = {CliStrings.TOPIC_GEODE_REGION, 
CliStrings.TOPIC_GEODE_DATA})
+  @ResourceOperation(resource = ResourcePermission.Resource.CLUSTER,
+  operation = ResourcePermission.Operation.MANAGE, target = 
ResourcePermission.Target.QUERY)
+  // TODO : Add optionContext for indexName
+  public Result createDefinedIndexes(
+
+  @CliOption(key = {CliStrings.MEMBER, CliStrings.MEMBERS},
+  optionContext = ConverterHint.MEMBERIDNAME,
+  help = CliStrings.CREATE_DEFINED_INDEXES__MEMBER__HELP) final 
String[] memberNameOrID,
+
+  @CliOption(key = {CliStrings.GROUP, CliStrings.GROUPS},
+  optionContext = ConverterHint.MEMBERGROUP,
+  help = CliStrings.CREATE_DEFINED_INDEXES__GROUP__HELP) final 
String[] group) {
+
+Result result;
+AtomicReference xmlEntity = new AtomicReference<>();
+
+if (IndexDefinition.indexDefinitions.isEmpty()) {
+  final InfoResultData infoResult = 
ResultBuilder.createInfoResultData();
+  infoResult.addLine(CliStrings.DEFINE_INDEX__FAILURE__MSG);
+  return ResultBuilder.buildResult(infoResult);
+}
+
+try {
+  final Set targetMembers = 
CliUtil.findMembers(group, memberNameOrID);
+
+  if (targetMembers.isEmpty()) {
+return 
ResultBuilder.createUserErrorResult(CliStrings.NO_MEMBERS_FOUND_MESSAGE);
+  }
+
+  // TODO PSR: is this safe to remove?
+  CacheFactory.getAnyInstance();
--- End diff --

Oh no I forgot to address all my TODOs!

That was there to remind me to spike that command out and see the right way 
to get rid of it.  Thanks for catchin

[jira] [Commented] (GEODE-3436) GFSH commands tests are failing after committing refactorings of command classes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144165#comment-16144165
 ] 

ASF GitHub Bot commented on GEODE-3436:
---

Github user pdxrunner commented on a diff in the pull request:

https://github.com/apache/geode/pull/745#discussion_r135597926
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateDefinedIndexesCommand.java
 ---
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+
+package org.apache.geode.management.internal.cli.commands;
+
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.TreeSet;
+import java.util.concurrent.atomic.AtomicReference;
+
+import org.springframework.shell.core.annotation.CliCommand;
+import org.springframework.shell.core.annotation.CliOption;
+
+import org.apache.geode.cache.CacheFactory;
+import org.apache.geode.cache.execute.ResultCollector;
+import org.apache.geode.distributed.DistributedMember;
+import org.apache.geode.management.cli.CliMetaData;
+import org.apache.geode.management.cli.ConverterHint;
+import org.apache.geode.management.cli.Result;
+import org.apache.geode.management.internal.cli.CliUtil;
+import 
org.apache.geode.management.internal.cli.functions.CliFunctionResult;
+import 
org.apache.geode.management.internal.cli.functions.CreateDefinedIndexesFunction;
+import org.apache.geode.management.internal.cli.i18n.CliStrings;
+import org.apache.geode.management.internal.cli.result.ErrorResultData;
+import org.apache.geode.management.internal.cli.result.InfoResultData;
+import org.apache.geode.management.internal.cli.result.ResultBuilder;
+import org.apache.geode.management.internal.configuration.domain.XmlEntity;
+import org.apache.geode.management.internal.security.ResourceOperation;
+import org.apache.geode.security.ResourcePermission;
+
+public class CreateDefinedIndexesCommand implements GfshCommand {
+  private static final CreateDefinedIndexesFunction 
createDefinedIndexesFunction =
+  new CreateDefinedIndexesFunction();
+
+  @CliCommand(value = CliStrings.CREATE_DEFINED_INDEXES, help = 
CliStrings.CREATE_DEFINED__HELP)
+  @CliMetaData(relatedTopic = {CliStrings.TOPIC_GEODE_REGION, 
CliStrings.TOPIC_GEODE_DATA})
+  @ResourceOperation(resource = ResourcePermission.Resource.CLUSTER,
+  operation = ResourcePermission.Operation.MANAGE, target = 
ResourcePermission.Target.QUERY)
+  // TODO : Add optionContext for indexName
+  public Result createDefinedIndexes(
+
+  @CliOption(key = {CliStrings.MEMBER, CliStrings.MEMBERS},
+  optionContext = ConverterHint.MEMBERIDNAME,
+  help = CliStrings.CREATE_DEFINED_INDEXES__MEMBER__HELP) final 
String[] memberNameOrID,
+
+  @CliOption(key = {CliStrings.GROUP, CliStrings.GROUPS},
+  optionContext = ConverterHint.MEMBERGROUP,
+  help = CliStrings.CREATE_DEFINED_INDEXES__GROUP__HELP) final 
String[] group) {
+
+Result result;
+AtomicReference xmlEntity = new AtomicReference<>();
+
+if (IndexDefinition.indexDefinitions.isEmpty()) {
+  final InfoResultData infoResult = 
ResultBuilder.createInfoResultData();
+  infoResult.addLine(CliStrings.DEFINE_INDEX__FAILURE__MSG);
+  return ResultBuilder.buildResult(infoResult);
+}
+
+try {
+  final Set targetMembers = 
CliUtil.findMembers(group, memberNameOrID);
+
+  if (targetMembers.isEmpty()) {
+return 
ResultBuilder.createUserErrorResult(CliStrings.NO_MEMBERS_FOUND_MESSAGE);
+  }
+
+  // TODO PSR: is this safe to remove?
+  CacheFactory.getAnyInstance();
--- End diff --

I think this should be replaced by calling the GfshCommand interface's 
getCache() to limit the places where this potentially deadlock prone call is 
made. . Most (or 

[jira] [Commented] (GEODE-3436) GFSH commands tests are failing after committing refactorings of command classes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144126#comment-16144126
 ] 

ASF GitHub Bot commented on GEODE-3436:
---

GitHub user PurelyApplied opened a pull request:

https://github.com/apache/geode/pull/745

GEODE-3436: Restore reverted GFSH command refactoring

Given that this would restore multiple tickets worth of commits, it was 
unclear if this PR should squash all commits or if the history would be clearer 
without one enormous commit.

Precheckin returned green excepting spotless and some other minor 
adjustments (import ordering correction, etc).  Running another precheckin for 
due course.

-

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [n/a] Have you written or updated unit tests to verify your changes? 
[Existing tests provide coverage for refactored code.]

- [n/a] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to d...@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PurelyApplied/geode geode-3436

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/745.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #745


commit caeb8375db68d68ec0ddbca6b81fd6ca6c91a73f
Author: YehEmily 
Date:   2017-08-22T17:57:05Z

GEODE-3436: Restore refactoring of MemberCommands

* See initial commit GEODE-3264 (d27f8b956de7d9c5d95ebdc68dfc67ee8b2d7b51)

commit 44cc0e8bb7927e61bb3e7613612703518fc87db6
Author: YehEmily 
Date:   2017-08-07T18:52:14Z

GEODE-3436: Restore refactoring of DurableClientCommands

* See initial commit GEODE-3259 (440c87f81fab96f9ce38a2d53ded75e5fe8390d7)

commit 1e9eea1f1b2d2c620679283aaf6e6c5ac12e1728
Author: YehEmily 
Date:   2017-08-04T17:47:48Z

GEODE-3436: Restore refactoring of PDXCommands

* See initial commit GEODE-3266 (67185abcdd68b908dea6888cb94286b8aa9ea49f)

commit 691700c2e51aef5b18ba5feec711bddf5ae9a05e
Author: YehEmily 
Date:   2017-08-07T20:58:08Z

GEODE-3436: Restore refactoring of RegionCommands

* See initial commits GEODE-3268 
(64de3b69c2aecb4930bcfd0a1161569b1d5fda89), GEODE-3255 
(756efe77c86bb03ac9984655e7bd040659e85890)

commit 0acf8be27f5ab5f6d9d5009bb7ec6740c1f7ae1b
Author: YehEmily 
Date:   2017-08-07T21:47:15Z

GEODE-3436: Restore refactoring of QueueCommands

* See initial commit GEODE-3267 (fd47ed660168864a6f81b2a4cd7dbceebc99a282)

commit 7594ebdd5e593179f0b33a94c30c7d5949fabf96
Author: YehEmily 
Date:   2017-08-24T22:42:12Z

GEODE-3436: Restore refactoring of GfshHelpCommands

* See initial commit GEODE-3261 (cf91426692349d0c81ce77394935576d9cc336e8)

commit 5daeb011cbeebfa2a71c225ed3dc3abc2047e3dd
Author: YehEmily 
Date:   2017-08-24T23:11:13Z

GEODE-3436: Restore refactoring of CreateAlterDestroyRegionCommands

* See initial commit GEODE-3255 (756efe77c86bb03ac9984655e7bd040659e85890)

commit a1823d323c26adebacf7536448e2cadf054d9528
Author: YehEmily 
Date:   2017-07-26T18:07:09Z

GEODE-3436: Restore refactoring of ConfigCommands

* See initial commit GEODE-3254 (97c4e9a59f17c7bc914e39dd048b0a4cd96293c4)

commit 78ec3cb687313799a911ed3d1ca6e560cb358de8
Author: YehEmily 
Date:   2017-08-03T16:00:08Z

GEODE-3436: Restore refactoring of DiskStoreCommands

* See initial commit GEODE-3258 (5d6cad7755ec3c4fe931e3d0f8e89fb181038543)

commit 1ecbd6fa08343a8de50bf30839c9ef47c02e73aa
Author: YehEmily 
Date:   2017-08-07T19:35:14Z

GEODE-3436: Restore refactoring of IndexCommands

* See initial commit GEODE-3262 (ed293e817e547fb5ecd399bf4ba10d694af51e0a)

commit b562bdafc46045bd2679c233cf591549fb016d8b
Author: YehEmily 
Date:   2017-08-07T19:56:17Z

GEODE-3436: Restore refactoring of Refactoring FunctionCommands

* See initial commit GEODE-3260 (90f5440de8ec747f301a309a0a34101e8defcd

[jira] [Commented] (GEODE-3436) GFSH commands tests are failing after committing refactorings of command classes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16126016#comment-16126016
 ] 

ASF GitHub Bot commented on GEODE-3436:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/711


> GFSH commands tests are failing after committing refactorings of command 
> classes
> 
>
> Key: GEODE-3436
> URL: https://issues.apache.org/jira/browse/GEODE-3436
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> {noformat}
> :geode-core:integrationTest
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHelpWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<2> but was:<4> in:
> <["help (Available)",
> "Display syntax and usage information for all commands or list all 
> available commands if  isn't specified.",
> "hint (Available)",
> "Provide hints for a topic or list all available topics if "topic" 
> isn't specified."]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHelpWithNoInput(HelperIntegrationTest.java:69)
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHintWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<21> but was:<22> in:
> <["Hints are available for the following topics. Use "hint " 
> for a specific hint.",
> "",
> "Client",
> "Cluster Configuration",
> "Configuration",
> "Data",
> "Debug-Utility",
> "Disk Store",
> "Function Execution",
> "GFSH",
> "Geode",
> "Help",
> "JMX",
> "Lifecycle",
> "Locator",
> "Logs",
> "Management-Monitoring",
> "Manager",
> "Region",
> "Server",
> "Statistics",
> "WAN"]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHintWithNoInput(HelperIntegrationTest.java:96)
> org.apache.geode.management.internal.cli.GfshParserConverterTest > 
> testHintConverter FAILED
> java.lang.StringIndexOutOfBoundsException: String index out of range: -1
> at java.lang.String.substring(String.java:1931)
> at 
> org.apache.geode.management.internal.cli.GfshParser.lambda$completeAdvanced$0(GfshParser.java:265)
> at java.util.ArrayList.replaceAll(ArrayList.java:1442)
> at 
> org.apache.geode.management.internal.cli.GfshParser.completeAdvanced(GfshParser.java:264)
> at 
> org.apache.geode.test.dunit.rules.GfshParserRule.complete(GfshParserRule.java:58)
> at 
> org.apache.geode.management.internal.cli.GfshParserConverterTest.testHintConverter(GfshParserConverterTest.java:126)
> org.apache.geode.management.internal.security.CliCommandsSecurityTest > 
> testNoAccess FAILED
> org.assertj.core.api.SoftAssertionError: 
> The following assertion failed:
> 1) [destroy function --id=InterestCalculations] 
> Expecting:
>  <"stranger not authorized for CLUSTER:MANAGE:JAR">
> to contain:
>  <"DATA:MANAGE"> 
> at CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:74)
> at 
> org.assertj.core.api.SoftAssertions.assertAll(SoftAssertions.java:134)
> at 
> org.apache.geode.management.internal.security.CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:78)
> org.apache.geode.management.internal.security.GfshCommandsSecurityTest > 
> testRegionAReader FAILED
> org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] 
> expected:<[110]> but was:<[415]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at 
> org.apache.geode.management.internal.security.GfshCommandsSecurityTest.runCommandsPermittedAndForbiddenBy(GfshCommandsSecurityTest.java:164)
> at 
> org.apache.geode.management.internal.security.GfshCommandsSecurityTest.testRegionAReader(GfshCommandsSecurityTest.java:108)
> org.apache.geode.management.internal.security.GfshCommandsSecurityTest > 
> testRegionAWriter FAILED
> org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] 
> expected:<[110]> but was:<[415]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingConstructorAccessorIm

[jira] [Commented] (GEODE-3436) GFSH commands tests are failing after committing refactorings of command classes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124728#comment-16124728
 ] 

ASF GitHub Bot commented on GEODE-3436:
---

GitHub user kirklund opened a pull request:

https://github.com/apache/geode/pull/711

GEODE-3436: revert all commands refactorings

Revert these commits to return precheckin to GREEN:

commit d27f8b956de7d9c5d95ebdc68dfc67ee8b2d7b51
Author: YehEmily 
Date:   Mon Aug 7 13:09:42 2017 -0700

GEODE-3264: Refactoring MemberCommands

This closes #692

commit 440c87f81fab96f9ce38a2d53ded75e5fe8390d7
Author: YehEmily 
Date:   Mon Aug 7 11:52:14 2017 -0700

GEODE-3259: Refactoring DurableClientCommands

This closes #689

commit 97c4e9a59f17c7bc914e39dd048b0a4cd96293c4
Author: YehEmily 
Date:   Wed Jul 26 11:07:09 2017 -0700

GEODE-3254: Refactoring ConfigCommands

This closes #665

commit ed293e817e547fb5ecd399bf4ba10d694af51e0a
Author: YehEmily 
Date:   Mon Aug 7 12:35:14 2017 -0700

GEODE-3262: Refactoring IndexCommands

This closes #690

commit 90f5440de8ec747f301a309a0a34101e8defcd29
Author: YehEmily 
Date:   Mon Aug 7 12:56:17 2017 -0700

GEODE-3260: Refactoring FunctionCommands

This closes #691

commit 5d6cad7755ec3c4fe931e3d0f8e89fb181038543
Author: YehEmily 
Date:   Thu Aug 3 09:00:08 2017 -0700

GEODE-3258: Refactoring DiskStoreCommands

This closes #687

commit 210ff9f15460c993f2bf7fd682d50ee65462cd23
Author: YehEmily 
Date:   Fri Aug 11 10:22:33 2017 -0700

GEODE-3337: Refactoring LauncherLifecycleCommandsDUnitTest

This closes #701

commit 63169699e933f6e0fdd90b95ed039e4e3c92c32c
Author: YehEmily 
Date:   Mon Aug 7 15:37:23 2017 -0700

GEODE-3265: Refactoring MiscellaneousCommands

This closes #696

commit cf91426692349d0c81ce77394935576d9cc336e8
Author: YehEmily 
Date:   Fri Aug 4 11:12:50 2017 -0700

GEODE-3261: Refactoring GfshHelpCommands

This closes #685

commit fd47ed660168864a6f81b2a4cd7dbceebc99a282
Author: YehEmily 
Date:   Mon Aug 7 14:47:15 2017 -0700

GEODE-3267: Refactoring QueueCommands

This closes #695

commit 359e3fff6482ecfb375939d387f4dad3a636246b
Author: YehEmily 
Date:   Mon Aug 7 14:32:43 2017 -0700

GEODE-3270: Refactoring (renaming) StatusCommands

This closes #694

commit 957d583e54dc34c029885f32a54f0b25a3ac1094
Author: YehEmily 
Date:   Mon Aug 7 15:25:24 2017 -0700

GEODE-3267: Refactoring QueueCommands - updated based on feedback

commit 64de3b69c2aecb4930bcfd0a1161569b1d5fda89
Author: YehEmily 
Date:   Mon Aug 7 13:58:08 2017 -0700

GEODE-3268: Refactoring RegionCommands

This closes #693

commit 67185abcdd68b908dea6888cb94286b8aa9ea49f
Author: YehEmily 
Date:   Fri Aug 4 10:47:48 2017 -0700

GEODE-3266: Refactoring PDXCommands

This closes #684

commit 9d967446a44a78b612f605b6a8f8eedcfc625b3a
Author: YehEmily 
Date:   Wed Aug 2 17:28:10 2017 -0700

GEODE-3257: Refactoring DeployCommands

This closes #680

commit 756efe77c86bb03ac9984655e7bd040659e85890
Author: YehEmily 
Date:   Fri Jul 28 14:23:25 2017 -0700

GEODE-3255: Refactor CreateAlterDestroyRegionCommands and tests

This closes #671

commit a7f29525df2981c1c99abac96ea83cb965295970
Author: YehEmily 
Date:   Fri Jul 21 14:29:55 2017 -0700

GEODE-3230: Cleaning up unused (Cli)Strings

This closes #651



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kirklund/geode revert-all

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/711.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #711


commit 47377c8086e57a88a87244ed77cad48e43495dd5
Author: Kirk Lund 
Date:   2017-08-12T16:38:20Z

Revert "GEODE-3264: Refactoring MemberCommands"

This reverts commit d27f8b956de7d9c5d95ebdc68dfc67ee8b2d7b51.

commit fd6fcc7dd65b83c030d6f7bb754ed921a9ab8829
Author: Kirk Lund 
Date:   2017-08-12T16:38:28Z

Revert "GEODE-3259: Refactoring DurableClientCommands"

This reverts commit 440c87f81fab96f9ce38a2d53ded75e5fe8390d7.

commit 969d71b60fa3d8ff8b91a21d8c4df4a830cfec30
Author: Kirk Lund 
Date:   2017-08-12T16:38