[jira] [Commented] (GEODE-4464) Remove singleton calls from all tests in org.apache.geode.cache30
[ https://issues.apache.org/jira/browse/GEODE-4464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373374#comment-16373374 ] ASF subversion and git services commented on GEODE-4464: Commit 0b15a3bee602c37c617429c919ed19384dd371ca in geode's branch refs/heads/develop from [~dschneider] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=0b15a3b ] GEODE-4464: remove singleton calls from all tests in org.apache.geode.cache30 (#1484) * removed unneeded fine logging on deprecated method so that getAnyInstance would not be called * changed getAnyInstance calls to getCache * InternalDistributedSystem.getConnectedInstance no longer called * InternalDistributedSystem.getAnyInstance call removed from CachedAllEventsDUnitTest * InternalDistributedSystem.getAnyInstance call removed from CallbackArgDUnitTest * removed InternalDistributedSystem.getAnyInstance call from ClientMembershipDUnitTest * removed getAnyInstance calls from ClientServerTestCase by removing the methods getDistributedMember and getSystemProperties * removed InternalDistributedSystem.getAnyInstance from ProxyDUnitTest * removed InternalDistributedSystem.getAnyInstance call from RegionMembershipListenerDUnitTest * removed unused InternalDistributedSystem.getAnyInstance call from RegionReliabilityTestCase * InternalDistributedSystem.getAnyInstance call removed from TXOrderDUnitTest > Remove singleton calls from all tests in org.apache.geode.cache30 > - > > Key: GEODE-4464 > URL: https://issues.apache.org/jira/browse/GEODE-4464 > Project: Geode > Issue Type: Sub-task > Components: regions, tests >Reporter: Kirk Lund >Assignee: Darrel Schneider >Priority: Major > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > These tests in org.apache.geode.cache30 invoke singleton getters. > CacheFactory.getAnyInstance(): > * CacheSerializableRunnable > * ClientServerCCEDUnitTest > * MultiVMRegionTestCase > * ReconnectDUnitTest > CacheFactory.getExisting(DistributedSystem): > * MultiVMRegionTestCase.testDistributedPut > * MultiVMRegionTestCase.testTXAlgebra > * MultiVMRegionTestCase.testTXSimpleOps > * MultiVMRegionTestCase.testTXUpdateLoadNoConflict > * MultiVMRegionTestCase.testTXRmtMirror > * MultiVMRegionTestCase.testTXMultiRegion > InternalDistributedSystem.getAnyInstance(): > * CachedAllEventsDUnitTest > * CallbackArgDUnitTest > * ClientMembershipDUnitTest > * ClientServerTestCase > * ProxyDUnitTest > * ReconnectDUnitTest > * RegionMembershipListenerDUnitTest > * RegionReliabilityTestCase > * RemotePRValuesAreNotDeserializedRegressionTest > * TXOrderDUnitTest > * ValuesAreLazilyDeserializedRegressionTest > InternalDistributedSystem.getConnectedInstance(): > * DistributedNoAckRegionCCEDUnitTest > * MultiVMRegionTestCase > * ReconnectDUnitTest -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-4464) Remove singleton calls from all tests in org.apache.geode.cache30
[ https://issues.apache.org/jira/browse/GEODE-4464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372186#comment-16372186 ] Darrel Schneider commented on GEODE-4464: - ValuesAreLazilyDeserializedRegressionTest is also GEODE-4714 > Remove singleton calls from all tests in org.apache.geode.cache30 > - > > Key: GEODE-4464 > URL: https://issues.apache.org/jira/browse/GEODE-4464 > Project: Geode > Issue Type: Sub-task > Components: regions, tests >Reporter: Kirk Lund >Assignee: Darrel Schneider >Priority: Major > > These tests in org.apache.geode.cache30 invoke singleton getters. > CacheFactory.getAnyInstance(): > * CacheSerializableRunnable > * ClientServerCCEDUnitTest > * MultiVMRegionTestCase > * ReconnectDUnitTest > CacheFactory.getExisting(DistributedSystem): > * MultiVMRegionTestCase.testDistributedPut > * MultiVMRegionTestCase.testTXAlgebra > * MultiVMRegionTestCase.testTXSimpleOps > * MultiVMRegionTestCase.testTXUpdateLoadNoConflict > * MultiVMRegionTestCase.testTXRmtMirror > * MultiVMRegionTestCase.testTXMultiRegion > InternalDistributedSystem.getAnyInstance(): > * CachedAllEventsDUnitTest > * CallbackArgDUnitTest > * ClientMembershipDUnitTest > * ClientServerTestCase > * ProxyDUnitTest > * ReconnectDUnitTest > * RegionMembershipListenerDUnitTest > * RegionReliabilityTestCase > * RemotePRValuesAreNotDeserializedRegressionTest > * TXOrderDUnitTest > * ValuesAreLazilyDeserializedRegressionTest > InternalDistributedSystem.getConnectedInstance(): > * DistributedNoAckRegionCCEDUnitTest > * MultiVMRegionTestCase > * ReconnectDUnitTest -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-4464) Remove singleton calls from all tests in org.apache.geode.cache30
[ https://issues.apache.org/jira/browse/GEODE-4464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372139#comment-16372139 ] Darrel Schneider commented on GEODE-4464: - for RemotePRValuesAreNotDeserializedRegressionTest I filed: GEODE-4714 > Remove singleton calls from all tests in org.apache.geode.cache30 > - > > Key: GEODE-4464 > URL: https://issues.apache.org/jira/browse/GEODE-4464 > Project: Geode > Issue Type: Sub-task > Components: regions, tests >Reporter: Kirk Lund >Assignee: Darrel Schneider >Priority: Major > > These tests in org.apache.geode.cache30 invoke singleton getters. > CacheFactory.getAnyInstance(): > * CacheSerializableRunnable > * ClientServerCCEDUnitTest > * MultiVMRegionTestCase > * ReconnectDUnitTest > CacheFactory.getExisting(DistributedSystem): > * MultiVMRegionTestCase.testDistributedPut > * MultiVMRegionTestCase.testTXAlgebra > * MultiVMRegionTestCase.testTXSimpleOps > * MultiVMRegionTestCase.testTXUpdateLoadNoConflict > * MultiVMRegionTestCase.testTXRmtMirror > * MultiVMRegionTestCase.testTXMultiRegion > InternalDistributedSystem.getAnyInstance(): > * CachedAllEventsDUnitTest > * CallbackArgDUnitTest > * ClientMembershipDUnitTest > * ClientServerTestCase > * ProxyDUnitTest > * ReconnectDUnitTest > * RegionMembershipListenerDUnitTest > * RegionReliabilityTestCase > * RemotePRValuesAreNotDeserializedRegressionTest > * TXOrderDUnitTest > * ValuesAreLazilyDeserializedRegressionTest > InternalDistributedSystem.getConnectedInstance(): > * DistributedNoAckRegionCCEDUnitTest > * MultiVMRegionTestCase > * ReconnectDUnitTest -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-4464) Remove singleton calls from all tests in org.apache.geode.cache30
[ https://issues.apache.org/jira/browse/GEODE-4464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372140#comment-16372140 ] Darrel Schneider commented on GEODE-4464: - for RemotePRValuesAreNotDeserializedRegressionTest I filed: GEODE-4714 > Remove singleton calls from all tests in org.apache.geode.cache30 > - > > Key: GEODE-4464 > URL: https://issues.apache.org/jira/browse/GEODE-4464 > Project: Geode > Issue Type: Sub-task > Components: regions, tests >Reporter: Kirk Lund >Assignee: Darrel Schneider >Priority: Major > > These tests in org.apache.geode.cache30 invoke singleton getters. > CacheFactory.getAnyInstance(): > * CacheSerializableRunnable > * ClientServerCCEDUnitTest > * MultiVMRegionTestCase > * ReconnectDUnitTest > CacheFactory.getExisting(DistributedSystem): > * MultiVMRegionTestCase.testDistributedPut > * MultiVMRegionTestCase.testTXAlgebra > * MultiVMRegionTestCase.testTXSimpleOps > * MultiVMRegionTestCase.testTXUpdateLoadNoConflict > * MultiVMRegionTestCase.testTXRmtMirror > * MultiVMRegionTestCase.testTXMultiRegion > InternalDistributedSystem.getAnyInstance(): > * CachedAllEventsDUnitTest > * CallbackArgDUnitTest > * ClientMembershipDUnitTest > * ClientServerTestCase > * ProxyDUnitTest > * ReconnectDUnitTest > * RegionMembershipListenerDUnitTest > * RegionReliabilityTestCase > * RemotePRValuesAreNotDeserializedRegressionTest > * TXOrderDUnitTest > * ValuesAreLazilyDeserializedRegressionTest > InternalDistributedSystem.getConnectedInstance(): > * DistributedNoAckRegionCCEDUnitTest > * MultiVMRegionTestCase > * ReconnectDUnitTest -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-4464) Remove singleton calls from all tests in org.apache.geode.cache30
[ https://issues.apache.org/jira/browse/GEODE-4464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371854#comment-16371854 ] Darrel Schneider commented on GEODE-4464: - GEODE-4713 covers * MultiVMRegionTestCase > Remove singleton calls from all tests in org.apache.geode.cache30 > - > > Key: GEODE-4464 > URL: https://issues.apache.org/jira/browse/GEODE-4464 > Project: Geode > Issue Type: Sub-task > Components: regions, tests >Reporter: Kirk Lund >Priority: Major > > These tests in org.apache.geode.cache30 invoke singleton getters. > CacheFactory.getAnyInstance(): > * CacheSerializableRunnable > * ClientServerCCEDUnitTest > * MultiVMRegionTestCase > * ReconnectDUnitTest > CacheFactory.getExisting(DistributedSystem): > * MultiVMRegionTestCase.testDistributedPut > * MultiVMRegionTestCase.testTXAlgebra > * MultiVMRegionTestCase.testTXSimpleOps > * MultiVMRegionTestCase.testTXUpdateLoadNoConflict > * MultiVMRegionTestCase.testTXRmtMirror > * MultiVMRegionTestCase.testTXMultiRegion > InternalDistributedSystem.getAnyInstance(): > * CachedAllEventsDUnitTest > * CallbackArgDUnitTest > * ClientMembershipDUnitTest > * ClientServerTestCase > * ProxyDUnitTest > * ReconnectDUnitTest > * RegionMembershipListenerDUnitTest > * RegionReliabilityTestCase > * RemotePRValuesAreNotDeserializedRegressionTest > * TXOrderDUnitTest > * ValuesAreLazilyDeserializedRegressionTest > InternalDistributedSystem.getConnectedInstance(): > * DistributedNoAckRegionCCEDUnitTest > * MultiVMRegionTestCase > * ReconnectDUnitTest -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-4464) Remove singleton calls from all tests in org.apache.geode.cache30
[ https://issues.apache.org/jira/browse/GEODE-4464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371834#comment-16371834 ] Darrel Schneider commented on GEODE-4464: - CacheFactory.getExisting(DistributedSystem) no longer exists so it has been taken care of > Remove singleton calls from all tests in org.apache.geode.cache30 > - > > Key: GEODE-4464 > URL: https://issues.apache.org/jira/browse/GEODE-4464 > Project: Geode > Issue Type: Sub-task > Components: regions, tests >Reporter: Kirk Lund >Priority: Major > > These tests in org.apache.geode.cache30 invoke singleton getters. > CacheFactory.getAnyInstance(): > * CacheSerializableRunnable > * ClientServerCCEDUnitTest > * MultiVMRegionTestCase > * ReconnectDUnitTest > CacheFactory.getExisting(DistributedSystem): > * MultiVMRegionTestCase.testDistributedPut > * MultiVMRegionTestCase.testTXAlgebra > * MultiVMRegionTestCase.testTXSimpleOps > * MultiVMRegionTestCase.testTXUpdateLoadNoConflict > * MultiVMRegionTestCase.testTXRmtMirror > * MultiVMRegionTestCase.testTXMultiRegion > InternalDistributedSystem.getAnyInstance(): > * CachedAllEventsDUnitTest > * CallbackArgDUnitTest > * ClientMembershipDUnitTest > * ClientServerTestCase > * ProxyDUnitTest > * ReconnectDUnitTest > * RegionMembershipListenerDUnitTest > * RegionReliabilityTestCase > * RemotePRValuesAreNotDeserializedRegressionTest > * TXOrderDUnitTest > * ValuesAreLazilyDeserializedRegressionTest > InternalDistributedSystem.getConnectedInstance(): > * DistributedNoAckRegionCCEDUnitTest > * MultiVMRegionTestCase > * ReconnectDUnitTest -- This message was sent by Atlassian JIRA (v7.6.3#76005)
