[jira] [Commented] (GEODE-4874) Inconsistency in gfsh help for create jndi-binding
[ https://issues.apache.org/jira/browse/GEODE-4874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436523#comment-16436523 ] ASF subversion and git services commented on GEODE-4874: Commit 34fdc32099d9c449bf67a37067158777847d0d8f in geode's branch refs/heads/feature/GEODE-5057 from [~sai.boorlaga...@gmail.com] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=34fdc32 ] GEODE-4874: Inconsistency in gfsh help for create jndi-binding (#1777) > Inconsistency in gfsh help for create jndi-binding > --- > > Key: GEODE-4874 > URL: https://issues.apache.org/jira/browse/GEODE-4874 > Project: Geode > Issue Type: Bug > Components: gfsh >Affects Versions: 1.5.0 >Reporter: Karen Smoler Miller >Priority: Minor > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > I see an error and an inconsistency when trying to use the gfsh help > functionality for create jndi-binding. > Tab completion of > create jndi-binding > outputs > gfsh>create jndi-binding – > create jndi-binding --connection-url > create jndi-binding --jdbc-driver-class > create jndi-binding --name > create jndi-binding --type > This is inconsistent with the output of other tab completions, which just > give the options, and do not repeat the "create jndi-binding" portion of the > command. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-4874) Inconsistency in gfsh help for create jndi-binding
[ https://issues.apache.org/jira/browse/GEODE-4874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436356#comment-16436356 ] ASF subversion and git services commented on GEODE-4874: Commit 34fdc32099d9c449bf67a37067158777847d0d8f in geode's branch refs/heads/develop from [~sai.boorlaga...@gmail.com] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=34fdc32 ] GEODE-4874: Inconsistency in gfsh help for create jndi-binding (#1777) > Inconsistency in gfsh help for create jndi-binding > --- > > Key: GEODE-4874 > URL: https://issues.apache.org/jira/browse/GEODE-4874 > Project: Geode > Issue Type: Bug > Components: gfsh >Affects Versions: 1.5.0 >Reporter: Karen Smoler Miller >Priority: Minor > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > I see an error and an inconsistency when trying to use the gfsh help > functionality for create jndi-binding. > Tab completion of > create jndi-binding > outputs > gfsh>create jndi-binding – > create jndi-binding --connection-url > create jndi-binding --jdbc-driver-class > create jndi-binding --name > create jndi-binding --type > This is inconsistent with the output of other tab completions, which just > give the options, and do not repeat the "create jndi-binding" portion of the > command. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-4874) Inconsistency in gfsh help for create jndi-binding
[ https://issues.apache.org/jira/browse/GEODE-4874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436177#comment-16436177 ] ASF subversion and git services commented on GEODE-4874: Commit 3f503ce8bff9f4ffcc507a9a5f998f9fffb17b1b in geode's branch refs/heads/develop from [~dbarnes97] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=3f503ce ] GEODE-4874: Inconsistency in gfsh help for create jndi-binding (doc update) > Inconsistency in gfsh help for create jndi-binding > --- > > Key: GEODE-4874 > URL: https://issues.apache.org/jira/browse/GEODE-4874 > Project: Geode > Issue Type: Bug > Components: gfsh >Affects Versions: 1.5.0 >Reporter: Karen Smoler Miller >Priority: Minor > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > > I see an error and an inconsistency when trying to use the gfsh help > functionality for create jndi-binding. > Tab completion of > create jndi-binding > outputs > gfsh>create jndi-binding – > create jndi-binding --connection-url > create jndi-binding --jdbc-driver-class > create jndi-binding --name > create jndi-binding --type > This is inconsistent with the output of other tab completions, which just > give the options, and do not repeat the "create jndi-binding" portion of the > command. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-4874) Inconsistency in gfsh help for create jndi-binding
[ https://issues.apache.org/jira/browse/GEODE-4874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435707#comment-16435707 ] Sai Boorlagadda commented on GEODE-4874: Repeati of *command* before mandatory parameters seems to be common among commands with multiple mandatory parameters. {code:java} Eg: gfsh>put -- put --key put --region put --value {code} Once all mandatory parameters are provided then the tab completion shows all available options: {code:java} gfsh>create jndi-binding --name=someName --connection-url=someUrl --jdbc-driver-class=someClass --type=SIMPLE -- --blocking-timeout-seconds --conn-pooled-datasource-class --datasource-config-properties --idle-timeout-seconds--if-not-exists --init-pool-size --login-timeout-seconds --managed-conn-factory-class --max-pool-size --password--transaction-type--username--xa-datasource-class {code} > Inconsistency in gfsh help for create jndi-binding > --- > > Key: GEODE-4874 > URL: https://issues.apache.org/jira/browse/GEODE-4874 > Project: Geode > Issue Type: Bug > Components: gfsh >Affects Versions: 1.5.0 >Reporter: Karen Smoler Miller >Priority: Minor > > I see an error and an inconsistency when trying to use the gfsh help > functionality for create jndi-binding. > Tab completion of > create jndi-binding > outputs > gfsh>create jndi-binding – > create jndi-binding --connection-url > create jndi-binding --jdbc-driver-class > create jndi-binding --name > create jndi-binding --type > This is inconsistent with the output of other tab completions, which just > give the options, and do not repeat the "create jndi-binding" portion of the > command. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-4874) Inconsistency in gfsh help for create jndi-binding
[ https://issues.apache.org/jira/browse/GEODE-4874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16402617#comment-16402617 ] Karen Smoler Miller commented on GEODE-4874: When fixing this, please correct 2 typos in the help info for this command: # Option conn-pooled-datasource-class says "This is the fully qualified name of the connection pool implementation to hold XS datasource connections." It should be "XA," not "XS." # Option type says "Type of the XA datasource. Type of region to create. The following types are pre-defined by the product: MANAGED, SIMPLE, POOLED, XAPOOLED." Please remove the irrelevant sentence "Type of region to create." > Inconsistency in gfsh help for create jndi-binding > --- > > Key: GEODE-4874 > URL: https://issues.apache.org/jira/browse/GEODE-4874 > Project: Geode > Issue Type: Bug > Components: gfsh >Affects Versions: 1.5.0 >Reporter: Karen Smoler Miller >Priority: Minor > > I see an error and an inconsistency when trying to use the gfsh help > functionality for create jndi-binding. > Tab completion of > create jndi-binding > outputs > gfsh>create jndi-binding – > create jndi-binding --connection-url > create jndi-binding --jdbc-driver-class > create jndi-binding --name > create jndi-binding --type > This is inconsistent with the output of other tab completions, which just > give the options, and do not repeat the "create jndi-binding" portion of the > command. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)