[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2022-06-08 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551831#comment-17551831
 ] 

ASF subversion and git services commented on GEODE-8334:


Commit 28d31d89de607d8947fe17890b5a951dfc895299 in geode's branch 
refs/heads/feature/GEODE-7665 from zhouxh
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=28d31d89de ]

GEODE-7683: introduce BR.cmnClearRegion

Co-authored-by: Xiaojian Zhou 

GEODE-7684: Create messaging class for PR Clear (#4689)

* Added new message class and test

Co-authored-by: Benjamin Ross 
Co-authored-by: Donal Evans 

GEODE-7682: add PR.clear  API (#4755)

* GEODE-7683: introduce BR.cmnClearRegion

Co-authored-by: Xiaojian Zhou 

PR.clear's event id should be created and used in BR (#4805)

* GEODE-7857: PR.clear's event id should be created and used in BR

GEODE-7912: cacheWriter should be triggered when PR.clear (#4882)

Co-authored-by: Anil 
Co-authored-by: Xiaojian Zhou 

GEODE-7983: Clear region writer callbacks should not be invoked for bucket 
regions (#4954)

GEODE-7676: Add PR clear with expiration tests (#4970)

Added distributed tests to verify the clear operation on Partitioned
Regions works as expected when expiration is configured.

- Added unit and distributed tests.
- Fixed LocalRegion class to clear the entryExpiryTasks Map whenever
  the cancelAllEntryExpiryTasks method is invoked.

GEODE-7667: Add a 'clear' gfsh command for PR and RR clear (#4818)

* Added clear command and modified remove functionality to clear PR

Authored-by: Benjamin Ross 

GEODE-7676: Conversion of duration to seconds.

GEODE-7894: Moving expiry tasks to AbstractRegion.

GEODE-7667: Fixing test to include PR clear help text.

GEODE-7678 (2nd PR) - Support for cache-listener and client-notification for 
Partitioned Region Clear operation  (#5124)

* GEODE-7678: Add support for cache listener and client notification for PR 
clear

The changes are made to PR clear messaging and locking mechanism to preserve
cache-listener and client-events ordering during concurrent cache operation
while clear in progress.

GEODE-7669 Test coverage for Partitioned Region clear with Overflow enabled 
(#5189)

Authored-by: Jianxia Chen 

GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208)

* GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class.
Co-authored-by: anilkumar gingade 

GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365)

Co-authored-by: Xiaojian Zhou 
Co-authored-by: Anil Gingade 

GEODE-8361: Use Set instead of List to track cleared buckets (#5379)

- Refactor PartitionRegionClear to use Set instead of List
- Some other changes to remove warnings/alerts from PartitionedRegionClear and 
PartitionedRegionClearMessage

Authored-by: Donal Evans 

GEODE-7670: PR Clear with Concurrent Ops DUnitTests (#4848)

Added distributed tests to verify that the clear operation on
Partitioned Regions works as expected when there are other
concurrent operations happening on the cache (put, putAll, get,
remove, removeAll, members added and members removed).

GEODE-7680: PR.clear must be successful when interacting with rebalance (#5095)

- Added DUnit tests to confirm that clear does not interfere with
rebalance or vice versa
- Test when member departs during clear/rebalance
- Test when member joins during clear/rebalance
- Fixed typo in PartitionedRegionClearWithExpirationDUnitTest
- Fixed typo in PartitionedRegion
- Call assignBucketsToPartitions() on leader colocated region during clear
instead of target region

Authored-by: Donal Evans 

GEODE-7846: Adding Stats for Partitioned Region Clear (#5391)

Added stats to CachePerfStats for PR Clear
- Changed clears to 'regionClears' and 'bucketClears' to differentiate between 
the number of times the region was cleared and the number of times a bucket was 
cleared in a PartitionedRegion
- Added Local and Total duration stats to record how long clear has been 
running for a specific region, as well as how long it was spent clearing any 
specific member

GEODE-7672: add dunit test to verify OQL index after PR clear. (#5436)

* require rvv lock when create index

fix rebase compiling error

GEODE-7845 blocking PR region clear if one or more server versions are too old 
(#5577)

- if a server is running an old version when a PR clear is invoked
by the client, the client will receive a ServerOperationException
with a cause of ServerVersionMismatchException.

GEODE-7845: Adding a cleaner simpler test. (#5622)

- Changed the test for ServerVersionMismatchException to be more readable.

GEODE-7845: Now behaving with clients of various versions. (#5645)

- added functionality that would allow the tests to be run using various 
versions of the clients against and and new versions of the server.

GEODE-7858: PR.clear notify client should let the queue holder member to 

[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2021-04-13 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17320395#comment-17320395
 ] 

ASF subversion and git services commented on GEODE-8334:


Commit 248a56aefcf72e0c60e197b377adc6542662bdc2 in geode's branch 
refs/heads/feature/GEODE-7665 from zhouxh
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=248a56a ]

GEODE-7683: introduce BR.cmnClearRegion

Co-authored-by: Xiaojian Zhou 

GEODE-7684: Create messaging class for PR Clear (#4689)

* Added new message class and test

Co-authored-by: Benjamin Ross 
Co-authored-by: Donal Evans 

GEODE-7682: add PR.clear  API (#4755)

* GEODE-7683: introduce BR.cmnClearRegion

Co-authored-by: Xiaojian Zhou 

PR.clear's event id should be created and used in BR (#4805)

* GEODE-7857: PR.clear's event id should be created and used in BR

GEODE-7912: cacheWriter should be triggered when PR.clear (#4882)

Co-authored-by: Anil 
Co-authored-by: Xiaojian Zhou 

GEODE-7983: Clear region writer callbacks should not be invoked for bucket 
regions (#4954)

GEODE-7676: Add PR clear with expiration tests (#4970)

Added distributed tests to verify the clear operation on Partitioned
Regions works as expected when expiration is configured.

- Added unit and distributed tests.
- Fixed LocalRegion class to clear the entryExpiryTasks Map whenever
  the cancelAllEntryExpiryTasks method is invoked.

GEODE-7667: Add a 'clear' gfsh command for PR and RR clear (#4818)

* Added clear command and modified remove functionality to clear PR

Authored-by: Benjamin Ross 

GEODE-7676: Conversion of duration to seconds.

GEODE-7894: Moving expiry tasks to AbstractRegion.

GEODE-7667: Fixing test to include PR clear help text.

GEODE-7678 (2nd PR) - Support for cache-listener and client-notification for 
Partitioned Region Clear operation  (#5124)

* GEODE-7678: Add support for cache listener and client notification for PR 
clear

The changes are made to PR clear messaging and locking mechanism to preserve
cache-listener and client-events ordering during concurrent cache operation
while clear in progress.

GEODE-7669 Test coverage for Partitioned Region clear with Overflow enabled 
(#5189)

Authored-by: Jianxia Chen 

GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208)

* GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class.
Co-authored-by: anilkumar gingade 

GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365)

Co-authored-by: Xiaojian Zhou 
Co-authored-by: Anil Gingade 

GEODE-8361: Use Set instead of List to track cleared buckets (#5379)

- Refactor PartitionRegionClear to use Set instead of List
- Some other changes to remove warnings/alerts from PartitionedRegionClear and 
PartitionedRegionClearMessage

Authored-by: Donal Evans 

GEODE-7670: PR Clear with Concurrent Ops DUnitTests (#4848)

Added distributed tests to verify that the clear operation on
Partitioned Regions works as expected when there are other
concurrent operations happening on the cache (put, putAll, get,
remove, removeAll, members added and members removed).

GEODE-7680: PR.clear must be successful when interacting with rebalance (#5095)

- Added DUnit tests to confirm that clear does not interfere with
rebalance or vice versa
- Test when member departs during clear/rebalance
- Test when member joins during clear/rebalance
- Fixed typo in PartitionedRegionClearWithExpirationDUnitTest
- Fixed typo in PartitionedRegion
- Call assignBucketsToPartitions() on leader colocated region during clear
instead of target region

Authored-by: Donal Evans 

GEODE-7846: Adding Stats for Partitioned Region Clear (#5391)

Added stats to CachePerfStats for PR Clear
- Changed clears to 'regionClears' and 'bucketClears' to differentiate between 
the number of times the region was cleared and the number of times a bucket was 
cleared in a PartitionedRegion
- Added Local and Total duration stats to record how long clear has been 
running for a specific region, as well as how long it was spent clearing any 
specific member

GEODE-7672: add dunit test to verify OQL index after PR clear. (#5436)

* require rvv lock when create index

fix rebase compiling error

GEODE-7845 blocking PR region clear if one or more server versions are too old 
(#5577)

- if a server is running an old version when a PR clear is invoked
by the client, the client will receive a ServerOperationException
with a cause of ServerVersionMismatchException.

GEODE-7845: Adding a cleaner simpler test. (#5622)

- Changed the test for ServerVersionMismatchException to be more readable.

GEODE-7845: Now behaving with clients of various versions. (#5645)

- added functionality that would allow the tests to be run using various 
versions of the clients against and and new versions of the server.

GEODE-7858: PR.clear notify client should let the queue holder member to 

[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2021-01-19 Thread Geode Integration (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17268101#comment-17268101
 ] 

Geode Integration commented on GEODE-8334:
--

Seen in [DistributedTestOpenJDK8 
#756|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/756]
 ... see [test 
results|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0617/test-results/distributedTest/1610976679/]
 or download 
[artifacts|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0617/test-artifacts/1610976679/distributedtestfiles-OpenJDK8-1.14.0-build.0617.tgz].

> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI, pull-request-available
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2021-01-19 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267973#comment-17267973
 ] 

ASF GitHub Bot commented on GEODE-8334:
---

smgoller commented on pull request #5917:
URL: https://github.com/apache/geode/pull/5917#issuecomment-762925721


   This should have been GEODE-8834.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI, pull-request-available
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2021-01-18 Thread Xiaojian Zhou (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267569#comment-17267569
 ] 

Xiaojian Zhou commented on GEODE-8334:
--

Sean's merge belongs to GEODE-8834. 

> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI, pull-request-available
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2021-01-15 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266449#comment-17266449
 ] 

ASF subversion and git services commented on GEODE-8334:


Commit a921254fdd2b468d5255cb59e99cdfcd66d3d87f in geode's branch 
refs/heads/develop from Sean Goller
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=a921254 ]

GEODE-8334: OS changes (#5917)

* Update Ubuntu to 20.04
* Use docker 19.03.14 because of breaking API changes.

> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI, pull-request-available
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2021-01-15 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266447#comment-17266447
 ] 

ASF GitHub Bot commented on GEODE-8334:
---

onichols-pivotal merged pull request #5917:
URL: https://github.com/apache/geode/pull/5917


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI, pull-request-available
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2021-01-15 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266423#comment-17266423
 ] 

ASF GitHub Bot commented on GEODE-8334:
---

smgoller opened a new pull request #5917:
URL: https://github.com/apache/geode/pull/5917


   * Update Ubuntu to 20.04
   * Use docker 19.03.14 because of breaking API changes.
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build 
issues and
   submit an update to your PR as soon as possible. If you need help, please 
send an
   email to d...@geode.apache.org.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-10-28 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222372#comment-17222372
 ] 

ASF subversion and git services commented on GEODE-8334:


Commit 0ea630f95230b1de5ee88fa80e44877734a61912 in geode's branch 
refs/heads/feature/GEODE-7665 from Xiaojian Zhou
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=0ea630f ]

GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365)


Co-authored-by: Xiaojian Zhou 
Co-authored-by: Anil Gingade 



> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-10-28 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222363#comment-17222363
 ] 

ASF subversion and git services commented on GEODE-8334:


Commit 0ea630f95230b1de5ee88fa80e44877734a61912 in geode's branch 
refs/heads/feature/GEODE-7665 from Xiaojian Zhou
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=0ea630f ]

GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365)


Co-authored-by: Xiaojian Zhou 
Co-authored-by: Anil Gingade 



> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-10-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214177#comment-17214177
 ] 

ASF subversion and git services commented on GEODE-8334:


Commit 5948b185a9f73ad8e12f01d449e2f1ec4d07bc62 in geode's branch 
refs/heads/feature/GEODE-7665 from Xiaojian Zhou
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=5948b18 ]

GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365)


Co-authored-by: Xiaojian Zhou 
Co-authored-by: Anil Gingade 



> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-10-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214166#comment-17214166
 ] 

ASF subversion and git services commented on GEODE-8334:


Commit 5948b185a9f73ad8e12f01d449e2f1ec4d07bc62 in geode's branch 
refs/heads/feature/GEODE-7665 from Xiaojian Zhou
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=5948b18 ]

GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365)


Co-authored-by: Xiaojian Zhou 
Co-authored-by: Anil Gingade 



> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-10-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214155#comment-17214155
 ] 

ASF subversion and git services commented on GEODE-8334:


Commit 5948b185a9f73ad8e12f01d449e2f1ec4d07bc62 in geode's branch 
refs/heads/feature/GEODE-7665 from Xiaojian Zhou
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=5948b18 ]

GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365)


Co-authored-by: Xiaojian Zhou 
Co-authored-by: Anil Gingade 



> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-10-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214145#comment-17214145
 ] 

ASF subversion and git services commented on GEODE-8334:


Commit 5948b185a9f73ad8e12f01d449e2f1ec4d07bc62 in geode's branch 
refs/heads/feature/GEODE-7665 from Xiaojian Zhou
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=5948b18 ]

GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365)


Co-authored-by: Xiaojian Zhou 
Co-authored-by: Anil Gingade 



> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-10-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214134#comment-17214134
 ] 

ASF subversion and git services commented on GEODE-8334:


Commit 5948b185a9f73ad8e12f01d449e2f1ec4d07bc62 in geode's branch 
refs/heads/feature/GEODE-7665 from Xiaojian Zhou
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=5948b18 ]

GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365)


Co-authored-by: Xiaojian Zhou 
Co-authored-by: Anil Gingade 



> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-10-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206476#comment-17206476
 ] 

ASF subversion and git services commented on GEODE-8334:


Commit eaa1322c769bb236c46330cddce6d06d5f83 in geode's branch 
refs/heads/feature/GEODE-7665 from Xiaojian Zhou
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=eaa1322 ]

GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365)


Co-authored-by: Xiaojian Zhou 
Co-authored-by: Anil Gingade 



> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-10-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206463#comment-17206463
 ] 

ASF subversion and git services commented on GEODE-8334:


Commit eaa1322c769bb236c46330cddce6d06d5f83 in geode's branch 
refs/heads/feature/GEODE-7665 from Xiaojian Zhou
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=eaa1322 ]

GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365)


Co-authored-by: Xiaojian Zhou 
Co-authored-by: Anil Gingade 



> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-10-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206450#comment-17206450
 ] 

ASF subversion and git services commented on GEODE-8334:


Commit eaa1322c769bb236c46330cddce6d06d5f83 in geode's branch 
refs/heads/feature/GEODE-7665 from Xiaojian Zhou
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=eaa1322 ]

GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365)


Co-authored-by: Xiaojian Zhou 
Co-authored-by: Anil Gingade 



> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-10-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206438#comment-17206438
 ] 

ASF subversion and git services commented on GEODE-8334:


Commit eaa1322c769bb236c46330cddce6d06d5f83 in geode's branch 
refs/heads/feature/GEODE-7665 from Xiaojian Zhou
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=eaa1322 ]

GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365)


Co-authored-by: Xiaojian Zhou 
Co-authored-by: Anil Gingade 



> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-10-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206425#comment-17206425
 ] 

ASF subversion and git services commented on GEODE-8334:


Commit eaa1322c769bb236c46330cddce6d06d5f83 in geode's branch 
refs/heads/feature/GEODE-7665 from Xiaojian Zhou
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=eaa1322 ]

GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365)


Co-authored-by: Xiaojian Zhou 
Co-authored-by: Anil Gingade 



> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-08-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177944#comment-17177944
 ] 

ASF subversion and git services commented on GEODE-8334:


Commit e3b0a7b035f04a99891ceba70ef85c0e7f89d679 in geode's branch 
refs/heads/feature/GEODE-7665 from Xiaojian Zhou
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=e3b0a7b ]

GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365)


Co-authored-by: Xiaojian Zhou 
Co-authored-by: Anil Gingade 



> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-08-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177932#comment-17177932
 ] 

ASF subversion and git services commented on GEODE-8334:


Commit e3b0a7b035f04a99891ceba70ef85c0e7f89d679 in geode's branch 
refs/heads/feature/GEODE-7665 from Xiaojian Zhou
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=e3b0a7b ]

GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365)


Co-authored-by: Xiaojian Zhou 
Co-authored-by: Anil Gingade 



> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-08-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177918#comment-17177918
 ] 

ASF subversion and git services commented on GEODE-8334:


Commit e3b0a7b035f04a99891ceba70ef85c0e7f89d679 in geode's branch 
refs/heads/feature/GEODE-7665 from Xiaojian Zhou
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=e3b0a7b ]

GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365)


Co-authored-by: Xiaojian Zhou 
Co-authored-by: Anil Gingade 



> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-08-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177896#comment-17177896
 ] 

ASF subversion and git services commented on GEODE-8334:


Commit e3b0a7b035f04a99891ceba70ef85c0e7f89d679 in geode's branch 
refs/heads/feature/GEODE-7665 from Xiaojian Zhou
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=e3b0a7b ]

GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365)


Co-authored-by: Xiaojian Zhou 
Co-authored-by: Anil Gingade 



> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-08-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177884#comment-17177884
 ] 

ASF subversion and git services commented on GEODE-8334:


Commit e3b0a7b035f04a99891ceba70ef85c0e7f89d679 in geode's branch 
refs/heads/feature/GEODE-7665 from Xiaojian Zhou
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=e3b0a7b ]

GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365)


Co-authored-by: Xiaojian Zhou 
Co-authored-by: Anil Gingade 



> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174926#comment-17174926
 ] 

ASF subversion and git services commented on GEODE-8334:


Commit 2d82c288e5af109ae0c3311a2702c83e389ad720 in geode's branch 
refs/heads/feature/GEODE-7665 from Xiaojian Zhou
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=2d82c28 ]

GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365)


Co-authored-by: Xiaojian Zhou 
Co-authored-by: Anil Gingade 



> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174913#comment-17174913
 ] 

ASF subversion and git services commented on GEODE-8334:


Commit 2d82c288e5af109ae0c3311a2702c83e389ad720 in geode's branch 
refs/heads/feature/GEODE-7665 from Xiaojian Zhou
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=2d82c28 ]

GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365)


Co-authored-by: Xiaojian Zhou 
Co-authored-by: Anil Gingade 



> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174900#comment-17174900
 ] 

ASF subversion and git services commented on GEODE-8334:


Commit 2d82c288e5af109ae0c3311a2702c83e389ad720 in geode's branch 
refs/heads/feature/GEODE-7665 from Xiaojian Zhou
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=2d82c28 ]

GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365)


Co-authored-by: Xiaojian Zhou 
Co-authored-by: Anil Gingade 



> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174593#comment-17174593
 ] 

ASF subversion and git services commented on GEODE-8334:


Commit 2d82c288e5af109ae0c3311a2702c83e389ad720 in geode's branch 
refs/heads/feature/GEODE-7665 from Xiaojian Zhou
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=2d82c28 ]

GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365)


Co-authored-by: Xiaojian Zhou 
Co-authored-by: Anil Gingade 



> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174457#comment-17174457
 ] 

ASF subversion and git services commented on GEODE-8334:


Commit 2d82c288e5af109ae0c3311a2702c83e389ad720 in geode's branch 
refs/heads/feature/GEODE-7665 from Xiaojian Zhou
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=2d82c28 ]

GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365)


Co-authored-by: Xiaojian Zhou 
Co-authored-by: Anil Gingade 



> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170323#comment-17170323
 ] 

ASF subversion and git services commented on GEODE-8334:


Commit 9a67231f5a107cf019af551f5a94d1ce49614d94 in geode's branch 
refs/heads/feature/GEODE-7665 from Xiaojian Zhou
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=9a67231 ]

GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365)


Co-authored-by: Xiaojian Zhou 
Co-authored-by: Anil Gingade 



> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170311#comment-17170311
 ] 

ASF subversion and git services commented on GEODE-8334:


Commit 9a67231f5a107cf019af551f5a94d1ce49614d94 in geode's branch 
refs/heads/feature/GEODE-7665 from Xiaojian Zhou
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=9a67231 ]

GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365)


Co-authored-by: Xiaojian Zhou 
Co-authored-by: Anil Gingade 



> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170299#comment-17170299
 ] 

ASF subversion and git services commented on GEODE-8334:


Commit 9a67231f5a107cf019af551f5a94d1ce49614d94 in geode's branch 
refs/heads/feature/GEODE-7665 from Xiaojian Zhou
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=9a67231 ]

GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365)


Co-authored-by: Xiaojian Zhou 
Co-authored-by: Anil Gingade 



> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170286#comment-17170286
 ] 

ASF subversion and git services commented on GEODE-8334:


Commit 9a67231f5a107cf019af551f5a94d1ce49614d94 in geode's branch 
refs/heads/feature/GEODE-7665 from Xiaojian Zhou
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=9a67231 ]

GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365)


Co-authored-by: Xiaojian Zhou 
Co-authored-by: Anil Gingade 



> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170273#comment-17170273
 ] 

ASF subversion and git services commented on GEODE-8334:


Commit 9a67231f5a107cf019af551f5a94d1ce49614d94 in geode's branch 
refs/heads/feature/GEODE-7665 from Xiaojian Zhou
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=9a67231 ]

GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365)


Co-authored-by: Xiaojian Zhou 
Co-authored-by: Anil Gingade 



> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-07-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17155570#comment-17155570
 ] 

ASF subversion and git services commented on GEODE-8334:


Commit edaf14896d951554d406bd16969948bbd3953d38 in geode's branch 
refs/heads/feature/GEODE-7665 from Xiaojian Zhou
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=edaf148 ]

GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365)


Co-authored-by: Xiaojian Zhou 
Co-authored-by: Anil Gingade 



> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-07-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17155564#comment-17155564
 ] 

ASF GitHub Bot commented on GEODE-8334:
---

gesterzhou merged pull request #5365:
URL: https://github.com/apache/geode/pull/5365


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-07-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17155567#comment-17155567
 ] 

ASF subversion and git services commented on GEODE-8334:


Commit edaf14896d951554d406bd16969948bbd3953d38 in geode's branch 
refs/heads/feature/GEODE-7665 from Xiaojian Zhou
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=edaf148 ]

GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365)


Co-authored-by: Xiaojian Zhou 
Co-authored-by: Anil Gingade 



> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-07-09 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154997#comment-17154997
 ] 

ASF GitHub Bot commented on GEODE-8334:
---

gesterzhou commented on a change in pull request #5365:
URL: https://github.com/apache/geode/pull/5365#discussion_r452547691



##
File path: 
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/RemoveAllPRMessageTest.java
##
@@ -131,4 +134,35 @@ public void 
removeAndNotifyKeysIsNotInvokedIfKeysNotLocked() throws Exception {
 verify(dataStore).checkRegionDestroyedOnBucket(eq(bucketRegion), eq(true),
 eq(regionDestroyedException));
   }
+
+  @Test
+  public void rvvLockedAfterKeysAreLockedAndUnlockRVVBeforeKeys() throws 
Exception {
+RemoveAllPRMessage message =
+spy(new RemoveAllPRMessage(bucketId, 1, false, false, false, null));
+message.addEntry(entryData);
+doReturn(keys).when(message).getKeysToBeLocked();
+when(bucketRegion.waitUntilLocked(keys)).thenReturn(true);
+when(bucketRegion.doLockForPrimary(false)).thenThrow(new 
PrimaryBucketException());
+doNothing().when(bucketRegion).lockRVVForBulkOp();
+doNothing().when(bucketRegion).unlockRVVForBulkOp();
+
+InternalCache cache = mock(InternalCache.class);
+InternalDistributedSystem ids = mock(InternalDistributedSystem.class);
+when(bucketRegion.getCache()).thenReturn(cache);
+when(cache.getDistributedSystem()).thenReturn(ids);
+when(ids.getOffHeapStore()).thenReturn(null);
+
+try {
+  message.doLocalRemoveAll(partitionedRegion, 
mock(InternalDistributedMember.class), true);
+  fail("Expect PrimaryBucketException");
+} catch (Exception e) {
+  assertThat(e instanceof PrimaryBucketException);
+}
+
+InOrder inOrder = inOrder(bucketRegion);
+inOrder.verify(bucketRegion).waitUntilLocked(keys);
+inOrder.verify(bucketRegion).lockRVVForBulkOp();
+inOrder.verify(bucketRegion).unlockRVVForBulkOp();

Review comment:
   doLockForPrimary acts as the operation to save a lot of trouble of 
mocking. The test expects this exception to happen.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-07-09 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154992#comment-17154992
 ] 

ASF GitHub Bot commented on GEODE-8334:
---

agingade commented on a change in pull request #5365:
URL: https://github.com/apache/geode/pull/5365#discussion_r452543360



##
File path: 
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/PutAllPRMessageTest.java
##
@@ -119,4 +122,34 @@ public void 
removeAndNotifyKeysIsNotInvokedIfKeysNotLocked() throws Exception {
 eq(regionDestroyedException));
   }
 
+  @Test
+  public void rvvLockedAfterKeysAreLockedAndUnlockRVVBeforeKeys() throws 
Exception {
+PutAllPRMessage message = spy(new PutAllPRMessage(bucketId, 1, false, 
false, false, null));
+message.addEntry(entryData);
+doReturn(keys).when(message).getKeysToBeLocked();
+when(bucketRegion.waitUntilLocked(keys)).thenReturn(true);
+when(bucketRegion.doLockForPrimary(false)).thenThrow(new 
PrimaryBucketException());
+doNothing().when(bucketRegion).lockRVVForBulkOp();
+doNothing().when(bucketRegion).unlockRVVForBulkOp();
+
+InternalCache cache = mock(InternalCache.class);
+InternalDistributedSystem ids = mock(InternalDistributedSystem.class);
+when(bucketRegion.getCache()).thenReturn(cache);
+when(cache.getDistributedSystem()).thenReturn(ids);
+when(ids.getOffHeapStore()).thenReturn(null);
+
+try {
+  message.doLocalPutAll(partitionedRegion, 
mock(InternalDistributedMember.class), 1);
+  fail("Expect PrimaryBucketException");
+} catch (Exception e) {
+  assertThat(e instanceof PrimaryBucketException);
+}
+
+InOrder inOrder = inOrder(bucketRegion);
+inOrder.verify(bucketRegion).waitUntilLocked(keys);
+inOrder.verify(bucketRegion).lockRVVForBulkOp();
+inOrder.verify(bucketRegion).unlockRVVForBulkOp();

Review comment:
   Having the actual operation "put" in between the lock and unlock makes 
sure the operation is operated under expected locking.

##
File path: 
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/RemoveAllPRMessageTest.java
##
@@ -131,4 +134,35 @@ public void 
removeAndNotifyKeysIsNotInvokedIfKeysNotLocked() throws Exception {
 verify(dataStore).checkRegionDestroyedOnBucket(eq(bucketRegion), eq(true),
 eq(regionDestroyedException));
   }
+
+  @Test
+  public void rvvLockedAfterKeysAreLockedAndUnlockRVVBeforeKeys() throws 
Exception {
+RemoveAllPRMessage message =
+spy(new RemoveAllPRMessage(bucketId, 1, false, false, false, null));
+message.addEntry(entryData);
+doReturn(keys).when(message).getKeysToBeLocked();
+when(bucketRegion.waitUntilLocked(keys)).thenReturn(true);
+when(bucketRegion.doLockForPrimary(false)).thenThrow(new 
PrimaryBucketException());
+doNothing().when(bucketRegion).lockRVVForBulkOp();
+doNothing().when(bucketRegion).unlockRVVForBulkOp();
+
+InternalCache cache = mock(InternalCache.class);
+InternalDistributedSystem ids = mock(InternalDistributedSystem.class);
+when(bucketRegion.getCache()).thenReturn(cache);
+when(cache.getDistributedSystem()).thenReturn(ids);
+when(ids.getOffHeapStore()).thenReturn(null);
+
+try {
+  message.doLocalRemoveAll(partitionedRegion, 
mock(InternalDistributedMember.class), true);
+  fail("Expect PrimaryBucketException");
+} catch (Exception e) {
+  assertThat(e instanceof PrimaryBucketException);
+}
+
+InOrder inOrder = inOrder(bucketRegion);
+inOrder.verify(bucketRegion).waitUntilLocked(keys);
+inOrder.verify(bucketRegion).lockRVVForBulkOp();
+inOrder.verify(bucketRegion).unlockRVVForBulkOp();

Review comment:
   Having the actual operation "remove" in between the lock and unlock 
makes sure the operation is operated under expected locking.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-07-09 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154991#comment-17154991
 ] 

ASF GitHub Bot commented on GEODE-8334:
---

agingade commented on a change in pull request #5365:
URL: https://github.com/apache/geode/pull/5365#discussion_r452542790



##
File path: 
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/PutAllPRMessageTest.java
##
@@ -119,4 +122,34 @@ public void 
removeAndNotifyKeysIsNotInvokedIfKeysNotLocked() throws Exception {
 eq(regionDestroyedException));
   }
 
+  @Test
+  public void rvvLockedAfterKeysAreLockedAndUnlockRVVBeforeKeys() throws 
Exception {
+PutAllPRMessage message = spy(new PutAllPRMessage(bucketId, 1, false, 
false, false, null));
+message.addEntry(entryData);
+doReturn(keys).when(message).getKeysToBeLocked();
+when(bucketRegion.waitUntilLocked(keys)).thenReturn(true);
+when(bucketRegion.doLockForPrimary(false)).thenThrow(new 
PrimaryBucketException());
+doNothing().when(bucketRegion).lockRVVForBulkOp();
+doNothing().when(bucketRegion).unlockRVVForBulkOp();
+
+InternalCache cache = mock(InternalCache.class);
+InternalDistributedSystem ids = mock(InternalDistributedSystem.class);
+when(bucketRegion.getCache()).thenReturn(cache);
+when(cache.getDistributedSystem()).thenReturn(ids);
+when(ids.getOffHeapStore()).thenReturn(null);
+
+try {
+  message.doLocalPutAll(partitionedRegion, 
mock(InternalDistributedMember.class), 1);
+  fail("Expect PrimaryBucketException");
+} catch (Exception e) {
+  assertThat(e instanceof PrimaryBucketException);
+}

Review comment:
   +1





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-07-09 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154984#comment-17154984
 ] 

ASF GitHub Bot commented on GEODE-8334:
---

DonalEvans commented on a change in pull request #5365:
URL: https://github.com/apache/geode/pull/5365#discussion_r452538880



##
File path: 
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/RemoveAllPRMessageTest.java
##
@@ -131,4 +134,35 @@ public void 
removeAndNotifyKeysIsNotInvokedIfKeysNotLocked() throws Exception {
 verify(dataStore).checkRegionDestroyedOnBucket(eq(bucketRegion), eq(true),
 eq(regionDestroyedException));
   }
+
+  @Test
+  public void rvvLockedAfterKeysAreLockedAndUnlockRVVBeforeKeys() throws 
Exception {
+RemoveAllPRMessage message =
+spy(new RemoveAllPRMessage(bucketId, 1, false, false, false, null));
+message.addEntry(entryData);
+doReturn(keys).when(message).getKeysToBeLocked();
+when(bucketRegion.waitUntilLocked(keys)).thenReturn(true);
+when(bucketRegion.doLockForPrimary(false)).thenThrow(new 
PrimaryBucketException());
+doNothing().when(bucketRegion).lockRVVForBulkOp();
+doNothing().when(bucketRegion).unlockRVVForBulkOp();
+
+InternalCache cache = mock(InternalCache.class);
+InternalDistributedSystem ids = mock(InternalDistributedSystem.class);
+when(bucketRegion.getCache()).thenReturn(cache);
+when(cache.getDistributedSystem()).thenReturn(ids);
+when(ids.getOffHeapStore()).thenReturn(null);
+
+try {
+  message.doLocalRemoveAll(partitionedRegion, 
mock(InternalDistributedMember.class), true);
+  fail("Expect PrimaryBucketException");
+} catch (Exception e) {
+  assertThat(e instanceof PrimaryBucketException);
+}

Review comment:
   This can be replaced with `assertThatThrownBy(() -> 
message.doLocalRemoveAll(partitionedRegion, 
mock(InternalDistributedMember.class), 
true)).isInstanceOf(PrimaryBucketException.class);` to make things a bit neater.

##
File path: 
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/PutAllPRMessageTest.java
##
@@ -119,4 +122,34 @@ public void 
removeAndNotifyKeysIsNotInvokedIfKeysNotLocked() throws Exception {
 eq(regionDestroyedException));
   }
 
+  @Test
+  public void rvvLockedAfterKeysAreLockedAndUnlockRVVBeforeKeys() throws 
Exception {
+PutAllPRMessage message = spy(new PutAllPRMessage(bucketId, 1, false, 
false, false, null));
+message.addEntry(entryData);
+doReturn(keys).when(message).getKeysToBeLocked();
+when(bucketRegion.waitUntilLocked(keys)).thenReturn(true);
+when(bucketRegion.doLockForPrimary(false)).thenThrow(new 
PrimaryBucketException());
+doNothing().when(bucketRegion).lockRVVForBulkOp();
+doNothing().when(bucketRegion).unlockRVVForBulkOp();
+
+InternalCache cache = mock(InternalCache.class);
+InternalDistributedSystem ids = mock(InternalDistributedSystem.class);
+when(bucketRegion.getCache()).thenReturn(cache);
+when(cache.getDistributedSystem()).thenReturn(ids);
+when(ids.getOffHeapStore()).thenReturn(null);
+
+try {
+  message.doLocalPutAll(partitionedRegion, 
mock(InternalDistributedMember.class), 1);
+  fail("Expect PrimaryBucketException");
+} catch (Exception e) {
+  assertThat(e instanceof PrimaryBucketException);
+}

Review comment:
   This can be replaced with `assertThatThrownBy(() -> 
message.doLocalPutAll(partitionedRegion, mock(InternalDistributedMember.class), 
1)).isInstanceOf(PrimaryBucketException.class);` to make things a bit neater.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-07-09 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154973#comment-17154973
 ] 

ASF GitHub Bot commented on GEODE-8334:
---

gesterzhou opened a new pull request #5365:
URL: https://github.com/apache/geode/pull/5365


   Co-authored-by: Xiaojian Zhou 
   Co-authored-by: Anil 
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build 
issues and
   submit an update to your PR as soon as possible. If you need help, please 
send an
   email to d...@geode.apache.org.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-07-09 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154972#comment-17154972
 ] 

ASF subversion and git services commented on GEODE-8334:


Commit 43cb2781e34b0b24f2628236256e13027f4b4e50 in geode's branch 
refs/heads/feature/GEODE-8334 from zhouxh
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=43cb278 ]

GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock

Co-authored-by: Xiaojian Zhou 
Co-authored-by: Anil 


> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-07-09 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154970#comment-17154970
 ] 

ASF subversion and git services commented on GEODE-8334:


Commit 4e6705335950d30fcc1e5831ca2d09612e47b78f in geode's branch 
refs/heads/feature/GEODE-8334 from zhouxh
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=4e67053 ]

GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock


> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-07-09 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154937#comment-17154937
 ] 

ASF subversion and git services commented on GEODE-8334:


Commit a6a62c6840b4916611ed850f1dd17b9ed7a3b709 in geode's branch 
refs/heads/feature/GEODE-8334 from Xiaojian Zhou
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=a6a62c6 ]

Merge branch 'feature/GEODE-7665' into feature/GEODE-8334

> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-07-06 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152404#comment-17152404
 ] 

ASF subversion and git services commented on GEODE-8334:


Commit a4104033ceb20e80b491ed4b3ae89da2c6969f5f in geode's branch 
refs/heads/feature/GEODE-8334 from zhouxh
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=a410403 ]

GEODE-8334: PutAll/RemoveAll at primary bucket should get rvvLock to sync with 
clear


> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)