[jira] [Commented] (GEODE-9101) Attribute VisibleNodes in MemberMXBean is incorrect

2022-07-28 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-9101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17572364#comment-17572364
 ] 

ASF subversion and git services commented on GEODE-9101:


Commit e2f7fe053ddc3de175f2b0342012b31b38aa46e5 in geode's branch 
refs/heads/develop from Mario Kevo
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=e2f7fe053d ]

GEODE-9101: fix VisibleNode attribute (#7829)



> Attribute VisibleNodes in MemberMXBean is incorrect
> ---
>
> Key: GEODE-9101
> URL: https://issues.apache.org/jira/browse/GEODE-9101
> Project: Geode
>  Issue Type: Bug
>  Components: statistics
>Reporter: Mario Kevo
>Assignee: Mario Kevo
>Priority: Major
>  Labels: needs-review, pull-request-available
>
> In documentation states:
> _The current number of nodes in this distributed system visible to this 
> member._
> But checking the value of the attribute we have a difference between locator 
> and server.
> For example, we have the following system:
> {code:java}
>  
> gfsh>list members
> Member Count : 4
> Name | Id
>  | -
> locator1 | 192.168.0.145(locator1:26377:locator):41000 [Coordinator]
> locator2 | 192.168.0.145(locator2:26509:locator):41001
> server1 | 192.168.0.145(server1:26648):41002
> server2 | 192.168.0.145(server2:26768):41003
>  
> {code}
>  
> For locators visibleNodes = 2, but for servers visibleNodes = 3.
> Locators see only servers as visible nodes(In this case it sees *server1* and 
> *server2*).
> Servers see first locator and all servers, including itself(In this case 
> server1 sees *locator1*, *server1* and *server2*).
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (GEODE-9101) Attribute VisibleNodes in MemberMXBean is incorrect

2021-04-08 Thread Kirk Lund (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-9101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317356#comment-17317356
 ] 

Kirk Lund commented on GEODE-9101:
--

The javadocs on MemberMXBean are misleading. They state:
{noformat}
  /**
   * The current number of nodes in this distributed system visible to this 
member.
   */
  int getVisibleNodes();
{noformat}
However, the value of {{getVisibleNodes()}} is {{nodes}} from 
{{DistributionStats}} which reflects the current number of nodes in the 
distributed system (including this member):
{noformat}
final String nodesDesc = "The current number of nodes in this distributed 
system.";
{noformat}
Users may be depending on {{getVisibleNodes()}} matching the same value as the 
{{nodes}} statistic, so the safest change is to introduce a new attribute that 
reflects the number of OTHER nodes.

If you really want to change {{getVisibleNodes()}} then you should propose this 
on the Geode dev mailing list.

> Attribute VisibleNodes in MemberMXBean is incorrect
> ---
>
> Key: GEODE-9101
> URL: https://issues.apache.org/jira/browse/GEODE-9101
> Project: Geode
>  Issue Type: Bug
>  Components: statistics
>Reporter: Mario Kevo
>Assignee: Mario Kevo
>Priority: Major
>  Labels: pull-request-available
>
> In documentation states:
> _The current number of nodes in this distributed system visible to this 
> member._
> But checking the value of the attribute we have a difference between locator 
> and server.
> For example, we have the following system:
> {code:java}
>  
> gfsh>list members
> Member Count : 4
> Name | Id
>  | -
> locator1 | 192.168.0.145(locator1:26377:locator):41000 [Coordinator]
> locator2 | 192.168.0.145(locator2:26509:locator):41001
> server1 | 192.168.0.145(server1:26648):41002
> server2 | 192.168.0.145(server2:26768):41003
>  
> {code}
>  
> For locators visibleNodes = 2, but for servers visibleNodes = 3.
> Locators see only servers as visible nodes(In this case it sees *server1* and 
> *server2*).
> Servers see first locator and all servers, including itself(In this case 
> server1 sees *locator1*, *server1* and *server2*).
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)